)]}'
{"neutron_tempest_plugin/api/test_routers_negative.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d1c6a0d2af724d6c0fde388a5f4b07c0a6c725b3","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        router \u003d self.admin_client.create_router("},{"line_number":94,"context_line":"            data_utils.rand_name(\u0027router\u0027), admin_state_up\u003dTrue,"},{"line_number":95,"context_line":"            **router_args)[\u0027router\u0027]"},{"line_number":96,"context_line":"        self.addCleanup(self.admin_client.delete_router, router[\u0027id\u0027])"},{"line_number":97,"context_line":"        self.assertTrue(router[\u0027admin_state_up\u0027])"},{"line_number":98,"context_line":"        self.assertFalse(router[\u0027distributed\u0027])"},{"line_number":99,"context_line":"        # attempt to set the router to distributed, catch BadRequest exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_351c6576","line":96,"updated":"2019-08-26 15:52:59.000000000","message":"Does using the method from the base class work, which will add a cleanup call?\n\nrouter \u003d self._create_admin_router(data_utils.rand_name(\u0027router\u0027), admin_state_up\u003dTrue, **router_args)\n\nI haven\u0027t tried it but the HA tests do that.\n\nIt\u0027s almost as if these tests should have been in api/admin/test_routers_negative.py (which doesn\u0027t exist actually) to make it clear they\u0027re admin ones.\n\nOh, but after looking at the original commit it did this in the test_routers.py file but not in the negative one.\n\nFor now I\u0027ll just leave the comment, I know the intent of most of these create_*() methods was to have them call addCleanup() so callers didn\u0027t have to worry.","commit_id":"6569bdeea85c4a46270fa70ff01b3bff1756e3b6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0e659d07f3055a4ccb543798dd70864429e587c7","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        router \u003d self.admin_client.create_router("},{"line_number":94,"context_line":"            data_utils.rand_name(\u0027router\u0027), admin_state_up\u003dTrue,"},{"line_number":95,"context_line":"            **router_args)[\u0027router\u0027]"},{"line_number":96,"context_line":"        self.addCleanup(self.admin_client.delete_router, router[\u0027id\u0027])"},{"line_number":97,"context_line":"        self.assertTrue(router[\u0027admin_state_up\u0027])"},{"line_number":98,"context_line":"        self.assertFalse(router[\u0027distributed\u0027])"},{"line_number":99,"context_line":"        # attempt to set the router to distributed, catch BadRequest exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_414a5883","line":96,"in_reply_to":"7faddb67_351c6576","updated":"2019-08-28 15:00:43.000000000","message":"+1 to use _create_admin_router() method from https://github.com/openstack/neutron-tempest-plugin/blob/41c43924712c728bfaff5955b92c210402c1faf5/neutron_tempest_plugin/api/base_routers.py#L41 instead of adding addCleanup() here.","commit_id":"6569bdeea85c4a46270fa70ff01b3bff1756e3b6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0e659d07f3055a4ccb543798dd70864429e587c7","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        router \u003d self.admin_client.create_router("},{"line_number":112,"context_line":"            data_utils.rand_name(\u0027router\u0027), admin_state_up\u003dTrue,"},{"line_number":113,"context_line":"            **router_args)[\u0027router\u0027]"},{"line_number":114,"context_line":"        self.addCleanup(self.admin_client.delete_router, router[\u0027id\u0027])"},{"line_number":115,"context_line":"        self.assertTrue(router[\u0027admin_state_up\u0027])"},{"line_number":116,"context_line":"        self.assertFalse(router[\u0027distributed\u0027])"},{"line_number":117,"context_line":"        # take the router down to modify distributed-\u003eTrue"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_21471c7a","line":114,"updated":"2019-08-28 15:00:43.000000000","message":"same here","commit_id":"6569bdeea85c4a46270fa70ff01b3bff1756e3b6"}]}