)]}'
{"neutron_tempest_plugin/scenario/test_dns_integration.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ff9ad9fb07f4658233fafc7d7f3ddbd29c880191","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        self._verify_dns_records(addr_v6, name, record_type\u003d\u0027AAAA\u0027)"},{"line_number":187,"context_line":"        self._verify_dns_records(addr_v4, name, found\u003dFalse)"},{"line_number":188,"context_line":"        self.client.delete_port(port[\u0027id\u0027])"},{"line_number":189,"context_line":"        self._verify_dns_records(addr_v6, name, record_type\u003d\u0027AAAA\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_bd6cea9c","line":189,"updated":"2019-09-06 11:53:36.000000000","message":"Meh, this is lacking \"found\u003dFalse\", so it actually verifies that record deletion still isn\u0027t working as it should ... :-(","commit_id":"8e9249f6debfe3f4e38ed02eeed7082e784a00ec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"04645c5073b93016d63370c69766719e321758c9","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        super(DNSIntegrationAdminTests, cls).resource_setup()"},{"line_number":144,"context_line":"        cls.network2 \u003d cls.create_network(dns_domain\u003dcls.zone[\u0027name\u0027],"},{"line_number":145,"context_line":"                provider_network_type\u003d\u0027vxlan\u0027,"},{"line_number":146,"context_line":"                provider_segmentation_id\u003d12345)"},{"line_number":147,"context_line":"        cls.subnet2 \u003d cls.create_subnet(cls.network2)"},{"line_number":148,"context_line":"        # cls.subnet2_v6 \u003d cls.create_subnet(cls.network2, ip_version\u003d6)"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5faad753_de9609f1","line":146,"updated":"2019-09-12 12:17:51.000000000","message":"In the interest of full disclosure: Using 12345 here is a bit of a hack, devstack currently hardcodes the tenant range to 1-1000, for the scenario to work, we will need to use any ID that\u0027s outside of that range. So the test could fail against deployments where 12345 is configured as valid vxlan ID for tenants. One could add code that looks at the configuration and dynamically determines a proper ID to use, but I decided that the added complexity wasn\u0027t worth the effort.","commit_id":"be20f4f6e323759ee2cef4341f209df9efcbe9f2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c1fb26f87635d24a1eaf51312a5b63bdd2fa2faa","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        super(DNSIntegrationAdminTests, cls).resource_setup()"},{"line_number":144,"context_line":"        cls.network2 \u003d cls.create_network(dns_domain\u003dcls.zone[\u0027name\u0027],"},{"line_number":145,"context_line":"                provider_network_type\u003d\u0027vxlan\u0027,"},{"line_number":146,"context_line":"                provider_segmentation_id\u003d12345)"},{"line_number":147,"context_line":"        cls.subnet2 \u003d cls.create_subnet(cls.network2)"},{"line_number":148,"context_line":"        # cls.subnet2_v6 \u003d cls.create_subnet(cls.network2, ip_version\u003d6)"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5faad753_d65ed742","line":146,"in_reply_to":"5faad753_8f8fe673","updated":"2019-09-13 12:41:15.000000000","message":"No, the IDs that are assigned automatically are those that will be filtered out by this check https://opendev.org/openstack/neutron/src/branch/master/neutron/plugins/ml2/extensions/dns_integration.py#L337-L351 , resulting in no DNS records being published for them. One could copy that code in this test in order to programatically determine an ID that would be useable, if you think that that would be preferable.","commit_id":"be20f4f6e323759ee2cef4341f209df9efcbe9f2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4eba1dfa7d68eff73578d3c05af943f2e25bcb56","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        super(DNSIntegrationAdminTests, cls).resource_setup()"},{"line_number":144,"context_line":"        cls.network2 \u003d cls.create_network(dns_domain\u003dcls.zone[\u0027name\u0027],"},{"line_number":145,"context_line":"                provider_network_type\u003d\u0027vxlan\u0027,"},{"line_number":146,"context_line":"                provider_segmentation_id\u003d12345)"},{"line_number":147,"context_line":"        cls.subnet2 \u003d cls.create_subnet(cls.network2)"},{"line_number":148,"context_line":"        # cls.subnet2_v6 \u003d cls.create_subnet(cls.network2, ip_version\u003d6)"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5faad753_5f43bc6c","line":146,"in_reply_to":"5faad753_d65ed742","updated":"2019-09-16 07:41:19.000000000","message":"If You would duplicate this code here and try to detect what segmentation id would be used, it would also require to have some config option in tempest to specify range used in neutron, right?\nIn that case, easier would be to just propose config option with segmentation_id which should be used here and avoid this extra logic here :)\nBut for now, IMO let\u0027s keep it as it is now. Maybe You can just add small comment why it is like that.","commit_id":"be20f4f6e323759ee2cef4341f209df9efcbe9f2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b678ad162eed27a164ff93ce2e5e5ff8033fb266","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        super(DNSIntegrationAdminTests, cls).resource_setup()"},{"line_number":144,"context_line":"        cls.network2 \u003d cls.create_network(dns_domain\u003dcls.zone[\u0027name\u0027],"},{"line_number":145,"context_line":"                provider_network_type\u003d\u0027vxlan\u0027,"},{"line_number":146,"context_line":"                provider_segmentation_id\u003d12345)"},{"line_number":147,"context_line":"        cls.subnet2 \u003d cls.create_subnet(cls.network2)"},{"line_number":148,"context_line":"        # cls.subnet2_v6 \u003d cls.create_subnet(cls.network2, ip_version\u003d6)"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5faad753_8f8fe673","line":146,"in_reply_to":"5faad753_de9609f1","updated":"2019-09-13 07:25:18.000000000","message":"Do we really need to specify that? Can\u0027t it be choosen automatically?","commit_id":"be20f4f6e323759ee2cef4341f209df9efcbe9f2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"67f1f55ea170eff9db7e28688e06d7753fbf0941","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                provider_network_type\u003d\u0027vxlan\u0027,"},{"line_number":146,"context_line":"                provider_segmentation_id\u003d12345)"},{"line_number":147,"context_line":"        cls.subnet2 \u003d cls.create_subnet(cls.network2)"},{"line_number":148,"context_line":"        # cls.subnet2_v6 \u003d cls.create_subnet(cls.network2, ip_version\u003d6)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    @decorators.idempotent_id(\u0027fa6477ce-a12b-41da-b671-5a3bbdafab07\u0027)"},{"line_number":151,"context_line":"    def test_port_on_special_network(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5faad753_5b7f8b14","line":148,"updated":"2019-09-12 11:22:29.000000000","message":"can You remove this commented line maybe?","commit_id":"be20f4f6e323759ee2cef4341f209df9efcbe9f2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"04645c5073b93016d63370c69766719e321758c9","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                provider_network_type\u003d\u0027vxlan\u0027,"},{"line_number":146,"context_line":"                provider_segmentation_id\u003d12345)"},{"line_number":147,"context_line":"        cls.subnet2 \u003d cls.create_subnet(cls.network2)"},{"line_number":148,"context_line":"        # cls.subnet2_v6 \u003d cls.create_subnet(cls.network2, ip_version\u003d6)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    @decorators.idempotent_id(\u0027fa6477ce-a12b-41da-b671-5a3bbdafab07\u0027)"},{"line_number":151,"context_line":"    def test_port_on_special_network(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5faad753_5e40d9a5","line":148,"in_reply_to":"5faad753_5b7f8b14","updated":"2019-09-12 12:17:51.000000000","message":"Oops, leftover from testing. I had considered whether to test with v6 addresses here, too, but they shouldn\u0027t behave differently in this scenario.","commit_id":"be20f4f6e323759ee2cef4341f209df9efcbe9f2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"67f1f55ea170eff9db7e28688e06d7753fbf0941","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                                dns_domain\u003dself.zone[\u0027name\u0027],"},{"line_number":179,"context_line":"                                dns_name\u003dname)"},{"line_number":180,"context_line":"        fixed_ips \u003d port[\u0027fixed_ips\u0027]"},{"line_number":181,"context_line":"        if fixed_ips[1][\u0027subnet_id\u0027] \u003d\u003d self.subnet2_v6[\u0027id\u0027]:"},{"line_number":182,"context_line":"            v6_index \u003d 1"},{"line_number":183,"context_line":"        else:"},{"line_number":184,"context_line":"            v6_index \u003d 0"},{"line_number":185,"context_line":"        addr_v4 \u003d port[\u0027fixed_ips\u0027][1 - v6_index][\u0027ip_address\u0027]"},{"line_number":186,"context_line":"        addr_v6 \u003d port[\u0027fixed_ips\u0027][v6_index][\u0027ip_address\u0027]"},{"line_number":187,"context_line":"        self._verify_dns_records(addr_v6, name, record_type\u003d\u0027AAAA\u0027)"},{"line_number":188,"context_line":"        self._verify_dns_records(addr_v4, name, found\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5faad753_3ba72faa","line":185,"range":{"start_line":181,"start_character":0,"end_line":185,"end_character":63},"updated":"2019-09-12 11:22:29.000000000","message":"smart way to get IPv4 and IPv6 addresses :)","commit_id":"be20f4f6e323759ee2cef4341f209df9efcbe9f2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"04645c5073b93016d63370c69766719e321758c9","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                                dns_domain\u003dself.zone[\u0027name\u0027],"},{"line_number":179,"context_line":"                                dns_name\u003dname)"},{"line_number":180,"context_line":"        fixed_ips \u003d port[\u0027fixed_ips\u0027]"},{"line_number":181,"context_line":"        if fixed_ips[1][\u0027subnet_id\u0027] \u003d\u003d self.subnet2_v6[\u0027id\u0027]:"},{"line_number":182,"context_line":"            v6_index \u003d 1"},{"line_number":183,"context_line":"        else:"},{"line_number":184,"context_line":"            v6_index \u003d 0"},{"line_number":185,"context_line":"        addr_v4 \u003d port[\u0027fixed_ips\u0027][1 - v6_index][\u0027ip_address\u0027]"},{"line_number":186,"context_line":"        addr_v6 \u003d port[\u0027fixed_ips\u0027][v6_index][\u0027ip_address\u0027]"},{"line_number":187,"context_line":"        self._verify_dns_records(addr_v6, name, record_type\u003d\u0027AAAA\u0027)"},{"line_number":188,"context_line":"        self._verify_dns_records(addr_v4, name, found\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5faad753_7e26f517","line":185,"range":{"start_line":181,"start_character":0,"end_line":185,"end_character":63},"in_reply_to":"5faad753_3ba72faa","updated":"2019-09-12 12:17:51.000000000","message":"Glad you like it, I don\u0027t think it\u0027s rather elegant, but it does seem to work.","commit_id":"be20f4f6e323759ee2cef4341f209df9efcbe9f2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4931dfad704ab7cf4888ba3d62a8a076ce4b7868","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        addr_v4 \u003d port[\u0027fixed_ips\u0027][1 - v6_index][\u0027ip_address\u0027]"},{"line_number":187,"context_line":"        addr_v6 \u003d port[\u0027fixed_ips\u0027][v6_index][\u0027ip_address\u0027]"},{"line_number":188,"context_line":"        self._verify_dns_records(addr_v6, name, record_type\u003d\u0027AAAA\u0027)"},{"line_number":189,"context_line":"        self._verify_dns_records(addr_v4, name, found\u003dFalse)"},{"line_number":190,"context_line":"        self.client.delete_port(port[\u0027id\u0027])"},{"line_number":191,"context_line":"        self._verify_dns_records(addr_v6, name, record_type\u003d\u0027AAAA\u0027,"},{"line_number":192,"context_line":"                                 found\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_5f477e1f","line":189,"updated":"2019-12-04 22:29:56.000000000","message":"This actually relates to the comment I made here: https://review.opendev.org/#/c/662409/38/neutron/plugins/ml2/extensions/dns_integration.py@438. Here we are testing that change in behavior","commit_id":"450d4a017b773a6b1e3d3112aff5af24b9c48d8e"}]}