)]}'
{"neutron_tempest_plugin/scenario/base.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"63919c9b5e1f7336f86d0f27fdf9570fb60eeb17","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                self._log_console_output(servers)"},{"line_number":409,"context_line":"            raise"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def nc_listen(self, server, ssh_client, port, protocol, echo_msg):"},{"line_number":412,"context_line":"        \"\"\"Create nc server listening on the given TCP/UDP port.\"\"\""},{"line_number":413,"context_line":"        udp \u003d \u0027\u0027"},{"line_number":414,"context_line":"        if protocol.lower() \u003d\u003d neutron_lib_constants.PROTO_NAME_UDP:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_6a2541ab","line":411,"updated":"2019-10-02 11:54:07.000000000","message":"nit: I think it\u0027s worth to mention that the listener is executed in a remote host and the client is local.","commit_id":"be4b70537d17e14577952e7c9a6aa05e4990b013"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"021bbf4a6332ed79913d3e0003fbacf62f415cfa","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                self._log_console_output(servers)"},{"line_number":409,"context_line":"            raise"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def nc_listen(self, server, ssh_client, port, protocol, echo_msg):"},{"line_number":412,"context_line":"        \"\"\"Create nc server listening on the given TCP/UDP port.\"\"\""},{"line_number":413,"context_line":"        udp \u003d \u0027\u0027"},{"line_number":414,"context_line":"        if protocol.lower() \u003d\u003d neutron_lib_constants.PROTO_NAME_UDP:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_dd38ab3e","line":411,"in_reply_to":"3fa7e38b_6a2541ab","updated":"2019-10-03 10:55:12.000000000","message":"Done","commit_id":"be4b70537d17e14577952e7c9a6aa05e4990b013"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"63919c9b5e1f7336f86d0f27fdf9570fb60eeb17","unresolved":false,"context_lines":[{"line_number":422,"context_line":"            self._log_console_output([server])"},{"line_number":423,"context_line":"            raise"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def nc_client(self, ip_address, port, protocol):"},{"line_number":426,"context_line":"        \"\"\"Check connectivity to TCP/UDP port at host via nc.\"\"\""},{"line_number":427,"context_line":"        udp \u003d \u0027\u0027"},{"line_number":428,"context_line":"        if protocol.lower() \u003d\u003d neutron_lib_constants.PROTO_NAME_UDP:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_4a55e5f9","line":425,"updated":"2019-10-02 11:54:07.000000000","message":"nit: (not for this patch) scenario/test_qos.py is using a nc client/server. Could be useful to merge this code.","commit_id":"be4b70537d17e14577952e7c9a6aa05e4990b013"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6a1cd83cadb7a4ecf2916e0697377750338e32c9","unresolved":false,"context_lines":[{"line_number":422,"context_line":"            self._log_console_output([server])"},{"line_number":423,"context_line":"            raise"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def nc_client(self, ip_address, port, protocol):"},{"line_number":426,"context_line":"        \"\"\"Check connectivity to TCP/UDP port at host via nc.\"\"\""},{"line_number":427,"context_line":"        udp \u003d \u0027\u0027"},{"line_number":428,"context_line":"        if protocol.lower() \u003d\u003d neutron_lib_constants.PROTO_NAME_UDP:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_4052243d","line":425,"in_reply_to":"3fa7e38b_3d477fbf","updated":"2019-10-10 12:52:20.000000000","message":"I\u0027ll do it once this patch is merged.","commit_id":"be4b70537d17e14577952e7c9a6aa05e4990b013"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"021bbf4a6332ed79913d3e0003fbacf62f415cfa","unresolved":false,"context_lines":[{"line_number":422,"context_line":"            self._log_console_output([server])"},{"line_number":423,"context_line":"            raise"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def nc_client(self, ip_address, port, protocol):"},{"line_number":426,"context_line":"        \"\"\"Check connectivity to TCP/UDP port at host via nc.\"\"\""},{"line_number":427,"context_line":"        udp \u003d \u0027\u0027"},{"line_number":428,"context_line":"        if protocol.lower() \u003d\u003d neutron_lib_constants.PROTO_NAME_UDP:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_3d477fbf","line":425,"in_reply_to":"3fa7e38b_4a55e5f9","updated":"2019-10-03 10:55:12.000000000","message":"Yes, I can explore it in follow up patch maybe. Would it be ok for You?","commit_id":"be4b70537d17e14577952e7c9a6aa05e4990b013"}],"neutron_tempest_plugin/scenario/test_port_forwardings.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"87cf7276f4a6890d27c09eeb356c22633ef10be9","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _prepare_resources(self, num_servers, internal_tcp_port, protocol):"},{"line_number":48,"context_line":"        servers \u003d []"},{"line_number":49,"context_line":"        external_port_base \u003d 1000"},{"line_number":50,"context_line":"        for i in range(1, num_servers + 1):"},{"line_number":51,"context_line":"            internal_udp_port \u003d internal_tcp_port + 10"},{"line_number":52,"context_line":"            external_tcp_port \u003d external_port_base + i"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_69888cc5","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":33},"updated":"2019-10-08 22:33:00.000000000","message":"Let\u0027s start with 1025 rather than 1000.  That way when people run tests in different environments including laptops etc. they won\u0027t need CAP_NET_BIND_SERVICE capability.","commit_id":"a66414e41a70ca889c9c26d0d1c18ba1e6222ebc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6aeb088a4af810fe709c3ac7646a0b052228672b","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _prepare_resources(self, num_servers, internal_tcp_port, protocol):"},{"line_number":48,"context_line":"        servers \u003d []"},{"line_number":49,"context_line":"        external_port_base \u003d 1000"},{"line_number":50,"context_line":"        for i in range(1, num_servers + 1):"},{"line_number":51,"context_line":"            internal_udp_port \u003d internal_tcp_port + 10"},{"line_number":52,"context_line":"            external_tcp_port \u003d external_port_base + i"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_3a9b9718","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":33},"in_reply_to":"3fa7e38b_69888cc5","updated":"2019-10-10 11:00:10.000000000","message":"good point","commit_id":"a66414e41a70ca889c9c26d0d1c18ba1e6222ebc"}]}