)]}'
{"neutron_tempest_plugin/api/test_security_groups.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c66ed486fbbc6ecc2764fbe864a6605deb09fbe1","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        which belongs to the tenant\u0027s security group are listed."},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        security_group \u003d self.create_security_group()"},{"line_number":87,"context_line":"        protocol \u003d random.choice(list(base_security_groups.V4_PROTOCOL_NAMES))"},{"line_number":88,"context_line":"        security_group_rule \u003d self.create_security_group_rule("},{"line_number":89,"context_line":"            security_group\u003dsecurity_group,"},{"line_number":90,"context_line":"            project\u003d{\u0027id\u0027: self.admin_client.tenant_id},"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_0930949e","line":87,"range":{"start_line":87,"start_character":19,"end_line":87,"end_character":32},"updated":"2019-10-15 15:06:20.000000000","message":"just a comment: with random in tests we have, sometimes, problems due to the random element chose. Maybe I would suggest to use a well known protocol (tcp) to make this test more robust and not dependent on a change related to protocols.\n\nAs said, only a comment","commit_id":"ec7508b347b12f914382f5a40cd6784a9e8f5fdf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d16e25533fabfb612a47fe776b6e2cd26907c456","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        which belongs to the tenant\u0027s security group are listed."},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        security_group \u003d self.create_security_group()"},{"line_number":87,"context_line":"        protocol \u003d random.choice(list(base_security_groups.V4_PROTOCOL_NAMES))"},{"line_number":88,"context_line":"        security_group_rule \u003d self.create_security_group_rule("},{"line_number":89,"context_line":"            security_group\u003dsecurity_group,"},{"line_number":90,"context_line":"            project\u003d{\u0027id\u0027: self.admin_client.tenant_id},"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_29d7f4f0","line":87,"range":{"start_line":87,"start_character":19,"end_line":87,"end_character":32},"in_reply_to":"3fa7e38b_0930949e","updated":"2019-12-04 20:50:02.000000000","message":"I can but in fact random is used in same way in test_show_security_group_contains_all_rules already (L63) and we never had problem with that so far.\nSo I would rather go with follow up patch to change it in both tests together with proper commit message description.","commit_id":"ec7508b347b12f914382f5a40cd6784a9e8f5fdf"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"71e771bf873b5c68b3dacba6adaf279f24b3a760","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        protocol \u003d random.choice(list(base_security_groups.V4_PROTOCOL_NAMES))"},{"line_number":88,"context_line":"        security_group_rule \u003d self.create_security_group_rule("},{"line_number":89,"context_line":"            security_group\u003dsecurity_group,"},{"line_number":90,"context_line":"            project\u003d{\u0027id\u0027: self.admin_client.tenant_id},"},{"line_number":91,"context_line":"            client\u003dself.admin_client,"},{"line_number":92,"context_line":"            protocol\u003dprotocol,"},{"line_number":93,"context_line":"            direction\u003dconstants.INGRESS_DIRECTION)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_1a3ce9c6","line":90,"range":{"start_line":90,"start_character":27,"end_line":90,"end_character":54},"updated":"2020-02-27 07:57:47.000000000","message":"shouldn\u0027t we use \"self.client.tenant_id\" instead?","commit_id":"31c0006ded28255e2502d2975648f1fe603ec127"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1f30655b63991370d34311d9a01f300c9ee305e9","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        protocol \u003d random.choice(list(base_security_groups.V4_PROTOCOL_NAMES))"},{"line_number":88,"context_line":"        security_group_rule \u003d self.create_security_group_rule("},{"line_number":89,"context_line":"            security_group\u003dsecurity_group,"},{"line_number":90,"context_line":"            project\u003d{\u0027id\u0027: self.admin_client.tenant_id},"},{"line_number":91,"context_line":"            client\u003dself.admin_client,"},{"line_number":92,"context_line":"            protocol\u003dprotocol,"},{"line_number":93,"context_line":"            direction\u003dconstants.INGRESS_DIRECTION)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_dab8912b","line":90,"range":{"start_line":90,"start_character":27,"end_line":90,"end_character":54},"in_reply_to":"1fa4df85_1a3ce9c6","updated":"2020-02-27 08:02:22.000000000","message":"no because this test is to check if regular user can see rules which are in his security group but belongs to someone else (admin tenant in this case)","commit_id":"31c0006ded28255e2502d2975648f1fe603ec127"}],"neutron_tempest_plugin/services/network/json/network_client.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c66ed486fbbc6ecc2764fbe864a6605deb09fbe1","unresolved":false,"context_lines":[{"line_number":878,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":879,"context_line":""},{"line_number":880,"context_line":"    def list_security_group_rules(self, **kwargs):"},{"line_number":881,"context_line":"        post_body \u003d {\u0027security_group_rules\u0027: kwargs}"},{"line_number":882,"context_line":"        body \u003d jsonutils.dumps(post_body)"},{"line_number":883,"context_line":"        uri \u003d \u0027%s/security-group-rules\u0027 % self.uri_prefix"},{"line_number":884,"context_line":"        if kwargs:"},{"line_number":885,"context_line":"            uri +\u003d \u0027?\u0027 + urlparse.urlencode(kwargs, doseq\u003d1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_29d7904d","line":882,"range":{"start_line":881,"start_character":8,"end_line":882,"end_character":41},"updated":"2019-10-15 15:06:20.000000000","message":"Why is this needed?","commit_id":"ec7508b347b12f914382f5a40cd6784a9e8f5fdf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d16e25533fabfb612a47fe776b6e2cd26907c456","unresolved":false,"context_lines":[{"line_number":878,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":879,"context_line":""},{"line_number":880,"context_line":"    def list_security_group_rules(self, **kwargs):"},{"line_number":881,"context_line":"        post_body \u003d {\u0027security_group_rules\u0027: kwargs}"},{"line_number":882,"context_line":"        body \u003d jsonutils.dumps(post_body)"},{"line_number":883,"context_line":"        uri \u003d \u0027%s/security-group-rules\u0027 % self.uri_prefix"},{"line_number":884,"context_line":"        if kwargs:"},{"line_number":885,"context_line":"            uri +\u003d \u0027?\u0027 + urlparse.urlencode(kwargs, doseq\u003d1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_69f64c93","line":882,"range":{"start_line":881,"start_character":8,"end_line":882,"end_character":41},"in_reply_to":"3fa7e38b_29d7904d","updated":"2019-12-04 20:50:02.000000000","message":"not needed. I don\u0027t know why I added it here","commit_id":"ec7508b347b12f914382f5a40cd6784a9e8f5fdf"}]}