)]}'
{"neutron_tempest_plugin/common/ssh.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c3a7fae4810bdd61cae34db13c2169801e3ecba2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import paramiko"},{"line_number":21,"context_line":"from tempest.lib.common import ssh"},{"line_number":22,"context_line":"from tempest.lib import exceptions"},{"line_number":23,"context_line":"import tenacity"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from neutron_tempest_plugin import config"},{"line_number":26,"context_line":"from neutron_tempest_plugin import exceptions as exc"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ba528066","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":15},"updated":"2019-09-19 08:22:25.000000000","message":"Don\u0027t you need to add tenacity to requirements.txt, as it is added to neutron/requirements.txt for example?","commit_id":"8a2df6842cf8b600cbf366d30d8e1761433575c1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1b81915bf996974e28bd632183c91a9eaf0522cb","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import paramiko"},{"line_number":21,"context_line":"from tempest.lib.common import ssh"},{"line_number":22,"context_line":"from tempest.lib import exceptions"},{"line_number":23,"context_line":"import tenacity"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from neutron_tempest_plugin import config"},{"line_number":26,"context_line":"from neutron_tempest_plugin import exceptions as exc"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_abcd545e","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":15},"in_reply_to":"3fa7e38b_ba528066","updated":"2019-09-19 11:01:33.000000000","message":"Of course we need to add it: https://review.opendev.org/#/c/682864/1/requirements.txt","commit_id":"8a2df6842cf8b600cbf366d30d8e1761433575c1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c37d4d817bacd72dd7d1014371d8349788847d3f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"if six.PY2:"},{"line_number":35,"context_line":"    TIMEOUT_EXCEPTIONS +\u003d (OSError, )"},{"line_number":36,"context_line":"else:"},{"line_number":37,"context_line":"    TIMEOUT_EXCEPTIONS +\u003d (TimeoutError, )"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class Client(ssh.Client):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_44127c0b","line":37,"updated":"2019-09-20 09:47:42.000000000","message":"* i guess RETRY_EXCEPTION is a better name.\n\n* why OSError needs to be retried is not obvious to me. can you put a comment?\n\n* one of the failure examples in the bug is with socket.error. don\u0027t you need to include it?","commit_id":"2057bfb10f65e291623ac1bb568ab0881b9b94f0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a2f63a65e98e8bdedb6d577daf1fc790ba1fca72","unresolved":false,"context_lines":[{"line_number":34,"context_line":"if six.PY2:"},{"line_number":35,"context_line":"    TIMEOUT_EXCEPTIONS +\u003d (OSError, )"},{"line_number":36,"context_line":"else:"},{"line_number":37,"context_line":"    TIMEOUT_EXCEPTIONS +\u003d (TimeoutError, )"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class Client(ssh.Client):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_47259eaa","line":37,"in_reply_to":"3fa7e38b_44127c0b","updated":"2019-09-20 10:12:57.000000000","message":"1) Ok, I\u0027m fine with this namw\n2) TimeoutError was added in 3.3 and corresponds to a OSError with errno.ETIMEDOUT\n3) I\u0027ll add this one too, good catch.","commit_id":"2057bfb10f65e291623ac1bb568ab0881b9b94f0"}]}