)]}'
{"neutron_tempest_plugin/api/admin/test_agent_management.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"14efc3941dd7e42bf61b87a770561d3af6765793","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        for agent in agents:"},{"line_number":39,"context_line":"            agent.pop(\u0027heartbeat_timestamp\u0027, None)"},{"line_number":40,"context_line":"            agent.pop(\u0027configurations\u0027, None)"},{"line_number":41,"context_line":"        self.assertIn(self.agent, agents)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @decorators.idempotent_id(\u0027e335be47-b9a1-46fd-be30-0874c0b751e6\u0027)"},{"line_number":44,"context_line":"    def test_list_agents_non_admin(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_a126db15","line":41,"updated":"2019-10-04 09:11:55.000000000","message":"maybe better solution for that would be to e.g. assert here that id of self.agent is in agents list, and don\u0027t expect that self.agent is not modified always.","commit_id":"7e8996cb1a919fc73082d567bbbd8a05e6e27582"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e352858b4ede8187e1a83053cff331be4a98a5af","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        for agent in agents:"},{"line_number":39,"context_line":"            agent.pop(\u0027heartbeat_timestamp\u0027, None)"},{"line_number":40,"context_line":"            agent.pop(\u0027configurations\u0027, None)"},{"line_number":41,"context_line":"        self.assertIn(self.agent, agents)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @decorators.idempotent_id(\u0027e335be47-b9a1-46fd-be30-0874c0b751e6\u0027)"},{"line_number":44,"context_line":"    def test_list_agents_non_admin(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_cb9d300b","line":41,"in_reply_to":"3fa7e38b_a126db15","updated":"2019-10-04 14:48:20.000000000","message":"You are right let\u0027s fix it correctly, see below.","commit_id":"7e8996cb1a919fc73082d567bbbd8a05e6e27582"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"14efc3941dd7e42bf61b87a770561d3af6765793","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @decorators.idempotent_id(\u002768a94a14-1243-46e6-83bf-157627e31556\u0027)"},{"line_number":66,"context_line":"    def test_update_agent_description(self):"},{"line_number":67,"context_line":"        agents \u003d self.admin_client.list_agents()[\u0027agents\u0027]"},{"line_number":68,"context_line":"        try:"},{"line_number":69,"context_line":"            dyn_agent \u003d agents[1]"},{"line_number":70,"context_line":"        except IndexError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_e10cd395","line":67,"updated":"2019-10-04 09:11:55.000000000","message":"but isn\u0027t that possible that here e.g. agents will be still returned in different order than in setUp method and we will in fact modify agent which shouldn\u0027t be modified?","commit_id":"7e8996cb1a919fc73082d567bbbd8a05e6e27582"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e352858b4ede8187e1a83053cff331be4a98a5af","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @decorators.idempotent_id(\u002768a94a14-1243-46e6-83bf-157627e31556\u0027)"},{"line_number":66,"context_line":"    def test_update_agent_description(self):"},{"line_number":67,"context_line":"        agents \u003d self.admin_client.list_agents()[\u0027agents\u0027]"},{"line_number":68,"context_line":"        try:"},{"line_number":69,"context_line":"            dyn_agent \u003d agents[1]"},{"line_number":70,"context_line":"        except IndexError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_cbe8d07d","line":67,"in_reply_to":"3fa7e38b_e10cd395","updated":"2019-10-04 14:48:20.000000000","message":"I come to the same conclusion finally.","commit_id":"7e8996cb1a919fc73082d567bbbd8a05e6e27582"}]}