)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"933b9dbe06e316f9498d2ff975719e1168b98692","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add test to attach and detach policies with regular client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The test validates that a regular client is allowd to attach\\detach"},{"line_number":10,"context_line":"QoS policies only to\\from networks with policies that were configured as \"Shared\"."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The test will not be running automatically,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3fa7e38b_33b540ee","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":50},"updated":"2019-12-03 10:10:50.000000000","message":"Noy - are you going to add \"e\" to finally fix that typo?\n:-)","commit_id":"149533ec1ab6859f29878810051818539252ad45"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2ab323e4fed2053edea738fc92de5f4a3c390cc5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add test to attach and detach policies with regular client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The test validates that a regular client is allowed to attach\\detach"},{"line_number":10,"context_line":"QoS policies only to\\from networks with policies that were configured as \"Shared\"."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The test will not be running automatically,"},{"line_number":13,"context_line":"Setting the create_shared_resources option as \u0027True\u0027 in the config.py file is needed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_b2331c13","line":10,"updated":"2019-12-08 22:48:05.000000000","message":"Please, can you limit the commit message lines to 72 chars?","commit_id":"56489152f31de148db341074bdca2abcf94a0e85"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ff2bf760e6b8fe16cb65ed045135c190991a4c6d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add test to attach and detach policies with regular client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The test validates that a regular client is allowed to attach\\detach"},{"line_number":10,"context_line":"QoS policies only to\\from networks with policies that were configured as \"Shared\"."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The test will not be running automatically,"},{"line_number":13,"context_line":"Setting the create_shared_resources option as \u0027True\u0027 in the config.py file is needed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_35b6338b","line":10,"in_reply_to":"3fa7e38b_b2331c13","updated":"2019-12-09 10:38:13.000000000","message":"+1","commit_id":"56489152f31de148db341074bdca2abcf94a0e85"},{"author":{"_account_id":30920,"name":"Noy fridman","email":"nfridman@redhat.com","username":"nfridman"},"change_message_id":"1bd857497728faff3fe23ec331fe92d1f515205d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add test to attach and detach policies with regular client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The test validates that a regular client is allowed to attach\\detach"},{"line_number":10,"context_line":"QoS policies only to\\from networks with policies that were configured as \"Shared\"."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The test will not be running automatically,"},{"line_number":13,"context_line":"Setting the create_shared_resources option as \u0027True\u0027 in the config.py file is needed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_4bcbb6a3","line":10,"in_reply_to":"3fa7e38b_b2331c13","updated":"2019-12-15 14:11:46.000000000","message":"Thank you, I will fix it!","commit_id":"56489152f31de148db341074bdca2abcf94a0e85"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ff2bf760e6b8fe16cb65ed045135c190991a4c6d","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The test will not be running automatically,"},{"line_number":13,"context_line":"Setting the create_shared_resources option as \u0027True\u0027 in the config.py file is needed."},{"line_number":14,"context_line":"Change-Id: Iec3fda32cbce00a677cb30dac3c234c99d7c27fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_d5aebf2d","line":14,"updated":"2019-12-09 10:38:13.000000000","message":"Please also add one empty line before \"Change-Id\" to have \"Change-Id\" in separate \"section\"","commit_id":"56489152f31de148db341074bdca2abcf94a0e85"},{"author":{"_account_id":30920,"name":"Noy fridman","email":"nfridman@redhat.com","username":"nfridman"},"change_message_id":"1bd857497728faff3fe23ec331fe92d1f515205d","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The test will not be running automatically,"},{"line_number":13,"context_line":"Setting the create_shared_resources option as \u0027True\u0027 in the config.py file is needed."},{"line_number":14,"context_line":"Change-Id: Iec3fda32cbce00a677cb30dac3c234c99d7c27fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_2bc67a9e","line":14,"in_reply_to":"3fa7e38b_d5aebf2d","updated":"2019-12-15 14:11:46.000000000","message":"Thanks, I will fix it","commit_id":"56489152f31de148db341074bdca2abcf94a0e85"}],"neutron_tempest_plugin/api/test_qos.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5d03e2d8e29ec31e3a457b938c725e3ec598502d","unresolved":false,"context_lines":[{"line_number":597,"context_line":"        self.admin_client.create_bandwidth_limit_rule("},{"line_number":598,"context_line":"            policy[\u0027id\u0027], 1024, 1024)[\u0027bandwidth_limit_rule\u0027]"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        self.admin_client.update_network("},{"line_number":601,"context_line":"            self.network[\u0027id\u0027], qos_policy_id\u003dpolicy[\u0027id\u0027])"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"        # As a tenant, try to detach the policy from the network"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_23954b32","line":600,"updated":"2019-11-05 12:07:02.000000000","message":"nit: you can combine L592 and this by first creating the QoS and then:\n\nself.network \u003d self.create_network(qos_policy_id\u003dpolicy[\u0027id\u0027])\n\nAs I said, this is trivial.","commit_id":"5b54ece8a350a3044e67e833ad8764fe21fac1da"},{"author":{"_account_id":30920,"name":"Noy fridman","email":"nfridman@redhat.com","username":"nfridman"},"change_message_id":"0621c4cd472185cb63843b4b1a59a7e3c5a13971","unresolved":false,"context_lines":[{"line_number":597,"context_line":"        self.admin_client.create_bandwidth_limit_rule("},{"line_number":598,"context_line":"            policy[\u0027id\u0027], 1024, 1024)[\u0027bandwidth_limit_rule\u0027]"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        self.admin_client.update_network("},{"line_number":601,"context_line":"            self.network[\u0027id\u0027], qos_policy_id\u003dpolicy[\u0027id\u0027])"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"        # As a tenant, try to detach the policy from the network"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_7a72f6b2","line":600,"in_reply_to":"3fa7e38b_23954b32","updated":"2019-11-10 11:27:09.000000000","message":"Combining this 2 operations forces me to create the network as an admin: \nself.network \u003d self.admin_client.create_network(qos_policy_id\u003dpolicy[\u0027id\u0027])\n(because the policies must be created as an admin).\n\nHowever, by doing so,the regular client won\u0027t be able to reach this network and attach\\detach policies even if the policy is \"Shared\"\n(he won\u0027t be able to reach the network at all).","commit_id":"5b54ece8a350a3044e67e833ad8764fe21fac1da"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5d03e2d8e29ec31e3a457b938c725e3ec598502d","unresolved":false,"context_lines":[{"line_number":616,"context_line":"                                   qos_policy_id\u003dNone)"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        retrieved_network \u003d self.admin_client.show_network(self.network[\u0027id\u0027])"},{"line_number":619,"context_line":"        self.assertIs("},{"line_number":620,"context_line":"            None, retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        # As a tenant, try to delete the policy from the network"},{"line_number":623,"context_line":"        # The operation should be forbidden"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_63dd8312","line":620,"range":{"start_line":619,"start_character":8,"end_line":620,"end_character":18},"updated":"2019-11-05 12:07:02.000000000","message":"self.assertIsNone(...)","commit_id":"5b54ece8a350a3044e67e833ad8764fe21fac1da"},{"author":{"_account_id":30920,"name":"Noy fridman","email":"nfridman@redhat.com","username":"nfridman"},"change_message_id":"0621c4cd472185cb63843b4b1a59a7e3c5a13971","unresolved":false,"context_lines":[{"line_number":616,"context_line":"                                   qos_policy_id\u003dNone)"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        retrieved_network \u003d self.admin_client.show_network(self.network[\u0027id\u0027])"},{"line_number":619,"context_line":"        self.assertIs("},{"line_number":620,"context_line":"            None, retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        # As a tenant, try to delete the policy from the network"},{"line_number":623,"context_line":"        # The operation should be forbidden"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_64c33f08","line":620,"range":{"start_line":619,"start_character":8,"end_line":620,"end_character":18},"in_reply_to":"3fa7e38b_63dd8312","updated":"2019-11-10 11:27:09.000000000","message":"Done","commit_id":"5b54ece8a350a3044e67e833ad8764fe21fac1da"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5357e30a642d04e7ac9dfefb84edea56d95ce794","unresolved":false,"context_lines":[{"line_number":588,"context_line":"    @decorators.idempotent_id(\u0027d911707e-fa2c-11e9-9553-5076af30bbf5\u0027)"},{"line_number":589,"context_line":"    def test_attach_and_detach_a_policy_by_a_tenant(self):"},{"line_number":590,"context_line":"        # As an admin create a policy, add a rule"},{"line_number":591,"context_line":"        # and associate it with a \"non shared\" network policy"},{"line_number":592,"context_line":"        self.network \u003d self.create_network()"},{"line_number":593,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":594,"context_line":"                                        description\u003d\u0027test policy for attach\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_b0188d76","line":591,"range":{"start_line":591,"start_character":47,"end_line":591,"end_character":61},"updated":"2019-11-06 12:40:33.000000000","message":"Ok, so the goal is to create the network, create the QoS and the update. Perfect then.","commit_id":"2f2de10b9ccfe0ef11d5218882efe91466226874"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e27f97c35f6d968307643dd34b44fb6a872f8737","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            self.network[\u0027id\u0027], qos_policy_id\u003dNone)"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"        # As an admin, make the policy shared"},{"line_number":611,"context_line":"        self.admin_client.update_qos_policy(policy[\u0027id\u0027], shared\u003dTrue)"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        # As a tenant, try to detach the policy from the network"},{"line_number":614,"context_line":"        # The operation should be allowed"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_a0cbdf6f","line":611,"updated":"2019-11-18 09:34:26.000000000","message":"I\u0027m not sure if we should have this in tempest test. In the past we had bunch of strange issues with e.g. shared resources which were used \"by accident\" in some completly different tests.\nHere it is probably the same - we can\u0027t assume that such qos policy will not be suddently used by network/port in other test and that this will later e.g. cause failure during the cleanup phase in this test.","commit_id":"2f2de10b9ccfe0ef11d5218882efe91466226874"},{"author":{"_account_id":30920,"name":"Noy fridman","email":"nfridman@redhat.com","username":"nfridman"},"change_message_id":"8d598827065e6bbc849fd31feb178ebe8a02cd31","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            self.network[\u0027id\u0027], qos_policy_id\u003dNone)"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"        # As an admin, make the policy shared"},{"line_number":611,"context_line":"        self.admin_client.update_qos_policy(policy[\u0027id\u0027], shared\u003dTrue)"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        # As a tenant, try to detach the policy from the network"},{"line_number":614,"context_line":"        # The operation should be allowed"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_4c66e553","line":611,"in_reply_to":"3fa7e38b_a0cbdf6f","updated":"2019-12-09 09:37:10.000000000","message":"Hi Slawek :)\nDoes deleting the policy or changing it to \"shared\u003dFalse\" by the end of the test could solve the problem?\n\nThanks!","commit_id":"2f2de10b9ccfe0ef11d5218882efe91466226874"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2ab323e4fed2053edea738fc92de5f4a3c390cc5","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        \"\"\"Creation of shared resources should be allowed,"},{"line_number":592,"context_line":"        setting the create_shared_resources option as \u0027True\u0027 is needed\"\"\")"},{"line_number":593,"context_line":"    @decorators.idempotent_id(\u0027d911707e-fa2c-11e9-9553-5076af30bbf5\u0027)"},{"line_number":594,"context_line":"    def test_attach_and_detach_a_policy_by_a_tenant(self):"},{"line_number":595,"context_line":"        # As an admin create an non shared QoS policy,add a rule"},{"line_number":596,"context_line":"        # and associate it with a network"},{"line_number":597,"context_line":"        self.network \u003d self.create_network()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_5266682a","line":594,"updated":"2019-12-08 22:48:05.000000000","message":"This test in not being executed.","commit_id":"56489152f31de148db341074bdca2abcf94a0e85"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ff2bf760e6b8fe16cb65ed045135c190991a4c6d","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        \"\"\"Creation of shared resources should be allowed,"},{"line_number":592,"context_line":"        setting the create_shared_resources option as \u0027True\u0027 is needed\"\"\")"},{"line_number":593,"context_line":"    @decorators.idempotent_id(\u0027d911707e-fa2c-11e9-9553-5076af30bbf5\u0027)"},{"line_number":594,"context_line":"    def test_attach_and_detach_a_policy_by_a_tenant(self):"},{"line_number":595,"context_line":"        # As an admin create an non shared QoS policy,add a rule"},{"line_number":596,"context_line":"        # and associate it with a network"},{"line_number":597,"context_line":"        self.network \u003d self.create_network()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_f5597b5a","line":594,"in_reply_to":"3fa7e38b_356e33c8","updated":"2019-12-09 10:38:13.000000000","message":"@Rodolfo: yes, that was intended here. We don\u0027t want to run such tests in gate where it may interfere with other tests running in parallel.","commit_id":"56489152f31de148db341074bdca2abcf94a0e85"},{"author":{"_account_id":30920,"name":"Noy fridman","email":"nfridman@redhat.com","username":"nfridman"},"change_message_id":"8d598827065e6bbc849fd31feb178ebe8a02cd31","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        \"\"\"Creation of shared resources should be allowed,"},{"line_number":592,"context_line":"        setting the create_shared_resources option as \u0027True\u0027 is needed\"\"\")"},{"line_number":593,"context_line":"    @decorators.idempotent_id(\u0027d911707e-fa2c-11e9-9553-5076af30bbf5\u0027)"},{"line_number":594,"context_line":"    def test_attach_and_detach_a_policy_by_a_tenant(self):"},{"line_number":595,"context_line":"        # As an admin create an non shared QoS policy,add a rule"},{"line_number":596,"context_line":"        # and associate it with a network"},{"line_number":597,"context_line":"        self.network \u003d self.create_network()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_356e33c8","line":594,"in_reply_to":"3fa7e38b_5266682a","updated":"2019-12-09 09:37:10.000000000","message":"The test is not running by default because the usage of the \"shared\" resource that may cause problems with other tests while running. \nIn order to make it run, the \u0027create_shared_resources\u0027 option in the config file should be set.","commit_id":"56489152f31de148db341074bdca2abcf94a0e85"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2ab323e4fed2053edea738fc92de5f4a3c390cc5","unresolved":false,"context_lines":[{"line_number":633,"context_line":""},{"line_number":634,"context_line":"class QosBandwidthLimitRuleWithDirectionTestJSON("},{"line_number":635,"context_line":"        QosBandwidthLimitRuleTestJSON):"},{"line_number":636,"context_line":"    DIRECTION_EGRESS \u003d \"egress\""},{"line_number":637,"context_line":"    DIRECTION_INGRESS \u003d \"ingress\""},{"line_number":638,"context_line":"    required_extensions \u003d ("},{"line_number":639,"context_line":"        QosBandwidthLimitRuleTestJSON.required_extensions +"},{"line_number":640,"context_line":"        [\u0027qos-bw-limit-direction\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_127470cf","line":637,"range":{"start_line":636,"start_character":4,"end_line":637,"end_character":33},"updated":"2019-12-08 22:48:05.000000000","message":"Please, use n-lib constants for this.","commit_id":"56489152f31de148db341074bdca2abcf94a0e85"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ff2bf760e6b8fe16cb65ed045135c190991a4c6d","unresolved":false,"context_lines":[{"line_number":633,"context_line":""},{"line_number":634,"context_line":"class QosBandwidthLimitRuleWithDirectionTestJSON("},{"line_number":635,"context_line":"        QosBandwidthLimitRuleTestJSON):"},{"line_number":636,"context_line":"    DIRECTION_EGRESS \u003d \"egress\""},{"line_number":637,"context_line":"    DIRECTION_INGRESS \u003d \"ingress\""},{"line_number":638,"context_line":"    required_extensions \u003d ("},{"line_number":639,"context_line":"        QosBandwidthLimitRuleTestJSON.required_extensions +"},{"line_number":640,"context_line":"        [\u0027qos-bw-limit-direction\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_153457f9","line":637,"range":{"start_line":636,"start_character":4,"end_line":637,"end_character":33},"in_reply_to":"3fa7e38b_127470cf","updated":"2019-12-09 10:38:13.000000000","message":"+1","commit_id":"56489152f31de148db341074bdca2abcf94a0e85"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2ab323e4fed2053edea738fc92de5f4a3c390cc5","unresolved":false,"context_lines":[{"line_number":656,"context_line":"                                        description\u003d\u0027test policy1\u0027,"},{"line_number":657,"context_line":"                                        shared\u003dFalse)"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        rule1 \u003d self.create_qos_bandwidth_limit_rule(policy_id\u003dpolicy[\u0027id\u0027],"},{"line_number":660,"context_line":"                                                     max_kbps\u003d1024,"},{"line_number":661,"context_line":"                                                     max_burst_kbps\u003d1024,"},{"line_number":662,"context_line":"                                                     direction\u003dself."}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_325acc4f","line":659,"updated":"2019-12-08 22:48:05.000000000","message":"Do we need to test this here again? Sorry, what\u0027s the goal of this test? I\u0027m a bit lost.\n\nBTW, this test has two scenarios, testing both directions.","commit_id":"56489152f31de148db341074bdca2abcf94a0e85"},{"author":{"_account_id":30920,"name":"Noy fridman","email":"nfridman@redhat.com","username":"nfridman"},"change_message_id":"1bd857497728faff3fe23ec331fe92d1f515205d","unresolved":false,"context_lines":[{"line_number":656,"context_line":"                                        description\u003d\u0027test policy1\u0027,"},{"line_number":657,"context_line":"                                        shared\u003dFalse)"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        rule1 \u003d self.create_qos_bandwidth_limit_rule(policy_id\u003dpolicy[\u0027id\u0027],"},{"line_number":660,"context_line":"                                                     max_kbps\u003d1024,"},{"line_number":661,"context_line":"                                                     max_burst_kbps\u003d1024,"},{"line_number":662,"context_line":"                                                     direction\u003dself."}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_ebbf02fb","line":659,"in_reply_to":"3fa7e38b_18024e09","updated":"2019-12-15 14:11:46.000000000","message":"Thanks a lot! I got it now.","commit_id":"56489152f31de148db341074bdca2abcf94a0e85"},{"author":{"_account_id":30920,"name":"Noy fridman","email":"nfridman@redhat.com","username":"nfridman"},"change_message_id":"8d598827065e6bbc849fd31feb178ebe8a02cd31","unresolved":false,"context_lines":[{"line_number":656,"context_line":"                                        description\u003d\u0027test policy1\u0027,"},{"line_number":657,"context_line":"                                        shared\u003dFalse)"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        rule1 \u003d self.create_qos_bandwidth_limit_rule(policy_id\u003dpolicy[\u0027id\u0027],"},{"line_number":660,"context_line":"                                                     max_kbps\u003d1024,"},{"line_number":661,"context_line":"                                                     max_burst_kbps\u003d1024,"},{"line_number":662,"context_line":"                                                     direction\u003dself."}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_952e078b","line":659,"in_reply_to":"3fa7e38b_325acc4f","updated":"2019-12-09 09:37:10.000000000","message":"Hi Rodolfo, Please let me explain:)\nThe test \"test_create_policy_with_multiple_rules\" has been already merged. I added it to this patch in order to prevent code conflict (shouldn\u0027t I do it?)","commit_id":"56489152f31de148db341074bdca2abcf94a0e85"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ff2bf760e6b8fe16cb65ed045135c190991a4c6d","unresolved":false,"context_lines":[{"line_number":656,"context_line":"                                        description\u003d\u0027test policy1\u0027,"},{"line_number":657,"context_line":"                                        shared\u003dFalse)"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        rule1 \u003d self.create_qos_bandwidth_limit_rule(policy_id\u003dpolicy[\u0027id\u0027],"},{"line_number":660,"context_line":"                                                     max_kbps\u003d1024,"},{"line_number":661,"context_line":"                                                     max_burst_kbps\u003d1024,"},{"line_number":662,"context_line":"                                                     direction\u003dself."}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_18024e09","line":659,"in_reply_to":"3fa7e38b_952e078b","updated":"2019-12-09 10:38:13.000000000","message":"if it was already merged, You should simply rebase Your patch and You don\u0027t need to add code again","commit_id":"56489152f31de148db341074bdca2abcf94a0e85"}],"neutron_tempest_plugin/config.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1cc13e95feabb9867b14eab6247f6104d6738580","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    # Option for creating QoS policies configures as \"shared\"."},{"line_number":120,"context_line":"    # The default is false in order to prevent undesired usage"},{"line_number":121,"context_line":"    # while testing in parallel."},{"line_number":122,"context_line":"    cfg.BoolOpt(\u0027create_shared_qos_policy\u0027,"},{"line_number":123,"context_line":"                default\u003dFalse,"},{"line_number":124,"context_line":"                help\u003d\u0027Allow creation of a QoS policy configured as \"shared\"\u0027"},{"line_number":125,"context_line":"                     \u0027The default value is false.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_c64bde83","line":122,"range":{"start_line":122,"start_character":17,"end_line":122,"end_character":41},"updated":"2019-12-02 13:06:22.000000000","message":"maybe we can do it more generic, like e.g. \"create_shared_resources\" or something like that?","commit_id":"149533ec1ab6859f29878810051818539252ad45"},{"author":{"_account_id":30920,"name":"Noy fridman","email":"nfridman@redhat.com","username":"nfridman"},"change_message_id":"8d598827065e6bbc849fd31feb178ebe8a02cd31","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    # Option for creating QoS policies configures as \"shared\"."},{"line_number":120,"context_line":"    # The default is false in order to prevent undesired usage"},{"line_number":121,"context_line":"    # while testing in parallel."},{"line_number":122,"context_line":"    cfg.BoolOpt(\u0027create_shared_qos_policy\u0027,"},{"line_number":123,"context_line":"                default\u003dFalse,"},{"line_number":124,"context_line":"                help\u003d\u0027Allow creation of a QoS policy configured as \"shared\"\u0027"},{"line_number":125,"context_line":"                     \u0027The default value is false.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_ccbe43ae","line":122,"range":{"start_line":122,"start_character":17,"end_line":122,"end_character":41},"in_reply_to":"3fa7e38b_33278066","updated":"2019-12-09 09:37:10.000000000","message":"Done","commit_id":"149533ec1ab6859f29878810051818539252ad45"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1110174488d3ab44174ea5b949c8da158b2cf68a","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    # Option for creating QoS policies configures as \"shared\"."},{"line_number":120,"context_line":"    # The default is false in order to prevent undesired usage"},{"line_number":121,"context_line":"    # while testing in parallel."},{"line_number":122,"context_line":"    cfg.BoolOpt(\u0027create_shared_qos_policy\u0027,"},{"line_number":123,"context_line":"                default\u003dFalse,"},{"line_number":124,"context_line":"                help\u003d\u0027Allow creation of a QoS policy configured as \"shared\"\u0027"},{"line_number":125,"context_line":"                     \u0027The default value is false.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_d83c0bc2","line":122,"range":{"start_line":122,"start_character":17,"end_line":122,"end_character":41},"in_reply_to":"3fa7e38b_c64bde83","updated":"2019-12-03 08:42:29.000000000","message":"Slawek - do you mean changing parameter\u0027s name?\n\"create_shared_qos_policy\" to \"create_shared_resources\"\nSo other tests that might use some shared resources will check this value as well?","commit_id":"149533ec1ab6859f29878810051818539252ad45"},{"author":{"_account_id":30920,"name":"Noy fridman","email":"nfridman@redhat.com","username":"nfridman"},"change_message_id":"8d598827065e6bbc849fd31feb178ebe8a02cd31","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    # Option for creating QoS policies configures as \"shared\"."},{"line_number":120,"context_line":"    # The default is false in order to prevent undesired usage"},{"line_number":121,"context_line":"    # while testing in parallel."},{"line_number":122,"context_line":"    cfg.BoolOpt(\u0027create_shared_qos_policy\u0027,"},{"line_number":123,"context_line":"                default\u003dFalse,"},{"line_number":124,"context_line":"                help\u003d\u0027Allow creation of a QoS policy configured as \"shared\"\u0027"},{"line_number":125,"context_line":"                     \u0027The default value is false.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_2cc6f74a","line":122,"range":{"start_line":122,"start_character":17,"end_line":122,"end_character":41},"in_reply_to":"3fa7e38b_d83c0bc2","updated":"2019-12-09 09:37:10.000000000","message":"Done","commit_id":"149533ec1ab6859f29878810051818539252ad45"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ff89d01e21890ea11b2e8ae3a339b06767303a39","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    # Option for creating QoS policies configures as \"shared\"."},{"line_number":120,"context_line":"    # The default is false in order to prevent undesired usage"},{"line_number":121,"context_line":"    # while testing in parallel."},{"line_number":122,"context_line":"    cfg.BoolOpt(\u0027create_shared_qos_policy\u0027,"},{"line_number":123,"context_line":"                default\u003dFalse,"},{"line_number":124,"context_line":"                help\u003d\u0027Allow creation of a QoS policy configured as \"shared\"\u0027"},{"line_number":125,"context_line":"                     \u0027The default value is false.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_33278066","line":122,"range":{"start_line":122,"start_character":17,"end_line":122,"end_character":41},"in_reply_to":"3fa7e38b_d83c0bc2","updated":"2019-12-03 10:06:42.000000000","message":"Exactly. I was thinking about something like that. Than in can be potentially reused in other tests if needed. And we will not end up with various, very similar config knobs :)","commit_id":"149533ec1ab6859f29878810051818539252ad45"}]}