)]}'
{"neutron_tempest_plugin/scenario/test_port_forwardings.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"960ef2eeb95d0f4c749532fc0bf9e3ec75ce721f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                self.fip[\u0027floating_ip_address\u0027],"},{"line_number":88,"context_line":"                server[\u0027port_forwarding_udp\u0027][\u0027external_port\u0027],"},{"line_number":89,"context_line":"                constants.PROTO_NAME_UDP)"},{"line_number":90,"context_line":"            return expected_msg in received_msg"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        for server in servers:"},{"line_number":93,"context_line":"            msg \u003d \"%s-UDP-test\" % server[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_faa12da9","line":90,"updated":"2020-01-09 14:59:30.000000000","message":"I\u0027m OK with this change but we can also change how netcat is called [1]. We are using netcat traditional (because we have the options -c and -e). Instead of \"-e\", we should use \"-c\" [2]\n\nscenario.base.BaseTempestTestCase.nc_listen\n\n[1] https://manpages.debian.org/testing/netcat-traditional/nc.1.en.html\n[2] http://paste.openstack.org/show/788205/","commit_id":"44e084ebad47b59ceb82a31bdc9b437aa1bab4e3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fd99b26329fda9f8ef90a35127ff14b0b15a862a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                self.fip[\u0027floating_ip_address\u0027],"},{"line_number":88,"context_line":"                server[\u0027port_forwarding_udp\u0027][\u0027external_port\u0027],"},{"line_number":89,"context_line":"                constants.PROTO_NAME_UDP)"},{"line_number":90,"context_line":"            return expected_msg in received_msg"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        for server in servers:"},{"line_number":93,"context_line":"            msg \u003d \"%s-UDP-test\" % server[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_4ca70c53","line":90,"in_reply_to":"3fa7e38b_faa12da9","updated":"2020-01-16 14:52:17.000000000","message":"Changed in separate patch https://review.opendev.org/702882","commit_id":"44e084ebad47b59ceb82a31bdc9b437aa1bab4e3"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"0816f0efabc35a1d279973bf5ee84e2cb6c29f0d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib import constants"},{"line_number":17,"context_line":"from neutron_lib.utils import test"},{"line_number":18,"context_line":"from oslo_log import log"},{"line_number":19,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_ef159596","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":34},"updated":"2020-02-04 11:18:42.000000000","message":"Can probably be dropped as we do not have anymore unstable tests here?","commit_id":"312039fdb2153813baa82520d7c7891b9bc9bce3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1eb02001c62ca6638528f36e052672dda07bd4bb","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def _test_udp_port_forwarding(self, servers):"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        def _message_received(server, ssh_client, expected_msg):"},{"line_number":86,"context_line":"            self.nc_listen(server,"},{"line_number":87,"context_line":"                           ssh_client,"},{"line_number":88,"context_line":"                           server[\u0027port_forwarding_udp\u0027][\u0027internal_port\u0027],"},{"line_number":89,"context_line":"                           constants.PROTO_NAME_UDP,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1fa4df85_73075a1e","line":86,"updated":"2020-02-26 13:13:00.000000000","message":"Yes, good idea to include the server/client creation in the wait context.","commit_id":"bd0f3712e25413e6c5b1ed5c35ef6e1361d922a6"}]}