)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"768a6de7f2ff471d2a92d464458ed52ec2479059","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ccamposr \u003cccamposr@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-01-29 11:12:21 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[neutron-dvr-NetworkConnectivity]Change net ip pool in test_connectivity_dvr_and_no_dvr_routers_in_same_subnet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" Change ip pool to avoid conflict with external network pool"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_86ec5892","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":33},"updated":"2020-01-29 11:34:31.000000000","message":"Not needed. Please, reduce the length of the title to 72 chars.","commit_id":"318fc9bde5c114ea96e79d5c69795f4a63f9278d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"768a6de7f2ff471d2a92d464458ed52ec2479059","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[neutron-dvr-NetworkConnectivity]Change net ip pool in test_connectivity_dvr_and_no_dvr_routers_in_same_subnet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" Change ip pool to avoid conflict with external network pool"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I39ca6474068d2e169dff1b81d2a0c71a8361c01f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_46e2e09d","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":1},"updated":"2020-01-29 11:34:31.000000000","message":"to be removed","commit_id":"318fc9bde5c114ea96e79d5c69795f4a63f9278d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"768a6de7f2ff471d2a92d464458ed52ec2479059","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[neutron-dvr-NetworkConnectivity]Change net ip pool in test_connectivity_dvr_and_no_dvr_routers_in_same_subnet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" Change ip pool to avoid conflict with external network pool"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I39ca6474068d2e169dff1b81d2a0c71a8361c01f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_26fb2448","line":10,"updated":"2020-01-29 11:34:31.000000000","message":"Do you have a launchpad bug? Do you have logs to document this possible bug?","commit_id":"318fc9bde5c114ea96e79d5c69795f4a63f9278d"},{"author":{"_account_id":29088,"name":"Candido Campos Rivas","email":"ccamposr@redhat.com","username":"ccamposr"},"change_message_id":"966677bd25e562853c6a5dd527b936f930c2d9e4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[neutron-dvr-NetworkConnectivity]Change net ip pool in test_connectivity_dvr_and_no_dvr_routers_in_same_subnet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" Change ip pool to avoid conflict with external network pool"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I39ca6474068d2e169dff1b81d2a0c71a8361c01f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_261c8479","line":10,"in_reply_to":"3fa7e38b_26fb2448","updated":"2020-01-29 11:42:06.000000000","message":"I have a bz:\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1795638","commit_id":"318fc9bde5c114ea96e79d5c69795f4a63f9278d"}],"neutron_tempest_plugin/common/ip.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"57283efd56073238b6ee1512ead53f4acc4e78b9","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        if valid_network in valid_ips:"},{"line_number":332,"context_line":"            return valid_network.cidr"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    raise Exception(\u0027Not valid CIDR found in %(valid_cidr)s, used CIDR \u0027"},{"line_number":335,"context_line":"                    \u0027%(used_cidr)s\u0027 % {\u0027valid_cidr\u0027: valid_cidr,"},{"line_number":336,"context_line":"                                       \u0027used_cidr\u0027: used_cidr})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_924c8b75","line":334,"range":{"start_line":334,"start_character":21,"end_line":334,"end_character":24},"updated":"2020-01-29 16:49:08.000000000","message":"s/No","commit_id":"3edb5eba3878aaf797ebda7042d1f9a27da147aa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2eb69d0c9cf3cf5e28ad31b53121eb5b39c301a6","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        if valid_network in valid_ips:"},{"line_number":332,"context_line":"            return valid_network.cidr"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    raise Exception(\u0027Not valid CIDR found in %(valid_cidr)s, used CIDR \u0027"},{"line_number":335,"context_line":"                    \u0027%(used_cidr)s\u0027 % {\u0027valid_cidr\u0027: valid_cidr,"},{"line_number":336,"context_line":"                                       \u0027used_cidr\u0027: used_cidr})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ed516464","line":334,"range":{"start_line":334,"start_character":21,"end_line":334,"end_character":24},"in_reply_to":"3fa7e38b_924c8b75","updated":"2020-01-29 18:19:35.000000000","message":"Done","commit_id":"3edb5eba3878aaf797ebda7042d1f9a27da147aa"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"23b9663fdb6275437089455468c4a1eac3827527","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        if valid_network in valid_ips:"},{"line_number":332,"context_line":"            return valid_network.cidr"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    raise Exception(\u0027Not valid CIDR found in %(valid_cidr)s, used CIDR \u0027"},{"line_number":335,"context_line":"                    \u0027%(used_cidr)s\u0027 % {\u0027valid_cidr\u0027: valid_cidr,"},{"line_number":336,"context_line":"                                       \u0027used_cidr\u0027: used_cidr})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d273e3e3","line":334,"range":{"start_line":334,"start_character":21,"end_line":334,"end_character":24},"in_reply_to":"3fa7e38b_924c8b75","updated":"2020-01-29 17:35:11.000000000","message":"I think it might make sense to have two different exceptions here based on an \"if used_cidr:\".  In the exception \"Exception: Not valid CIDR found in 10.0.0.0/8, used CIDR None\", the part after the comma will just be confusing.  \n\n  exception_str \u003d \u0027Not valid CIDR found in %(valid_cidr)s\u0027 % {\u0027valid_cidr\u0027: valid_cidr}\n  if used_cidr:\n     exception_str +\u003d \u0027, used CIDR %(used_cidr)s\u0027 % {\u0027used_cidr\u0027: used_cidr}\n  raise Exception(exception_str)","commit_id":"3edb5eba3878aaf797ebda7042d1f9a27da147aa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2eb69d0c9cf3cf5e28ad31b53121eb5b39c301a6","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        if valid_network in valid_ips:"},{"line_number":332,"context_line":"            return valid_network.cidr"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    raise Exception(\u0027Not valid CIDR found in %(valid_cidr)s, used CIDR \u0027"},{"line_number":335,"context_line":"                    \u0027%(used_cidr)s\u0027 % {\u0027valid_cidr\u0027: valid_cidr,"},{"line_number":336,"context_line":"                                       \u0027used_cidr\u0027: used_cidr})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_0d4de0c3","line":334,"range":{"start_line":334,"start_character":21,"end_line":334,"end_character":24},"in_reply_to":"3fa7e38b_d273e3e3","updated":"2020-01-29 18:19:35.000000000","message":"Done","commit_id":"3edb5eba3878aaf797ebda7042d1f9a27da147aa"}],"neutron_tempest_plugin/scenario/test_connectivity.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"768a6de7f2ff471d2a92d464458ed52ec2479059","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                               +---+"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        where:"},{"line_number":179,"context_line":"        10.1.0.1 - is subnet\u0027s gateway IP address,"},{"line_number":180,"context_line":"        10.1.0.x - is any other IP address taken from subnet\u0027s range"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        Test ensures that both 10.1.0.1 and 10.1.0.x IP addresses are"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e6850cac","line":179,"updated":"2020-01-29 11:34:31.000000000","message":"Something a bit more elaborated, if we are having IP clashes, is to implement something like [1]:\n- List the ports\n- Read the CIDRs\n- Find an unused one.\n\n[1] https://review.opendev.org/#/c/684279/3/neutron/tests/fullstack/base.py","commit_id":"318fc9bde5c114ea96e79d5c69795f4a63f9278d"}]}