)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"c5e637c691cb62fb4fcfa7c78a154466589d11bf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-07 11:10:15 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enhance the test_multicast_between_vms_on_same_network test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is enhancing the test_multicast_between_vms_on_same_network"},{"line_number":10,"context_line":"test to fit the different scenarios that can be encountered when using"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_b3c829a7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":59},"updated":"2020-02-07 11:19:35.000000000","message":"I would actually rephrase this somehow to reflect that is not just enhancing the current test but also adding IGMP test coverage which didn\u0027t exist before :)","commit_id":"436a4a5df4a5e973cebac9078b541fe98d5a7953"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6fcd4cc27448a21d4a0c788c122075f6f1b9bf5a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-07 11:10:15 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enhance the test_multicast_between_vms_on_same_network test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is enhancing the test_multicast_between_vms_on_same_network"},{"line_number":10,"context_line":"test to fit the different scenarios that can be encountered when using"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_5344551a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":59},"in_reply_to":"3fa7e38b_b3c829a7","updated":"2020-02-07 11:20:45.000000000","message":"True that, well, if I happen to send a new patch-set I can update it.","commit_id":"436a4a5df4a5e973cebac9078b541fe98d5a7953"}],"neutron_tempest_plugin/config.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"099cb5b0ae71e82ea27c037eda03a840206ce20e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                help\u003d\u0027Indicates whether IGMP snooping is enabled or not. \u0027"},{"line_number":129,"context_line":"                     \u0027If True, multicast test(s) will assert that multicast \u0027"},{"line_number":130,"context_line":"                     \u0027traffic is not being flooded to all ports. Defaults \u0027"},{"line_number":131,"context_line":"                     \u0027to False.\u0027),"},{"line_number":132,"context_line":"]"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# TODO(amuller): Redo configuration options registration as part of the planned"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_c00a941c","line":131,"updated":"2020-02-10 09:38:37.000000000","message":"maybe we should add release note as we are adding new config option?","commit_id":"436a4a5df4a5e973cebac9078b541fe98d5a7953"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"0c76a3268b154c3d1d4e8f0ade377516678b281a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                help\u003d\u0027Indicates whether IGMP snooping is enabled or not. \u0027"},{"line_number":129,"context_line":"                     \u0027If True, multicast test(s) will assert that multicast \u0027"},{"line_number":130,"context_line":"                     \u0027traffic is not being flooded to all ports. Defaults \u0027"},{"line_number":131,"context_line":"                     \u0027to False.\u0027),"},{"line_number":132,"context_line":"]"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# TODO(amuller): Redo configuration options registration as part of the planned"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_cd672c52","line":131,"in_reply_to":"3fa7e38b_c00a941c","updated":"2020-02-10 12:03:29.000000000","message":"+1","commit_id":"436a4a5df4a5e973cebac9078b541fe98d5a7953"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a50b08413596e8bcebbced854e02da4d243bb5e4","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                help\u003d\u0027Indicates whether IGMP snooping is enabled or not. \u0027"},{"line_number":129,"context_line":"                     \u0027If True, multicast test(s) will assert that multicast \u0027"},{"line_number":130,"context_line":"                     \u0027traffic is not being flooded to all ports. Defaults \u0027"},{"line_number":131,"context_line":"                     \u0027to False.\u0027),"},{"line_number":132,"context_line":"]"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# TODO(amuller): Redo configuration options registration as part of the planned"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_2d7fe0de","line":131,"in_reply_to":"3fa7e38b_c00a941c","updated":"2020-02-10 11:51:16.000000000","message":"Fair enough, will do!","commit_id":"436a4a5df4a5e973cebac9078b541fe98d5a7953"}],"neutron_tempest_plugin/scenario/test_multicast.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"af2bdb10c4f4413af180e093edc0bf86be7e86fd","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @test.unstable_test(\"bug 1850288\")"},{"line_number":253,"context_line":"    @decorators.idempotent_id(\u0027113486fc-24c9-4be4-8361-03b1c9892867\u0027)"},{"line_number":254,"context_line":"    def test_multicast_between_vms_on_same_network(self):"},{"line_number":255,"context_line":"        \"\"\"Test multicast messaging between two servers on the same network"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        [Sender server] -\u003e (Multicast network) -\u003e [Receiver server]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_d2438a11","line":254,"updated":"2020-02-05 10:25:36.000000000","message":"igmp snooping can be turned on in config and it\u0027s not enabled by default. So IMO we should skip this test if igmp snooping is disabled. Otherwise it will fail in such case.","commit_id":"7e2b01766ce0fb90bd31abd006334c26d36f750c"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"fafbc12e4890661206ede4f246470f11b80fb780","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @test.unstable_test(\"bug 1850288\")"},{"line_number":253,"context_line":"    @decorators.idempotent_id(\u0027113486fc-24c9-4be4-8361-03b1c9892867\u0027)"},{"line_number":254,"context_line":"    def test_multicast_between_vms_on_same_network(self):"},{"line_number":255,"context_line":"        \"\"\"Test multicast messaging between two servers on the same network"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        [Sender server] -\u003e (Multicast network) -\u003e [Receiver server]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8894029a","line":254,"in_reply_to":"3fa7e38b_451b536e","updated":"2020-02-05 14:55:12.000000000","message":"Regardless of the option, this test should run and pass anyways no? Even if IGMP is disabled, multicast traffic should pass by default as it\u0027s expected to be flooded to all ports. It was actually passing before we had IGMP snooping support.","commit_id":"7e2b01766ce0fb90bd31abd006334c26d36f750c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eb3e1023a331514291f472c929f3657bf47c1a32","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @test.unstable_test(\"bug 1850288\")"},{"line_number":253,"context_line":"    @decorators.idempotent_id(\u0027113486fc-24c9-4be4-8361-03b1c9892867\u0027)"},{"line_number":254,"context_line":"    def test_multicast_between_vms_on_same_network(self):"},{"line_number":255,"context_line":"        \"\"\"Test multicast messaging between two servers on the same network"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        [Sender server] -\u003e (Multicast network) -\u003e [Receiver server]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_451b536e","line":254,"in_reply_to":"3fa7e38b_ad0f93d2","updated":"2020-02-05 14:08:23.000000000","message":"\u003e Is this the config you thinking of: https://opendev.org/openstack/neutron/src/branch/master/neutron/conf/agent/ovs_conf.py#L36\n \u003e ?\n\nYes, this is the option I was thinking of.\n\n \u003e \n \u003e If so I have a question, because I thought about re-using it in the\n \u003e OVN driver but I didn\u0027t know if it makes sense since it\u0027s part of\n \u003e the neutron agent configuration which is not deployed with OVN.\n \u003e \n \u003e Instead, I added another config for OVN (patch is not yet merged so\n \u003e we can change).\n \u003e \n \u003e Perhaps we can refactor this config out of the agent and reuse on\n \u003e both drivers, what u think ?\n\nYes, when I was adding this option I though it can be used by both drivers (ovs agent and ovn). Can\u0027t You simply import this config option in ovn mechanism driver and reuse it there? It should be simply put in \"OVS\" section in config file so it should be fine IMO.","commit_id":"7e2b01766ce0fb90bd31abd006334c26d36f750c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f7683ed5f175011d3f43caf8f53df0856835134a","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @test.unstable_test(\"bug 1850288\")"},{"line_number":253,"context_line":"    @decorators.idempotent_id(\u0027113486fc-24c9-4be4-8361-03b1c9892867\u0027)"},{"line_number":254,"context_line":"    def test_multicast_between_vms_on_same_network(self):"},{"line_number":255,"context_line":"        \"\"\"Test multicast messaging between two servers on the same network"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        [Sender server] -\u003e (Multicast network) -\u003e [Receiver server]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ad0f93d2","line":254,"in_reply_to":"3fa7e38b_d2438a11","updated":"2020-02-05 11:41:47.000000000","message":"Is this the config you thinking of: https://opendev.org/openstack/neutron/src/branch/master/neutron/conf/agent/ovs_conf.py#L36 ?\n\nIf so I have a question, because I thought about re-using it in the OVN driver but I didn\u0027t know if it makes sense since it\u0027s part of the neutron agent configuration which is not deployed with OVN. \n\nInstead, I added another config for OVN (patch is not yet merged so we can change).\n\nPerhaps we can refactor this config out of the agent and reuse on both drivers, what u think ?","commit_id":"7e2b01766ce0fb90bd31abd006334c26d36f750c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"af2bdb10c4f4413af180e093edc0bf86be7e86fd","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        # Assert that the message sent by the sender did not arrive"},{"line_number":330,"context_line":"        # at the unregistered node"},{"line_number":331,"context_line":"        unregistered_result \u003d unregistered[\u0027ssh_client\u0027].execute_script("},{"line_number":332,"context_line":"            \"cat {path} || echo \u0027{path} not exists yet\u0027\".format("},{"line_number":333,"context_line":"                path\u003dself.unregistered_output_file))"},{"line_number":334,"context_line":"        self.assertIn(\u00270 packets captured\u0027, unregistered_result)"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_72ce56b7","line":332,"updated":"2020-02-05 10:25:36.000000000","message":"so if this file don\u0027t exists for some reason, test will fail, right?","commit_id":"7e2b01766ce0fb90bd31abd006334c26d36f750c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f7683ed5f175011d3f43caf8f53df0856835134a","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        # Assert that the message sent by the sender did not arrive"},{"line_number":330,"context_line":"        # at the unregistered node"},{"line_number":331,"context_line":"        unregistered_result \u003d unregistered[\u0027ssh_client\u0027].execute_script("},{"line_number":332,"context_line":"            \"cat {path} || echo \u0027{path} not exists yet\u0027\".format("},{"line_number":333,"context_line":"                path\u003dself.unregistered_output_file))"},{"line_number":334,"context_line":"        self.assertIn(\u00270 packets captured\u0027, unregistered_result)"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_6d019bb4","line":332,"in_reply_to":"3fa7e38b_72ce56b7","updated":"2020-02-05 11:41:47.000000000","message":"Yes, because it won\u0027t match the \"0 packets captured\" on the assertion from L334","commit_id":"7e2b01766ce0fb90bd31abd006334c26d36f750c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ae696a14a69aa8b818a33be58d2160474b87eeec","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        if not advanced_image_available:"},{"line_number":146,"context_line":"            skip_reason \u003d \"This test require advanced tools for this test\""},{"line_number":147,"context_line":"            raise cls.skipException(skip_reason)"},{"line_number":148,"context_line":"        elif not cfg.CONF.ovs.igmp_snooping_enable:"},{"line_number":149,"context_line":"            skip_reason \u003d \"This test require IGMP snooping to be enabled\""},{"line_number":150,"context_line":"            raise cls.skipException(skip_reason)"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_48afea9c","line":148,"updated":"2020-02-05 15:05:51.000000000","message":"Doesn\u0027t seem to work... Perhaps I will need to import the ovs_config from neutron ?! Not sure will search about it.","commit_id":"650a0efc883db72ede8efddf24e29cc4729b83a5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"531255f956b13127bb8b031e732b42d294a20161","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        if not advanced_image_available:"},{"line_number":146,"context_line":"            skip_reason \u003d \"This test require advanced tools for this test\""},{"line_number":147,"context_line":"            raise cls.skipException(skip_reason)"},{"line_number":148,"context_line":"        elif not cfg.CONF.ovs.igmp_snooping_enable:"},{"line_number":149,"context_line":"            skip_reason \u003d \"This test require IGMP snooping to be enabled\""},{"line_number":150,"context_line":"            raise cls.skipException(skip_reason)"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c6c5f736","line":148,"in_reply_to":"3fa7e38b_48afea9c","updated":"2020-02-06 14:45:28.000000000","message":"ahh, no. I was thinking that this option can be re-used in the ovn driver in neutron.\nBut in tempest plugin it will not work like that. Here You wil probably need to define new config option in https://github.com/openstack/neutron-tempest-plugin/blob/master/neutron_tempest_plugin/config.py module, something like \"is_igmp_snooping_enabled\" which we can use to tell to tempest that infra has got enabled this option (or not) and than decide in the test how test should runs.","commit_id":"650a0efc883db72ede8efddf24e29cc4729b83a5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"97ea4e2b60f9de2972c2e32af5d491e7092ce615","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        if not advanced_image_available:"},{"line_number":146,"context_line":"            skip_reason \u003d \"This test require advanced tools for this test\""},{"line_number":147,"context_line":"            raise cls.skipException(skip_reason)"},{"line_number":148,"context_line":"        elif not cfg.CONF.ovs.igmp_snooping_enable:"},{"line_number":149,"context_line":"            skip_reason \u003d \"This test require IGMP snooping to be enabled\""},{"line_number":150,"context_line":"            raise cls.skipException(skip_reason)"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_027e986c","line":148,"in_reply_to":"3fa7e38b_c6c5f736","updated":"2020-02-06 16:21:57.000000000","message":"Yeah... I\u0027ve changed the patch in neutron to reuse that option. But here, as you said, I think I will need to create a new one.\n\nWill do. Thanks for the pointers Slawek++!","commit_id":"650a0efc883db72ede8efddf24e29cc4729b83a5"}]}