)]}'
{"neutron_tempest_plugin/scenario/base.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3833625e7efc5ee0ac378df83a7a74c690399858","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        udp \u003d \u0027-u\u0027"},{"line_number":68,"context_line":"    cmd \u003d \u0027echo \"knock knock\" | nc \u0027"},{"line_number":69,"context_line":"    ncat_version \u003d get_ncat_version()"},{"line_number":70,"context_line":"    if ncat_version \u003e distutils.version.StrictVersion(\u00277.60\u0027):"},{"line_number":71,"context_line":"        cmd +\u003d \u0027-z \u0027"},{"line_number":72,"context_line":"    cmd +\u003d \u0027-w 1 %(udp)s %(host)s %(port)s\u0027 % {"},{"line_number":73,"context_line":"        \u0027udp\u0027: udp, \u0027host\u0027: ip_address, \u0027port\u0027: port}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_7d059b14","line":70,"range":{"start_line":70,"start_character":20,"end_line":70,"end_character":21},"updated":"2020-02-07 16:37:01.000000000","message":"\u003e\u003d\n\n-u was added in 7.30 [1]. Actually in 7.25 but that was a beta verison.\n\n[1] https://nmap.org/changelog.html#7.30","commit_id":"189440c13306d9d249059f9e2b15cfccfa794eb6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f468c596d6480286ac7d918b5d3a1e33619a56ea","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        m \u003d re.match(r\"Ncat: Version ([\\d.]+) *.\", version_result)"},{"line_number":51,"context_line":"    # NOTE(slaweq): by default lets assume we have ncat 7.60 which is in Ubuntu"},{"line_number":52,"context_line":"    # 18.04 which is used on u/s gates"},{"line_number":53,"context_line":"    return distutils.version.StrictVersion(m.group(1) if m else \u00277.60\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def get_ncat_server_cmd(port, protocol, msg):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_ebc6226b","line":53,"range":{"start_line":53,"start_character":63,"end_line":53,"end_character":70},"updated":"2020-02-17 17:05:04.000000000","message":"As commented in [1], this should be 7.30. BTW, you should make it a constant and use it here and in L75.\n\n[1]https://review.opendev.org/#/c/705926/3/neutron_tempest_plugin/scenario/base.py","commit_id":"642d6792f21dbca9eb54b1c4875590f0d7588ef7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bffa404dfa28f485bc76d866533c8d536d8ce628","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        m \u003d re.match(r\"Ncat: Version ([\\d.]+) *.\", version_result)"},{"line_number":51,"context_line":"    # NOTE(slaweq): by default lets assume we have ncat 7.60 which is in Ubuntu"},{"line_number":52,"context_line":"    # 18.04 which is used on u/s gates"},{"line_number":53,"context_line":"    return distutils.version.StrictVersion(m.group(1) if m else \u00277.60\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def get_ncat_server_cmd(port, protocol, msg):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_af855d0b","line":53,"range":{"start_line":53,"start_character":63,"end_line":53,"end_character":70},"in_reply_to":"3fa7e38b_4f0709ca","updated":"2020-02-20 10:56:57.000000000","message":"That\u0027s perfect","commit_id":"642d6792f21dbca9eb54b1c4875590f0d7588ef7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2af959cc83fe023311620259565584c9c9ed6c79","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        m \u003d re.match(r\"Ncat: Version ([\\d.]+) *.\", version_result)"},{"line_number":51,"context_line":"    # NOTE(slaweq): by default lets assume we have ncat 7.60 which is in Ubuntu"},{"line_number":52,"context_line":"    # 18.04 which is used on u/s gates"},{"line_number":53,"context_line":"    return distutils.version.StrictVersion(m.group(1) if m else \u00277.60\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def get_ncat_server_cmd(port, protocol, msg):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_0fc4b141","line":53,"range":{"start_line":53,"start_character":63,"end_line":53,"end_character":70},"in_reply_to":"3fa7e38b_af855d0b","updated":"2020-02-20 11:05:14.000000000","message":"Thx","commit_id":"642d6792f21dbca9eb54b1c4875590f0d7588ef7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0a99925d88404b559fd7d5ed6c310599d67562f2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        m \u003d re.match(r\"Ncat: Version ([\\d.]+) *.\", version_result)"},{"line_number":51,"context_line":"    # NOTE(slaweq): by default lets assume we have ncat 7.60 which is in Ubuntu"},{"line_number":52,"context_line":"    # 18.04 which is used on u/s gates"},{"line_number":53,"context_line":"    return distutils.version.StrictVersion(m.group(1) if m else \u00277.60\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def get_ncat_server_cmd(port, protocol, msg):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_4f0709ca","line":53,"range":{"start_line":53,"start_character":63,"end_line":53,"end_character":70},"in_reply_to":"3fa7e38b_ebc6226b","updated":"2020-02-20 10:49:01.000000000","message":"But I checked on 2 different OSes: Ubuntu with nmap 7.60 and RHEL with 7.70 and there was this different behaviour between those 2 versions. That\u0027s why I assume that this is the version which we should check.\n\nAbout constant, I will do it in follow-up patch if there will be no need to respin this one. Is that ok for You?","commit_id":"642d6792f21dbca9eb54b1c4875590f0d7588ef7"}]}