)]}'
{"neutron_tempest_plugin/api/test_trunk.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"52f35a3100cc174b7f83a4957262ebfeca2678af","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # Validate that subport got segmentation details from the network"},{"line_number":238,"context_line":"        self.assertIn(expected_subports[0], trunk[\u0027sub_ports\u0027])"},{"line_number":239,"context_line":"        self.assertIn(expected_subports[1], trunk[\u0027sub_ports\u0027])"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"class TrunkTestMtusJSONBase(TrunkTestJSONBase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b0cf2689","line":239,"updated":"2020-02-18 10:52:22.000000000","message":"I would go with something like:\n\n    expected_subports \u003d sort([...])\n    self.assertEqual(expected_subports, sort(trunk[\u0027sub_ports\u0027])\n\nOtherwise, You may have some additional subport in trunk[\u0027sub_ports\u0027] and You will not catch that.","commit_id":"b2761cf1bb4360a0b02a6f8cc1c1efaf1628b0b4"},{"author":{"_account_id":11692,"name":"Cédric OLLIVIER","email":"ollivier.cedric@gmail.com","username":"col"},"change_message_id":"bf46e58bc7707942666a8524863473b5aa3de786","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # Validate that subport got segmentation details from the network"},{"line_number":238,"context_line":"        self.assertIn(expected_subports[0], trunk[\u0027sub_ports\u0027])"},{"line_number":239,"context_line":"        self.assertIn(expected_subports[1], trunk[\u0027sub_ports\u0027])"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"class TrunkTestMtusJSONBase(TrunkTestJSONBase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b322cd0d","line":239,"in_reply_to":"3fa7e38b_0b384fca","updated":"2020-02-18 14:21:05.000000000","message":"TypeError: \u0027\u0026lt;\u0027 not supported between instances of \u0027dict\u0027 and \u0027dict\u0027","commit_id":"b2761cf1bb4360a0b02a6f8cc1c1efaf1628b0b4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"480d2e0e53f8930cca0b18fe2867866dab3a288f","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # Validate that subport got segmentation details from the network"},{"line_number":238,"context_line":"        self.assertIn(expected_subports[0], trunk[\u0027sub_ports\u0027])"},{"line_number":239,"context_line":"        self.assertIn(expected_subports[1], trunk[\u0027sub_ports\u0027])"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"class TrunkTestMtusJSONBase(TrunkTestJSONBase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0b384fca","line":239,"in_reply_to":"3fa7e38b_b0cf2689","updated":"2020-02-18 11:33:32.000000000","message":"\"sort\" is the list method to sort an object. In this case you should use the function \"sorted\":\n\nself.assertEqual(sorted(expected_subports),\n                 sorted(trunk[\u0027sub_ports\u0027]))","commit_id":"b2761cf1bb4360a0b02a6f8cc1c1efaf1628b0b4"}]}
