)]}'
{"neutron_tempest_plugin/api/test_security_groups.py":[{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"bb831cc9f32b1c07ef69a42cd776b1f5ec623034","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        self._create_security_group_rule(sg_rules_to_create)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def _create_security_group_rule(self, amount):"},{"line_number":191,"context_line":"                for i in range(amount):"},{"line_number":192,"context_line":"                                sg_rule \u003d self.create_security_group_rule(**{"},{"line_number":193,"context_line":"                                    \u0027project_id\u0027: self.client.tenant_id,"},{"line_number":194,"context_line":"                                    \u0027direction\u0027: \u0027ingress\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_af479d79","line":191,"updated":"2020-02-20 11:26:27.000000000","message":"Fix indentation","commit_id":"af2bb87f08a4f6d7f9bad88d9b69733adbfc3112"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"bb831cc9f32b1c07ef69a42cd776b1f5ec623034","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                                sg_rule \u003d self.create_security_group_rule(**{"},{"line_number":193,"context_line":"                                    \u0027project_id\u0027: self.client.tenant_id,"},{"line_number":194,"context_line":"                                    \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":195,"context_line":"                                    \u0027port_range_max\u0027: 100+i,"},{"line_number":196,"context_line":"                                    \u0027port_range_min\u0027: 100+i,"},{"line_number":197,"context_line":"                                    \u0027protocol\u0027: \u0027tcp\u0027})"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_6f368504","line":195,"range":{"start_line":195,"start_character":54,"end_line":195,"end_character":59},"updated":"2020-02-20 11:26:27.000000000","message":"It will not work if the function will be executed more than one time for the same security group. I would suggest to create a separate security group each time you create bunch of rules","commit_id":"af2bb87f08a4f6d7f9bad88d9b69733adbfc3112"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"45851f1c6182f9d70e1352a3032947d63b7ab284","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        project_id \u003d self.client.tenant_id"},{"line_number":122,"context_line":"        self.admin_client.update_quotas(project_id, **{\u0027security_group\u0027: val})"},{"line_number":123,"context_line":"        self.addCleanup(self.admin_client.update_quotas,"},{"line_number":124,"context_line":"                project_id,"},{"line_number":125,"context_line":"                **{\u0027security_group\u0027: sg_quota})"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _get_sg_quota(self):"},{"line_number":128,"context_line":"        project_id \u003d self.client.tenant_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_41c5ba3b","side":"PARENT","line":125,"range":{"start_line":124,"start_character":27,"end_line":125,"end_character":16},"updated":"2020-02-25 17:02:06.000000000","message":"This indentation fix (and the others up to L178 + last on L335) does not look it is needed, did PEP8 fail without?","commit_id":"b7e0eef8de92f6a70c16c879f6a9a20377e82882"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"5accfe0b3bd2463292a5b5e3ddbaf1b8148c3d5f","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        project_id \u003d self.client.tenant_id"},{"line_number":122,"context_line":"        self.admin_client.update_quotas(project_id, **{\u0027security_group\u0027: val})"},{"line_number":123,"context_line":"        self.addCleanup(self.admin_client.update_quotas,"},{"line_number":124,"context_line":"                project_id,"},{"line_number":125,"context_line":"                **{\u0027security_group\u0027: sg_quota})"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _get_sg_quota(self):"},{"line_number":128,"context_line":"        project_id \u003d self.client.tenant_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_a82481c7","side":"PARENT","line":125,"range":{"start_line":124,"start_character":27,"end_line":125,"end_character":16},"in_reply_to":"1fa4df85_41c5ba3b","updated":"2020-03-03 05:59:09.000000000","message":"PEP8 passed with this indentation so I think I can leave it like that.","commit_id":"b7e0eef8de92f6a70c16c879f6a9a20377e82882"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"32076f33348507d5159653c8fcc6d295d7b7205a","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"class BaseSecGroupRulesQuota(base.BaseAdminNetworkTest):"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def _create_max_allowed_sg_rules_amount(self, index\u003d0):"},{"line_number":184,"context_line":"        sg_rules_amount \u003d self._get_sg_rules_amount()"},{"line_number":185,"context_line":"        sg_rules_quota \u003d self._get_sg_rules_quota()"},{"line_number":186,"context_line":"        sg_rules_to_create \u003d sg_rules_quota - sg_rules_amount"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_08b7d5d7","line":183,"range":{"start_line":183,"start_character":50,"end_line":183,"end_character":56},"updated":"2020-02-26 11:45:09.000000000","message":"index doesnt\u0027 seem meaningful to me. \nMaybe something like port_range_base or something similar.","commit_id":"69432e004917ab42b8af9391d39120dfc58c257d"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"1d9de11b7df484a75412426f37981061a9e96bbc","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"class BaseSecGroupRulesQuota(base.BaseAdminNetworkTest):"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def _create_max_allowed_sg_rules_amount(self, index\u003d0):"},{"line_number":184,"context_line":"        sg_rules_amount \u003d self._get_sg_rules_amount()"},{"line_number":185,"context_line":"        sg_rules_quota \u003d self._get_sg_rules_quota()"},{"line_number":186,"context_line":"        sg_rules_to_create \u003d sg_rules_quota - sg_rules_amount"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_7cc7d897","line":183,"range":{"start_line":183,"start_character":50,"end_line":183,"end_character":56},"in_reply_to":"1fa4df85_08b7d5d7","updated":"2020-03-03 12:34:01.000000000","message":"Done","commit_id":"69432e004917ab42b8af9391d39120dfc58c257d"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"32076f33348507d5159653c8fcc6d295d7b7205a","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        index +\u003d sg_rules_to_create"},{"line_number":188,"context_line":"        self._create_security_group_rule(sg_rules_to_create, index\u003dindex)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def _create_security_group_rule(self, amount, index\u003d0):"},{"line_number":191,"context_line":"        for i in range(amount):"},{"line_number":192,"context_line":"            self.create_security_group_rule(**{"},{"line_number":193,"context_line":"                \u0027project_id\u0027: self.client.tenant_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_68c5293c","line":190,"range":{"start_line":190,"start_character":31,"end_line":190,"end_character":35},"updated":"2020-02-26 11:45:09.000000000","message":"IIUC it Should be rules","commit_id":"69432e004917ab42b8af9391d39120dfc58c257d"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"1d9de11b7df484a75412426f37981061a9e96bbc","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        index +\u003d sg_rules_to_create"},{"line_number":188,"context_line":"        self._create_security_group_rule(sg_rules_to_create, index\u003dindex)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def _create_security_group_rule(self, amount, index\u003d0):"},{"line_number":191,"context_line":"        for i in range(amount):"},{"line_number":192,"context_line":"            self.create_security_group_rule(**{"},{"line_number":193,"context_line":"                \u0027project_id\u0027: self.client.tenant_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_3cbde001","line":190,"range":{"start_line":190,"start_character":31,"end_line":190,"end_character":35},"in_reply_to":"1fa4df85_68c5293c","updated":"2020-03-03 12:34:01.000000000","message":"Done","commit_id":"69432e004917ab42b8af9391d39120dfc58c257d"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"32076f33348507d5159653c8fcc6d295d7b7205a","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _increase_sg_rules_quota(self):"},{"line_number":200,"context_line":"        sg_rules_quota \u003d self._get_sg_rules_quota()"},{"line_number":201,"context_line":"        new_sg_rules_quota \u003d 2 * sg_rules_quota"},{"line_number":202,"context_line":"        self._set_sg_rules_quota(new_sg_rules_quota)"},{"line_number":203,"context_line":"        return new_sg_rules_quota"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_c8245d10","line":201,"range":{"start_line":201,"start_character":29,"end_line":201,"end_character":30},"updated":"2020-02-26 11:45:09.000000000","message":"Use a parameter with a default.\nAlso maybe use addition instead of multiplicationץ","commit_id":"69432e004917ab42b8af9391d39120dfc58c257d"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"32076f33348507d5159653c8fcc6d295d7b7205a","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def _decrease_sg_rules_quota(self):"},{"line_number":206,"context_line":"        sg_rules_quota \u003d self._get_sg_rules_quota()"},{"line_number":207,"context_line":"        new_sg_rules_quota \u003d sg_rules_quota // 2"},{"line_number":208,"context_line":"        self._set_sg_rules_quota(new_sg_rules_quota)"},{"line_number":209,"context_line":"        return new_sg_rules_quota"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_287971fb","line":207,"range":{"start_line":207,"start_character":44,"end_line":207,"end_character":48},"updated":"2020-02-26 11:45:09.000000000","message":"Same comment as above","commit_id":"69432e004917ab42b8af9391d39120dfc58c257d"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"32076f33348507d5159653c8fcc6d295d7b7205a","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def _set_sg_rules_quota(self, val):"},{"line_number":212,"context_line":"        sg_rules_quota \u003d self._get_sg_rules_quota()"},{"line_number":213,"context_line":"        project_id \u003d self.client.tenant_id"},{"line_number":214,"context_line":"        self.admin_client.update_quotas(project_id,"},{"line_number":215,"context_line":"                                        **{\u0027security_group_rule\u0027: val})"},{"line_number":216,"context_line":"        self.addCleanup(self.admin_client.update_quotas,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_a8556152","line":213,"range":{"start_line":213,"start_character":8,"end_line":213,"end_character":42},"updated":"2020-02-26 11:45:09.000000000","message":"You can remove it and just use self.client.tenant_id where needed","commit_id":"69432e004917ab42b8af9391d39120dfc58c257d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"61069c567705c3cae5a85b5d63d19d48edf4f551","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        self._create_security_group_rule(sg_rules_to_create,"},{"line_number":189,"context_line":"                                         port_index\u003dport_index)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def _create_security_group_rule(self, amount, port_index\u003d0):"},{"line_number":192,"context_line":"        for i in range(amount):"},{"line_number":193,"context_line":"            self.create_security_group_rule(**{"},{"line_number":194,"context_line":"                \u0027project_id\u0027: self.client.tenant_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_64699a89","line":191,"range":{"start_line":191,"start_character":8,"end_line":191,"end_character":35},"updated":"2020-03-02 11:34:17.000000000","message":"this should be named \"_create_security_group_rules\" probably","commit_id":"913ea88c6c0e6a8495b93d4137026692b33c880d"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"5accfe0b3bd2463292a5b5e3ddbaf1b8148c3d5f","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        self._create_security_group_rule(sg_rules_to_create,"},{"line_number":189,"context_line":"                                         port_index\u003dport_index)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def _create_security_group_rule(self, amount, port_index\u003d0):"},{"line_number":192,"context_line":"        for i in range(amount):"},{"line_number":193,"context_line":"            self.create_security_group_rule(**{"},{"line_number":194,"context_line":"                \u0027project_id\u0027: self.client.tenant_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_fc8aed67","line":191,"range":{"start_line":191,"start_character":8,"end_line":191,"end_character":35},"in_reply_to":"1fa4df85_64699a89","updated":"2020-03-03 05:59:09.000000000","message":"Done","commit_id":"913ea88c6c0e6a8495b93d4137026692b33c880d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"61069c567705c3cae5a85b5d63d19d48edf4f551","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                \u0027project_id\u0027: self.client.tenant_id,"},{"line_number":195,"context_line":"                \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":196,"context_line":"                \u0027port_range_max\u0027: port_index + i,"},{"line_number":197,"context_line":"                \u0027port_range_min\u0027: port_index + i,"},{"line_number":198,"context_line":"                \u0027protocol\u0027: \u0027tcp\u0027})"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def _increase_sg_rules_quota(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_44033eb9","line":197,"updated":"2020-03-02 11:34:17.000000000","message":"it can happen that port_range_min and max will be \"0\" - will that work fine? Shouldn\u0027t it start from one?","commit_id":"913ea88c6c0e6a8495b93d4137026692b33c880d"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"5accfe0b3bd2463292a5b5e3ddbaf1b8148c3d5f","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                \u0027project_id\u0027: self.client.tenant_id,"},{"line_number":195,"context_line":"                \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":196,"context_line":"                \u0027port_range_max\u0027: port_index + i,"},{"line_number":197,"context_line":"                \u0027port_range_min\u0027: port_index + i,"},{"line_number":198,"context_line":"                \u0027protocol\u0027: \u0027tcp\u0027})"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def _increase_sg_rules_quota(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_9c7bb979","line":197,"in_reply_to":"1fa4df85_44033eb9","updated":"2020-03-03 05:59:09.000000000","message":"Done","commit_id":"913ea88c6c0e6a8495b93d4137026692b33c880d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"61069c567705c3cae5a85b5d63d19d48edf4f551","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        sg_rules_quota \u003d self._get_sg_rules_quota()"},{"line_number":214,"context_line":"        project_id \u003d self.client.tenant_id"},{"line_number":215,"context_line":"        self.admin_client.update_quotas(project_id,"},{"line_number":216,"context_line":"                                        **{\u0027security_group_rule\u0027: val})"},{"line_number":217,"context_line":"        self.addCleanup(self.admin_client.update_quotas,"},{"line_number":218,"context_line":"                        project_id, **{\u0027security_group_rule\u0027: sg_rules_quota})"},{"line_number":219,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_c4e72ee4","line":216,"updated":"2020-03-02 11:34:17.000000000","message":"Can You maybe add logging of new quota value here and in method above? It may sometimes help with debugging some issues.","commit_id":"913ea88c6c0e6a8495b93d4137026692b33c880d"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"5615746b80798f3a5948e2b3d8f3da1933ca2343","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        sg_rules_quota \u003d self._get_sg_rules_quota()"},{"line_number":214,"context_line":"        project_id \u003d self.client.tenant_id"},{"line_number":215,"context_line":"        self.admin_client.update_quotas(project_id,"},{"line_number":216,"context_line":"                                        **{\u0027security_group_rule\u0027: val})"},{"line_number":217,"context_line":"        self.addCleanup(self.admin_client.update_quotas,"},{"line_number":218,"context_line":"                        project_id, **{\u0027security_group_rule\u0027: sg_rules_quota})"},{"line_number":219,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_7c935d5c","line":216,"in_reply_to":"1fa4df85_c4e72ee4","updated":"2020-03-03 06:30:30.000000000","message":"Done","commit_id":"913ea88c6c0e6a8495b93d4137026692b33c880d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"61069c567705c3cae5a85b5d63d19d48edf4f551","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        self.admin_client.update_quotas(project_id,"},{"line_number":216,"context_line":"                                        **{\u0027security_group_rule\u0027: val})"},{"line_number":217,"context_line":"        self.addCleanup(self.admin_client.update_quotas,"},{"line_number":218,"context_line":"                        project_id, **{\u0027security_group_rule\u0027: sg_rules_quota})"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def _get_sg_rules_quota(self):"},{"line_number":221,"context_line":"        project_id \u003d self.client.tenant_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_c4008e6a","line":218,"updated":"2020-03-02 11:34:17.000000000","message":"why do You need this cleanup? and if You really need it I think You should do it in setUp method as here You will override value which should be restored every time when You will call _set_sg_rules_quota()","commit_id":"913ea88c6c0e6a8495b93d4137026692b33c880d"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"d0f5b2b37b62f65ebabcca5fc3648b4ce2bc3a75","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        self.admin_client.update_quotas(project_id,"},{"line_number":216,"context_line":"                                        **{\u0027security_group_rule\u0027: val})"},{"line_number":217,"context_line":"        self.addCleanup(self.admin_client.update_quotas,"},{"line_number":218,"context_line":"                        project_id, **{\u0027security_group_rule\u0027: sg_rules_quota})"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def _get_sg_rules_quota(self):"},{"line_number":221,"context_line":"        project_id \u003d self.client.tenant_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_fcd8ad7b","line":218,"in_reply_to":"1fa4df85_c4008e6a","updated":"2020-03-03 06:18:28.000000000","message":"I am using it because  I want to clean the rules after the test is finished.","commit_id":"913ea88c6c0e6a8495b93d4137026692b33c880d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"557b159be66ec92031f61845796eab7b4fb01fa2","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        self.admin_client.update_quotas(project_id,"},{"line_number":216,"context_line":"                                        **{\u0027security_group_rule\u0027: val})"},{"line_number":217,"context_line":"        self.addCleanup(self.admin_client.update_quotas,"},{"line_number":218,"context_line":"                        project_id, **{\u0027security_group_rule\u0027: sg_rules_quota})"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def _get_sg_rules_quota(self):"},{"line_number":221,"context_line":"        project_id \u003d self.client.tenant_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_0d1b15d0","line":218,"in_reply_to":"1fa4df85_fcd8ad7b","updated":"2020-03-03 10:46:52.000000000","message":"I understand but if You will call _set_sg_rules_quota() twice in one test, during the cleanup You will restore not the value which was before test was started but value set in first _set_sg_rules_quota(). I don\u0027t think this is really Your intention here.\nIMO You should add this:\n\n    sg_rules_quota \u003d self._get_sg_rules_quota()\n    self.addCleanup(self.admin_client.update_quotas,\n                        project_id, **{\u0027security_group_rule\u0027: sg_rules_quota})\n\nto the setUp method and that way You will be sure that sg_rules_quota value is what was before test was started.","commit_id":"913ea88c6c0e6a8495b93d4137026692b33c880d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9da9397c2c6fec3cd423904325a1ba81ec31f2d1","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        return new_sg_rules_quota"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def _set_sg_rules_quota(self, val):"},{"line_number":215,"context_line":"        sg_rules_quota \u003d self._get_sg_rules_quota()"},{"line_number":216,"context_line":"        project_id \u003d self.client.tenant_id"},{"line_number":217,"context_line":"        self.admin_client.update_quotas(project_id,"},{"line_number":218,"context_line":"                                        **{\u0027security_group_rule\u0027: val})"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_687877c3","line":215,"updated":"2020-03-03 12:10:52.000000000","message":"Now this value is not used at all","commit_id":"ea8947100635e955196567cfc9fefa0a320e152b"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b52ab2a94b4d9b5ecc2210065f4feb8c09e18532","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        return new_sg_rules_quota"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def _set_sg_rules_quota(self, val):"},{"line_number":215,"context_line":"        sg_rules_quota \u003d self._get_sg_rules_quota()"},{"line_number":216,"context_line":"        project_id \u003d self.client.tenant_id"},{"line_number":217,"context_line":"        self.admin_client.update_quotas(project_id,"},{"line_number":218,"context_line":"                                        **{\u0027security_group_rule\u0027: val})"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_1cd9047e","line":215,"in_reply_to":"1fa4df85_687877c3","updated":"2020-03-03 12:33:07.000000000","message":"Done","commit_id":"ea8947100635e955196567cfc9fefa0a320e152b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2edb95794970bf54e2fbd6d28700fab5c8254377","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        project_id \u003d self.client.tenant_id"},{"line_number":125,"context_line":"        self.admin_client.update_quotas(project_id, **{\u0027security_group\u0027: val})"},{"line_number":126,"context_line":"        self.addCleanup(self.admin_client.update_quotas,"},{"line_number":127,"context_line":"                        project_id, **{\u0027security_group\u0027: sg_quota})"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _get_sg_quota(self):"},{"line_number":130,"context_line":"        project_id \u003d self.client.tenant_id"}],"source_content_type":"text/x-python","patch_set":12,"id":"1fa4df85_5a37654e","line":127,"updated":"2020-03-04 15:57:32.000000000","message":"unrelated (as commented before)","commit_id":"1b896ca1968affede6a611f3e1e717037c43ca84"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"c85a1929be06d430b6f9628a313c49aa448cebe3","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        project_id \u003d self.client.tenant_id"},{"line_number":125,"context_line":"        self.admin_client.update_quotas(project_id, **{\u0027security_group\u0027: val})"},{"line_number":126,"context_line":"        self.addCleanup(self.admin_client.update_quotas,"},{"line_number":127,"context_line":"                        project_id, **{\u0027security_group\u0027: sg_quota})"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _get_sg_quota(self):"},{"line_number":130,"context_line":"        project_id \u003d self.client.tenant_id"}],"source_content_type":"text/x-python","patch_set":12,"id":"1fa4df85_3ddaa34a","line":127,"in_reply_to":"1fa4df85_5a37654e","updated":"2020-03-04 16:24:44.000000000","message":"I just changed it because the patch failed on PEP8 thats the reason I \"fixed\" it.","commit_id":"1b896ca1968affede6a611f3e1e717037c43ca84"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2edb95794970bf54e2fbd6d28700fab5c8254377","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        self._create_max_allowed_sg_amount()"},{"line_number":163,"context_line":"        quota_set \u003d self._get_sg_quota()"},{"line_number":164,"context_line":"        self.assertEqual(quota_set, new_quota,"},{"line_number":165,"context_line":"                         \"Security group quota was not changed correctly\")"},{"line_number":166,"context_line":"        self.assertEqual(quota_set, self._get_sg_amount(),"},{"line_number":167,"context_line":"                         \"Amount of security groups doesn\u0027t match quota\")"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1fa4df85_9a315d5d","line":165,"updated":"2020-03-04 15:57:32.000000000","message":"unrelated","commit_id":"1b896ca1968affede6a611f3e1e717037c43ca84"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"c85a1929be06d430b6f9628a313c49aa448cebe3","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        self._create_max_allowed_sg_amount()"},{"line_number":163,"context_line":"        quota_set \u003d self._get_sg_quota()"},{"line_number":164,"context_line":"        self.assertEqual(quota_set, new_quota,"},{"line_number":165,"context_line":"                         \"Security group quota was not changed correctly\")"},{"line_number":166,"context_line":"        self.assertEqual(quota_set, self._get_sg_amount(),"},{"line_number":167,"context_line":"                         \"Amount of security groups doesn\u0027t match quota\")"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1fa4df85_bded33f1","line":165,"in_reply_to":"1fa4df85_9a315d5d","updated":"2020-03-04 16:24:44.000000000","message":"see my first comment","commit_id":"1b896ca1968affede6a611f3e1e717037c43ca84"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2edb95794970bf54e2fbd6d28700fab5c8254377","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        # ensure that \u0027client2\u0027 can\u0027t see the rbac-policy sharing the"},{"line_number":385,"context_line":"        # sg to it because the rbac-policy belongs to \u0027client\u0027"},{"line_number":386,"context_line":"        self.assertNotIn(rbac_policy[\u0027id\u0027], [p[\u0027id\u0027] for p in"},{"line_number":387,"context_line":"                         self.client2.list_rbac_policies()[\u0027rbac_policies\u0027]])"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    @decorators.idempotent_id(\u00272a9fd480-2a35-11e9-9cb6-acde48001122\u0027)"},{"line_number":390,"context_line":"    def test_filter_fields(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"1fa4df85_7a07c183","line":387,"updated":"2020-03-04 15:57:32.000000000","message":"unrelated","commit_id":"1b896ca1968affede6a611f3e1e717037c43ca84"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"c85a1929be06d430b6f9628a313c49aa448cebe3","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        # ensure that \u0027client2\u0027 can\u0027t see the rbac-policy sharing the"},{"line_number":385,"context_line":"        # sg to it because the rbac-policy belongs to \u0027client\u0027"},{"line_number":386,"context_line":"        self.assertNotIn(rbac_policy[\u0027id\u0027], [p[\u0027id\u0027] for p in"},{"line_number":387,"context_line":"                         self.client2.list_rbac_policies()[\u0027rbac_policies\u0027]])"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    @decorators.idempotent_id(\u00272a9fd480-2a35-11e9-9cb6-acde48001122\u0027)"},{"line_number":390,"context_line":"    def test_filter_fields(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"1fa4df85_7dbd7bd6","line":387,"in_reply_to":"1fa4df85_7a07c183","updated":"2020-03-04 16:24:44.000000000","message":"see my first comment","commit_id":"1b896ca1968affede6a611f3e1e717037c43ca84"}]}