)]}'
{"neutron_tempest_plugin/api/test_security_groups.py":[{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"f4697acad9032c38a709ad8dee51f4516482554f","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    def test_sg_rules_quota_increased(self):"},{"line_number":237,"context_line":"        self._create_max_allowed_sg_rules_amount()"},{"line_number":238,"context_line":"        new_quota \u003d self._increase_sg_rules_quota()"},{"line_number":239,"context_line":"        index \u003d new_quota"},{"line_number":240,"context_line":"        self._create_max_allowed_sg_rules_amount(index)"},{"line_number":241,"context_line":"        quota_set \u003d self._get_sg_rules_quota()"},{"line_number":242,"context_line":"        self.assertEqual(quota_set, new_quota,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_af90fdf3","line":239,"range":{"start_line":239,"start_character":8,"end_line":239,"end_character":25},"updated":"2020-02-20 11:19:07.000000000","message":"Why do you need it?","commit_id":"748db7ba56e5f990328a6ee76839104efcbc933c"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"f4697acad9032c38a709ad8dee51f4516482554f","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        self._create_max_allowed_sg_rules_amount()"},{"line_number":238,"context_line":"        new_quota \u003d self._increase_sg_rules_quota()"},{"line_number":239,"context_line":"        index \u003d new_quota"},{"line_number":240,"context_line":"        self._create_max_allowed_sg_rules_amount(index)"},{"line_number":241,"context_line":"        quota_set \u003d self._get_sg_rules_quota()"},{"line_number":242,"context_line":"        self.assertEqual(quota_set, new_quota,"},{"line_number":243,"context_line":"                \"Security group rules quota was not changed correctly\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_eff03563","line":240,"range":{"start_line":240,"start_character":49,"end_line":240,"end_character":54},"updated":"2020-02-20 11:19:07.000000000","message":"Your helper function doesn\u0027t allow any parameters","commit_id":"748db7ba56e5f990328a6ee76839104efcbc933c"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"0697385a86349aeae4529717e074e8887e3b584a","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":235,"context_line":"    required_extensions \u003d [\u0027security-group\u0027, \u0027quotas\u0027]"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def test_sg_rules_quota_increased(self):"},{"line_number":238,"context_line":"        self._create_max_allowed_sg_rules_amount()"},{"line_number":239,"context_line":"        new_quota \u003d self._increase_sg_rules_quota()"},{"line_number":240,"context_line":"        index \u003d new_quota"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_693241aa","line":237,"range":{"start_line":237,"start_character":8,"end_line":237,"end_character":38},"updated":"2020-02-23 12:30:17.000000000","message":"Please add a test id","commit_id":"9c1d18b96b035b0f00edf242426e414463af3551"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"8f3134907ebe0d4e1d75a6d10ecca15fb297e3a0","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":235,"context_line":"    required_extensions \u003d [\u0027security-group\u0027, \u0027quotas\u0027]"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def test_sg_rules_quota_increased(self):"},{"line_number":238,"context_line":"        self._create_max_allowed_sg_rules_amount()"},{"line_number":239,"context_line":"        new_quota \u003d self._increase_sg_rules_quota()"},{"line_number":240,"context_line":"        index \u003d new_quota"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_09aaad84","line":237,"range":{"start_line":237,"start_character":8,"end_line":237,"end_character":38},"in_reply_to":"1fa4df85_693241aa","updated":"2020-02-23 12:59:55.000000000","message":"Done","commit_id":"9c1d18b96b035b0f00edf242426e414463af3551"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d047754033ca414cefd483458c5f28318cf70774","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    @decorators.idempotent_id(\u002777ec038c-5638-11ea-8e2d-0242ac130003\u0027)"},{"line_number":238,"context_line":"    def test_sg_rules_quota_increased(self):"},{"line_number":239,"context_line":"        self._create_max_allowed_sg_rules_amount()"},{"line_number":240,"context_line":"        new_quota \u003d self._increase_sg_rules_quota()"},{"line_number":241,"context_line":"        index \u003d new_quota"},{"line_number":242,"context_line":"        self._create_max_allowed_sg_rules_amount(index)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1fa4df85_41acda8b","line":239,"range":{"start_line":239,"start_character":13,"end_line":239,"end_character":48},"updated":"2020-02-25 17:00:10.000000000","message":"Test hits timeout here so default values are probably high, we should have lower quotas for this test (no need for 100s of rules).\nRodolfo added something similar in https://review.opendev.org/709691 (to set to unlimited)","commit_id":"74d8d5660b82724eaf91ebfe695887f092a9a6b1"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"98ce9c01b583e998892760e56df99ef8ae471690","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    @decorators.idempotent_id(\u002777ec038c-5638-11ea-8e2d-0242ac130003\u0027)"},{"line_number":238,"context_line":"    def test_sg_rules_quota_increased(self):"},{"line_number":239,"context_line":"        self._create_max_allowed_sg_rules_amount()"},{"line_number":240,"context_line":"        new_quota \u003d self._increase_sg_rules_quota()"},{"line_number":241,"context_line":"        index \u003d new_quota"},{"line_number":242,"context_line":"        self._create_max_allowed_sg_rules_amount(index)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1fa4df85_3c5e4512","line":239,"range":{"start_line":239,"start_character":13,"end_line":239,"end_character":48},"in_reply_to":"1fa4df85_41acda8b","updated":"2020-03-03 05:53:31.000000000","message":"Hi Bernard, in that case  I think its a problem with the gate and not with the test because actually the goal is to test that its possible to increase the quota from the default value with is 100. what do you think?","commit_id":"74d8d5660b82724eaf91ebfe695887f092a9a6b1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"91252f6c5c5f7b1d8a577714a8d21ad80c80eb8b","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        self._create_max_allowed_sg_rules_amount(port_index)"},{"line_number":244,"context_line":"        quota_set \u003d self._get_sg_rules_quota()"},{"line_number":245,"context_line":"        self.assertEqual(quota_set, new_quota,"},{"line_number":246,"context_line":"                \"Security group rules quota was not changed correctly\")"},{"line_number":247,"context_line":"        self.assertEqual(quota_set, self._get_sg_rules_amount(),"},{"line_number":248,"context_line":"                \"Amount of security groups rules doesn\u0027t match quota\")"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1fa4df85_4449fecd","line":246,"updated":"2020-03-02 11:35:08.000000000","message":"nitty nit: please fix indentation here to be aligned with line above","commit_id":"e6d3c532da06402238b0b960ef32790d949ce3d8"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"48ed3f19c79c2bafb37becf33c36c109866b8a72","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        self._create_max_allowed_sg_rules_amount(port_index)"},{"line_number":244,"context_line":"        quota_set \u003d self._get_sg_rules_quota()"},{"line_number":245,"context_line":"        self.assertEqual(quota_set, new_quota,"},{"line_number":246,"context_line":"                \"Security group rules quota was not changed correctly\")"},{"line_number":247,"context_line":"        self.assertEqual(quota_set, self._get_sg_rules_amount(),"},{"line_number":248,"context_line":"                \"Amount of security groups rules doesn\u0027t match quota\")"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1fa4df85_8f2034ae","line":246,"in_reply_to":"1fa4df85_4449fecd","updated":"2020-03-05 07:46:14.000000000","message":"Done","commit_id":"e6d3c532da06402238b0b960ef32790d949ce3d8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"91252f6c5c5f7b1d8a577714a8d21ad80c80eb8b","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        self.assertEqual(quota_set, new_quota,"},{"line_number":246,"context_line":"                \"Security group rules quota was not changed correctly\")"},{"line_number":247,"context_line":"        self.assertEqual(quota_set, self._get_sg_rules_amount(),"},{"line_number":248,"context_line":"                \"Amount of security groups rules doesn\u0027t match quota\")"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"class SecGroupProtocolTest(base.BaseNetworkTest):"}],"source_content_type":"text/x-python","patch_set":12,"id":"1fa4df85_64443ab8","line":248,"updated":"2020-03-02 11:35:08.000000000","message":"same here","commit_id":"e6d3c532da06402238b0b960ef32790d949ce3d8"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"48ed3f19c79c2bafb37becf33c36c109866b8a72","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        self.assertEqual(quota_set, new_quota,"},{"line_number":246,"context_line":"                \"Security group rules quota was not changed correctly\")"},{"line_number":247,"context_line":"        self.assertEqual(quota_set, self._get_sg_rules_amount(),"},{"line_number":248,"context_line":"                \"Amount of security groups rules doesn\u0027t match quota\")"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"class SecGroupProtocolTest(base.BaseNetworkTest):"}],"source_content_type":"text/x-python","patch_set":12,"id":"1fa4df85_2f11005e","line":248,"in_reply_to":"1fa4df85_64443ab8","updated":"2020-03-05 07:46:14.000000000","message":"Done","commit_id":"e6d3c532da06402238b0b960ef32790d949ce3d8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d1647caea03232af6e2b9488a7fd0f2e45727d01","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        self._create_max_allowed_sg_rules_amount(port_index)"},{"line_number":252,"context_line":"        quota_set \u003d self._get_sg_rules_quota()"},{"line_number":253,"context_line":"        self.assertEqual(quota_set, new_quota,"},{"line_number":254,"context_line":"                         \"Security group rules quota wasn\u0027t changed correctly\")"},{"line_number":255,"context_line":"        self.assertEqual(quota_set, self._get_sg_rules_amount(),"},{"line_number":256,"context_line":"                         \"Amount of security groups rules doesn\u0027t match quota\")"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1fa4df85_97856b09","line":254,"updated":"2020-03-10 09:40:28.000000000","message":"this assertion in fact is checking if quota returned from _increate_sg_rules_quota() is different than _get_sg_rules_quota(). But if first method will not change it, this assertion will pass properly and that will be mistake, right?\nSo IMO You should do assertion that old quota value, before L249 is lower than new value after increase.\nMaybe You could even move this assertion to the _increase_sg_rules_quota() method directly.","commit_id":"8fc22f4ae8c3e5177d4584cbf36f83004d6b2e94"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b64f10f6f855a46b065a024cc7ce5ee0fe9d297c","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        self._create_max_allowed_sg_rules_amount(port_index)"},{"line_number":252,"context_line":"        quota_set \u003d self._get_sg_rules_quota()"},{"line_number":253,"context_line":"        self.assertEqual(quota_set, new_quota,"},{"line_number":254,"context_line":"                         \"Security group rules quota wasn\u0027t changed correctly\")"},{"line_number":255,"context_line":"        self.assertEqual(quota_set, self._get_sg_rules_amount(),"},{"line_number":256,"context_line":"                         \"Amount of security groups rules doesn\u0027t match quota\")"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1fa4df85_513ffe85","line":254,"in_reply_to":"1fa4df85_97856b09","updated":"2020-03-10 12:42:54.000000000","message":"Done","commit_id":"8fc22f4ae8c3e5177d4584cbf36f83004d6b2e94"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"021651adff17d288b80365fd31f77db1cdd3aab7","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        self._create_max_allowed_sg_rules_amount(port_index)"},{"line_number":252,"context_line":"        quota_set \u003d self._get_sg_rules_quota()"},{"line_number":253,"context_line":"        self.assertEqual(quota_set, new_quota,"},{"line_number":254,"context_line":"                         \"Security group rules quota wasn\u0027t changed correctly\")"},{"line_number":255,"context_line":"        self.assertEqual(quota_set, self._get_sg_rules_amount(),"},{"line_number":256,"context_line":"                         \"Amount of security groups rules doesn\u0027t match quota\")"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1fa4df85_ed4650c0","line":254,"in_reply_to":"1fa4df85_97856b09","updated":"2020-03-10 12:01:02.000000000","message":"Good idea, this check will be asserted in other tests calling this method \"_increase_sg_rules_quota\".","commit_id":"8fc22f4ae8c3e5177d4584cbf36f83004d6b2e94"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"b64f10f6f855a46b065a024cc7ce5ee0fe9d297c","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        self._create_max_allowed_sg_rules_amount(port_index)"},{"line_number":252,"context_line":"        quota_set \u003d self._get_sg_rules_quota()"},{"line_number":253,"context_line":"        self.assertEqual(quota_set, new_quota,"},{"line_number":254,"context_line":"                         \"Security group rules quota wasn\u0027t changed correctly\")"},{"line_number":255,"context_line":"        self.assertEqual(quota_set, self._get_sg_rules_amount(),"},{"line_number":256,"context_line":"                         \"Amount of security groups rules doesn\u0027t match quota\")"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1fa4df85_71423a11","line":254,"in_reply_to":"1fa4df85_ed4650c0","updated":"2020-03-10 12:42:54.000000000","message":"Done","commit_id":"8fc22f4ae8c3e5177d4584cbf36f83004d6b2e94"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4d16f82e41f091efe81a093e3eaede45e44a3057","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        sg_rules_quota \u003d self._get_sg_rules_quota()"},{"line_number":206,"context_line":"        new_sg_rules_quota \u003d 2 * sg_rules_quota"},{"line_number":207,"context_line":"        self._set_sg_rules_quota(new_sg_rules_quota)"},{"line_number":208,"context_line":"        self.assertEqual(self._get_sg_rules_quota, new_sg_rules_quota,"},{"line_number":209,"context_line":"                         \"Security group rules quota wasn\u0027t changed correctly\")"},{"line_number":210,"context_line":"        return new_sg_rules_quota"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1fa4df85_b1cc3235","line":208,"updated":"2020-03-10 13:09:30.000000000","message":"two things here:\n1. You are asserting function (self._get_sg_rules_quota) with value new_sg_rules_quota - that not gonna work :)\n2. Please use pattern with assertEqual(expected, actual)","commit_id":"d08e7b0e806ba85accf5ce856c286f7c662d9f4d"}]}