)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a79fd44ac33deae9303e5f22487033b5d414b357","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Maciej Józefczyk \u003cmjozefcz@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-03-04 13:22:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"QoS - Increase size of tested file lineary with limit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Sometimes it is visible that first kilobytes of the"},{"line_number":10,"context_line":"test file are downloaded a little bit faster than the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_1338fd3a","line":7,"range":{"start_line":7,"start_character":35,"end_line":7,"end_character":53},"updated":"2020-03-04 14:17:57.000000000","message":"small nit: proportionally with the limit","commit_id":"60acdd24f6c36062e683d038ee44eab60f8e0e68"}],"neutron_tempest_plugin/scenario/test_qos.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3768be95143c4030ce02a8a52584446da8b0a1ac","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":70,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    FILE_SIZE \u003d 1024 * 1024"},{"line_number":73,"context_line":"    TOLERANCE_FACTOR \u003d 1.5"},{"line_number":74,"context_line":"    BUFFER_SIZE \u003d 512"},{"line_number":75,"context_line":"    LIMIT_BYTES_SEC \u003d (constants.LIMIT_KILO_BITS_PER_SECOND * 1024 *"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_d230d158","line":72,"updated":"2020-03-10 10:55:10.000000000","message":"shouldn\u0027t be this base FILE_SIZE also calculated as some function of expected bandwidth? That it would always take around 5 or 10 seconds to send the file with this limit.","commit_id":"06c19b30f33e24f30418d032c9c870bc9ce0c715"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"debd03dafaf9e897f89d8400ba04d0e2e04b058d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":70,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    FILE_SIZE \u003d 1024 * 1024"},{"line_number":73,"context_line":"    TOLERANCE_FACTOR \u003d 1.5"},{"line_number":74,"context_line":"    BUFFER_SIZE \u003d 512"},{"line_number":75,"context_line":"    LIMIT_BYTES_SEC \u003d (constants.LIMIT_KILO_BITS_PER_SECOND * 1024 *"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_52936a01","line":72,"in_reply_to":"1fa4df85_d230d158","updated":"2020-03-11 14:59:40.000000000","message":"For every test we pass parameters like:\n\nfile_size\u003dQoSTest.FILE_SIZE * 3,\nexpected_bw\u003dQoSTest.LIMIT_BYTES_SEC * 3\n\nSo I can leave the expected_bw paremeter and calculate what FILE_SIZE should be used in this test instead providing it.","commit_id":"06c19b30f33e24f30418d032c9c870bc9ce0c715"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3768be95143c4030ce02a8a52584446da8b0a1ac","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _check_bw(self, ssh_client, host, port, file_size\u003dFILE_SIZE,"},{"line_number":95,"context_line":"                  expected_bw\u003dLIMIT_BYTES_SEC):"},{"line_number":96,"context_line":"        self._create_file_for_bw_tests(ssh_client, file_size)"},{"line_number":97,"context_line":"        utils.kill_nc_process(ssh_client)"},{"line_number":98,"context_line":"        cmd \u003d (\"(nc -ll -p %(port)d \u003c %(file_path)s \u003e /dev/null \u0026)\" % {"},{"line_number":99,"context_line":"                \u0027port\u0027: port, \u0027file_path\u0027: self.FILE_PATH})"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_f2aaad6e","line":96,"updated":"2020-03-10 10:55:10.000000000","message":"I\u0027m not sure if I understand it. Now You are doing \"dd\" on the vm every time You call _check_bw() method so, it\u0027s every 1 second when it\u0027s called from wait_until_true() below. Is that necessary?","commit_id":"06c19b30f33e24f30418d032c9c870bc9ce0c715"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"d99b67301cdffe6e03700f6006b0c48e7ae0fb83","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _check_bw(self, ssh_client, host, port, file_size\u003dFILE_SIZE,"},{"line_number":95,"context_line":"                  expected_bw\u003dLIMIT_BYTES_SEC):"},{"line_number":96,"context_line":"        self._create_file_for_bw_tests(ssh_client, file_size)"},{"line_number":97,"context_line":"        utils.kill_nc_process(ssh_client)"},{"line_number":98,"context_line":"        cmd \u003d (\"(nc -ll -p %(port)d \u003c %(file_path)s \u003e /dev/null \u0026)\" % {"},{"line_number":99,"context_line":"                \u0027port\u0027: port, \u0027file_path\u0027: self.FILE_PATH})"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_debbd2c1","line":96,"in_reply_to":"1fa4df85_0c9396a5","updated":"2020-03-12 09:45:33.000000000","message":"I\u0027m happy it helped.","commit_id":"06c19b30f33e24f30418d032c9c870bc9ce0c715"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"debd03dafaf9e897f89d8400ba04d0e2e04b058d","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _check_bw(self, ssh_client, host, port, file_size\u003dFILE_SIZE,"},{"line_number":95,"context_line":"                  expected_bw\u003dLIMIT_BYTES_SEC):"},{"line_number":96,"context_line":"        self._create_file_for_bw_tests(ssh_client, file_size)"},{"line_number":97,"context_line":"        utils.kill_nc_process(ssh_client)"},{"line_number":98,"context_line":"        cmd \u003d (\"(nc -ll -p %(port)d \u003c %(file_path)s \u003e /dev/null \u0026)\" % {"},{"line_number":99,"context_line":"                \u0027port\u0027: port, \u0027file_path\u0027: self.FILE_PATH})"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_0c9396a5","line":96,"in_reply_to":"1fa4df85_29d449bd","updated":"2020-03-11 14:59:40.000000000","message":"Bence, that is great idea!\nWith the solution You proposed the test is much faster. Now for OVN backend the test passed in around 80 seconds, previously it was around 160 seconds! That is huge! Thanks a lot!\n\n\n{0} neutron_tempest_plugin.scenario.test_qos.QoSTest.test_qos_basic_and_update [78.711523s] ... ok","commit_id":"06c19b30f33e24f30418d032c9c870bc9ce0c715"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"f5d94ec4ca75e145421c3b879dae94009043925a","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _check_bw(self, ssh_client, host, port, file_size\u003dFILE_SIZE,"},{"line_number":95,"context_line":"                  expected_bw\u003dLIMIT_BYTES_SEC):"},{"line_number":96,"context_line":"        self._create_file_for_bw_tests(ssh_client, file_size)"},{"line_number":97,"context_line":"        utils.kill_nc_process(ssh_client)"},{"line_number":98,"context_line":"        cmd \u003d (\"(nc -ll -p %(port)d \u003c %(file_path)s \u003e /dev/null \u0026)\" % {"},{"line_number":99,"context_line":"                \u0027port\u0027: port, \u0027file_path\u0027: self.FILE_PATH})"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_29d449bd","line":96,"in_reply_to":"1fa4df85_f2aaad6e","updated":"2020-03-11 11:58:10.000000000","message":"I also think this could be made simpler. IIUC it is time dependent to get a stable result from the bw shaping, so we could easily download a stream for a given duration, like:\n\n1) delete _create_file_for_bw_tests altogether\n2) make nc read directly from /dev/zero\n3) change the condition in line 108 like:\n\nwhile time.time() - start_time \u003c download_duration:\n...\n\nand hardcode what download_duration we want.\n\nWhat do you think?","commit_id":"06c19b30f33e24f30418d032c9c870bc9ce0c715"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"debd03dafaf9e897f89d8400ba04d0e2e04b058d","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _check_bw(self, ssh_client, host, port, file_size\u003dFILE_SIZE,"},{"line_number":95,"context_line":"                  expected_bw\u003dLIMIT_BYTES_SEC):"},{"line_number":96,"context_line":"        self._create_file_for_bw_tests(ssh_client, file_size)"},{"line_number":97,"context_line":"        utils.kill_nc_process(ssh_client)"},{"line_number":98,"context_line":"        cmd \u003d (\"(nc -ll -p %(port)d \u003c %(file_path)s \u003e /dev/null \u0026)\" % {"},{"line_number":99,"context_line":"                \u0027port\u0027: port, \u0027file_path\u0027: self.FILE_PATH})"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_129df209","line":96,"in_reply_to":"1fa4df85_f2aaad6e","updated":"2020-03-11 14:59:40.000000000","message":"It is not necessary. I\u0027ll modify it.","commit_id":"06c19b30f33e24f30418d032c9c870bc9ce0c715"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f158b621a32e7ff8f7f3fe15897a619d6f07f735","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _check_bw(self, ssh_client, host, port, expected_bw\u003dLIMIT_BYTES_SEC):"},{"line_number":82,"context_line":"        utils.kill_nc_process(ssh_client)"},{"line_number":83,"context_line":"        cmd \u003d (\"(nc -ll -p %d \u003c /dev/zero \u003e /dev/null \u0026)\" % port)"},{"line_number":84,"context_line":"        ssh_client.exec_command(cmd, timeout\u003d5)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # Open TCP socket to remote VM and download big file"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_c2eb07da","line":83,"updated":"2020-03-11 15:52:13.000000000","message":"Good idea, just to send zeros without creating a file.","commit_id":"41b8019c7b4b3921a077a032463b9d8c74957b4b"}]}