)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"b3727828cf3d062f4065e6f98361d53d81f6d7a5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alex Katz \u003cakatz@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-03-05 11:31:19 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Test connectivity after migration of the server with trunk"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I519e2685dbc9d0ae0011b7b9f8a04c705f31ef3b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_0f8df630","line":7,"updated":"2020-03-09 09:05:12.000000000","message":"I\u0027d suggest to elaborate a bit more about the test scenario in a few sentences.","commit_id":"fa5e74bef66e42e6b98f7a04b03bf12594696fe9"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"1d5643f4d6d038bda5d3579c4b8b25dd67bef74c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alex Katz \u003cakatz@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-03-05 11:31:19 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Test connectivity after migration of the server with trunk"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I519e2685dbc9d0ae0011b7b9f8a04c705f31ef3b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_06032544","line":7,"in_reply_to":"1fa4df85_0f8df630","updated":"2020-03-17 11:14:18.000000000","message":"Done","commit_id":"fa5e74bef66e42e6b98f7a04b03bf12594696fe9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1124918753f9e1d2f451592944cd1bb48511e7db","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alex Katz \u003cakatz@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-03-05 11:31:19 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Test connectivity after migration of the server with trunk"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I519e2685dbc9d0ae0011b7b9f8a04c705f31ef3b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_d4c4ea42","line":7,"in_reply_to":"1fa4df85_0f8df630","updated":"2020-03-16 08:52:52.000000000","message":"yes, and maybe, if this test case is related to some related issue which we actually had in the past, maybe it\u0027s also worth to mention it here.","commit_id":"fa5e74bef66e42e6b98f7a04b03bf12594696fe9"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"1d5643f4d6d038bda5d3579c4b8b25dd67bef74c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alex Katz \u003cakatz@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-03-05 11:31:19 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Test connectivity after migration of the server with trunk"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I519e2685dbc9d0ae0011b7b9f8a04c705f31ef3b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_26fe6138","line":7,"in_reply_to":"1fa4df85_d4c4ea42","updated":"2020-03-17 11:14:18.000000000","message":"Done","commit_id":"fa5e74bef66e42e6b98f7a04b03bf12594696fe9"}],"neutron_tempest_plugin/scenario/test_trunk.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1124918753f9e1d2f451592944cd1bb48511e7db","unresolved":false,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        self.check_remote_connectivity("},{"line_number":335,"context_line":"                servers[\u0027connection_test\u0027].ssh_client,"},{"line_number":336,"context_line":"                servers[\u0027migrate\u0027].subport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @testtools.skipUnless("},{"line_number":339,"context_line":"        (CONF.neutron_plugin_options.advanced_image_ref or"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_54aa3a85","line":336,"updated":"2020-03-16 08:52:52.000000000","message":"shouldn\u0027t You check connectivity before migration too?","commit_id":"fa5e74bef66e42e6b98f7a04b03bf12594696fe9"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"1d5643f4d6d038bda5d3579c4b8b25dd67bef74c","unresolved":false,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        self.check_remote_connectivity("},{"line_number":335,"context_line":"                servers[\u0027connection_test\u0027].ssh_client,"},{"line_number":336,"context_line":"                servers[\u0027migrate\u0027].subport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @testtools.skipUnless("},{"line_number":339,"context_line":"        (CONF.neutron_plugin_options.advanced_image_ref or"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_66ec598f","line":336,"in_reply_to":"1fa4df85_067d651b","updated":"2020-03-17 11:14:18.000000000","message":"Done","commit_id":"fa5e74bef66e42e6b98f7a04b03bf12594696fe9"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"4926d82f3c6b8107e4568f8d6f0d1612b6bdb78b","unresolved":false,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        self.check_remote_connectivity("},{"line_number":335,"context_line":"                servers[\u0027connection_test\u0027].ssh_client,"},{"line_number":336,"context_line":"                servers[\u0027migrate\u0027].subport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @testtools.skipUnless("},{"line_number":339,"context_line":"        (CONF.neutron_plugin_options.advanced_image_ref or"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_942af2e4","line":336,"in_reply_to":"1fa4df85_54aa3a85","updated":"2020-03-16 09:52:46.000000000","message":"Connectivity before migration is verified in \"test_subport_connectivity\" I think it is enough. What do you think?","commit_id":"fa5e74bef66e42e6b98f7a04b03bf12594696fe9"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"22499d4ae321be6454f15dff0109aef451c19d09","unresolved":false,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        self.check_remote_connectivity("},{"line_number":335,"context_line":"                servers[\u0027connection_test\u0027].ssh_client,"},{"line_number":336,"context_line":"                servers[\u0027migrate\u0027].subport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @testtools.skipUnless("},{"line_number":339,"context_line":"        (CONF.neutron_plugin_options.advanced_image_ref or"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_9f61ab3c","line":336,"in_reply_to":"1fa4df85_942af2e4","updated":"2020-03-16 10:14:15.000000000","message":"its a good point, if we are checking connectivity in \"test_subport_connectivity\" I think there is no need to verify that here too.","commit_id":"fa5e74bef66e42e6b98f7a04b03bf12594696fe9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8c3497634440d47a875ab1d48686f8a28a3b6039","unresolved":false,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        self.check_remote_connectivity("},{"line_number":335,"context_line":"                servers[\u0027connection_test\u0027].ssh_client,"},{"line_number":336,"context_line":"                servers[\u0027migrate\u0027].subport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @testtools.skipUnless("},{"line_number":339,"context_line":"        (CONF.neutron_plugin_options.advanced_image_ref or"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_067d651b","line":336,"in_reply_to":"1fa4df85_9f61ab3c","updated":"2020-03-17 10:54:23.000000000","message":"I don\u0027t understand exactly. Are You talking about other test case which is defined above? If so, I don\u0027t think it\u0027s enough as this test creates new vms and IMO it would be good to check first that those vms are running fine (just to be sure that we are starting migration from \"well known\" point always) and then do migration and test connectivity again.","commit_id":"fa5e74bef66e42e6b98f7a04b03bf12594696fe9"}]}
