)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e29590a95ec7cfbc393aee3b7737e8546498dd57","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Igor Malinovskiy \u003cu.glide@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-03-12 12:02:29 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow assigning shared Address Scope to Subnet Pool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove negative test that forbids assigning shared"},{"line_number":10,"context_line":"address scope to subnet pool for tenant users."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1fa4df85_9276703e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":51},"updated":"2020-03-17 09:53:31.000000000","message":"nit: This line is first visible so better to make it significant for the specific change:\n\"Remove negative shared address scope test\"\nor similar","commit_id":"7a671c4091fb347b5c516d1f6e909e658c0f4c33"}],"neutron_tempest_plugin/api/test_subnetpools_negative.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"990dc37b2198545a00462cc8c2e24b63cbee8f12","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        self.assertRaises(lib_exc.BadRequest, self._create_subnetpool,"},{"line_number":180,"context_line":"                          address_scope_id\u003daddress_scope[\u0027id\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":183,"context_line":"    @decorators.idempotent_id(\u00276d3d9ad5-32d4-4d63-aa00-8c62f73e2881\u0027)"},{"line_number":184,"context_line":"    @utils.requires_ext(extension\u003d\u0027address-scope\u0027, service\u003d\u0027network\u0027)"},{"line_number":185,"context_line":"    def test_update_subnetpool_associate_address_scope_of_other_owner(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_cf9adac3","side":"PARENT","line":182,"updated":"2020-03-19 09:26:41.000000000","message":"IMO You shouldn\u0027t remove this test completly (for now at least) but skip it if new API extension related to Your RBAC changes is enabled.\nThat way it can still work for Train and older releases where this test is still valid.","commit_id":"b82476000ce29b010ed2246d364e4ed027c7dc1a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a6a10633051950d49af9fb70b44b681cd65aba90","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    # Ussuri release to be able to test \u0026 merge"},{"line_number":177,"context_line":"    # https://review.opendev.org/709122/ and will be removed in"},{"line_number":178,"context_line":"    # https://review.opendev.org/711610/"},{"line_number":179,"context_line":"    @testtools.skipIf("},{"line_number":180,"context_line":"        utils.is_extension_enabled(\u0027tag-ports-during-bulk-creation\u0027,"},{"line_number":181,"context_line":"                                   \u0027network\u0027),"},{"line_number":182,"context_line":"        reason\u003d\"Test is outdated starting from Ussuri release.\""},{"line_number":183,"context_line":"    )"},{"line_number":184,"context_line":"    @testtools.skipIf("},{"line_number":185,"context_line":"        utils.is_extension_enabled(\u0027rbac-address-scope\u0027, \u0027network\u0027),"},{"line_number":186,"context_line":"        reason\u003d\"Test is outdated starting from Ussuri release.\""},{"line_number":187,"context_line":"    )"},{"line_number":188,"context_line":"    @utils.requires_ext(extension\u003d\u0027address-scope\u0027, service\u003d\u0027network\u0027)"},{"line_number":189,"context_line":"    def test_tenant_create_subnetpool_associate_shared_address_scope(self):"},{"line_number":190,"context_line":"        address_scope \u003d self.create_address_scope("}],"source_content_type":"text/x-python","patch_set":11,"id":"df33271e_584ceec6","line":187,"range":{"start_line":179,"start_character":0,"end_line":187,"end_character":5},"updated":"2020-03-23 14:04:19.000000000","message":"yeah with the decorator there is no way to express negative  logic","commit_id":"873bf4ae6c06920215b49b898cdba8621085e43b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c7b1e0e4014f369e1e05a6add449277036c6d935","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                          address_scope_id\u003daddress_scope[\u0027id\u0027])"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":173,"context_line":"    @decorators.idempotent_id(\u00273396ec6c-cb80-4ebe-b897-84e904580bdf\u0027)"},{"line_number":174,"context_line":"    @utils.requires_ext(extension\u003d\u0027address-scope\u0027, service\u003d\u0027network\u0027)"},{"line_number":175,"context_line":"    def test_tenant_create_subnetpool_associate_shared_address_scope(self):"},{"line_number":176,"context_line":"        address_scope \u003d self.create_address_scope("},{"line_number":177,"context_line":"            name\u003ddata_utils.rand_name(\u0027smoke-address-scope\u0027), is_admin\u003dTrue,"},{"line_number":178,"context_line":"            shared\u003dTrue, ip_version\u003d4)"},{"line_number":179,"context_line":"        self.assertRaises(lib_exc.BadRequest, self._create_subnetpool,"},{"line_number":180,"context_line":"                          address_scope_id\u003daddress_scope[\u0027id\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":183,"context_line":"    @decorators.idempotent_id(\u00276d3d9ad5-32d4-4d63-aa00-8c62f73e2881\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_932e2c41","side":"PARENT","line":180,"range":{"start_line":173,"start_character":0,"end_line":180,"end_character":63},"updated":"2020-03-25 16:16:19.000000000","message":"If I understand well the issue is that tempest \u0026 neutron-tempest-plugin is branchless.\nOne option is to add fullstack/functional test for this on stable branches, then the coverage will be there, and on master tempest this can be deleted, see:\nhttps://review.opendev.org/644847 \u0026 https://review.opendev.org/609724","commit_id":"22d7cc950ba228ec00383b1ee6447c64ea713cb0"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"f1595a633da48be475c7c0fb0adb0cad4126fc96","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                          address_scope_id\u003daddress_scope[\u0027id\u0027])"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":173,"context_line":"    @decorators.idempotent_id(\u00273396ec6c-cb80-4ebe-b897-84e904580bdf\u0027)"},{"line_number":174,"context_line":"    @utils.requires_ext(extension\u003d\u0027address-scope\u0027, service\u003d\u0027network\u0027)"},{"line_number":175,"context_line":"    def test_tenant_create_subnetpool_associate_shared_address_scope(self):"},{"line_number":176,"context_line":"        address_scope \u003d self.create_address_scope("},{"line_number":177,"context_line":"            name\u003ddata_utils.rand_name(\u0027smoke-address-scope\u0027), is_admin\u003dTrue,"},{"line_number":178,"context_line":"            shared\u003dTrue, ip_version\u003d4)"},{"line_number":179,"context_line":"        self.assertRaises(lib_exc.BadRequest, self._create_subnetpool,"},{"line_number":180,"context_line":"                          address_scope_id\u003daddress_scope[\u0027id\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":183,"context_line":"    @decorators.idempotent_id(\u00276d3d9ad5-32d4-4d63-aa00-8c62f73e2881\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_bcf84fc4","side":"PARENT","line":180,"range":{"start_line":173,"start_character":0,"end_line":180,"end_character":63},"in_reply_to":"df33271e_30e0e8cc","updated":"2020-03-26 12:39:54.000000000","message":"Still, Slawek\u0027s suggestion works here, no need to skip the test for all branches until patch is fixed?","commit_id":"22d7cc950ba228ec00383b1ee6447c64ea713cb0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"45fbf0f68e113beba6e0232a4054e079ac04c61d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                          address_scope_id\u003daddress_scope[\u0027id\u0027])"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":173,"context_line":"    @decorators.idempotent_id(\u00273396ec6c-cb80-4ebe-b897-84e904580bdf\u0027)"},{"line_number":174,"context_line":"    @utils.requires_ext(extension\u003d\u0027address-scope\u0027, service\u003d\u0027network\u0027)"},{"line_number":175,"context_line":"    def test_tenant_create_subnetpool_associate_shared_address_scope(self):"},{"line_number":176,"context_line":"        address_scope \u003d self.create_address_scope("},{"line_number":177,"context_line":"            name\u003ddata_utils.rand_name(\u0027smoke-address-scope\u0027), is_admin\u003dTrue,"},{"line_number":178,"context_line":"            shared\u003dTrue, ip_version\u003d4)"},{"line_number":179,"context_line":"        self.assertRaises(lib_exc.BadRequest, self._create_subnetpool,"},{"line_number":180,"context_line":"                          address_scope_id\u003daddress_scope[\u0027id\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":183,"context_line":"    @decorators.idempotent_id(\u00276d3d9ad5-32d4-4d63-aa00-8c62f73e2881\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_d07d3c1d","side":"PARENT","line":180,"range":{"start_line":173,"start_character":0,"end_line":180,"end_character":63},"in_reply_to":"df33271e_932e2c41","updated":"2020-03-26 08:51:26.000000000","message":"Instead of dropping this extension You should simply do something like:\n\n    if utils.is_extension_enabled(extension_name\u003d\u0027rbac-subnetpool\u0027, service\u003d\u0027network):\n        self.skip(\"RBAC for subnetpools is available.\")\n\nThat way this will still be run for stable branches and not for master.","commit_id":"22d7cc950ba228ec00383b1ee6447c64ea713cb0"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"e0544e04ff29ae5e8ffb60f70580f9a21ecd4663","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                          address_scope_id\u003daddress_scope[\u0027id\u0027])"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":173,"context_line":"    @decorators.idempotent_id(\u00273396ec6c-cb80-4ebe-b897-84e904580bdf\u0027)"},{"line_number":174,"context_line":"    @utils.requires_ext(extension\u003d\u0027address-scope\u0027, service\u003d\u0027network\u0027)"},{"line_number":175,"context_line":"    def test_tenant_create_subnetpool_associate_shared_address_scope(self):"},{"line_number":176,"context_line":"        address_scope \u003d self.create_address_scope("},{"line_number":177,"context_line":"            name\u003ddata_utils.rand_name(\u0027smoke-address-scope\u0027), is_admin\u003dTrue,"},{"line_number":178,"context_line":"            shared\u003dTrue, ip_version\u003d4)"},{"line_number":179,"context_line":"        self.assertRaises(lib_exc.BadRequest, self._create_subnetpool,"},{"line_number":180,"context_line":"                          address_scope_id\u003daddress_scope[\u0027id\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":183,"context_line":"    @decorators.idempotent_id(\u00276d3d9ad5-32d4-4d63-aa00-8c62f73e2881\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_30e0e8cc","side":"PARENT","line":180,"range":{"start_line":173,"start_character":0,"end_line":180,"end_character":63},"in_reply_to":"df33271e_d07d3c1d","updated":"2020-03-26 08:58:07.000000000","message":"This removal is temporary. It allows merging of https://review.opendev.org/#/c/709124/  \n\nAnd this test will be restored with rbac-address-scope extension check later in tempest tests change in https://review.opendev.org/#/c/711610/","commit_id":"22d7cc950ba228ec00383b1ee6447c64ea713cb0"}]}