)]}'
{"neutron_tempest_plugin/api/test_security_groups.py":[{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"f42350dd3e83608a490ec0105f3f3b1cc45548f0","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        sg_quota \u003d self._get_sg_quota()"},{"line_number":146,"context_line":"        new_sg_quota \u003d 2 * sg_quota"},{"line_number":147,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":148,"context_line":"        self.assertGreater(self._get_sg_quota(), sg_quota,"},{"line_number":149,"context_line":"                           \"Security group quota wasn\u0027t changed correctly\")"},{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_4c6cf89b","line":148,"range":{"start_line":148,"start_character":13,"end_line":148,"end_character":26},"updated":"2020-03-15 11:07:18.000000000","message":"1. I think it is enough to verify that the quota has been changed correctly only within the designated test but not every time the helper function is used\n2. assertGreater verifies just the fact of increasing quota. It checked that the quota has been set to the desired value.","commit_id":"f1999fe9934a4103be665ffc52287d1ebcd40ee3"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"ec32fcc5d65c186475ce21b688469430ead7c89b","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        sg_quota \u003d self._get_sg_quota()"},{"line_number":146,"context_line":"        new_sg_quota \u003d 2 * sg_quota"},{"line_number":147,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":148,"context_line":"        self.assertGreater(self._get_sg_quota(), sg_quota,"},{"line_number":149,"context_line":"                           \"Security group quota wasn\u0027t changed correctly\")"},{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_cc0d48e9","line":148,"range":{"start_line":148,"start_character":13,"end_line":148,"end_character":26},"in_reply_to":"1fa4df85_4c6cf89b","updated":"2020-03-15 11:10:34.000000000","message":"this assertion in fact is checking if quota returned from _increate_sg_quota() is different than _get_sg_quota(). But if first method will not change it, this assertion will pass properly and that will be mistake. thats why I made this change.","commit_id":"f1999fe9934a4103be665ffc52287d1ebcd40ee3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"42afe760c8a670e90c1d8ea9a468c7c23ec559ee","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        self._create_max_allowed_sg_amount()"},{"line_number":195,"context_line":"        new_quota \u003d self._increase_sg_quota()"},{"line_number":196,"context_line":"        self._create_max_allowed_sg_amount()"},{"line_number":197,"context_line":"        quota_set \u003d self._get_sg_quota()"},{"line_number":198,"context_line":"        self.assertEqual(quota_set, new_quota,"},{"line_number":199,"context_line":"                         \"Security group quota was not changed correctly\")"},{"line_number":200,"context_line":"        self.assertEqual(quota_set, self._get_sg_amount(),"},{"line_number":201,"context_line":"                         \"Amount of security groups doesn\u0027t match quota\")"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @decorators.idempotent_id(\u0027ba95676c-8d9a-4482-b4ec-74d51a4602a6\u0027)"},{"line_number":204,"context_line":"    def test_sg_quota_decrease_less_than_created(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_dac89175","side":"PARENT","line":201,"range":{"start_line":197,"start_character":8,"end_line":201,"end_character":73},"updated":"2020-03-16 11:04:17.000000000","message":"actually I\u0027m not sure if those all lines are really needed here. You have assertion that quota was changed in the _increase_sg_quota() method directly.","commit_id":"b82476000ce29b010ed2246d364e4ed027c7dc1a"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"e55bdb398752a609c985fb4c5e0c1841f74b3ec2","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        self._create_max_allowed_sg_amount()"},{"line_number":195,"context_line":"        new_quota \u003d self._increase_sg_quota()"},{"line_number":196,"context_line":"        self._create_max_allowed_sg_amount()"},{"line_number":197,"context_line":"        quota_set \u003d self._get_sg_quota()"},{"line_number":198,"context_line":"        self.assertEqual(quota_set, new_quota,"},{"line_number":199,"context_line":"                         \"Security group quota was not changed correctly\")"},{"line_number":200,"context_line":"        self.assertEqual(quota_set, self._get_sg_amount(),"},{"line_number":201,"context_line":"                         \"Amount of security groups doesn\u0027t match quota\")"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @decorators.idempotent_id(\u0027ba95676c-8d9a-4482-b4ec-74d51a4602a6\u0027)"},{"line_number":204,"context_line":"    def test_sg_quota_decrease_less_than_created(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_1a0dc93d","side":"PARENT","line":201,"range":{"start_line":197,"start_character":8,"end_line":201,"end_character":73},"in_reply_to":"1fa4df85_dac89175","updated":"2020-03-16 11:31:03.000000000","message":"Done","commit_id":"b82476000ce29b010ed2246d364e4ed027c7dc1a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"42afe760c8a670e90c1d8ea9a468c7c23ec559ee","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        sg_quota \u003d self._get_sg_quota()"},{"line_number":146,"context_line":"        new_sg_quota \u003d 2 * sg_quota"},{"line_number":147,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":148,"context_line":"        self.assertGreater(self._get_sg_quota(), sg_quota,"},{"line_number":149,"context_line":"                           \"Security group quota wasn\u0027t changed correctly\")"},{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_5aaa6185","line":148,"range":{"start_line":148,"start_character":13,"end_line":148,"end_character":26},"updated":"2020-03-16 11:04:17.000000000","message":"if You would use assertEqual() here, than probably assertions from test_sg_quota_increase() test case wouldn\u0027t be needed at all.","commit_id":"2335a9ecd80c73b816ce84aaeb6494e158e54754"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"e55bdb398752a609c985fb4c5e0c1841f74b3ec2","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        sg_quota \u003d self._get_sg_quota()"},{"line_number":146,"context_line":"        new_sg_quota \u003d 2 * sg_quota"},{"line_number":147,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":148,"context_line":"        self.assertGreater(self._get_sg_quota(), sg_quota,"},{"line_number":149,"context_line":"                           \"Security group quota wasn\u0027t changed correctly\")"},{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_3a1f6571","line":148,"range":{"start_line":148,"start_character":13,"end_line":148,"end_character":26},"in_reply_to":"1fa4df85_5aaa6185","updated":"2020-03-16 11:31:03.000000000","message":"Done","commit_id":"2335a9ecd80c73b816ce84aaeb6494e158e54754"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"42afe760c8a670e90c1d8ea9a468c7c23ec559ee","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":148,"context_line":"        self.assertGreater(self._get_sg_quota(), sg_quota,"},{"line_number":149,"context_line":"                           \"Security group quota wasn\u0027t changed correctly\")"},{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def _decrease_sg_quota(self):"},{"line_number":153,"context_line":"        sg_quota \u003d self._get_sg_quota()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_7a2abd2c","line":150,"updated":"2020-03-16 11:04:17.000000000","message":"I don\u0027t think we need this return value, it\u0027s not used anywhere IMO","commit_id":"2335a9ecd80c73b816ce84aaeb6494e158e54754"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"e55bdb398752a609c985fb4c5e0c1841f74b3ec2","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":148,"context_line":"        self.assertGreater(self._get_sg_quota(), sg_quota,"},{"line_number":149,"context_line":"                           \"Security group quota wasn\u0027t changed correctly\")"},{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def _decrease_sg_quota(self):"},{"line_number":153,"context_line":"        sg_quota \u003d self._get_sg_quota()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_7a163d58","line":150,"in_reply_to":"1fa4df85_7a2abd2c","updated":"2020-03-16 11:31:03.000000000","message":"leaved it for future in case we need that.","commit_id":"2335a9ecd80c73b816ce84aaeb6494e158e54754"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"fe072e021dcd192af07beb89a2cb537d35566f21","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        sg_quota \u003d self._get_sg_quota()"},{"line_number":146,"context_line":"        new_sg_quota \u003d 2 * sg_quota"},{"line_number":147,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":148,"context_line":"        self.assertEqual(self._get_sg_quota(), sg_quota,"},{"line_number":149,"context_line":"                           \"Security group quota wasn\u0027t changed correctly\")"},{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_e5c85275","line":148,"range":{"start_line":148,"start_character":47,"end_line":148,"end_character":55},"updated":"2020-03-16 11:53:48.000000000","message":"should be new_sg_quota","commit_id":"d1e3b464e0e142fb4eb7a5b2afb287ffa531caeb"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"1bec49367e3c1a7c9e4438fe18ebb76a380861f4","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        sg_quota \u003d self._get_sg_quota()"},{"line_number":146,"context_line":"        new_sg_quota \u003d 2 * sg_quota"},{"line_number":147,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":148,"context_line":"        self.assertEqual(self._get_sg_quota(), sg_quota,"},{"line_number":149,"context_line":"                           \"Security group quota wasn\u0027t changed correctly\")"},{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_00455c43","line":148,"range":{"start_line":148,"start_character":47,"end_line":148,"end_character":55},"in_reply_to":"1fa4df85_e5c85275","updated":"2020-03-16 12:26:07.000000000","message":"indeed you are right :)","commit_id":"d1e3b464e0e142fb4eb7a5b2afb287ffa531caeb"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"3db89e70efb9283df247bc2cf32ef0801690c550","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        quota_set \u003d self._get_sg_quota()"},{"line_number":198,"context_line":"        self.assertEqual(quota_set, new_quota,"},{"line_number":199,"context_line":"                         \"Security group quota was not changed correctly\")"},{"line_number":200,"context_line":"        self.assertEqual(quota_set, self._get_sg_amount(),"},{"line_number":201,"context_line":"                         \"Amount of security groups doesn\u0027t match quota\")"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @decorators.idempotent_id(\u0027ba95676c-8d9a-4482-b4ec-74d51a4602a6\u0027)"},{"line_number":204,"context_line":"    def test_sg_quota_decrease_less_than_created(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_8a72c6ac","side":"PARENT","line":201,"range":{"start_line":200,"start_character":8,"end_line":201,"end_character":73},"updated":"2020-03-16 14:42:28.000000000","message":"I would keep that assertion to check that L196 method call passed correctly","commit_id":"b82476000ce29b010ed2246d364e4ed027c7dc1a"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"3db89e70efb9283df247bc2cf32ef0801690c550","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        sg_quota \u003d self._get_sg_quota()"},{"line_number":146,"context_line":"        new_sg_quota \u003d 2 * sg_quota"},{"line_number":147,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":148,"context_line":"        self.assertEqual(self._get_sg_quota(), new_sg_quota,"},{"line_number":149,"context_line":"                         \"Security group quota wasn\u0027t changed correctly\")"},{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_ca867e66","line":148,"range":{"start_line":148,"start_character":47,"end_line":148,"end_character":59},"updated":"2020-03-16 14:42:28.000000000","message":"You can do the math here as the \"new_sg_quota\" is not used anywhere else","commit_id":"b7499876845fcc35f26bb30744334eeea1f74c77"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"f106592bb433aec92fb3c1587a00198209699463","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        sg_quota \u003d self._get_sg_quota()"},{"line_number":146,"context_line":"        new_sg_quota \u003d 2 * sg_quota"},{"line_number":147,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":148,"context_line":"        self.assertEqual(self._get_sg_quota(), new_sg_quota,"},{"line_number":149,"context_line":"                         \"Security group quota wasn\u0027t changed correctly\")"},{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_b767deb7","line":148,"range":{"start_line":148,"start_character":47,"end_line":148,"end_character":59},"in_reply_to":"1fa4df85_9762e2d7","updated":"2020-03-17 08:46:37.000000000","message":"oops... indeed","commit_id":"b7499876845fcc35f26bb30744334eeea1f74c77"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"890dcf01080d671e8e958c5462d4cc407960b2c4","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        sg_quota \u003d self._get_sg_quota()"},{"line_number":146,"context_line":"        new_sg_quota \u003d 2 * sg_quota"},{"line_number":147,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":148,"context_line":"        self.assertEqual(self._get_sg_quota(), new_sg_quota,"},{"line_number":149,"context_line":"                         \"Security group quota wasn\u0027t changed correctly\")"},{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_3831910c","line":148,"range":{"start_line":148,"start_character":47,"end_line":148,"end_character":59},"in_reply_to":"1fa4df85_b767deb7","updated":"2020-03-17 19:38:06.000000000","message":"Done","commit_id":"b7499876845fcc35f26bb30744334eeea1f74c77"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a49e6c435d0ff3b6b8e182678ed1e960d7cd3917","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        sg_quota \u003d self._get_sg_quota()"},{"line_number":146,"context_line":"        new_sg_quota \u003d 2 * sg_quota"},{"line_number":147,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":148,"context_line":"        self.assertEqual(self._get_sg_quota(), new_sg_quota,"},{"line_number":149,"context_line":"                         \"Security group quota wasn\u0027t changed correctly\")"},{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_9762e2d7","line":148,"range":{"start_line":148,"start_character":47,"end_line":148,"end_character":59},"in_reply_to":"1fa4df85_ca867e66","updated":"2020-03-17 08:32:09.000000000","message":"it is used also in L147 :)","commit_id":"b7499876845fcc35f26bb30744334eeea1f74c77"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"3db89e70efb9283df247bc2cf32ef0801690c550","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":148,"context_line":"        self.assertEqual(self._get_sg_quota(), new_sg_quota,"},{"line_number":149,"context_line":"                         \"Security group quota wasn\u0027t changed correctly\")"},{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def _decrease_sg_quota(self):"},{"line_number":153,"context_line":"        sg_quota \u003d self._get_sg_quota()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_8aa7260c","line":150,"range":{"start_line":150,"start_character":8,"end_line":150,"end_character":27},"updated":"2020-03-16 14:42:28.000000000","message":"No need to return anything as you will not use it later","commit_id":"b7499876845fcc35f26bb30744334eeea1f74c77"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"890dcf01080d671e8e958c5462d4cc407960b2c4","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":148,"context_line":"        self.assertEqual(self._get_sg_quota(), new_sg_quota,"},{"line_number":149,"context_line":"                         \"Security group quota wasn\u0027t changed correctly\")"},{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def _decrease_sg_quota(self):"},{"line_number":153,"context_line":"        sg_quota \u003d self._get_sg_quota()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_58348dfb","line":150,"range":{"start_line":150,"start_character":8,"end_line":150,"end_character":27},"in_reply_to":"1fa4df85_579a2ac5","updated":"2020-03-17 19:38:06.000000000","message":"Done","commit_id":"b7499876845fcc35f26bb30744334eeea1f74c77"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a49e6c435d0ff3b6b8e182678ed1e960d7cd3917","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":148,"context_line":"        self.assertEqual(self._get_sg_quota(), new_sg_quota,"},{"line_number":149,"context_line":"                         \"Security group quota wasn\u0027t changed correctly\")"},{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def _decrease_sg_quota(self):"},{"line_number":153,"context_line":"        sg_quota \u003d self._get_sg_quota()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_579a2ac5","line":150,"range":{"start_line":150,"start_character":8,"end_line":150,"end_character":27},"in_reply_to":"1fa4df85_8aa7260c","updated":"2020-03-17 08:32:09.000000000","message":"I agree that there is no need to return value if it\u0027s not used anywhere","commit_id":"b7499876845fcc35f26bb30744334eeea1f74c77"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a49e6c435d0ff3b6b8e182678ed1e960d7cd3917","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def _decrease_sg_quota(self):"},{"line_number":153,"context_line":"        sg_quota \u003d self._get_sg_quota()"},{"line_number":154,"context_line":"        new_sg_quota \u003d sg_quota // 2"},{"line_number":155,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":156,"context_line":"        return new_sg_quota"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def _set_sg_quota(self, val):"},{"line_number":159,"context_line":"        sg_quota \u003d self._get_sg_quota()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_97b7423b","line":156,"range":{"start_line":153,"start_character":7,"end_line":156,"end_character":27},"updated":"2020-03-17 08:32:09.000000000","message":"sorry for late comment but can You also change this method in same way as it is doing exactly the same thing but in the opposite \"direction\"","commit_id":"b7499876845fcc35f26bb30744334eeea1f74c77"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"890dcf01080d671e8e958c5462d4cc407960b2c4","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def _decrease_sg_quota(self):"},{"line_number":153,"context_line":"        sg_quota \u003d self._get_sg_quota()"},{"line_number":154,"context_line":"        new_sg_quota \u003d sg_quota // 2"},{"line_number":155,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":156,"context_line":"        return new_sg_quota"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def _set_sg_quota(self, val):"},{"line_number":159,"context_line":"        sg_quota \u003d self._get_sg_quota()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_183e15da","line":156,"range":{"start_line":153,"start_character":7,"end_line":156,"end_character":27},"in_reply_to":"1fa4df85_867875f8","updated":"2020-03-17 19:38:06.000000000","message":"Done","commit_id":"b7499876845fcc35f26bb30744334eeea1f74c77"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"f106592bb433aec92fb3c1587a00198209699463","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def _decrease_sg_quota(self):"},{"line_number":153,"context_line":"        sg_quota \u003d self._get_sg_quota()"},{"line_number":154,"context_line":"        new_sg_quota \u003d sg_quota // 2"},{"line_number":155,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":156,"context_line":"        return new_sg_quota"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def _set_sg_quota(self, val):"},{"line_number":159,"context_line":"        sg_quota \u003d self._get_sg_quota()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_b7fcbeb5","line":156,"range":{"start_line":153,"start_character":7,"end_line":156,"end_character":27},"in_reply_to":"1fa4df85_97b7423b","updated":"2020-03-17 08:46:37.000000000","message":"do you think that we can do the assertion in the \"_set_sg_quota\" method?","commit_id":"b7499876845fcc35f26bb30744334eeea1f74c77"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"12a9ab7707dc66aeeb16f9af73453636dd28e10c","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        return new_sg_quota"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def _decrease_sg_quota(self):"},{"line_number":153,"context_line":"        sg_quota \u003d self._get_sg_quota()"},{"line_number":154,"context_line":"        new_sg_quota \u003d sg_quota // 2"},{"line_number":155,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":156,"context_line":"        return new_sg_quota"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def _set_sg_quota(self, val):"},{"line_number":159,"context_line":"        sg_quota \u003d self._get_sg_quota()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_867875f8","line":156,"range":{"start_line":153,"start_character":7,"end_line":156,"end_character":27},"in_reply_to":"1fa4df85_b7fcbeb5","updated":"2020-03-17 11:07:19.000000000","message":"no, lets keep set_sg_quota simple :)","commit_id":"b7499876845fcc35f26bb30744334eeea1f74c77"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"7022a7d6eb87d2374e78066482bab428cf09bfcd","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        quota_set \u003d self._get_sg_quota()"},{"line_number":198,"context_line":"        self.assertEqual(quota_set, new_quota,"},{"line_number":199,"context_line":"                         \"Security group quota was not changed correctly\")"},{"line_number":200,"context_line":"        self.assertEqual(quota_set, self._get_sg_amount(),"},{"line_number":201,"context_line":"                         \"Amount of security groups doesn\u0027t match quota\")"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @decorators.idempotent_id(\u0027ba95676c-8d9a-4482-b4ec-74d51a4602a6\u0027)"},{"line_number":204,"context_line":"    def test_sg_quota_decrease_less_than_created(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1fa4df85_23a886d9","side":"PARENT","line":201,"range":{"start_line":200,"start_character":8,"end_line":201,"end_character":73},"updated":"2020-03-17 19:51:25.000000000","message":"I would still ask you to keep this assertion to verify that the amount of created security groups matches the quota","commit_id":"b82476000ce29b010ed2246d364e4ed027c7dc1a"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"bf20614c64c7e3314eb5dc9b8db673b34b0b293e","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        quota_set \u003d self._get_sg_quota()"},{"line_number":198,"context_line":"        self.assertEqual(quota_set, new_quota,"},{"line_number":199,"context_line":"                         \"Security group quota was not changed correctly\")"},{"line_number":200,"context_line":"        self.assertEqual(quota_set, self._get_sg_amount(),"},{"line_number":201,"context_line":"                         \"Amount of security groups doesn\u0027t match quota\")"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @decorators.idempotent_id(\u0027ba95676c-8d9a-4482-b4ec-74d51a4602a6\u0027)"},{"line_number":204,"context_line":"    def test_sg_quota_decrease_less_than_created(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1fa4df85_9bae7ae5","side":"PARENT","line":201,"range":{"start_line":200,"start_character":8,"end_line":201,"end_character":73},"in_reply_to":"1fa4df85_23a886d9","updated":"2020-03-18 07:30:57.000000000","message":"sorry I missed your first comment. I will return this check.","commit_id":"b82476000ce29b010ed2246d364e4ed027c7dc1a"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"7022a7d6eb87d2374e78066482bab428cf09bfcd","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    def test_sg_quota_decrease_less_than_created(self):"},{"line_number":205,"context_line":"        self._create_max_allowed_sg_amount()"},{"line_number":206,"context_line":"        new_quota \u003d self._decrease_sg_quota()"},{"line_number":207,"context_line":"        self.assertEqual(self._get_sg_quota(), new_quota)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @decorators.idempotent_id(\u0027d43cf1a7-aa7e-4c41-9340-627a1a6ab961\u0027)"},{"line_number":210,"context_line":"    def test_create_sg_when_quota_disabled(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1fa4df85_e33b4ec5","side":"PARENT","line":207,"range":{"start_line":207,"start_character":8,"end_line":207,"end_character":57},"updated":"2020-03-17 19:51:25.000000000","message":"no need it anymore","commit_id":"b82476000ce29b010ed2246d364e4ed027c7dc1a"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"bf20614c64c7e3314eb5dc9b8db673b34b0b293e","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    def test_sg_quota_decrease_less_than_created(self):"},{"line_number":205,"context_line":"        self._create_max_allowed_sg_amount()"},{"line_number":206,"context_line":"        new_quota \u003d self._decrease_sg_quota()"},{"line_number":207,"context_line":"        self.assertEqual(self._get_sg_quota(), new_quota)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @decorators.idempotent_id(\u0027d43cf1a7-aa7e-4c41-9340-627a1a6ab961\u0027)"},{"line_number":210,"context_line":"    def test_create_sg_when_quota_disabled(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1fa4df85_1b2b6aeb","side":"PARENT","line":207,"range":{"start_line":207,"start_character":8,"end_line":207,"end_character":57},"in_reply_to":"1fa4df85_e33b4ec5","updated":"2020-03-18 07:30:57.000000000","message":"Done","commit_id":"b82476000ce29b010ed2246d364e4ed027c7dc1a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5c9d7892f6e5f75ccd554ed6d896016e6f74c857","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        new_sg_quota \u003d 2 * sg_quota"},{"line_number":147,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":148,"context_line":"        self.assertEqual(self._get_sg_quota(), new_sg_quota,"},{"line_number":149,"context_line":"                         \"Security group quota wasn\u0027t changed correctly\")"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _decrease_sg_quota(self):"},{"line_number":152,"context_line":"        sg_quota \u003d self._get_sg_quota()"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_5b4fa2bc","line":149,"updated":"2020-03-18 07:44:15.000000000","message":"Why don\u0027t you return new_sg_quota? You can use this value later in L200, skipping a second call.\n\nI know you removed it since [1], but then you added again the L200 check.\n\n[1] https://review.opendev.org/#/c/713130/7/neutron_tempest_plugin/api/test_security_groups.py@148","commit_id":"330f24098f9082f765d750b0b88c3759db562220"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6453be142e455b1aeb5ee5943a7219b70a339976","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        new_sg_quota \u003d 2 * sg_quota"},{"line_number":147,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":148,"context_line":"        self.assertEqual(self._get_sg_quota(), new_sg_quota,"},{"line_number":149,"context_line":"                         \"Security group quota wasn\u0027t changed correctly\")"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _decrease_sg_quota(self):"},{"line_number":152,"context_line":"        sg_quota \u003d self._get_sg_quota()"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_0ab8edc5","line":149,"in_reply_to":"1fa4df85_4e912299","updated":"2020-03-18 16:32:58.000000000","message":"well...","commit_id":"330f24098f9082f765d750b0b88c3759db562220"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"1d17c5a623af018a7f4df631b617d6c1948f7b4d","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        new_sg_quota \u003d 2 * sg_quota"},{"line_number":147,"context_line":"        self._set_sg_quota(new_sg_quota)"},{"line_number":148,"context_line":"        self.assertEqual(self._get_sg_quota(), new_sg_quota,"},{"line_number":149,"context_line":"                         \"Security group quota wasn\u0027t changed correctly\")"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _decrease_sg_quota(self):"},{"line_number":152,"context_line":"        sg_quota \u003d self._get_sg_quota()"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fa4df85_4e912299","line":149,"in_reply_to":"1fa4df85_5b4fa2bc","updated":"2020-03-18 10:46:20.000000000","message":"I think I will leave like that","commit_id":"330f24098f9082f765d750b0b88c3759db562220"}]}