)]}'
{"neutron_tempest_plugin/scenario/base.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"95ddf62e1ec94e686bd64e8902c2c8a75879a56f","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            ip_version \u003d ("},{"line_number":323,"context_line":"                IP_VERSION_6 if netaddr.valid_ipv6(host) else IP_VERSION_4)"},{"line_number":324,"context_line":"            cmd \u003d ("},{"line_number":325,"context_line":"                \u0027ping6\u0027 if ip_version \u003d\u003d IP_VERSION_6 else \u0027ping -4\u0027)"},{"line_number":326,"context_line":"            if nic:"},{"line_number":327,"context_line":"                cmd \u003d \u0027sudo {cmd} -I {nic}\u0027.format(cmd\u003dcmd, nic\u003dnic)"},{"line_number":328,"context_line":"            if mtu:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_2a971293","line":325,"range":{"start_line":325,"start_character":60,"end_line":325,"end_character":67},"updated":"2020-03-16 14:42:54.000000000","message":"nit: i think most distros these days have a unified ping binary, where both ping4 and ping6 can be used, each forcing the correct address family.  Don\u0027t know if cirros uses this convention though.","commit_id":"8d9c9f38d3868ab60044439f913cc11e71a134f8"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"1e60d4b395a6bb0cf8494dc6e9f9534b58e22b0a","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            ip_version \u003d ("},{"line_number":323,"context_line":"                IP_VERSION_6 if netaddr.valid_ipv6(host) else IP_VERSION_4)"},{"line_number":324,"context_line":"            cmd \u003d ("},{"line_number":325,"context_line":"                \u0027ping6\u0027 if ip_version \u003d\u003d IP_VERSION_6 else \u0027ping -4\u0027)"},{"line_number":326,"context_line":"            if nic:"},{"line_number":327,"context_line":"                cmd \u003d \u0027sudo {cmd} -I {nic}\u0027.format(cmd\u003dcmd, nic\u003dnic)"},{"line_number":328,"context_line":"            if mtu:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_5236b8b6","line":325,"range":{"start_line":325,"start_character":60,"end_line":325,"end_character":67},"in_reply_to":"1fa4df85_2a971293","updated":"2020-03-17 09:45:39.000000000","message":"You\u0027re right Brian: for Cirros the ping command works both for IPv6 and IPv4.\n\nexample taken from Cirros 0.5.1\n\n$ ping fe80::f816:3eff:fe9f:c178\nPING fe80::f816:3eff:fe9f:c178 (fe80::f816:3eff:fe9f:c178): 56 data bytes\n64 bytes from fe80::f816:3eff:fe9f:c178: seq\u003d0 ttl\u003d64 time\u003d11.612 ms\n64 bytes from fe80::f816:3eff:fe9f:c178: seq\u003d1 ttl\u003d64 time\u003d0.603 ms\n64 bytes from fe80::f816:3eff:fe9f:c178: seq\u003d2 ttl\u003d64 time\u003d0.516 m","commit_id":"8d9c9f38d3868ab60044439f913cc11e71a134f8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3e3c7934571cc458f8f605ea39b638c171cbb1f2","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            ip_version \u003d ("},{"line_number":323,"context_line":"                IP_VERSION_6 if netaddr.valid_ipv6(host) else IP_VERSION_4)"},{"line_number":324,"context_line":"            cmd \u003d ("},{"line_number":325,"context_line":"                \u0027ping6\u0027 if ip_version \u003d\u003d IP_VERSION_6 else \u0027ping\u0027)"},{"line_number":326,"context_line":"            if nic:"},{"line_number":327,"context_line":"                cmd \u003d \u0027sudo {cmd} -I {nic}\u0027.format(cmd\u003dcmd, nic\u003dnic)"},{"line_number":328,"context_line":"            if mtu:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_1a9db256","line":325,"range":{"start_line":325,"start_character":60,"end_line":325,"end_character":64},"updated":"2020-03-17 14:21:04.000000000","message":"I guess you still could have used ping4 here, which will force ping to use an AF_INET lookup.","commit_id":"3c324e0548ca2227ab556cc03b184dadbd56f098"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"26644138a96bdd90f3fa1c8e3d04102701f656c5","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            ip_version \u003d ("},{"line_number":323,"context_line":"                IP_VERSION_6 if netaddr.valid_ipv6(host) else IP_VERSION_4)"},{"line_number":324,"context_line":"            cmd \u003d ("},{"line_number":325,"context_line":"                \u0027ping6\u0027 if ip_version \u003d\u003d IP_VERSION_6 else \u0027ping\u0027)"},{"line_number":326,"context_line":"            if nic:"},{"line_number":327,"context_line":"                cmd \u003d \u0027sudo {cmd} -I {nic}\u0027.format(cmd\u003dcmd, nic\u003dnic)"},{"line_number":328,"context_line":"            if mtu:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_e9133e65","line":325,"range":{"start_line":325,"start_character":60,"end_line":325,"end_character":64},"in_reply_to":"1fa4df85_1a9db256","updated":"2020-05-27 08:30:17.000000000","message":"I can modify this to use ping in all cases.","commit_id":"3c324e0548ca2227ab556cc03b184dadbd56f098"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"ee79ad165b8cf3607a977b39c0c357e346ff7f17","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                    mtu\u003dmtu, ip_version\u003dip_version))"},{"line_number":333,"context_line":"            if pattern:"},{"line_number":334,"context_line":"                cmd +\u003d \u0027 -p {pattern}\u0027.format(pattern\u003dpattern)"},{"line_number":335,"context_line":"            cmd +\u003d \u0027 -c{0} -W{0} -s{1} {2}\u0027.format(count, size, host)"},{"line_number":336,"context_line":"            return source.exec_command(cmd)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        def ping_remote():"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_d2f8687d","line":335,"range":{"start_line":335,"start_character":28,"end_line":335,"end_character":29},"updated":"2020-03-17 09:59:28.000000000","message":"From Cirros ping help page:\n        -W SEC          Seconds to wait for the first response (default:10)\n                        (after all -c CNT packets are sent)\n        -w SEC          Seconds until ping exits (default:infinite)\n                        (can exit earlier with -c CNT)\n\n\nWith this change the OVN tests started to pass, as cirros ping doesn\u0027t timeout on waiting for AAAA responses.","commit_id":"3c324e0548ca2227ab556cc03b184dadbd56f098"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3e3c7934571cc458f8f605ea39b638c171cbb1f2","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                    mtu\u003dmtu, ip_version\u003dip_version))"},{"line_number":333,"context_line":"            if pattern:"},{"line_number":334,"context_line":"                cmd +\u003d \u0027 -p {pattern}\u0027.format(pattern\u003dpattern)"},{"line_number":335,"context_line":"            cmd +\u003d \u0027 -c{0} -W{0} -s{1} {2}\u0027.format(count, size, host)"},{"line_number":336,"context_line":"            return source.exec_command(cmd)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        def ping_remote():"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_bae33ea4","line":335,"range":{"start_line":335,"start_character":28,"end_line":335,"end_character":29},"in_reply_to":"1fa4df85_d2f8687d","updated":"2020-03-17 14:21:04.000000000","message":"My only concern with this internally these options affect different parts of the ping source code, and it\u0027s unclear if it could cause other issues.  The descriptions of both are pretty terrible imo.","commit_id":"3c324e0548ca2227ab556cc03b184dadbd56f098"}]}