)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb9cc469c43bd83fcb980f96870c6aec975b58a4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"if real bandwidth is lower then configured one, such test can\u0027t catch"},{"line_number":16,"context_line":"any issues with e.g. bandwidth limit rule updates."},{"line_number":17,"context_line":"So this patch changes this to set first highest value and then update"},{"line_number":18,"context_line":"it to lower one."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"In case when QoS is attached to Floating IP, it adds update of bandwidth"},{"line_number":21,"context_line":"limit rule and ensure that this rule is also updated properly and new"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4c43b2_98ee02eb","line":18,"updated":"2020-04-20 11:08:05.000000000","message":"I don\u0027t disagree with the change.\n\nBut the method \"_check_bw\" should measure the BW and compare it to the expected value, within a tolerance interval.","commit_id":"722e6d1044fe3e704b310edf8ac99f70157ad68b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4a85ce1911d1e1c22bf19cbaa2f4f6d512e4fb99","unresolved":false,"context_lines":[{"line_number":15,"context_line":"if real bandwidth is lower then configured one, such test can\u0027t catch"},{"line_number":16,"context_line":"any issues with e.g. bandwidth limit rule updates."},{"line_number":17,"context_line":"So this patch changes this to set first highest value and then update"},{"line_number":18,"context_line":"it to lower one."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"In case when QoS is attached to Floating IP, it adds update of bandwidth"},{"line_number":21,"context_line":"limit rule and ensure that this rule is also updated properly and new"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4c43b2_61542254","line":18,"in_reply_to":"3f4c43b2_01eb9e12","updated":"2020-04-20 13:27:57.000000000","message":"I\u0027m not sure if we can improve that. This is test of max bw limit, so we can\u0027t assume that VM will actually have full this bw available. We only want to test if bw isn\u0027t higher than limit.","commit_id":"722e6d1044fe3e704b310edf8ac99f70157ad68b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4912875ef417e123dfe87a4acf4f146da2fdaf5e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"if real bandwidth is lower then configured one, such test can\u0027t catch"},{"line_number":16,"context_line":"any issues with e.g. bandwidth limit rule updates."},{"line_number":17,"context_line":"So this patch changes this to set first highest value and then update"},{"line_number":18,"context_line":"it to lower one."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"In case when QoS is attached to Floating IP, it adds update of bandwidth"},{"line_number":21,"context_line":"limit rule and ensure that this rule is also updated properly and new"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4c43b2_01eb9e12","line":18,"in_reply_to":"3f4c43b2_215a1a29","updated":"2020-04-20 13:06:02.000000000","message":"Right, we apply a tolerance to the BW limit but we only check that the BW is below the BW limit increased with the tolerance factor.\n\n+1\n\n(btw, maybe we should improve this, but not in this patch).","commit_id":"722e6d1044fe3e704b310edf8ac99f70157ad68b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"419d2eece32be33107dea8af59952022eb8f9954","unresolved":false,"context_lines":[{"line_number":15,"context_line":"if real bandwidth is lower then configured one, such test can\u0027t catch"},{"line_number":16,"context_line":"any issues with e.g. bandwidth limit rule updates."},{"line_number":17,"context_line":"So this patch changes this to set first highest value and then update"},{"line_number":18,"context_line":"it to lower one."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"In case when QoS is attached to Floating IP, it adds update of bandwidth"},{"line_number":21,"context_line":"limit rule and ensure that this rule is also updated properly and new"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4c43b2_215a1a29","line":18,"in_reply_to":"3f4c43b2_98ee02eb","updated":"2020-04-20 13:01:25.000000000","message":"_check_bw is only checking if bytes_per_second \u003c\u003d expected_bw, please check https://github.com/openstack/neutron-tempest-plugin/blob/master/neutron_tempest_plugin/scenario/test_qos.py#L108","commit_id":"722e6d1044fe3e704b310edf8ac99f70157ad68b"}],"neutron_tempest_plugin/scenario/test_qos.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb9cc469c43bd83fcb980f96870c6aec975b58a4","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            bw_limit_policy_id_new,"},{"line_number":292,"context_line":"            rule_id_new,"},{"line_number":293,"context_line":"            max_kbps\u003dconstants.LIMIT_KILO_BITS_PER_SECOND,"},{"line_number":294,"context_line":"            max_burst_kbps\u003dconstants.LIMIT_KILO_BITS_PER_SECOND)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        # Check that actual BW while downloading file"},{"line_number":297,"context_line":"        # is as expected (Update BW)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_78eb36db","line":294,"updated":"2020-04-20 11:08:05.000000000","message":"You are setting again the same value as before. Is that what you want?","commit_id":"722e6d1044fe3e704b310edf8ac99f70157ad68b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"419d2eece32be33107dea8af59952022eb8f9954","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            bw_limit_policy_id_new,"},{"line_number":292,"context_line":"            rule_id_new,"},{"line_number":293,"context_line":"            max_kbps\u003dconstants.LIMIT_KILO_BITS_PER_SECOND,"},{"line_number":294,"context_line":"            max_burst_kbps\u003dconstants.LIMIT_KILO_BITS_PER_SECOND)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        # Check that actual BW while downloading file"},{"line_number":297,"context_line":"        # is as expected (Update BW)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_21733ab3","line":294,"in_reply_to":"3f4c43b2_78eb36db","updated":"2020-04-20 13:01:25.000000000","message":"Nope, I simple forgot to change the one above :) Thx","commit_id":"722e6d1044fe3e704b310edf8ac99f70157ad68b"}]}