)]}'
{"neutron_tempest_plugin/scenario/test_multicast.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"3937872d03b7fe0ab838639bf244a3e783361f61","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        # Run the unregistered node script"},{"line_number":305,"context_line":"        unregistered[\u0027ssh_client\u0027].execute_script("},{"line_number":306,"context_line":"            \"bash ~/unregistered_traffic_receiver.sh\", become_root\u003dTrue)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        self._prepare_sender(sender, mcast_address)"},{"line_number":309,"context_line":"        receiver_ids \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_fe4d6f9a","line":306,"range":{"start_line":306,"start_character":13,"end_line":306,"end_character":52},"updated":"2020-04-20 12:52:36.000000000","message":"Do we need to move this to /tmp/ as well for the same reasons?","commit_id":"35e96fd5d709562e936983c0aa48ea2edbf82ec0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d2d7a59e26420353cd1077ccf064cc209486dbba","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        # Run the unregistered node script"},{"line_number":305,"context_line":"        unregistered[\u0027ssh_client\u0027].execute_script("},{"line_number":306,"context_line":"            \"bash ~/unregistered_traffic_receiver.sh\", become_root\u003dTrue)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        self._prepare_sender(sender, mcast_address)"},{"line_number":309,"context_line":"        receiver_ids \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_a1e10a2d","line":306,"range":{"start_line":306,"start_character":13,"end_line":306,"end_character":52},"in_reply_to":"3f4c43b2_1e177b53","updated":"2020-04-20 13:07:33.000000000","message":"Oh sorry I missed your second comment... Lemme do it.","commit_id":"35e96fd5d709562e936983c0aa48ea2edbf82ec0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fdaa748554eb812c1bbe98026bde5abab9a47a63","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        # Run the unregistered node script"},{"line_number":305,"context_line":"        unregistered[\u0027ssh_client\u0027].execute_script("},{"line_number":306,"context_line":"            \"bash ~/unregistered_traffic_receiver.sh\", become_root\u003dTrue)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        self._prepare_sender(sender, mcast_address)"},{"line_number":309,"context_line":"        receiver_ids \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_1e177b53","line":306,"range":{"start_line":306,"start_character":13,"end_line":306,"end_character":52},"in_reply_to":"3f4c43b2_3e3997f1","updated":"2020-04-20 12:55:11.000000000","message":"oh yes! Let\u0027s do it","commit_id":"35e96fd5d709562e936983c0aa48ea2edbf82ec0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6f654efed7b5d588237451c5ebf89121d5e20621","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        # Run the unregistered node script"},{"line_number":305,"context_line":"        unregistered[\u0027ssh_client\u0027].execute_script("},{"line_number":306,"context_line":"            \"bash ~/unregistered_traffic_receiver.sh\", become_root\u003dTrue)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        self._prepare_sender(sender, mcast_address)"},{"line_number":309,"context_line":"        receiver_ids \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_81968e4b","line":306,"range":{"start_line":306,"start_character":13,"end_line":306,"end_character":52},"in_reply_to":"3f4c43b2_a1e10a2d","updated":"2020-04-20 13:18:50.000000000","message":"Note, I still need to keep the \"bash \u003cscript\u003e\" even if shell is set to bash or I get a:\n\nscript:\n/tmp/unregistered_traffic_receiver.sh\nstderr:\nbash: line 1: /tmp/unregistered_traffic_receiver.sh: Permission denied\n\nThis is because the script does not have execution permission (chmod +x). I can perhaps set that permission but, not sure if it\u0027s needed ? Keeping the bash command prefix works.","commit_id":"35e96fd5d709562e936983c0aa48ea2edbf82ec0"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"51888ebf10e7fba01c7d56a5a833c555ee0597b7","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        # Run the unregistered node script"},{"line_number":305,"context_line":"        unregistered[\u0027ssh_client\u0027].execute_script("},{"line_number":306,"context_line":"            \"bash ~/unregistered_traffic_receiver.sh\", become_root\u003dTrue)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        self._prepare_sender(sender, mcast_address)"},{"line_number":309,"context_line":"        receiver_ids \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_3e3997f1","line":306,"range":{"start_line":306,"start_character":13,"end_line":306,"end_character":52},"in_reply_to":"3f4c43b2_fe4d6f9a","updated":"2020-04-20 12:54:15.000000000","message":"Oh also, it\u0027s unrelated but perhaps we can use the same thing as in L314 and pass \u0027bash\u0027 as the shell parameter?","commit_id":"35e96fd5d709562e936983c0aa48ea2edbf82ec0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"52671075f7922c4a0c6f9b5b17f10e3e650e50df","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        unregistered_result \u003d unregistered[\u0027ssh_client\u0027].execute_script("},{"line_number":352,"context_line":"            \"cat {path} || echo \u0027{path} not exists yet\u0027\".format("},{"line_number":353,"context_line":"                path\u003dself.unregistered_output_file))"},{"line_number":354,"context_line":"        LOG.debug(\"Unregirested VM result: %s\", unregistered_result)"},{"line_number":355,"context_line":"        expected_result \u003d \u00270 packets captured\u0027"},{"line_number":356,"context_line":"        if self._is_multicast_traffic_expected(mcast_address):"},{"line_number":357,"context_line":"            expected_result \u003d \u00271 packet captured\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_2fa571b6","line":354,"range":{"start_line":354,"start_character":19,"end_line":354,"end_character":31},"updated":"2020-04-20 18:59:23.000000000","message":"s/Unregistered","commit_id":"c68244faa5f77cccd441374dc46c2d016685867e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"dfd314c20041ba05d7c51b5a31476e95df552d45","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        [Sender server] -\u003e (Multicast network) -\u003e [Receiver server]"},{"line_number":261,"context_line":"        \"\"\""},{"line_number":262,"context_line":"        LOG.debug(\"IGMP snooping enabled: %s\","},{"line_number":263,"context_line":"                  CONF.neutron_plugin_options.is_igmp_snooping_enabled)"},{"line_number":264,"context_line":"        sender \u003d self._create_server()"},{"line_number":265,"context_line":"        receivers \u003d [self._create_server() for _ in range(1)]"},{"line_number":266,"context_line":"        # Sender can be also receiver of multicast traffic"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_8dbe0d63","line":263,"range":{"start_line":262,"start_character":8,"end_line":263,"end_character":71},"updated":"2020-04-23 11:38:03.000000000","message":"nit: Is this related to the fix?","commit_id":"023396f59facd2caa28e992b85102ff2befcf467"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6a810ffd46e04dddcfd78d5fddb41b9547c92a18","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        [Sender server] -\u003e (Multicast network) -\u003e [Receiver server]"},{"line_number":261,"context_line":"        \"\"\""},{"line_number":262,"context_line":"        LOG.debug(\"IGMP snooping enabled: %s\","},{"line_number":263,"context_line":"                  CONF.neutron_plugin_options.is_igmp_snooping_enabled)"},{"line_number":264,"context_line":"        sender \u003d self._create_server()"},{"line_number":265,"context_line":"        receivers \u003d [self._create_server() for _ in range(1)]"},{"line_number":266,"context_line":"        # Sender can be also receiver of multicast traffic"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_dc2284a4","line":263,"range":{"start_line":262,"start_character":8,"end_line":263,"end_character":71},"in_reply_to":"1f493fa4_8dbe0d63","updated":"2020-04-23 12:27:22.000000000","message":"I thought it was nice to log whether the option is enabled or not cause it saves some time when troubleshooting. I would say it\u0027s similar to the log on L293 (the multicast group address).\n\nShould I remove it ?","commit_id":"023396f59facd2caa28e992b85102ff2befcf467"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"043a5fcc6347222bf0f8def520915974fa239406","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        [Sender server] -\u003e (Multicast network) -\u003e [Receiver server]"},{"line_number":261,"context_line":"        \"\"\""},{"line_number":262,"context_line":"        LOG.debug(\"IGMP snooping enabled: %s\","},{"line_number":263,"context_line":"                  CONF.neutron_plugin_options.is_igmp_snooping_enabled)"},{"line_number":264,"context_line":"        sender \u003d self._create_server()"},{"line_number":265,"context_line":"        receivers \u003d [self._create_server() for _ in range(1)]"},{"line_number":266,"context_line":"        # Sender can be also receiver of multicast traffic"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_ab376cb0","line":263,"range":{"start_line":262,"start_character":8,"end_line":263,"end_character":71},"in_reply_to":"1f493fa4_dc2284a4","updated":"2020-04-23 15:16:10.000000000","message":"I can leave with it, I thought it was some left overs from local debug","commit_id":"023396f59facd2caa28e992b85102ff2befcf467"}]}