)]}'
{"neutron_tempest_plugin/api/admin/test_external_network_extension.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7049299e20b8dad96a2bd4bca802088380ac8cd0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def _delete_network(self, net_id):"},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            self.admin_client.delete_network(net_id)"},{"line_number":44,"context_line":"        except lib_exc.Conflict:"},{"line_number":45,"context_line":"            ports \u003d self.admin_client.list_ports(network_id\u003dnet_id)[\u0027ports\u0027]"},{"line_number":46,"context_line":"            for port in ports:"},{"line_number":47,"context_line":"                self.admin_client.delete_port(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_439dac08","line":44,"updated":"2020-04-27 15:42:59.000000000","message":"While I think this is Ok since it covers the DVR case, I don\u0027t think our tempest code in general is using it\u0027s own built-in mechanisms to cleanup resources created using the admin client.  I know we started doing this at one point in time, just don\u0027t remember if things were never finished or abandoned.  I created https://review.opendev.org/723587 as an example of what I mean.","commit_id":"03700aa12b4e22552f8626ffb9d5261d7a7c44c8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e0e52734916cbd2bff2decc636902a7e675890d7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def _delete_network(self, net_id):"},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            self.admin_client.delete_network(net_id)"},{"line_number":44,"context_line":"        except lib_exc.Conflict:"},{"line_number":45,"context_line":"            ports \u003d self.admin_client.list_ports(network_id\u003dnet_id)[\u0027ports\u0027]"},{"line_number":46,"context_line":"            for port in ports:"},{"line_number":47,"context_line":"                self.admin_client.delete_port(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_584d8598","line":44,"in_reply_to":"1f493fa4_439dac08","updated":"2020-04-28 08:46:13.000000000","message":"I commented it that Your patch. And here it\u0027s a bit different because network isn\u0027t created with self.create_network but by directly calling self.admin_client.create_network in L36 so this network isn\u0027t added to cls.networks list to be cleaned automatically.","commit_id":"03700aa12b4e22552f8626ffb9d5261d7a7c44c8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f3fd89fe6fc85eaa219711bf5f96a3d2a82f4a59","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def _delete_network(self, net_id):"},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            self.admin_client.delete_network(net_id)"},{"line_number":44,"context_line":"        except lib_exc.Conflict:"},{"line_number":45,"context_line":"            ports \u003d self.admin_client.list_ports(network_id\u003dnet_id)[\u0027ports\u0027]"},{"line_number":46,"context_line":"            for port in ports:"},{"line_number":47,"context_line":"                self.admin_client.delete_port(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_7b0cb6eb","line":44,"in_reply_to":"1f493fa4_584d8598","updated":"2020-04-28 13:53:36.000000000","message":"Right, and thanks for the review, need to update the other patch.","commit_id":"03700aa12b4e22552f8626ffb9d5261d7a7c44c8"}]}