)]}'
{"neutron_tempest_plugin/api/admin/test_external_network_extension.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"cc18646ba399962908d6eacfad6992bfd6bae036","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        post_body \u003d {\u0027name\u0027: data_utils.rand_name(\u0027network\u0027)}"},{"line_number":34,"context_line":"        if external:"},{"line_number":35,"context_line":"            post_body[\u0027router:external\u0027] \u003d external"},{"line_number":36,"context_line":"        body \u003d self.admin_client.create_network(**post_body)"},{"line_number":37,"context_line":"        network \u003d body[\u0027network\u0027]"},{"line_number":38,"context_line":"        self.addCleanup(self._delete_network, network[\u0027id\u0027])"},{"line_number":39,"context_line":"        return network"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _delete_network(self, net_id):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_593ce32f","line":38,"range":{"start_line":36,"start_character":0,"end_line":38,"end_character":60},"updated":"2020-06-09 12:53:05.000000000","message":"perhaps this one too?\nAs I see base.create_network can handle **kwargs so router:external can work with it too?","commit_id":"24bd100825c10f0833828777bcc47d99f25064b1"}],"neutron_tempest_plugin/api/admin/test_shared_network_extension.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2113c0ef18c4730f67f3cb2a8aa0265af0cfb722","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        body \u003d self.admin_client.create_bulk_network(net_nm, shared\u003dTrue)"},{"line_number":116,"context_line":"        created_networks \u003d body[\u0027networks\u0027]"},{"line_number":117,"context_line":"        for net in created_networks:"},{"line_number":118,"context_line":"            self.addCleanup(self.admin_client.delete_network(net[\u0027id\u0027]))"},{"line_number":119,"context_line":"            self.assertIsNotNone(net[\u0027id\u0027])"},{"line_number":120,"context_line":"            self.assertTrue(net[\u0027shared\u0027])"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_bbe0da27","line":118,"updated":"2020-04-29 17:02:09.000000000","message":"oops","commit_id":"957c8f63dabb545c38c68ab45395e7521cca2ff6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2113c0ef18c4730f67f3cb2a8aa0265af0cfb722","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        pol \u003d self.admin_client.create_rbac_policy("},{"line_number":193,"context_line":"            object_type\u003d\u0027network\u0027, object_id\u003dnet[\u0027id\u0027],"},{"line_number":194,"context_line":"            action\u003d\u0027access_as_shared\u0027, target_tenant\u003dproject_id"},{"line_number":195,"context_line":"        )[\u0027rbac_policy\u0027]"},{"line_number":196,"context_line":"        return {\u0027network\u0027: net, \u0027subnet\u0027: subnet, \u0027policy\u0027: pol}"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    @decorators.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_7bcdb283","line":195,"updated":"2020-04-29 17:02:09.000000000","message":"Odd that this is causing an rbac failure","commit_id":"957c8f63dabb545c38c68ab45395e7521cca2ff6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"29c0c9630075c3e9780747db300ad204dffb69f4","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    def _make_admin_net_and_subnet_shared_to_project_id(self, project_id):"},{"line_number":187,"context_line":"        net \u003d self.create_network("},{"line_number":188,"context_line":"            network_name\u003ddata_utils.rand_name(\u0027test-network\u0027),"},{"line_number":189,"context_line":"            client\u003dself.admin_client)"},{"line_number":190,"context_line":"        subnet \u003d self.create_subnet(net, client\u003dself.admin_client)"},{"line_number":191,"context_line":"        # network is shared to first unprivileged client by default"},{"line_number":192,"context_line":"        pol \u003d self.admin_client.create_rbac_policy("}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_fc008136","line":189,"updated":"2020-04-30 16:23:19.000000000","message":"I give up, just going to revert this part.","commit_id":"228ebee2be1409e95ad4b4136d968ea79d6b54a0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b139ad3d266e4980be7e89e68596b9a3688a4367","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        # network is shared to first unprivileged client by default"},{"line_number":192,"context_line":"        pol \u003d self.admin_client.create_rbac_policy("},{"line_number":193,"context_line":"            object_type\u003d\u0027network\u0027, object_id\u003dnet[\u0027id\u0027],"},{"line_number":194,"context_line":"            action\u003d\u0027access_as_shared\u0027, target_tenant\u003dproject_id"},{"line_number":195,"context_line":"        )[\u0027rbac_policy\u0027]"},{"line_number":196,"context_line":"        return {\u0027network\u0027: net, \u0027subnet\u0027: subnet, \u0027policy\u0027: pol}"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_7efc7b3d","line":194,"updated":"2020-04-29 21:44:31.000000000","message":"This is still the call that\u0027s failing with an over quota warning, guess I could change it back just seems like it should work.","commit_id":"228ebee2be1409e95ad4b4136d968ea79d6b54a0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"cc18646ba399962908d6eacfad6992bfd6bae036","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        cls.client2 \u003d cls.os_alt.network_client"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def _make_admin_net_and_subnet_shared_to_project_id(self, project_id):"},{"line_number":187,"context_line":"        net \u003d self.admin_client.create_network("},{"line_number":188,"context_line":"            name\u003ddata_utils.rand_name(\u0027test-network\u0027))[\u0027network\u0027]"},{"line_number":189,"context_line":"        self.addCleanup(self.admin_client.delete_network, net[\u0027id\u0027])"},{"line_number":190,"context_line":"        subnet \u003d self.create_subnet(net, client\u003dself.admin_client)"},{"line_number":191,"context_line":"        # network is shared to first unprivileged client by default"},{"line_number":192,"context_line":"        pol \u003d self.admin_client.create_rbac_policy("}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_f985f7d0","line":189,"range":{"start_line":187,"start_character":0,"end_line":189,"end_character":68},"updated":"2020-06-09 12:53:05.000000000","message":"this one as well perhaps?","commit_id":"24bd100825c10f0833828777bcc47d99f25064b1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2c1417d030a9780887c3cd513a232723a055a3d1","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        max_policies \u003d quota[\u0027rbac_policy\u0027]"},{"line_number":373,"context_line":"        self.assertGreater(max_policies, 0)"},{"line_number":374,"context_line":"        net \u003d self.create_network("},{"line_number":375,"context_line":"            network_name\u003ddata_utils.rand_name(\u0027test-network\u0027))"},{"line_number":376,"context_line":"        with testtools.ExpectedException(lib_exc.Conflict):"},{"line_number":377,"context_line":"            for i in range(0, max_policies + 1):"},{"line_number":378,"context_line":"                self.admin_client.create_rbac_policy("}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_187ba68b","line":375,"updated":"2020-05-01 15:41:28.000000000","message":"I give up","commit_id":"24bd100825c10f0833828777bcc47d99f25064b1"}],"neutron_tempest_plugin/api/base.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a86ddeff6ac18670edaefb7eaad84d40512d540d","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        super(BaseNetworkTest, cls).resource_setup()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        cls.networks \u003d []"},{"line_number":114,"context_line":"        cls.admin_networks \u003d []"},{"line_number":115,"context_line":"        cls.subnets \u003d []"},{"line_number":116,"context_line":"        cls.admin_subnets \u003d []"},{"line_number":117,"context_line":"        cls.ports \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_3b006e01","line":114,"updated":"2020-04-28 13:59:12.000000000","message":"So I guess this is unnecessary since we never add anything to it.","commit_id":"5e761634eeeddb592b09eab9d7732418f1b86ffa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a86ddeff6ac18670edaefb7eaad84d40512d540d","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            # Clean up admin networks"},{"line_number":202,"context_line":"            for network in cls.admin_networks:"},{"line_number":203,"context_line":"                cls._try_delete_resource(cls.admin_client.delete_network,"},{"line_number":204,"context_line":"                                         network[\u0027id\u0027])"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"            # Clean up security groups"},{"line_number":207,"context_line":"            for security_group in cls.security_groups:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_982268b8","line":204,"updated":"2020-04-28 13:59:12.000000000","message":"And this too","commit_id":"5e761634eeeddb592b09eab9d7732418f1b86ffa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ca32b684fbb0818a394eb886ab3416c44976ca01","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        if client is cls.client:"},{"line_number":369,"context_line":"            cls.networks.append(network)"},{"line_number":370,"context_line":"        else:"},{"line_number":371,"context_line":"            cls.admin_networks.append(network)"},{"line_number":372,"context_line":"        return network"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_986a6dea","line":371,"updated":"2020-04-28 08:44:42.000000000","message":"it shouldn\u0027t be needed because client which creates network, is stored in network[\u0027client\u0027] in L367. And later in L376 it is choosen first. So always client which created network should  be used to delete it too.","commit_id":"5e761634eeeddb592b09eab9d7732418f1b86ffa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a86ddeff6ac18670edaefb7eaad84d40512d540d","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        if client is cls.client:"},{"line_number":369,"context_line":"            cls.networks.append(network)"},{"line_number":370,"context_line":"        else:"},{"line_number":371,"context_line":"            cls.admin_networks.append(network)"},{"line_number":372,"context_line":"        return network"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_5b861a15","line":371,"in_reply_to":"1f493fa4_986a6dea","updated":"2020-04-28 13:59:12.000000000","message":"Right, it was right in front of me and I missed it :(\n\nSo there are cases in this patch where callers could be using cls.create_network(client\u003dcls.admin_client) and get things done automatically.  There are also cases where I should have left things alone, so I\u0027ll work on an update.","commit_id":"5e761634eeeddb592b09eab9d7732418f1b86ffa"}],"neutron_tempest_plugin/api/test_subnetpools.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"cc18646ba399962908d6eacfad6992bfd6bae036","unresolved":false,"context_lines":[{"line_number":468,"context_line":"            subnetpool_id\u003dres[\u0027subnetpool\u0027][\u0027id\u0027],"},{"line_number":469,"context_line":"            name\u003ddata_utils.rand_name(\"rbac-subnetpool\"),"},{"line_number":470,"context_line":"        )[\"subnet\"]"},{"line_number":471,"context_line":"        self.addCleanup(self.client2.delete_network, network[\u0027id\u0027])"},{"line_number":472,"context_line":"        self.addCleanup("},{"line_number":473,"context_line":"            self.admin_client.delete_subnetpool,"},{"line_number":474,"context_line":"            res[\u0027subnetpool\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_b9eb7f10","side":"PARENT","line":471,"range":{"start_line":471,"start_character":8,"end_line":471,"end_character":67},"updated":"2020-06-09 12:53:05.000000000","message":"this can be removed as well as I see","commit_id":"4bc1b00213cf660648cad1916fe6497ac29b2e78"}],"neutron_tempest_plugin/vpnaas/api/test_vpnaas.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"cc18646ba399962908d6eacfad6992bfd6bae036","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        router2 \u003d self.create_router(data_utils.rand_name(\u0027router-\u0027),"},{"line_number":461,"context_line":"                                     external_network_id\u003dself.ext_net_id)"},{"line_number":462,"context_line":"        self.addCleanup(self.admin_client.delete_router, router2[\u0027id\u0027])"},{"line_number":463,"context_line":"        self.addCleanup(self.admin_client.delete_network, network2[\u0027id\u0027])"},{"line_number":464,"context_line":"        name \u003d data_utils.rand_name(\u0027vpn-service\u0027)"},{"line_number":465,"context_line":"        self.assertRaises("},{"line_number":466,"context_line":"            lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_59d863ef","line":463,"range":{"start_line":463,"start_character":9,"end_line":463,"end_character":73},"updated":"2020-06-09 12:53:05.000000000","message":"this one can be removed as I see","commit_id":"24bd100825c10f0833828777bcc47d99f25064b1"}]}