)]}'
{"neutron_tempest_plugin/api/test_security_groups.py":[{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"140061d609c9c950c0985f5e1ea217d73fe68ddb","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    def test_create_sg_rules_when_quota_disabled(self):"},{"line_number":312,"context_line":"        sg_rules_amount \u003d self._get_sg_rules_amount()"},{"line_number":313,"context_line":"        self._set_sg_rules_quota(-1)"},{"line_number":314,"context_line":"        self._create_security_group_rules(10, port_index\u003d100)"},{"line_number":315,"context_line":"        new_sg_rules_amount \u003d self._get_sg_rules_amount()"},{"line_number":316,"context_line":"        self.assertGreater(new_sg_rules_amount, sg_rules_amount)"},{"line_number":317,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_ef21b0a1","line":314,"range":{"start_line":314,"start_character":8,"end_line":314,"end_character":61},"updated":"2020-05-11 13:55:05.000000000","message":"according to the logs this test has been executed before the one that is introduced in the patch. seems like an issue is happening because you do not clear newly created rules so the new test failed without even creating one rule.","commit_id":"5fe8d0fd712b61ce5845a52fefc473ff41b96c97"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"e3d505c25808df2151764bb6eb382d51e672e0da","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    def test_create_sg_rules_when_quota_disabled(self):"},{"line_number":312,"context_line":"        sg_rules_amount \u003d self._get_sg_rules_amount()"},{"line_number":313,"context_line":"        self._set_sg_rules_quota(-1)"},{"line_number":314,"context_line":"        self._create_security_group_rules(10, port_index\u003d100)"},{"line_number":315,"context_line":"        new_sg_rules_amount \u003d self._get_sg_rules_amount()"},{"line_number":316,"context_line":"        self.assertGreater(new_sg_rules_amount, sg_rules_amount)"},{"line_number":317,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_f22197a1","line":314,"range":{"start_line":314,"start_character":8,"end_line":314,"end_character":61},"in_reply_to":"ff570b3c_ef21b0a1","updated":"2020-05-11 14:32:21.000000000","message":"so I need to add to def _create_security_group_rules cleanup in the end that should resolve the problem something like self.addCleanup(self.delete_security_group_rules)","commit_id":"5fe8d0fd712b61ce5845a52fefc473ff41b96c97"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cdcdde817a8686a985c51f44fd1991385035118e","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        new_quota \u003d self._increase_sg_rules_quota()"},{"line_number":291,"context_line":"        port_index \u003d new_quota"},{"line_number":292,"context_line":"        self._create_max_allowed_sg_rules_amount(port_index)"},{"line_number":293,"context_line":"        quota_set \u003d self._get_sg_rules_quota()"},{"line_number":294,"context_line":"        self.assertEqual(quota_set, self._get_sg_rules_amount(),"},{"line_number":295,"context_line":"                         \"Amount of security groups rules doesn\u0027t match quota\")"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @decorators.idempotent_id(\u002737508c8d-270b-4b93-8007-72876a1fec38\u0027)"},{"line_number":298,"context_line":"    def test_sg_rules_quota_values(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_d4d2c6d0","line":295,"range":{"start_line":293,"start_character":8,"end_line":295,"end_character":79},"updated":"2020-05-20 06:16:28.000000000","message":"This is already the same test as you intend to add it, just with some action happening before.\n\nSo I don\u0027t understand what the added value of the new test will be, can you explain that a bit?\n\nOr maybe just add your assert after the initial _create_max_allowed_sg_rules_amount() above?","commit_id":"26dbdd115d63c9cfa21cb780955f31719fe23712"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ee9fedef56ee3f84e7303043f22ccb56f8fc118e","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        new_quota \u003d self._increase_sg_rules_quota()"},{"line_number":291,"context_line":"        port_index \u003d new_quota"},{"line_number":292,"context_line":"        self._create_max_allowed_sg_rules_amount(port_index)"},{"line_number":293,"context_line":"        quota_set \u003d self._get_sg_rules_quota()"},{"line_number":294,"context_line":"        self.assertEqual(quota_set, self._get_sg_rules_amount(),"},{"line_number":295,"context_line":"                         \"Amount of security groups rules doesn\u0027t match quota\")"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @decorators.idempotent_id(\u002737508c8d-270b-4b93-8007-72876a1fec38\u0027)"},{"line_number":298,"context_line":"    def test_sg_rules_quota_values(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_805da116","line":295,"range":{"start_line":293,"start_character":8,"end_line":295,"end_character":79},"in_reply_to":"ff570b3c_cf0a2f1e","updated":"2020-05-20 11:51:40.000000000","message":"Actually I think I agree with Jens here. I don\u0027t see really need for the new test which is almost the same as this one. IN both You are checking if it is possible to create as many rules as is set in quota. Nothing else. Does it really matters if this quota was updated before or not? IMO this case can cover also this new one proposed by You in this patch.","commit_id":"26dbdd115d63c9cfa21cb780955f31719fe23712"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"1702a0a7c085b01c81ae2803d63f4eef5991cc20","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        new_quota \u003d self._increase_sg_rules_quota()"},{"line_number":291,"context_line":"        port_index \u003d new_quota"},{"line_number":292,"context_line":"        self._create_max_allowed_sg_rules_amount(port_index)"},{"line_number":293,"context_line":"        quota_set \u003d self._get_sg_rules_quota()"},{"line_number":294,"context_line":"        self.assertEqual(quota_set, self._get_sg_rules_amount(),"},{"line_number":295,"context_line":"                         \"Amount of security groups rules doesn\u0027t match quota\")"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @decorators.idempotent_id(\u002737508c8d-270b-4b93-8007-72876a1fec38\u0027)"},{"line_number":298,"context_line":"    def test_sg_rules_quota_values(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_cf0a2f1e","line":295,"range":{"start_line":293,"start_character":8,"end_line":295,"end_character":79},"in_reply_to":"ff570b3c_d4d2c6d0","updated":"2020-05-20 06:32:19.000000000","message":"this test is testing the option of create max security group rules after changing the value and the test that is creating the max SG rules according to the current quota value that set.","commit_id":"26dbdd115d63c9cfa21cb780955f31719fe23712"}]}