)]}'
{"neutron_tempest_plugin/scenario/test_floatingip.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"53ff792b7cbf832cf3984c24ccf97aa50b35cb19","unresolved":false,"context_lines":[{"line_number":566,"context_line":"            self._create_network_and_servers(servers_num\u003d2))"},{"line_number":567,"context_line":"        self._check_fips_connectivity(mutable_fip, permanent_fip)"},{"line_number":568,"context_line":"        ip_address \u003d mutable_fip[\u0027floating_ip_address\u0027]"},{"line_number":569,"context_line":"        self.delete_floatingip(mutable_fip)"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":""},{"line_number":572,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_5c5f74e4","line":569,"range":{"start_line":569,"start_character":8,"end_line":569,"end_character":43},"updated":"2020-05-28 04:33:53.000000000","message":"I think you have to move this to _delete_floating_ip","commit_id":"25ee0c94e2fdcdff7a5d5aa34635a250f626b11e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5cbf068d3e058857bf7c9af3b8c267feb3ce791a","unresolved":false,"context_lines":[{"line_number":566,"context_line":"            self._create_network_and_servers(servers_num\u003d2))"},{"line_number":567,"context_line":"        self._check_fips_connectivity(mutable_fip, permanent_fip)"},{"line_number":568,"context_line":"        ip_address \u003d mutable_fip[\u0027floating_ip_address\u0027]"},{"line_number":569,"context_line":"        self.delete_floatingip(mutable_fip)"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":""},{"line_number":572,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_72289c33","line":569,"range":{"start_line":569,"start_character":8,"end_line":569,"end_character":43},"in_reply_to":"ff570b3c_5c5f74e4","updated":"2020-05-28 10:32:13.000000000","message":"Definitely I need to pay more attention when coding...","commit_id":"25ee0c94e2fdcdff7a5d5aa34635a250f626b11e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bd8e3562551c5a1f86ab0b4d43323d942d93abb3","unresolved":false,"context_lines":[{"line_number":566,"context_line":"            self._create_network_and_servers(servers_num\u003d2))"},{"line_number":567,"context_line":"        self._check_fips_connectivity(mutable_fip, permanent_fip)"},{"line_number":568,"context_line":"        ip_address \u003d mutable_fip[\u0027floating_ip_address\u0027]"},{"line_number":569,"context_line":"        self.delete_floatingip(mutable_fip)"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":""},{"line_number":572,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_edf32d9d","line":569,"range":{"start_line":569,"start_character":8,"end_line":569,"end_character":43},"in_reply_to":"ff570b3c_72289c33","updated":"2020-05-28 11:47:53.000000000","message":"This is why we work in teams :-)\nAs my mother says: \"Those who never work will never do mistakes\" :-)","commit_id":"25ee0c94e2fdcdff7a5d5aa34635a250f626b11e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8a9ff1e4c7b58902c2f0cf68ec6e6afa08981a7b","unresolved":false,"context_lines":[{"line_number":570,"context_line":""},{"line_number":571,"context_line":""},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        [mutable_fip] \u003d self._create_network_and_servers("},{"line_number":574,"context_line":"            servers_num\u003d1, fip_addresses\u003d[ip_address])"},{"line_number":575,"context_line":"        self._check_fips_connectivity(mutable_fip, permanent_fip)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_653d82dc","line":573,"updated":"2020-05-27 19:42:54.000000000","message":"pep8: E303 too many blank lines (3)","commit_id":"25ee0c94e2fdcdff7a5d5aa34635a250f626b11e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"53ff792b7cbf832cf3984c24ccf97aa50b35cb19","unresolved":false,"context_lines":[{"line_number":571,"context_line":""},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        [mutable_fip] \u003d self._create_network_and_servers("},{"line_number":574,"context_line":"            servers_num\u003d1, fip_addresses\u003d[ip_address])"},{"line_number":575,"context_line":"        self._check_fips_connectivity(mutable_fip, permanent_fip)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_7c5cf8ec","line":574,"updated":"2020-05-28 04:33:53.000000000","message":"If I understand well the problem \u0026 test here you have to call here with delete_fip_addresses\u003d[ip_address]:\n[mutable_fip] \u003d self._create_network_and_servers(\n            servers_num\u003d1, fip_addresses\u003d[ip_address],\n            delete_fip_addresses\u003d[ip_address])","commit_id":"25ee0c94e2fdcdff7a5d5aa34635a250f626b11e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5cbf068d3e058857bf7c9af3b8c267feb3ce791a","unresolved":false,"context_lines":[{"line_number":571,"context_line":""},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        [mutable_fip] \u003d self._create_network_and_servers("},{"line_number":574,"context_line":"            servers_num\u003d1, fip_addresses\u003d[ip_address])"},{"line_number":575,"context_line":"        self._check_fips_connectivity(mutable_fip, permanent_fip)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_522bd82e","line":574,"in_reply_to":"ff570b3c_7c5cf8ec","updated":"2020-05-28 10:32:13.000000000","message":"Same here... thanks a lot!!","commit_id":"25ee0c94e2fdcdff7a5d5aa34635a250f626b11e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bd8e3562551c5a1f86ab0b4d43323d942d93abb3","unresolved":false,"context_lines":[{"line_number":460,"context_line":"            secgroup_id\u003dself.secgroup[\u0027id\u0027])"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    def _delete_floating_ip(self, ip_address):"},{"line_number":463,"context_line":"        def _fip_is_free():"},{"line_number":464,"context_line":"            fips \u003d self.os_admin.network_client.list_floatingips()"},{"line_number":465,"context_line":"            for fip in fips[\u0027floatingips\u0027]:"},{"line_number":466,"context_line":"                if ip_address \u003d\u003d fip[\u0027floating_ip_address\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_edda0d15","line":463,"updated":"2020-05-28 11:47:53.000000000","message":"self.delete_floatingip(mutable_fip)","commit_id":"54ad23157ff283d702e4778237387abfce993711"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"37928fc0599a526b925fe0a80b33fb1d44f39298","unresolved":false,"context_lines":[{"line_number":460,"context_line":"            secgroup_id\u003dself.secgroup[\u0027id\u0027])"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    def _delete_floating_ip(self, ip_address):"},{"line_number":463,"context_line":"        def _fip_is_free():"},{"line_number":464,"context_line":"            fips \u003d self.os_admin.network_client.list_floatingips()"},{"line_number":465,"context_line":"            for fip in fips[\u0027floatingips\u0027]:"},{"line_number":466,"context_line":"                if ip_address \u003d\u003d fip[\u0027floating_ip_address\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_e5bea1d2","line":463,"in_reply_to":"ff570b3c_edda0d15","updated":"2020-05-28 13:42:23.000000000","message":"Thanks again!","commit_id":"54ad23157ff283d702e4778237387abfce993711"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e100c76dbc270482f3eb5fa2c68b8303d13f0ee8","unresolved":false,"context_lines":[{"line_number":467,"context_line":"                    return False"},{"line_number":468,"context_line":"            return True"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        self.delete_floatingip(mutable_fip)         "},{"line_number":471,"context_line":"        try:"},{"line_number":472,"context_line":"            common_utils.wait_until_true(lambda: _fip_is_free(),"},{"line_number":473,"context_line":"                                         timeout\u003d30, sleep\u003d5)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_748fe12d","line":470,"updated":"2020-05-28 16:23:53.000000000","message":"pep8: F821 undefined name \u0027mutable_fip\u0027","commit_id":"dbe9a12b08ccf40b9a3091e726829dfac2945040"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e100c76dbc270482f3eb5fa2c68b8303d13f0ee8","unresolved":false,"context_lines":[{"line_number":467,"context_line":"                    return False"},{"line_number":468,"context_line":"            return True"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        self.delete_floatingip(mutable_fip)         "},{"line_number":471,"context_line":"        try:"},{"line_number":472,"context_line":"            common_utils.wait_until_true(lambda: _fip_is_free(),"},{"line_number":473,"context_line":"                                         timeout\u003d30, sleep\u003d5)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_d49ead61","line":470,"updated":"2020-05-28 16:23:53.000000000","message":"pep8: W291 trailing whitespace","commit_id":"dbe9a12b08ccf40b9a3091e726829dfac2945040"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6d9f152883cf1201d1efb61e89ece5fe5c380be5","unresolved":false,"context_lines":[{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        self.delete_floatingip(fip_address)"},{"line_number":473,"context_line":"        try:"},{"line_number":474,"context_line":"            common_utils.wait_until_true(lambda: _fip_is_free(),"},{"line_number":475,"context_line":"                                         timeout\u003d30, sleep\u003d5)"},{"line_number":476,"context_line":"        except common_utils.WaitTimeout:"},{"line_number":477,"context_line":"            self.fail(\"Can\u0027t reuse IP address because it is not free\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_c8cd2931","line":474,"updated":"2020-06-02 20:40:40.000000000","message":"nit: I think You wouldn\u0027t need lambda if You would do something like:\n\n    common_utils.wait_until_true(_fip_is_free, timeout\u003d30, sleep\u003d5)","commit_id":"97b0d2ac3d41fe3d0da61daf51e461cac723745e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"feba3cb733b6696a92870ed3d26f6568d6d565bd","unresolved":false,"context_lines":[{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        self.delete_floatingip(fip_address)"},{"line_number":473,"context_line":"        try:"},{"line_number":474,"context_line":"            common_utils.wait_until_true(lambda: _fip_is_free(),"},{"line_number":475,"context_line":"                                         timeout\u003d30, sleep\u003d5)"},{"line_number":476,"context_line":"        except common_utils.WaitTimeout:"},{"line_number":477,"context_line":"            self.fail(\"Can\u0027t reuse IP address because it is not free\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_350027ac","line":474,"in_reply_to":"ff570b3c_c8cd2931","updated":"2020-06-08 16:31:03.000000000","message":"Right! (I copy/pasted from somewhere and I left it)","commit_id":"97b0d2ac3d41fe3d0da61daf51e461cac723745e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6d9f152883cf1201d1efb61e89ece5fe5c380be5","unresolved":false,"context_lines":[{"line_number":474,"context_line":"            common_utils.wait_until_true(lambda: _fip_is_free(),"},{"line_number":475,"context_line":"                                         timeout\u003d30, sleep\u003d5)"},{"line_number":476,"context_line":"        except common_utils.WaitTimeout:"},{"line_number":477,"context_line":"            self.fail(\"Can\u0027t reuse IP address because it is not free\")"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    def _create_network_and_servers(self, servers_num\u003d1, fip_addresses\u003dNone,"},{"line_number":480,"context_line":"                                    delete_fip_ids\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_28de65d9","line":477,"updated":"2020-06-02 20:40:40.000000000","message":"let\u0027s maybe add exactly what IP address can\u0027t be reused, and maybe where it is already used - that may help us debugging issues if we will have any :)","commit_id":"97b0d2ac3d41fe3d0da61daf51e461cac723745e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"feba3cb733b6696a92870ed3d26f6568d6d565bd","unresolved":false,"context_lines":[{"line_number":474,"context_line":"            common_utils.wait_until_true(lambda: _fip_is_free(),"},{"line_number":475,"context_line":"                                         timeout\u003d30, sleep\u003d5)"},{"line_number":476,"context_line":"        except common_utils.WaitTimeout:"},{"line_number":477,"context_line":"            self.fail(\"Can\u0027t reuse IP address because it is not free\")"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    def _create_network_and_servers(self, servers_num\u003d1, fip_addresses\u003dNone,"},{"line_number":480,"context_line":"                                    delete_fip_ids\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_952ad329","line":477,"in_reply_to":"ff570b3c_28de65d9","updated":"2020-06-08 16:31:03.000000000","message":"Or leave it as is now, the IP address will be a mystery!","commit_id":"97b0d2ac3d41fe3d0da61daf51e461cac723745e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"930dcb95f746c1e4d5672760704f74d498ae7493","unresolved":false,"context_lines":[{"line_number":474,"context_line":"            common_utils.wait_until_true(lambda: _fip_is_free(),"},{"line_number":475,"context_line":"                                         timeout\u003d30, sleep\u003d5)"},{"line_number":476,"context_line":"        except common_utils.WaitTimeout:"},{"line_number":477,"context_line":"            self.fail(\"Can\u0027t reuse IP address because it is not free\")"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    def _create_network_and_servers(self, servers_num\u003d1, fip_addresses\u003dNone,"},{"line_number":480,"context_line":"                                    delete_fip_ids\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_62e3c3a5","line":477,"in_reply_to":"ff570b3c_952ad329","updated":"2020-06-11 12:04:45.000000000","message":":)","commit_id":"97b0d2ac3d41fe3d0da61daf51e461cac723745e"}]}