)]}'
{"neutron_tempest_plugin/scenario/test_dns_integration.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d1a22132b2a5fd617a53512eadf9bb6223d82789","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        self._verify_dns_records(addr_v6, name, record_type\u003d\u0027AAAA\u0027,"},{"line_number":192,"context_line":"                                 found\u003dFalse)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"class DNSIntegrationDomainPerProjectTests(BaseDNSIntegrationTests):"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_9d0cc73a","line":194,"updated":"2020-06-08 01:06:54.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"9a1007283445bd3651472513c9c6789f2df72559"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9953b3a3d6eba2197e385ada100fdfb8d662c9d7","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        cls.subnet_v6 \u003d cls.create_subnet(cls.network,"},{"line_number":231,"context_line":"                                          ip_version\u003d6,"},{"line_number":232,"context_line":"                                          dns_publish_fixed_ip\u003dTrue)"},{"line_number":233,"context_line":"        cls.router \u003d cls.create_router_by_client()"},{"line_number":234,"context_line":"        cls.create_router_interface(cls.router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":235,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_3f8aeb62","line":233,"updated":"2020-08-26 14:43:11.000000000","message":"I think you can reuse the router created in super(BaseDNSIntegrationTests, cls).resource_setup()","commit_id":"11953d82ff4a1f80b8cc93754df9b218e6c59fb4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ab747e6f04eb2f263965d7189edd3d18603f988b","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        cls.subnet_v6 \u003d cls.create_subnet(cls.network,"},{"line_number":231,"context_line":"                                          ip_version\u003d6,"},{"line_number":232,"context_line":"                                          dns_publish_fixed_ip\u003dTrue)"},{"line_number":233,"context_line":"        cls.router \u003d cls.create_router_by_client()"},{"line_number":234,"context_line":"        cls.create_router_interface(cls.router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":235,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_79b8dae4","line":233,"in_reply_to":"9f560f44_3f8aeb62","updated":"2020-08-28 13:11:04.000000000","message":"But classes neutron_tempest_plugin.scenario.base.BaseTempestTestCase and designate_tempest_plugin.tests.base.BaseDnsV2Test from which BaseDNSIntegrationTests inherits don\u0027t create router. So I need to create one here. Or am I missing something?","commit_id":"11953d82ff4a1f80b8cc93754df9b218e6c59fb4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4a4d969e6cedf5328bc6a5a752a89b9b4e85ff4f","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        cls.subnet_v6 \u003d cls.create_subnet(cls.network,"},{"line_number":231,"context_line":"                                          ip_version\u003d6,"},{"line_number":232,"context_line":"                                          dns_publish_fixed_ip\u003dTrue)"},{"line_number":233,"context_line":"        cls.router \u003d cls.create_router_by_client()"},{"line_number":234,"context_line":"        cls.create_router_interface(cls.router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":235,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_1417e547","line":233,"in_reply_to":"9f560f44_79b8dae4","updated":"2020-08-28 13:34:36.000000000","message":"That should be created in BaseDNSIntegrationTests.resource_setup()\n\nBut because the router could depend on the networks created, let\u0027s make it again, just in case.","commit_id":"11953d82ff4a1f80b8cc93754df9b218e6c59fb4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9953b3a3d6eba2197e385ada100fdfb8d662c9d7","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                                          dns_publish_fixed_ip\u003dTrue)"},{"line_number":233,"context_line":"        cls.router \u003d cls.create_router_by_client()"},{"line_number":234,"context_line":"        cls.create_router_interface(cls.router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":235,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    @decorators.idempotent_id(\u002743a67509-3161-4125-8f2c-0d4a67599721\u0027)"},{"line_number":238,"context_line":"    def test_port_with_dns_name(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_dff00f00","line":235,"updated":"2020-08-26 14:43:11.000000000","message":"ditto","commit_id":"11953d82ff4a1f80b8cc93754df9b218e6c59fb4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ab747e6f04eb2f263965d7189edd3d18603f988b","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                                          dns_publish_fixed_ip\u003dTrue)"},{"line_number":233,"context_line":"        cls.router \u003d cls.create_router_by_client()"},{"line_number":234,"context_line":"        cls.create_router_interface(cls.router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":235,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    @decorators.idempotent_id(\u002743a67509-3161-4125-8f2c-0d4a67599721\u0027)"},{"line_number":238,"context_line":"    def test_port_with_dns_name(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_79ad7a9a","line":235,"in_reply_to":"9f560f44_dff00f00","updated":"2020-08-28 13:11:04.000000000","message":"same here","commit_id":"11953d82ff4a1f80b8cc93754df9b218e6c59fb4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"363810f8318377169cdfc67837a08d05d66a9b1a","unresolved":true,"context_lines":[{"line_number":206,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    required_extensions \u003d [\u0027subnet-dns-publish-fixed-ip\u0027,"},{"line_number":209,"context_line":"                           \u0027dns-integration-domain-keywords\u0027]"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    @classmethod"},{"line_number":212,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"cd3d0266_742f9623","line":209,"range":{"start_line":209,"start_character":28,"end_line":209,"end_character":59},"updated":"2021-06-24 07:31:21.000000000","message":"I don\u0027t see this extension in the designate job API extension list.","commit_id":"913c3065e2f2adcf74167b3bdf3e7e0f5200fc18"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"89269db5606eb6fdb903c3b80132684020e856fd","unresolved":true,"context_lines":[{"line_number":206,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    required_extensions \u003d [\u0027subnet-dns-publish-fixed-ip\u0027,"},{"line_number":209,"context_line":"                           \u0027dns-integration-domain-keywords\u0027]"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    @classmethod"},{"line_number":212,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bbaa0c3f_25870c93","line":209,"range":{"start_line":209,"start_character":28,"end_line":209,"end_character":59},"in_reply_to":"8fb4422d_14627965","updated":"2021-06-24 14:48:47.000000000","message":"Oh my... I only reviewed 50% of the patch! I made a search for this extension in the current repo but I didn\u0027t check the other file.\n\nSorry!","commit_id":"913c3065e2f2adcf74167b3bdf3e7e0f5200fc18"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"515e987fcf6c9631a242c271fa64b4dea26162f4","unresolved":true,"context_lines":[{"line_number":206,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    required_extensions \u003d [\u0027subnet-dns-publish-fixed-ip\u0027,"},{"line_number":209,"context_line":"                           \u0027dns-integration-domain-keywords\u0027]"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    @classmethod"},{"line_number":212,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"8fb4422d_14627965","line":209,"range":{"start_line":209,"start_character":28,"end_line":209,"end_character":59},"in_reply_to":"cd3d0266_742f9623","updated":"2021-06-24 14:44:11.000000000","message":"It\u0027s added in https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/733994/8/zuul.d/master_jobs.yaml#19 and tests are run properly, see https://8011428c57c656673612-eb8cb59c110a9d33c33aa832e5c84dda.ssl.cf5.rackcdn.com/733994/8/experimental/neutron-tempest-plugin-designate-scenario/c8cfcf6/testr_results.html","commit_id":"913c3065e2f2adcf74167b3bdf3e7e0f5200fc18"}],"zuul.d/master_jobs.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0f992e8bb5b43a660d922ec2b19c6997b0f41b3c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        - binding"},{"line_number":15,"context_line":"        - default-subnetpools"},{"line_number":16,"context_line":"        - dhcp_agent_scheduler"},{"line_number":17,"context_line":"        - dns-domain-keywords"},{"line_number":18,"context_line":"        - dns-domain-ports"},{"line_number":19,"context_line":"        - dns-integration"},{"line_number":20,"context_line":"        - empty-string-filtering"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_70516236","line":17,"updated":"2020-07-13 09:13:30.000000000","message":"This should be \"dns-integration-domain-keywords\". Although the shorter name might have been nicer and more consistent with existing extensions in retrospect.","commit_id":"85f3c9d3b30876170112095e7e10bda288e8c811"}]}