)]}'
{"neutron_tempest_plugin/api/test_qos.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b117fe6b5c08486f749e6d5d8297517c0c4f5fc4","unresolved":false,"context_lines":[{"line_number":555,"context_line":"            self.client.create_bandwidth_limit_rule,"},{"line_number":556,"context_line":"            \u0027policy\u0027, 1, 2, self.direction)"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"    @decorators.idempotent_id(\u0027e9ce8042-c828-4cb9-b1f1-85bd35e6553a\u0027)"},{"line_number":559,"context_line":"    def test_rule_update_rule_nonexistent_policy(self):"},{"line_number":560,"context_line":"        non_exist_id \u003d data_utils.rand_name(\u0027qos_policy\u0027)"},{"line_number":561,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":562,"context_line":"                                        description\u003d\u0027test policy\u0027,"},{"line_number":563,"context_line":"                                        shared\u003dFalse)"},{"line_number":564,"context_line":"        rule \u003d self.create_qos_bandwidth_limit_rule(policy_id\u003dpolicy[\u0027id\u0027],"},{"line_number":565,"context_line":"                                                    max_kbps\u003d1,"},{"line_number":566,"context_line":"                                                    max_burst_kbps\u003d1,"},{"line_number":567,"context_line":"                                                    direction\u003dself.direction)"},{"line_number":568,"context_line":"        self.assertRaises("},{"line_number":569,"context_line":"            exceptions.NotFound,"},{"line_number":570,"context_line":"            self.admin_client.update_bandwidth_limit_rule,"},{"line_number":571,"context_line":"            non_exist_id, rule[\u0027id\u0027], max_kbps\u003d200, max_burst_kbps\u003d1337)"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    @decorators.idempotent_id(\u0027a2c72066-0c32-4f28-be7f-78fa721588b6\u0027)"},{"line_number":574,"context_line":"    def test_rule_update_rule_nonexistent_rule(self):"},{"line_number":575,"context_line":"        non_exist_id \u003d data_utils.rand_name(\u0027qos_rule\u0027)"},{"line_number":576,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":577,"context_line":"                                        description\u003d\u0027test policy\u0027,"},{"line_number":578,"context_line":"                                        shared\u003dFalse)"},{"line_number":579,"context_line":"        self.assertRaises("},{"line_number":580,"context_line":"            exceptions.NotFound,"},{"line_number":581,"context_line":"            self.admin_client.update_bandwidth_limit_rule,"},{"line_number":582,"context_line":"            policy[\u0027id\u0027], non_exist_id, max_kbps\u003d200, max_burst_kbps\u003d1337)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"    @decorators.idempotent_id(\u00271bfc55d9-6fd8-4293-ab3a-b1d69bf7cd2e\u0027)"},{"line_number":585,"context_line":"    def test_rule_update_forbidden_for_regular_tenants_own_policy(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_9d1555e8","line":582,"range":{"start_line":558,"start_character":0,"end_line":582,"end_character":74},"updated":"2020-07-09 12:49:14.000000000","message":"These seems to be negative tests, so better to add them to test_qos_negative","commit_id":"303bfb066ea26cb427a479711f05c0eb77b796fa"},{"author":{"_account_id":31280,"name":"lkk","email":"likangkang01@inspur.com","username":"likangkang"},"change_message_id":"08d59efa7f02d79fbe79e1cbe95ee8668354335d","unresolved":false,"context_lines":[{"line_number":555,"context_line":"            self.client.create_bandwidth_limit_rule,"},{"line_number":556,"context_line":"            \u0027policy\u0027, 1, 2, self.direction)"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"    @decorators.idempotent_id(\u0027e9ce8042-c828-4cb9-b1f1-85bd35e6553a\u0027)"},{"line_number":559,"context_line":"    def test_rule_update_rule_nonexistent_policy(self):"},{"line_number":560,"context_line":"        non_exist_id \u003d data_utils.rand_name(\u0027qos_policy\u0027)"},{"line_number":561,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":562,"context_line":"                                        description\u003d\u0027test policy\u0027,"},{"line_number":563,"context_line":"                                        shared\u003dFalse)"},{"line_number":564,"context_line":"        rule \u003d self.create_qos_bandwidth_limit_rule(policy_id\u003dpolicy[\u0027id\u0027],"},{"line_number":565,"context_line":"                                                    max_kbps\u003d1,"},{"line_number":566,"context_line":"                                                    max_burst_kbps\u003d1,"},{"line_number":567,"context_line":"                                                    direction\u003dself.direction)"},{"line_number":568,"context_line":"        self.assertRaises("},{"line_number":569,"context_line":"            exceptions.NotFound,"},{"line_number":570,"context_line":"            self.admin_client.update_bandwidth_limit_rule,"},{"line_number":571,"context_line":"            non_exist_id, rule[\u0027id\u0027], max_kbps\u003d200, max_burst_kbps\u003d1337)"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    @decorators.idempotent_id(\u0027a2c72066-0c32-4f28-be7f-78fa721588b6\u0027)"},{"line_number":574,"context_line":"    def test_rule_update_rule_nonexistent_rule(self):"},{"line_number":575,"context_line":"        non_exist_id \u003d data_utils.rand_name(\u0027qos_rule\u0027)"},{"line_number":576,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":577,"context_line":"                                        description\u003d\u0027test policy\u0027,"},{"line_number":578,"context_line":"                                        shared\u003dFalse)"},{"line_number":579,"context_line":"        self.assertRaises("},{"line_number":580,"context_line":"            exceptions.NotFound,"},{"line_number":581,"context_line":"            self.admin_client.update_bandwidth_limit_rule,"},{"line_number":582,"context_line":"            policy[\u0027id\u0027], non_exist_id, max_kbps\u003d200, max_burst_kbps\u003d1337)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"    @decorators.idempotent_id(\u00271bfc55d9-6fd8-4293-ab3a-b1d69bf7cd2e\u0027)"},{"line_number":585,"context_line":"    def test_rule_update_forbidden_for_regular_tenants_own_policy(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_5a38d8ec","line":582,"range":{"start_line":558,"start_character":0,"end_line":582,"end_character":74},"in_reply_to":"bf51134e_9d1555e8","updated":"2020-07-13 00:58:22.000000000","message":"ok,I will move it into negative file","commit_id":"303bfb066ea26cb427a479711f05c0eb77b796fa"}],"neutron_tempest_plugin/api/test_qos_negative.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"175fd38fdc25a6b70093279071ae4dd4b2e4ff63","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        rule \u003d self.create_qos_bandwidth_limit_rule(policy_id\u003dpolicy[\u0027id\u0027],"},{"line_number":84,"context_line":"                                                    max_kbps\u003d1,"},{"line_number":85,"context_line":"                                                    max_burst_kbps\u003d1,"},{"line_number":86,"context_line":"                                                    direction\u003dself.direction)"},{"line_number":87,"context_line":"        self.assertRaises("},{"line_number":88,"context_line":"            lib_exc.NotFound,"},{"line_number":89,"context_line":"            self.admin_client.update_bandwidth_limit_rule,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_8d0b55d3","line":86,"range":{"start_line":86,"start_character":52,"end_line":86,"end_character":76},"updated":"2020-07-10 12:00:23.000000000","message":"you don\u0027t need this direction property, create_qos_minimum_bandwidth_rule has a default (egress) for it, see:\nhttps://opendev.org/openstack/neutron-tempest-plugin/src/branch/master/neutron_tempest_plugin/api/base.py#L756","commit_id":"cbd097fb9dddd9224b1345f1f50166f8f805fae6"},{"author":{"_account_id":31280,"name":"lkk","email":"likangkang01@inspur.com","username":"likangkang"},"change_message_id":"08d59efa7f02d79fbe79e1cbe95ee8668354335d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        rule \u003d self.create_qos_bandwidth_limit_rule(policy_id\u003dpolicy[\u0027id\u0027],"},{"line_number":84,"context_line":"                                                    max_kbps\u003d1,"},{"line_number":85,"context_line":"                                                    max_burst_kbps\u003d1,"},{"line_number":86,"context_line":"                                                    direction\u003dself.direction)"},{"line_number":87,"context_line":"        self.assertRaises("},{"line_number":88,"context_line":"            lib_exc.NotFound,"},{"line_number":89,"context_line":"            self.admin_client.update_bandwidth_limit_rule,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_fa171aed","line":86,"range":{"start_line":86,"start_character":52,"end_line":86,"end_character":76},"in_reply_to":"bf51134e_8d0b55d3","updated":"2020-07-13 00:58:22.000000000","message":"ok, thank you","commit_id":"cbd097fb9dddd9224b1345f1f50166f8f805fae6"}]}
