)]}'
{"neutron_tempest_plugin/scenario/test_qos.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"99d8f97a93f575448a5680802168a0d28676ce1f","unresolved":false,"context_lines":[{"line_number":394,"context_line":"                                retrieved_rule_id))"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    @decorators.idempotent_id(\u0027b23cf762-0aba-11eb-b926-74e5f9e2a801\u0027)"},{"line_number":397,"context_line":"    def test_port_priority(self):"},{"line_number":398,"context_line":"        # Setup resources"},{"line_number":399,"context_line":"        self._test_basic_resources()"},{"line_number":400,"context_line":"        ssh_client \u003d self._create_ssh_client()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_43861367","line":397,"updated":"2020-10-11 18:38:28.000000000","message":"how this test is really different than what is in L255-286? IMO the use case which You described is already covered there. Do You think we should have 2 separate tests for that? If so, maybe we should simplify a bit existing test above?","commit_id":"9eb996a0f39ec3855f2a4c9bb711425643f092a4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"a9de833a10f2c88f4f81557128040cf809c9748a","unresolved":false,"context_lines":[{"line_number":394,"context_line":"                                retrieved_rule_id))"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    @decorators.idempotent_id(\u0027b23cf762-0aba-11eb-b926-74e5f9e2a801\u0027)"},{"line_number":397,"context_line":"    def test_port_priority(self):"},{"line_number":398,"context_line":"        # Setup resources"},{"line_number":399,"context_line":"        self._test_basic_resources()"},{"line_number":400,"context_line":"        ssh_client \u003d self._create_ssh_client()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_e3e3e704","line":397,"in_reply_to":"9f560f44_43861367","updated":"2020-10-11 20:52:27.000000000","message":"This test is about \"port priority\" check, see:\nhttps://docs.openstack.org/mitaka/networking-guide/config-qos.html search for: \n\"The meaning of this is that any compute port connected to the network will use the network policy by default unless the port has a specific policy attached to it. Network owned ports like DHCP and router ports are excluded from network policy application.\"\nThe \"test_qos_basic_and_update\" is already covers several scenarios: basic and update for both options: network and port, but \"port priority\" is not covered in it.\n\nI think that having \"port priority\" test a separate test would be better than adding into the existing, because it\u0027s already \"too long\" and in case of failure it will require some time to find out what exactly went wrong: basic network? basic port? update network, update port, port priority?","commit_id":"9eb996a0f39ec3855f2a4c9bb711425643f092a4"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"b44af20b810a0711da137c02b52198535418ddb6","unresolved":false,"context_lines":[{"line_number":394,"context_line":"                                retrieved_rule_id))"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    @decorators.idempotent_id(\u0027b23cf762-0aba-11eb-b926-74e5f9e2a801\u0027)"},{"line_number":397,"context_line":"    def test_port_priority(self):"},{"line_number":398,"context_line":"        # Setup resources"},{"line_number":399,"context_line":"        self._test_basic_resources()"},{"line_number":400,"context_line":"        ssh_client \u003d self._create_ssh_client()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_f288ce22","line":397,"in_reply_to":"9f560f44_e3e3e704","updated":"2020-10-12 04:08:09.000000000","message":"Please ignore my previous comment, you are right \"port priority\" is covered in \"test_qos_basic_and_update\".\nI\u0027ll modify the existing test code a bit in my next patch.\nSo in case of failure it will be clear what exactly went wrong: basic, update, port priority.","commit_id":"9eb996a0f39ec3855f2a4c9bb711425643f092a4"}]}