)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"52e97c139cdd523e4e1be2003f341868324a2ec0","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-11-23 08:24:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enforce security group cleanup if created in the test case"},{"line_number":8,"context_line":"Fixed Issue with Security Group Rules"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Closes-Bug: #1904694"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"d9ae05f7_eca92f0e","line":8,"updated":"2020-11-24 09:41:02.000000000","message":"please add empty line between commit title (first line) and description","commit_id":"c81ef6350a68234fdd213365304a564a3d8fcaa4"},{"author":{"_account_id":19519,"name":"Abhishek Jaiswal","display_name":"jkabhishek (ajaiswal)","email":"abhishek.jaiswal@windriver.com","username":"aj355y","status":"Wind River System"},"change_message_id":"64d56a4e5954ec307c99ebff21a72af0f1077419","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-11-23 08:24:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enforce security group cleanup if created in the test case"},{"line_number":8,"context_line":"Fixed Issue with Security Group Rules"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Closes-Bug: #1904694"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"e6f5f40c_61936a88","line":8,"in_reply_to":"d9ae05f7_eca92f0e","updated":"2020-11-25 09:34:54.000000000","message":"Done","commit_id":"c81ef6350a68234fdd213365304a564a3d8fcaa4"}],"neutron_tempest_plugin/api/test_security_groups.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"52e97c139cdd523e4e1be2003f341868324a2ec0","unresolved":true,"context_lines":[{"line_number":233,"context_line":"                \u0027protocol\u0027: \u0027tcp\u0027})"},{"line_number":234,"context_line":"            self.addCleanup("},{"line_number":235,"context_line":"                self.client.delete_security_group_rule, sg_rule[\u0027id\u0027]"},{"line_number":236,"context_line":"            )"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def _increase_sg_rules_quota(self):"},{"line_number":239,"context_line":"        sg_rules_quota \u003d self._get_sg_rules_quota()"}],"source_content_type":"text/x-python","patch_set":5,"id":"c420399c_72f5b376","line":236,"updated":"2020-11-24 09:41:02.000000000","message":"can You explain a bit more why it\u0027s needed? AFAIK security groups are cleaned automatically as they are added to list of resources to cleanup in https://github.com/openstack/neutron-tempest-plugin/blob/master/neutron_tempest_plugin/api/base.py#L846 so every time when there will be cleanup after test done it should clean resources and clean this SG. When SG is removed, rules from it should also be removed, no?","commit_id":"c81ef6350a68234fdd213365304a564a3d8fcaa4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bd4ac58dbf82e005a365b34ce9f1585ed8e0789d","unresolved":true,"context_lines":[{"line_number":233,"context_line":"                \u0027protocol\u0027: \u0027tcp\u0027})"},{"line_number":234,"context_line":"            self.addCleanup("},{"line_number":235,"context_line":"                self.client.delete_security_group_rule, sg_rule[\u0027id\u0027]"},{"line_number":236,"context_line":"            )"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def _increase_sg_rules_quota(self):"},{"line_number":239,"context_line":"        sg_rules_quota \u003d self._get_sg_rules_quota()"}],"source_content_type":"text/x-python","patch_set":5,"id":"35479313_3ac8064e","line":236,"in_reply_to":"0683cb4c_8952e3ee","updated":"2020-11-27 08:19:24.000000000","message":"Are You sure that security group is removed in such case? I just tested it locally, when I deleted SG, all rules which belongs to it were also removed. And that should be guarantee by the DB engine, see db model https://github.com/openstack/neutron/blob/master/neutron/db/models/securitygroup.py#L83\nSo if that is not the case and You really have not removed SG rule when SG is removed, then IMHO there is serious bug in MySQL (or other db engine which You are using).\nGiving that I\u0027m not sure if we really need this patch. It seems for me that the root cause of the reported issue may be somewhere else really.","commit_id":"c81ef6350a68234fdd213365304a564a3d8fcaa4"},{"author":{"_account_id":19519,"name":"Abhishek Jaiswal","display_name":"jkabhishek (ajaiswal)","email":"abhishek.jaiswal@windriver.com","username":"aj355y","status":"Wind River System"},"change_message_id":"64d56a4e5954ec307c99ebff21a72af0f1077419","unresolved":true,"context_lines":[{"line_number":233,"context_line":"                \u0027protocol\u0027: \u0027tcp\u0027})"},{"line_number":234,"context_line":"            self.addCleanup("},{"line_number":235,"context_line":"                self.client.delete_security_group_rule, sg_rule[\u0027id\u0027]"},{"line_number":236,"context_line":"            )"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def _increase_sg_rules_quota(self):"},{"line_number":239,"context_line":"        sg_rules_quota \u003d self._get_sg_rules_quota()"}],"source_content_type":"text/x-python","patch_set":5,"id":"0683cb4c_8952e3ee","line":236,"in_reply_to":"c420399c_72f5b376","updated":"2020-11-25 09:34:54.000000000","message":"Yes the Security group is deleted , but not the rule , Update the bug with stack trace","commit_id":"c81ef6350a68234fdd213365304a564a3d8fcaa4"}]}