)]}'
{"neutron_tempest_plugin/api/test_security_groups.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"54815b3bb95f8bdd44763444b576b5273c78b075","unresolved":true,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @decorators.idempotent_id(\u0027e93f33d8-57ea-11eb-b69b-74e5f9e2a801\u0027)"},{"line_number":131,"context_line":"    def test_create_sec_groups_with_the_same_name(self):"},{"line_number":132,"context_line":"        same_name_sg_number \u003d 5"},{"line_number":133,"context_line":"        sg_name \u003d \u0027sg_zahlabut\u0027"},{"line_number":134,"context_line":"        sg_names \u003d [sg_name] * same_name_sg_number"},{"line_number":135,"context_line":"        for name in sg_names:"},{"line_number":136,"context_line":"            self.create_security_group(name\u003dname)"},{"line_number":137,"context_line":"        sec_groups \u003d [item[\u0027id\u0027] for item in"}],"source_content_type":"text/x-python","patch_set":4,"id":"c3530e57_aa93e680","line":134,"range":{"start_line":132,"start_character":8,"end_line":134,"end_character":50},"updated":"2021-01-19 10:22:27.000000000","message":"(irrelevant comment): I never used this \"list\" operator.","commit_id":"8ebc061c05d8502fdb5410f34020438492b9e364"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"3b5be053b4b2ec455cc48d36ba4d323730c622ee","unresolved":true,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @decorators.idempotent_id(\u0027e93f33d8-57ea-11eb-b69b-74e5f9e2a801\u0027)"},{"line_number":131,"context_line":"    def test_create_sec_groups_with_the_same_name(self):"},{"line_number":132,"context_line":"        same_name_sg_number \u003d 5"},{"line_number":133,"context_line":"        sg_name \u003d \u0027sg_zahlabut\u0027"},{"line_number":134,"context_line":"        sg_names \u003d [sg_name] * same_name_sg_number"},{"line_number":135,"context_line":"        for name in sg_names:"},{"line_number":136,"context_line":"            self.create_security_group(name\u003dname)"},{"line_number":137,"context_line":"        sec_groups \u003d [item[\u0027id\u0027] for item in"}],"source_content_type":"text/x-python","patch_set":4,"id":"e73ef127_47d7dd67","line":134,"range":{"start_line":132,"start_character":8,"end_line":134,"end_character":50},"in_reply_to":"c3530e57_aa93e680","updated":"2021-01-19 10:31:18.000000000","message":"Yep, I\u0027m also seeing this \"list operator\" for a first time :-))\nThanks!","commit_id":"8ebc061c05d8502fdb5410f34020438492b9e364"}],"neutron_tempest_plugin/api/test_security_groups_negative.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"691b3fff58edc103107a61754e334804f878993d","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            \u0027Failed - expected number of groups with the same name\u0027"},{"line_number":139,"context_line":"            \u0027 is: {}\u0027.format(same_name_sg_number))"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"class NegativeSecGroupIPv6Test(NegativeSecGroupTest):"},{"line_number":142,"context_line":"    _ip_version \u003d constants.IP_VERSION_6"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_1b429aab","line":141,"updated":"2020-11-16 16:04:27.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"de73383f3559ef6b239868ac99aa86c98be16eb6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7e04939bd7377ec46c6f45c2bae649e1254d1b05","unresolved":true,"context_lines":[{"line_number":134,"context_line":"                      self.client.list_security_groups("},{"line_number":135,"context_line":"                          name\u003dsg_name)[\u0027security_groups\u0027]]"},{"line_number":136,"context_line":"        self.assertEqual("},{"line_number":137,"context_line":"            len(set(sec_groups)), same_name_sg_number,"},{"line_number":138,"context_line":"            \u0027Failed - expected number of groups with the same name\u0027"},{"line_number":139,"context_line":"            \u0027 is: {}\u0027.format(same_name_sg_number))"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c27c0760_c03b3109","line":137,"updated":"2020-12-21 10:19:31.000000000","message":"we should use pattern like:\n\n    self.assertEqual(expected, actual)\n\nalways.","commit_id":"925e930c311a6a78489013f9d527c53c8f5847d6"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"90c4e0e515f3c38fcb96ac5a5d09ce9faa229952","unresolved":true,"context_lines":[{"line_number":134,"context_line":"                      self.client.list_security_groups("},{"line_number":135,"context_line":"                          name\u003dsg_name)[\u0027security_groups\u0027]]"},{"line_number":136,"context_line":"        self.assertEqual("},{"line_number":137,"context_line":"            len(set(sec_groups)), same_name_sg_number,"},{"line_number":138,"context_line":"            \u0027Failed - expected number of groups with the same name\u0027"},{"line_number":139,"context_line":"            \u0027 is: {}\u0027.format(same_name_sg_number))"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"d815999e_78eff703","line":137,"in_reply_to":"c27c0760_c03b3109","updated":"2020-12-21 11:24:32.000000000","message":"Will be fixed.","commit_id":"925e930c311a6a78489013f9d527c53c8f5847d6"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1ef12e96f4674b46c80d8e71687c0e99ea0cf92f","unresolved":true,"context_lines":[{"line_number":134,"context_line":"                      self.client.list_security_groups("},{"line_number":135,"context_line":"                          name\u003dsg_name)[\u0027security_groups\u0027]]"},{"line_number":136,"context_line":"        self.assertEqual("},{"line_number":137,"context_line":"            len(set(sec_groups)), same_name_sg_number,"},{"line_number":138,"context_line":"            \u0027Failed - expected number of groups with the same name\u0027"},{"line_number":139,"context_line":"            \u0027 is: {}\u0027.format(same_name_sg_number))"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8e94697f_ca0ce6dc","line":137,"in_reply_to":"d815999e_78eff703","updated":"2021-01-12 14:28:16.000000000","message":"fixed","commit_id":"925e930c311a6a78489013f9d527c53c8f5847d6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7e04939bd7377ec46c6f45c2bae649e1254d1b05","unresolved":true,"context_lines":[{"line_number":136,"context_line":"        self.assertEqual("},{"line_number":137,"context_line":"            len(set(sec_groups)), same_name_sg_number,"},{"line_number":138,"context_line":"            \u0027Failed - expected number of groups with the same name\u0027"},{"line_number":139,"context_line":"            \u0027 is: {}\u0027.format(same_name_sg_number))"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"class NegativeSecGroupIPv6Test(NegativeSecGroupTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ee01c60b_e829841b","line":139,"updated":"2020-12-21 10:19:31.000000000","message":"IIUC correctly the test, all 5 SG should be created fine. If so, why this test is in the \"negative\" tests?","commit_id":"925e930c311a6a78489013f9d527c53c8f5847d6"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"1ef12e96f4674b46c80d8e71687c0e99ea0cf92f","unresolved":true,"context_lines":[{"line_number":136,"context_line":"        self.assertEqual("},{"line_number":137,"context_line":"            len(set(sec_groups)), same_name_sg_number,"},{"line_number":138,"context_line":"            \u0027Failed - expected number of groups with the same name\u0027"},{"line_number":139,"context_line":"            \u0027 is: {}\u0027.format(same_name_sg_number))"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"class NegativeSecGroupIPv6Test(NegativeSecGroupTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"a36b1685_ec6ae9da","line":139,"in_reply_to":"2544bc3d_39ed7c10","updated":"2021-01-12 14:28:16.000000000","message":"fixed","commit_id":"925e930c311a6a78489013f9d527c53c8f5847d6"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"04a789d53a2bdaa1831ed1ba6389276aa0478658","unresolved":true,"context_lines":[{"line_number":136,"context_line":"        self.assertEqual("},{"line_number":137,"context_line":"            len(set(sec_groups)), same_name_sg_number,"},{"line_number":138,"context_line":"            \u0027Failed - expected number of groups with the same name\u0027"},{"line_number":139,"context_line":"            \u0027 is: {}\u0027.format(same_name_sg_number))"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"class NegativeSecGroupIPv6Test(NegativeSecGroupTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"2544bc3d_39ed7c10","line":139,"in_reply_to":"837fc5cd_15cdd5e9","updated":"2021-01-12 12:12:38.000000000","message":"I believe a negative test is when a failure is expected and we want to verify the failure happens.  So I think this is a positive test, since no failure is expected.","commit_id":"925e930c311a6a78489013f9d527c53c8f5847d6"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"90c4e0e515f3c38fcb96ac5a5d09ce9faa229952","unresolved":true,"context_lines":[{"line_number":136,"context_line":"        self.assertEqual("},{"line_number":137,"context_line":"            len(set(sec_groups)), same_name_sg_number,"},{"line_number":138,"context_line":"            \u0027Failed - expected number of groups with the same name\u0027"},{"line_number":139,"context_line":"            \u0027 is: {}\u0027.format(same_name_sg_number))"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"class NegativeSecGroupIPv6Test(NegativeSecGroupTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"837fc5cd_15cdd5e9","line":139,"in_reply_to":"ee01c60b_e829841b","updated":"2020-12-21 11:24:32.000000000","message":"Because the best effort would be to avoid creating objects with the same name, from administrative point of view.\nOpenstack is \"smart enough\" to support such kind of things, but it\u0027s not really appreciated I guess.","commit_id":"925e930c311a6a78489013f9d527c53c8f5847d6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9ee7601ebda904069e16d50bfffb56001c030f9a","unresolved":true,"context_lines":[{"line_number":123,"context_line":"        self.assertEqual(sg_list_before_failure, sg_list_after_failure)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @decorators.idempotent_id(\u00279c99cc42-2805-11eb-b175-74e5f9e2a801\u0027)"},{"line_number":126,"context_line":"    def test_create_sec_groups_with_the_same_name(self):"},{"line_number":127,"context_line":"        same_name_sg_number \u003d 5"},{"line_number":128,"context_line":"        sg_name \u003d \u0027sg_zahlabut\u0027"},{"line_number":129,"context_line":"        sg_names \u003d [sg_name] * same_name_sg_number"}],"source_content_type":"text/x-python","patch_set":3,"id":"24ed3bd4_7a94b515","line":126,"updated":"2021-01-13 22:10:40.000000000","message":"So I\u0027m guessing based on Nate\u0027s last comment that since this isn\u0027t a negative test is should be in test_security_groups.py and not this file.","commit_id":"1a1a8cf477f52f7685cce08e030a2f9a90e2a17a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"af8512b625c0551d6e4bcc5fa63dfd2f117d9017","unresolved":true,"context_lines":[{"line_number":123,"context_line":"        self.assertEqual(sg_list_before_failure, sg_list_after_failure)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @decorators.idempotent_id(\u00279c99cc42-2805-11eb-b175-74e5f9e2a801\u0027)"},{"line_number":126,"context_line":"    def test_create_sec_groups_with_the_same_name(self):"},{"line_number":127,"context_line":"        same_name_sg_number \u003d 5"},{"line_number":128,"context_line":"        sg_name \u003d \u0027sg_zahlabut\u0027"},{"line_number":129,"context_line":"        sg_names \u003d [sg_name] * same_name_sg_number"}],"source_content_type":"text/x-python","patch_set":3,"id":"65c5b88d_0a857f50","line":126,"in_reply_to":"24ed3bd4_7a94b515","updated":"2021-01-14 10:10:00.000000000","message":"+1","commit_id":"1a1a8cf477f52f7685cce08e030a2f9a90e2a17a"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"4a9b76f3ea7e6ee68680f2445ad1550d85278cf2","unresolved":true,"context_lines":[{"line_number":123,"context_line":"        self.assertEqual(sg_list_before_failure, sg_list_after_failure)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @decorators.idempotent_id(\u00279c99cc42-2805-11eb-b175-74e5f9e2a801\u0027)"},{"line_number":126,"context_line":"    def test_create_sec_groups_with_the_same_name(self):"},{"line_number":127,"context_line":"        same_name_sg_number \u003d 5"},{"line_number":128,"context_line":"        sg_name \u003d \u0027sg_zahlabut\u0027"},{"line_number":129,"context_line":"        sg_names \u003d [sg_name] * same_name_sg_number"}],"source_content_type":"text/x-python","patch_set":3,"id":"01005c77_b78f8848","line":126,"in_reply_to":"65c5b88d_0a857f50","updated":"2021-01-14 10:14:08.000000000","message":"Thank you guys!\nI though that this discussion was all about the \"negative\" decorator I\u0027ve used (already removed), now I understand that the test should land in test_security_groups.py.\nWill be fixed!","commit_id":"1a1a8cf477f52f7685cce08e030a2f9a90e2a17a"}]}