)]}'
{"neutron_tempest_plugin/common/ip.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"52850d486f8541b3a215acae02b38427641fd4db","unresolved":true,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        return self.configure_vlan(addresses, port, vlan_tag, subport_ips)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def configure_vlan_trasparent(self, port, vlan_tag, ip_addresses):"},{"line_number":97,"context_line":"        addresses \u003d self.list_addresses()"},{"line_number":98,"context_line":"        try:"},{"line_number":99,"context_line":"            subport_device \u003d get_vlan_device_name(addresses, ip_addresses)"}],"source_content_type":"text/x-python","patch_set":16,"id":"cce03351_68fdcb9d","line":96,"range":{"start_line":96,"start_character":23,"end_line":96,"end_character":33},"updated":"2021-01-14 09:56:28.000000000","message":"transparent","commit_id":"f70cf419f7ed2d1a5197ba20a7398ea058cb531c"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"a01df1143982f7445628e4c1a9dcc9f6dc277b20","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        return self.configure_vlan(addresses, port, vlan_tag, subport_ips)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def configure_vlan_trasparent(self, port, vlan_tag, ip_addresses):"},{"line_number":97,"context_line":"        addresses \u003d self.list_addresses()"},{"line_number":98,"context_line":"        try:"},{"line_number":99,"context_line":"            subport_device \u003d get_vlan_device_name(addresses, ip_addresses)"}],"source_content_type":"text/x-python","patch_set":16,"id":"554adabd_989dd05c","line":96,"range":{"start_line":96,"start_character":23,"end_line":96,"end_character":33},"in_reply_to":"cce03351_68fdcb9d","updated":"2021-01-15 07:38:10.000000000","message":"Done","commit_id":"f70cf419f7ed2d1a5197ba20a7398ea058cb531c"}],"neutron_tempest_plugin/scenario/test_vlan_transparency.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bfcc0852e20ca1155cab4bda683fc8d4b13baec1","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                \u0027Advanced image is required to run these tests.\u0027)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _create_port_and_server(self, index,"},{"line_number":67,"context_line":"                       port_security\u003dTrue, allowed_address_pairs\u003dNone):"},{"line_number":68,"context_line":"        flavor_ref \u003d CONF.neutron_plugin_options.advanced_image_flavor_ref"},{"line_number":69,"context_line":"        image_ref \u003d CONF.neutron_plugin_options.advanced_image_ref"},{"line_number":70,"context_line":"        server_name \u003d \u0027server-%s-%d\u0027 % (self.rand_name, index)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0283a8ac_e22d2c95","line":67,"updated":"2020-12-04 08:46:58.000000000","message":"nitty nit: please align that with line above","commit_id":"be77c53b194dc7b2cc7ec85402d00eb68efd8587"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"774e6084b8ca607dae95eab4657e7d3c45ca5a8e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                \u0027Advanced image is required to run these tests.\u0027)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _create_port_and_server(self, index,"},{"line_number":67,"context_line":"                       port_security\u003dTrue, allowed_address_pairs\u003dNone):"},{"line_number":68,"context_line":"        flavor_ref \u003d CONF.neutron_plugin_options.advanced_image_flavor_ref"},{"line_number":69,"context_line":"        image_ref \u003d CONF.neutron_plugin_options.advanced_image_ref"},{"line_number":70,"context_line":"        server_name \u003d \u0027server-%s-%d\u0027 % (self.rand_name, index)"}],"source_content_type":"text/x-python","patch_set":3,"id":"e137d40e_5bb12e70","line":67,"in_reply_to":"0283a8ac_e22d2c95","updated":"2020-12-04 09:16:18.000000000","message":"done","commit_id":"be77c53b194dc7b2cc7ec85402d00eb68efd8587"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bfcc0852e20ca1155cab4bda683fc8d4b13baec1","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            self.fail(\"Sub-port fixed IP not found on server.\")"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def _create_ssh_client(self, floating_ip):"},{"line_number":106,"context_line":"        username \u003d CONF.neutron_plugin_options.advanced_image_ssh_user"},{"line_number":107,"context_line":"        return ssh.Client(host\u003dfloating_ip[\u0027floating_ip_address\u0027],"},{"line_number":108,"context_line":"                          username\u003dusername,"},{"line_number":109,"context_line":"                          pkey\u003dself.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"8c26bc31_1a4f1c69","line":106,"updated":"2020-12-04 08:46:58.000000000","message":"is that correct? What if \"default_image_is_advanced\" is True? Then You should use regular user name, right?","commit_id":"be77c53b194dc7b2cc7ec85402d00eb68efd8587"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"774e6084b8ca607dae95eab4657e7d3c45ca5a8e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            self.fail(\"Sub-port fixed IP not found on server.\")"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def _create_ssh_client(self, floating_ip):"},{"line_number":106,"context_line":"        username \u003d CONF.neutron_plugin_options.advanced_image_ssh_user"},{"line_number":107,"context_line":"        return ssh.Client(host\u003dfloating_ip[\u0027floating_ip_address\u0027],"},{"line_number":108,"context_line":"                          username\u003dusername,"},{"line_number":109,"context_line":"                          pkey\u003dself.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ca226eaf_df939b1c","line":106,"in_reply_to":"8c26bc31_1a4f1c69","updated":"2020-12-04 09:16:18.000000000","message":"You are right! Thanks!","commit_id":"be77c53b194dc7b2cc7ec85402d00eb68efd8587"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bfcc0852e20ca1155cab4bda683fc8d4b13baec1","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _test_basic_vlan_transparency_connectivty("},{"line_number":112,"context_line":"            self, port_security\u003dTrue, use_allowed_address_pairs\u003dFalse):"},{"line_number":113,"context_line":"        vlan_tag \u003d data_utils.rand_int_id(start\u003d0, end\u003dMAX_VLAN_ID)"},{"line_number":114,"context_line":"        vlan_ipmask_template \u003d \u0027192.168.%d.{ip_last_byte}/24\u0027 % (vlan_tag %"},{"line_number":115,"context_line":"                                                                 256)"},{"line_number":116,"context_line":"        vms \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a9979d0_c77124a6","line":113,"updated":"2020-12-04 08:46:58.000000000","message":"is vlan\u003d0 ok to be used in test? And also second question: why we need to use random vlan? can\u0027t it be always the same one?","commit_id":"be77c53b194dc7b2cc7ec85402d00eb68efd8587"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"774e6084b8ca607dae95eab4657e7d3c45ca5a8e","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _test_basic_vlan_transparency_connectivty("},{"line_number":112,"context_line":"            self, port_security\u003dTrue, use_allowed_address_pairs\u003dFalse):"},{"line_number":113,"context_line":"        vlan_tag \u003d data_utils.rand_int_id(start\u003d0, end\u003dMAX_VLAN_ID)"},{"line_number":114,"context_line":"        vlan_ipmask_template \u003d \u0027192.168.%d.{ip_last_byte}/24\u0027 % (vlan_tag %"},{"line_number":115,"context_line":"                                                                 256)"},{"line_number":116,"context_line":"        vms \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"c518b1b2_f96ce0e0","line":113,"in_reply_to":"9a9979d0_c77124a6","updated":"2020-12-04 09:16:18.000000000","message":"\u003e is vlan\u003d0 ok to be used in test?\nno, it\u0027s not ok. I should change it. Thanks!\n\n\u003e And also second question: why we need to use random vlan? can\u0027t it be always the same one?\nI just like it, but it can be always the same one.","commit_id":"be77c53b194dc7b2cc7ec85402d00eb68efd8587"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"52850d486f8541b3a215acae02b38427641fd4db","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def setUp(self):"},{"line_number":55,"context_line":"        super(VlanTransparencyTest, self).setUp()"},{"line_number":56,"context_line":"        self.security_group \u003d self.create_security_group(name\u003dself.rand_name)"},{"line_number":57,"context_line":"        self.create_loginable_secgroup_rule(self.security_group[\u0027id\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @classmethod"},{"line_number":60,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":16,"id":"92789892_ea5fd6d3","line":57,"range":{"start_line":56,"start_character":8,"end_line":57,"end_character":70},"updated":"2021-01-14 09:56:28.000000000","message":"why this is in setUp and not in resource_setup method, as creation of all other resources?","commit_id":"f70cf419f7ed2d1a5197ba20a7398ea058cb531c"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"a01df1143982f7445628e4c1a9dcc9f6dc277b20","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def setUp(self):"},{"line_number":55,"context_line":"        super(VlanTransparencyTest, self).setUp()"},{"line_number":56,"context_line":"        self.security_group \u003d self.create_security_group(name\u003dself.rand_name)"},{"line_number":57,"context_line":"        self.create_loginable_secgroup_rule(self.security_group[\u0027id\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @classmethod"},{"line_number":60,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":16,"id":"c0cacfa1_e3d2576d","line":57,"range":{"start_line":56,"start_character":8,"end_line":57,"end_character":70},"in_reply_to":"92789892_ea5fd6d3","updated":"2021-01-15 07:38:10.000000000","message":"Done","commit_id":"f70cf419f7ed2d1a5197ba20a7398ea058cb531c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b967f9dc33dc223b1a20b7b751e35bdf65ee4799","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    def _create_port_and_server(self, index,"},{"line_number":65,"context_line":"                                port_security\u003dTrue,"},{"line_number":66,"context_line":"                                allowed_address_pairs\u003dNone):"},{"line_number":67,"context_line":"        if CONF.neutron_plugin_options.default_image_is_advanced:"},{"line_number":68,"context_line":"            flavor_ref \u003d CONF.compute.flavor_ref"},{"line_number":69,"context_line":"            image_ref \u003d CONF.compute.image_ref"},{"line_number":70,"context_line":"        else:"},{"line_number":71,"context_line":"            flavor_ref \u003d CONF.neutron_plugin_options.advanced_image_flavor_ref"},{"line_number":72,"context_line":"            image_ref \u003d CONF.neutron_plugin_options.advanced_image_ref"},{"line_number":73,"context_line":"        server_name \u003d \u0027server-%s-%d\u0027 % (self.rand_name, index)"},{"line_number":74,"context_line":"        port_name \u003d \u0027port-%s-%d\u0027 % (self.rand_name, index)"},{"line_number":75,"context_line":"        if port_security:"}],"source_content_type":"text/x-python","patch_set":18,"id":"29db0ea8_8899075e","line":72,"range":{"start_line":67,"start_character":7,"end_line":72,"end_character":70},"updated":"2021-01-19 09:01:28.000000000","message":"nit: this could be defined in \"resource_setup\"","commit_id":"8800d5a98545b7404534c50723698e93ba451efb"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"486296d803e08426ae61b7a9ec113a50770b2ce8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def _create_port_and_server(self, index,"},{"line_number":65,"context_line":"                                port_security\u003dTrue,"},{"line_number":66,"context_line":"                                allowed_address_pairs\u003dNone):"},{"line_number":67,"context_line":"        if CONF.neutron_plugin_options.default_image_is_advanced:"},{"line_number":68,"context_line":"            flavor_ref \u003d CONF.compute.flavor_ref"},{"line_number":69,"context_line":"            image_ref \u003d CONF.compute.image_ref"},{"line_number":70,"context_line":"        else:"},{"line_number":71,"context_line":"            flavor_ref \u003d CONF.neutron_plugin_options.advanced_image_flavor_ref"},{"line_number":72,"context_line":"            image_ref \u003d CONF.neutron_plugin_options.advanced_image_ref"},{"line_number":73,"context_line":"        server_name \u003d \u0027server-%s-%d\u0027 % (self.rand_name, index)"},{"line_number":74,"context_line":"        port_name \u003d \u0027port-%s-%d\u0027 % (self.rand_name, index)"},{"line_number":75,"context_line":"        if port_security:"}],"source_content_type":"text/x-python","patch_set":18,"id":"9c529515_08b0d200","line":72,"range":{"start_line":67,"start_character":7,"end_line":72,"end_character":70},"in_reply_to":"29db0ea8_8899075e","updated":"2021-01-19 11:42:15.000000000","message":"Done","commit_id":"8800d5a98545b7404534c50723698e93ba451efb"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b967f9dc33dc223b1a20b7b751e35bdf65ee4799","unresolved":true,"context_lines":[{"line_number":90,"context_line":"    def _configure_vlan_transparent(self, port, ssh_client,"},{"line_number":91,"context_line":"                                    vlan_tag, vlan_ip):"},{"line_number":92,"context_line":"        ip_command \u003d ip.IPCommand(ssh_client\u003dssh_client)"},{"line_number":93,"context_line":"        for address in ip_command.list_addresses(port\u003dport):"},{"line_number":94,"context_line":"            port_iface \u003d address.device.name"},{"line_number":95,"context_line":"            break"},{"line_number":96,"context_line":"        else:"},{"line_number":97,"context_line":"            self.fail(\"Parent port fixed IP not found on server.\")"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        subport_iface \u003d ip_command.configure_vlan_transparent("},{"line_number":100,"context_line":"            port\u003dport, vlan_tag\u003dvlan_tag, ip_addresses\u003d[vlan_ip])"},{"line_number":101,"context_line":"        for address in ip_command.list_addresses(ip_addresses\u003dvlan_ip):"}],"source_content_type":"text/x-python","patch_set":18,"id":"ce93e5f8_324ece6e","line":98,"range":{"start_line":93,"start_character":8,"end_line":98,"end_character":0},"updated":"2021-01-19 09:01:28.000000000","message":"You can reuse \"get_vlan_device_name\". I recommend to use another method name.","commit_id":"8800d5a98545b7404534c50723698e93ba451efb"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"486296d803e08426ae61b7a9ec113a50770b2ce8","unresolved":true,"context_lines":[{"line_number":90,"context_line":"    def _configure_vlan_transparent(self, port, ssh_client,"},{"line_number":91,"context_line":"                                    vlan_tag, vlan_ip):"},{"line_number":92,"context_line":"        ip_command \u003d ip.IPCommand(ssh_client\u003dssh_client)"},{"line_number":93,"context_line":"        for address in ip_command.list_addresses(port\u003dport):"},{"line_number":94,"context_line":"            port_iface \u003d address.device.name"},{"line_number":95,"context_line":"            break"},{"line_number":96,"context_line":"        else:"},{"line_number":97,"context_line":"            self.fail(\"Parent port fixed IP not found on server.\")"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        subport_iface \u003d ip_command.configure_vlan_transparent("},{"line_number":100,"context_line":"            port\u003dport, vlan_tag\u003dvlan_tag, ip_addresses\u003d[vlan_ip])"},{"line_number":101,"context_line":"        for address in ip_command.list_addresses(ip_addresses\u003dvlan_ip):"}],"source_content_type":"text/x-python","patch_set":18,"id":"e82fa6b5_af91ec14","line":98,"range":{"start_line":93,"start_character":8,"end_line":98,"end_character":0},"in_reply_to":"ce93e5f8_324ece6e","updated":"2021-01-19 11:42:15.000000000","message":"I was not sure about this comment, but I think the code looks better with the change in patch set #19.\nAt this point, there is no vlan yet and what is needed is the port interface (eth0, ens3 or similar)","commit_id":"8800d5a98545b7404534c50723698e93ba451efb"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b967f9dc33dc223b1a20b7b751e35bdf65ee4799","unresolved":true,"context_lines":[{"line_number":114,"context_line":"                          username\u003dusername,"},{"line_number":115,"context_line":"                          pkey\u003dself.keypair[\u0027private_key\u0027])"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def _test_basic_vlan_transparency_connectivty("},{"line_number":118,"context_line":"            self, port_security\u003dTrue, use_allowed_address_pairs\u003dFalse):"},{"line_number":119,"context_line":"        vlan_tag \u003d data_utils.rand_int_id(start\u003dMIN_VLAN_ID, end\u003dMAX_VLAN_ID)"},{"line_number":120,"context_line":"        vlan_ipmask_template \u003d \u0027192.168.%d.{ip_last_byte}/24\u0027 % (vlan_tag %"}],"source_content_type":"text/x-python","patch_set":18,"id":"0d1175fc_99f95988","line":117,"range":{"start_line":117,"start_character":38,"end_line":117,"end_character":49},"updated":"2021-01-19 09:01:28.000000000","message":"connectivity","commit_id":"8800d5a98545b7404534c50723698e93ba451efb"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"486296d803e08426ae61b7a9ec113a50770b2ce8","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                          username\u003dusername,"},{"line_number":115,"context_line":"                          pkey\u003dself.keypair[\u0027private_key\u0027])"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def _test_basic_vlan_transparency_connectivty("},{"line_number":118,"context_line":"            self, port_security\u003dTrue, use_allowed_address_pairs\u003dFalse):"},{"line_number":119,"context_line":"        vlan_tag \u003d data_utils.rand_int_id(start\u003dMIN_VLAN_ID, end\u003dMAX_VLAN_ID)"},{"line_number":120,"context_line":"        vlan_ipmask_template \u003d \u0027192.168.%d.{ip_last_byte}/24\u0027 % (vlan_tag %"}],"source_content_type":"text/x-python","patch_set":18,"id":"caff8041_6ffa5837","line":117,"range":{"start_line":117,"start_character":38,"end_line":117,"end_character":49},"in_reply_to":"0d1175fc_99f95988","updated":"2021-01-19 11:42:15.000000000","message":"Done","commit_id":"8800d5a98545b7404534c50723698e93ba451efb"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b967f9dc33dc223b1a20b7b751e35bdf65ee4799","unresolved":true,"context_lines":[{"line_number":115,"context_line":"                          pkey\u003dself.keypair[\u0027private_key\u0027])"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def _test_basic_vlan_transparency_connectivty("},{"line_number":118,"context_line":"            self, port_security\u003dTrue, use_allowed_address_pairs\u003dFalse):"},{"line_number":119,"context_line":"        vlan_tag \u003d data_utils.rand_int_id(start\u003dMIN_VLAN_ID, end\u003dMAX_VLAN_ID)"},{"line_number":120,"context_line":"        vlan_ipmask_template \u003d \u0027192.168.%d.{ip_last_byte}/24\u0027 % (vlan_tag %"},{"line_number":121,"context_line":"                                                                 256)"}],"source_content_type":"text/x-python","patch_set":18,"id":"5dad9ea3_b3846954","line":118,"range":{"start_line":118,"start_character":18,"end_line":118,"end_character":69},"updated":"2021-01-19 09:01:28.000000000","message":"In sake of clarity, I would make those parameters positional. And the methods calling this function should pass them both. That will explicitly show the value of them.\n\n@decorators.idempotent_id(\u0027a2694e3a-6d4d-4a23-9fcc-c3ed3ef37b16\u0027)\n    def test_vlan_transparent_port_sec_disabled(self):\n        self._test_basic_vlan_transparency_connectivty(\n            port_security\u003dFalse,\n            use_allowed_address_pairs\u003dFalse)\n\n    @decorators.idempotent_id(\u00272dd03b4f-9c20-4cda-8c6a-40fa453ec69a\u0027)\n    def test_vlan_transparent_allowed_address_pairs(self):\n        self._test_basic_vlan_transparency_connectivty(\n            port_security\u003dTrue,\n            use_allowed_address_pairs\u003dTrue)\n\n              ^^^ that shows better what you are testing,","commit_id":"8800d5a98545b7404534c50723698e93ba451efb"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"486296d803e08426ae61b7a9ec113a50770b2ce8","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                          pkey\u003dself.keypair[\u0027private_key\u0027])"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def _test_basic_vlan_transparency_connectivty("},{"line_number":118,"context_line":"            self, port_security\u003dTrue, use_allowed_address_pairs\u003dFalse):"},{"line_number":119,"context_line":"        vlan_tag \u003d data_utils.rand_int_id(start\u003dMIN_VLAN_ID, end\u003dMAX_VLAN_ID)"},{"line_number":120,"context_line":"        vlan_ipmask_template \u003d \u0027192.168.%d.{ip_last_byte}/24\u0027 % (vlan_tag %"},{"line_number":121,"context_line":"                                                                 256)"}],"source_content_type":"text/x-python","patch_set":18,"id":"7364ed7e_11f0f665","line":118,"range":{"start_line":118,"start_character":18,"end_line":118,"end_character":69},"in_reply_to":"5dad9ea3_b3846954","updated":"2021-01-19 11:42:15.000000000","message":"Done","commit_id":"8800d5a98545b7404534c50723698e93ba451efb"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4e277201b8c40c98f60cbc15958627a93e9fbdef","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        port_iface \u003d ip.get_port_device_name(addresses, port)"},{"line_number":97,"context_line":"        subport_iface \u003d ip_command.configure_vlan_transparent("},{"line_number":98,"context_line":"            port\u003dport, vlan_tag\u003dvlan_tag, ip_addresses\u003d[vlan_ip])"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        for address in ip_command.list_addresses(ip_addresses\u003dvlan_ip):"},{"line_number":101,"context_line":"            self.assertEqual(subport_iface, address.device.name)"},{"line_number":102,"context_line":"            self.assertEqual(port_iface, address.device.parent)"}],"source_content_type":"text/x-python","patch_set":19,"id":"515f1973_44321cf4","line":99,"updated":"2021-01-20 10:02:33.000000000","message":"unrelated","commit_id":"088707bf5c4cdffd403c2cb4c7743b811ece5635"}],"zuul.d/master_jobs.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c4566696aeb6501bf136e6d49a47579308abc911","unresolved":false,"context_lines":[{"line_number":192,"context_line":"          # lib/neutron-legacy"},{"line_number":193,"context_line":"          /$NEUTRON_CORE_PLUGIN_CONF:"},{"line_number":194,"context_line":"            ml2:"},{"line_number":195,"context_line":"              type_drivers: flat,vlan,local,vxlan"},{"line_number":196,"context_line":"        test-config:"},{"line_number":197,"context_line":"          $TEMPEST_CONFIG:"},{"line_number":198,"context_line":"            network-feature-enabled:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"4ec37610_19b28e43","line":195,"updated":"2020-12-07 09:48:00.000000000","message":"by default devstack configures openvswitch and linuxbridge as mechanism drivers and that is set in this job. Due to that Your new test if failing in that linuxbridge job so You should change this setting here to linuxbridge only","commit_id":"05fdba3a056590b3c16ab2c274bfb990ed063c27"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"256b310eb7930615ee162ef138061aadf3d2dc28","unresolved":false,"context_lines":[{"line_number":192,"context_line":"          # lib/neutron-legacy"},{"line_number":193,"context_line":"          /$NEUTRON_CORE_PLUGIN_CONF:"},{"line_number":194,"context_line":"            ml2:"},{"line_number":195,"context_line":"              type_drivers: flat,vlan,local,vxlan"},{"line_number":196,"context_line":"        test-config:"},{"line_number":197,"context_line":"          $TEMPEST_CONFIG:"},{"line_number":198,"context_line":"            network-feature-enabled:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"13670bb1_f9a02aa0","line":195,"in_reply_to":"4ec37610_19b28e43","updated":"2020-12-09 11:19:54.000000000","message":"ok, I see here: https://zuul.opendev.org/t/openstack/build/322b20f9f8424ff6ae39574f80a0672e/log/controller/logs/etc/neutron/plugins/ml2/ml2_conf.ini\n\nI\u0027m changing that.\nThanks!","commit_id":"05fdba3a056590b3c16ab2c274bfb990ed063c27"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c4566696aeb6501bf136e6d49a47579308abc911","unresolved":false,"context_lines":[{"line_number":222,"context_line":"          (^neutron_tempest_plugin.scenario.test_mtu.NetworkWritableMtuTest)\""},{"line_number":223,"context_line":"      devstack_localrc:"},{"line_number":224,"context_line":"        Q_AGENT: ovn"},{"line_number":225,"context_line":"        NETWORK_API_EXTENSIONS: \"{{ (network_api_extensions + network_api_extensions_ovn) | join(\u0027,\u0027) }}\""},{"line_number":226,"context_line":"        Q_ML2_PLUGIN_MECHANISM_DRIVERS: ovn,logger"},{"line_number":227,"context_line":"        Q_ML2_PLUGIN_TYPE_DRIVERS: local,flat,vlan,geneve"},{"line_number":228,"context_line":"        Q_ML2_TENANT_NETWORK_TYPE: geneve"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a16b0a70_54fc2b91","line":225,"updated":"2020-12-07 09:48:00.000000000","message":"In ovn case the way how network api extensions are configured is a bit different. It is taken by devstack from the https://github.com/openstack/neutron/blob/master/neutron/common/ovn/extensions.py#L74 - see https://opendev.org/openstack/devstack/src/branch/master/lib/neutron_plugins/ovn_agent#L398\nSo to make this test run in the gate, You should propose one additional patch to neutron to add this extension to that list.","commit_id":"05fdba3a056590b3c16ab2c274bfb990ed063c27"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"256b310eb7930615ee162ef138061aadf3d2dc28","unresolved":false,"context_lines":[{"line_number":222,"context_line":"          (^neutron_tempest_plugin.scenario.test_mtu.NetworkWritableMtuTest)\""},{"line_number":223,"context_line":"      devstack_localrc:"},{"line_number":224,"context_line":"        Q_AGENT: ovn"},{"line_number":225,"context_line":"        NETWORK_API_EXTENSIONS: \"{{ (network_api_extensions + network_api_extensions_ovn) | join(\u0027,\u0027) }}\""},{"line_number":226,"context_line":"        Q_ML2_PLUGIN_MECHANISM_DRIVERS: ovn,logger"},{"line_number":227,"context_line":"        Q_ML2_PLUGIN_TYPE_DRIVERS: local,flat,vlan,geneve"},{"line_number":228,"context_line":"        Q_ML2_TENANT_NETWORK_TYPE: geneve"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3e6686cb_058057ed","line":225,"in_reply_to":"a16b0a70_54fc2b91","updated":"2020-12-09 11:19:54.000000000","message":"Understood. I will send that patch in a moment.","commit_id":"05fdba3a056590b3c16ab2c274bfb990ed063c27"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e0ab03bb605ab1df6c293ee76bd8fa7c80f6c16d","unresolved":true,"context_lines":[{"line_number":238,"context_line":"        ENABLE_TLS: True"},{"line_number":239,"context_line":"        OVN_IGMP_SNOOPING_ENABLE: True"},{"line_number":240,"context_line":"        OVN_BRANCH: \"branch-20.12\""},{"line_number":241,"context_line":"        OVS_BRANCH: \"master\""},{"line_number":242,"context_line":"      devstack_services:"},{"line_number":243,"context_line":"        br-ex-tcpdump: true"},{"line_number":244,"context_line":"        br-int-flows: true"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"54566bef_c6f7c15b","line":241,"updated":"2020-12-22 10:04:25.000000000","message":"I\u0027m not sure if we really want to use OVS from master branch always in that job. I would prefer to use some stable branch there as this is voting job in the Neutron","commit_id":"69955d1f9bc1a93a463053883edf022800579694"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"52850d486f8541b3a215acae02b38427641fd4db","unresolved":true,"context_lines":[{"line_number":237,"context_line":"        OVN_DBS_LOG_LEVEL: dbg"},{"line_number":238,"context_line":"        ENABLE_TLS: True"},{"line_number":239,"context_line":"        OVN_IGMP_SNOOPING_ENABLE: True"},{"line_number":240,"context_line":"        OVN_BUILD_FROM_SOURCE: True"},{"line_number":241,"context_line":"        OVN_BRANCH: \"branch-20.12\""},{"line_number":242,"context_line":"        OVS_BRANCH: \"master\""},{"line_number":243,"context_line":"      devstack_services:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"e1eabca9_4d4271c6","line":240,"updated":"2021-01-14 09:56:28.000000000","message":"can You add TODO here that we can stop doing build from source when vlan_transparency will be in released ovn version?","commit_id":"f70cf419f7ed2d1a5197ba20a7398ea058cb531c"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"a01df1143982f7445628e4c1a9dcc9f6dc277b20","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        OVN_DBS_LOG_LEVEL: dbg"},{"line_number":238,"context_line":"        ENABLE_TLS: True"},{"line_number":239,"context_line":"        OVN_IGMP_SNOOPING_ENABLE: True"},{"line_number":240,"context_line":"        OVN_BUILD_FROM_SOURCE: True"},{"line_number":241,"context_line":"        OVN_BRANCH: \"branch-20.12\""},{"line_number":242,"context_line":"        OVS_BRANCH: \"master\""},{"line_number":243,"context_line":"      devstack_services:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"5128f63b_a41205ce","line":240,"in_reply_to":"e1eabca9_4d4271c6","updated":"2021-01-15 07:38:10.000000000","message":"Done","commit_id":"f70cf419f7ed2d1a5197ba20a7398ea058cb531c"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"a01df1143982f7445628e4c1a9dcc9f6dc277b20","unresolved":true,"context_lines":[{"line_number":241,"context_line":"        # is included in an ovn released version"},{"line_number":242,"context_line":"        OVN_BUILD_FROM_SOURCE: True"},{"line_number":243,"context_line":"        OVN_BRANCH: \"branch-20.12\""},{"line_number":244,"context_line":"        OVS_BRANCH: \"master\""},{"line_number":245,"context_line":"      devstack_services:"},{"line_number":246,"context_line":"        br-ex-tcpdump: true"},{"line_number":247,"context_line":"        br-int-flows: true"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"86fc2a30_e90972aa","line":244,"range":{"start_line":244,"start_character":8,"end_line":244,"end_character":28},"updated":"2021-01-15 07:38:10.000000000","message":"OVS branch 2.15 creation is planned for today - I will replace master by 2.15 once it\u0027s available","commit_id":"089f4621a250a5fca16ca0e0cb88d1c712a7c83c"}],"zuul.d/ussuri_jobs.yaml":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a2176b59853c16eecc40bf992239110aae0f57e1","unresolved":true,"context_lines":[{"line_number":163,"context_line":"        OVN_BUILD_MODULES: True"},{"line_number":164,"context_line":"        # TODO(skaplons): v2.13.1 is incompatible with kernel 4.15.0-118, sticking to commit hash until new v2.13 tag is created"},{"line_number":165,"context_line":"        OVS_BRANCH: 0047ca3a0290f1ef954f2c76b31477cf4b9755f5"},{"line_number":166,"context_line":"        OVN_BRANCH: \"v20.03.0\""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"- job:"},{"line_number":169,"context_line":"    name: neutron-tempest-plugin-dvr-multinode-scenario-ussuri"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"b4e2d96f_4c79ea86","line":166,"range":{"start_line":166,"start_character":8,"end_line":166,"end_character":30},"updated":"2020-12-18 17:39:32.000000000","message":"Is this needed in older versions too?","commit_id":"69955d1f9bc1a93a463053883edf022800579694"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1113015d756254d2cdad938a7458324ff75355c0","unresolved":true,"context_lines":[{"line_number":163,"context_line":"        OVN_BUILD_MODULES: True"},{"line_number":164,"context_line":"        # TODO(skaplons): v2.13.1 is incompatible with kernel 4.15.0-118, sticking to commit hash until new v2.13 tag is created"},{"line_number":165,"context_line":"        OVS_BRANCH: 0047ca3a0290f1ef954f2c76b31477cf4b9755f5"},{"line_number":166,"context_line":"        OVN_BRANCH: \"v20.03.0\""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"- job:"},{"line_number":169,"context_line":"    name: neutron-tempest-plugin-dvr-multinode-scenario-ussuri"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"70444ff8_922cdf92","line":166,"range":{"start_line":166,"start_character":8,"end_line":166,"end_character":30},"in_reply_to":"2ef86422_09b2e072","updated":"2020-12-18 17:43:11.000000000","message":"Sorry, for OVN, U is the older stable branch.","commit_id":"69955d1f9bc1a93a463053883edf022800579694"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ba458f02b6fdebad19848dd9e8ef188d63e3b512","unresolved":true,"context_lines":[{"line_number":163,"context_line":"        OVN_BUILD_MODULES: True"},{"line_number":164,"context_line":"        # TODO(skaplons): v2.13.1 is incompatible with kernel 4.15.0-118, sticking to commit hash until new v2.13 tag is created"},{"line_number":165,"context_line":"        OVS_BRANCH: 0047ca3a0290f1ef954f2c76b31477cf4b9755f5"},{"line_number":166,"context_line":"        OVN_BRANCH: \"v20.03.0\""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"- job:"},{"line_number":169,"context_line":"    name: neutron-tempest-plugin-dvr-multinode-scenario-ussuri"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"2ef86422_09b2e072","line":166,"range":{"start_line":166,"start_character":8,"end_line":166,"end_character":30},"in_reply_to":"b4e2d96f_4c79ea86","updated":"2020-12-18 17:40:21.000000000","message":"older versions \u003d\u003d previous stable branches (you know what I mean)","commit_id":"69955d1f9bc1a93a463053883edf022800579694"}]}