)]}'
{"neutron_tempest_plugin/scenario/test_vlan_transparency.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"74e56a5f7da85e63aab3aecce424a1696d5c3bb9","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        for i in range(num_vlans):"},{"line_number":116,"context_line":"            for server_name_j in self.server_names:"},{"line_number":117,"context_line":"                for server_name_k in self.server_names:"},{"line_number":118,"context_line":"                    if server_name_j !\u003d server_name_k:"},{"line_number":119,"context_line":"                        if untagged:"},{"line_number":120,"context_line":"                            destination \u003d self.vm_ports[server_name_k]["},{"line_number":121,"context_line":"                                \u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"b6882b31_cc382f89","line":118,"updated":"2020-12-04 08:59:11.000000000","message":"IIUC You are always creating 2 servers to test traffic between them, right? If yes, do we really need such \"automated\" way of doing things? IMO it\u0027s hard to read and understand what it is going to do exactly. And also debugging this may be hard in the future. Maybe You can propose something simpler, but less generic?","commit_id":"334e4785089f979c775b4de8f3aabe446269e71c"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"57a9f2b447180d03f5e90416d4e2b4ff61195b93","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        for i in range(num_vlans):"},{"line_number":116,"context_line":"            for server_name_j in self.server_names:"},{"line_number":117,"context_line":"                for server_name_k in self.server_names:"},{"line_number":118,"context_line":"                    if server_name_j !\u003d server_name_k:"},{"line_number":119,"context_line":"                        if untagged:"},{"line_number":120,"context_line":"                            destination \u003d self.vm_ports[server_name_k]["},{"line_number":121,"context_line":"                                \u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"24a5315a_d41ffc23","line":118,"in_reply_to":"b6882b31_cc382f89","updated":"2020-12-04 11:19:42.000000000","message":"OK! I think it\u0027s simpler now","commit_id":"334e4785089f979c775b4de8f3aabe446269e71c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"74e56a5f7da85e63aab3aecce424a1696d5c3bb9","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        self.vms \u003d {}"},{"line_number":149,"context_line":"        self.vlan_ipmasks \u003d {}"},{"line_number":150,"context_line":"        self.ssh_clients \u003d {}"},{"line_number":151,"context_line":"        self.server_names \u003d []"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        for i in range(2):"},{"line_number":154,"context_line":"            server_name \u003d \u0027server-%s-%d\u0027 % (self.rand_name, i)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1afa404b_16b3a49e","line":151,"updated":"2020-12-04 08:59:11.000000000","message":"do You need to have all those dicts/lists? Can\u0027t You simly have self.vms which will be like:\n\n    self.servers \u003d {server_name: {\u0027vm\u0027: vm_object, \u0027ssh_client\u0027: ssh_client, \u0027floating_ip\u0027: floating_ip}}\n?","commit_id":"334e4785089f979c775b4de8f3aabe446269e71c"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"57a9f2b447180d03f5e90416d4e2b4ff61195b93","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        self.vms \u003d {}"},{"line_number":149,"context_line":"        self.vlan_ipmasks \u003d {}"},{"line_number":150,"context_line":"        self.ssh_clients \u003d {}"},{"line_number":151,"context_line":"        self.server_names \u003d []"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        for i in range(2):"},{"line_number":154,"context_line":"            server_name \u003d \u0027server-%s-%d\u0027 % (self.rand_name, i)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d536fdb3_e000bc79","line":151,"in_reply_to":"1afa404b_16b3a49e","updated":"2020-12-04 11:19:42.000000000","message":"done","commit_id":"334e4785089f979c775b4de8f3aabe446269e71c"}]}