)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1e674c25351b3cc0b37caf8d7ae85b3e82f49c6a","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"New test, extends test_subport_connectivity"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Based on the following launchpad #1869244"},{"line_number":10,"context_line":"Adding new test test_subport_connectivity_reboot"},{"line_number":11,"context_line":"which call test_subport_connectivity and find vms"},{"line_number":12,"context_line":"and reboot it and test connection"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff7397f9_29343f84","line":9,"range":{"start_line":9,"start_character":34,"end_line":9,"end_character":41},"updated":"2021-01-08 09:07:57.000000000","message":"Please add:\n\nRelated-Bug: #1869244\n\nbelow the commit message if this is related to that bug somehow.","commit_id":"1c7060144128b7aef8daf28e3e844c9dd264a881"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"dbf62460d8782654b77fa0ed7ecfc275ea164da4","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"New test, extends test_subport_connectivity"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Based on the following launchpad #1869244"},{"line_number":10,"context_line":"Adding new test test_subport_connectivity_reboot"},{"line_number":11,"context_line":"which call test_subport_connectivity and find vms"},{"line_number":12,"context_line":"and reboot it and test connection"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dc8c32ee_91bab416","line":9,"range":{"start_line":9,"start_character":34,"end_line":9,"end_character":41},"in_reply_to":"ff7397f9_29343f84","updated":"2021-01-10 08:30:08.000000000","message":"\u003e Please add:\n\u003e \n\u003e Related-Bug: #1869244\n\u003e \n\u003e below the commit message if this is related to that bug somehow.\n\nAck","commit_id":"1c7060144128b7aef8daf28e3e844c9dd264a881"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d131eb773057ff30a44253e4e1b64c4294ad9e90","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Related-Bug: #1869244"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Adding new test test_subport_connectivity_reboot"},{"line_number":12,"context_line":"The test is checking trunks are ports are recreated during server"},{"line_number":13,"context_line":"reboots, specialy in ovs_dpdk ports,"},{"line_number":14,"context_line":"Since test flow is very close to test_subport_connectivity"},{"line_number":15,"context_line":"Two methods added:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"825bfd62_2d05c735","line":12,"range":{"start_line":12,"start_character":28,"end_line":12,"end_character":31},"updated":"2021-02-12 08:52:48.000000000","message":"nit: and?","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"a7832cc586831b4ec3d0d216d558153aba1b679e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Related-Bug: #1869244"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Adding new test test_subport_connectivity_reboot"},{"line_number":12,"context_line":"The test is checking trunks are ports are recreated during server"},{"line_number":13,"context_line":"reboots, specialy in ovs_dpdk ports,"},{"line_number":14,"context_line":"Since test flow is very close to test_subport_connectivity"},{"line_number":15,"context_line":"Two methods added:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"10c6c685_d6c66f59","line":12,"range":{"start_line":12,"start_character":28,"end_line":12,"end_character":31},"in_reply_to":"825bfd62_2d05c735","updated":"2021-03-22 13:20:30.000000000","message":"Ack","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"}],"neutron_tempest_plugin/config.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"16b4bf27df5bada2d9f8842fbf776743754b8f22","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    cfg.IntOpt(\u0027ssh_proxy_jump_port\u0027,"},{"line_number":93,"context_line":"               default\u003d22,"},{"line_number":94,"context_line":"               help\u003d\u0027Port used to connect to \"ssh_proxy_jump_host\".\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027max_reboots_to_test\u0027,"},{"line_number":96,"context_line":"               default\u003d0,"},{"line_number":97,"context_line":"               help\u003d\u0027Number of reboots to apply if tests requires reboots\u0027),"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # Options for special, \"advanced\" image like e.g. Ubuntu. Such image can be"},{"line_number":100,"context_line":"    # used in tests which require some more advanced tool than available in"}],"source_content_type":"text/x-python","patch_set":3,"id":"b34877d5_0661f7ea","line":97,"range":{"start_line":95,"start_character":4,"end_line":97,"end_character":76},"updated":"2021-01-15 12:42:33.000000000","message":"If you really need a new config option for this (as I see it is used only for 1 test, so I don\u0027t see the need for it) be sure to change the necessary job configs in zuul.yaml (not sure by heart which yaml and which job is for you for trunk tests, but you can find them under .zuul directory)","commit_id":"91527a1352fe7ade4121346187bdc263e45ff136"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"5d2e4611bb88039e801e875a8089c3a96daebc3f","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    cfg.IntOpt(\u0027ssh_proxy_jump_port\u0027,"},{"line_number":93,"context_line":"               default\u003d22,"},{"line_number":94,"context_line":"               help\u003d\u0027Port used to connect to \"ssh_proxy_jump_host\".\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027max_reboots_to_test\u0027,"},{"line_number":96,"context_line":"               default\u003d0,"},{"line_number":97,"context_line":"               help\u003d\u0027Number of reboots to apply if tests requires reboots\u0027),"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # Options for special, \"advanced\" image like e.g. Ubuntu. Such image can be"},{"line_number":100,"context_line":"    # used in tests which require some more advanced tool than available in"}],"source_content_type":"text/x-python","patch_set":3,"id":"97d4cd20_757de805","line":97,"range":{"start_line":95,"start_character":4,"end_line":97,"end_character":76},"in_reply_to":"13d28c87_cf4bacd7","updated":"2021-01-18 16:13:08.000000000","message":"\u003e So IIUC Your point, You don\u0027t wan\u0027t to reboot vm in u/s ci but You want to modify that config option in Your d/s CI and reboot vm there, is that correct?\n\u003e If there is/was really and issue with subports connectivity after vm reboot, why we can\u0027t simply reboot vm once and test connectivity then?\n\nIf you look at the BZ attached to this launchpad, it was mentioned that there is timing issue\nso it could recreated on non consistent way.\n\nsee this:\n\n1. The port is deleted\n2. A thread is spawned to delete the trunk\n3. The port is recreated\n\nIf the trunk is deleted after #3 happens then the instance has no\nnetworking and is inaccessible; this is the scenario that was dealt with\n\nso since it is related to timing and and neutron load, it could be verified in other setups with higher reboot tries. \n\nWill add Nate here, as launchpad owner, maybe he could add additional reviewers","commit_id":"91527a1352fe7ade4121346187bdc263e45ff136"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"a87ea29ef339f1dc49d7dd0a4d2570672a9ce2a4","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    cfg.IntOpt(\u0027ssh_proxy_jump_port\u0027,"},{"line_number":93,"context_line":"               default\u003d22,"},{"line_number":94,"context_line":"               help\u003d\u0027Port used to connect to \"ssh_proxy_jump_host\".\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027max_reboots_to_test\u0027,"},{"line_number":96,"context_line":"               default\u003d0,"},{"line_number":97,"context_line":"               help\u003d\u0027Number of reboots to apply if tests requires reboots\u0027),"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # Options for special, \"advanced\" image like e.g. Ubuntu. Such image can be"},{"line_number":100,"context_line":"    # used in tests which require some more advanced tool than available in"}],"source_content_type":"text/x-python","patch_set":3,"id":"5b33b503_8f0d994e","line":97,"range":{"start_line":95,"start_character":4,"end_line":97,"end_character":76},"in_reply_to":"6b964a67_5bef03d6","updated":"2021-01-19 17:58:37.000000000","message":"Is there any way to specify that this test is to validate trunk port behavior on reboot but specifically in the scenario where DPDK vhost user mode is in use?  The behavior where a port is deleted when the VM is rebooted is specific to DPDK vhu.","commit_id":"91527a1352fe7ade4121346187bdc263e45ff136"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"6e77f07e34e55ac4bd632ebb47785c7eaef29f65","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    cfg.IntOpt(\u0027ssh_proxy_jump_port\u0027,"},{"line_number":93,"context_line":"               default\u003d22,"},{"line_number":94,"context_line":"               help\u003d\u0027Port used to connect to \"ssh_proxy_jump_host\".\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027max_reboots_to_test\u0027,"},{"line_number":96,"context_line":"               default\u003d0,"},{"line_number":97,"context_line":"               help\u003d\u0027Number of reboots to apply if tests requires reboots\u0027),"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # Options for special, \"advanced\" image like e.g. Ubuntu. Such image can be"},{"line_number":100,"context_line":"    # used in tests which require some more advanced tool than available in"}],"source_content_type":"text/x-python","patch_set":3,"id":"6b964a67_5bef03d6","line":97,"range":{"start_line":95,"start_character":4,"end_line":97,"end_character":76},"in_reply_to":"97d4cd20_757de805","updated":"2021-01-18 18:06:31.000000000","message":"\u003e So IIUC Your point, You don\u0027t wan\u0027t to reboot vm in u/s ci but You want to modify that config option in Your d/s CI and reboot vm there, is that correct?\n\u003e If there is/was really and issue with subports connectivity after vm reboot, why we can\u0027t simply reboot vm once and test connectivity then?\n\nI am trying to understand, do you suggest set default parameter to 1?\nI will be happy","commit_id":"91527a1352fe7ade4121346187bdc263e45ff136"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"fd2163f7b7768675f220534a9fa3e7fb6463de05","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    cfg.IntOpt(\u0027ssh_proxy_jump_port\u0027,"},{"line_number":93,"context_line":"               default\u003d22,"},{"line_number":94,"context_line":"               help\u003d\u0027Port used to connect to \"ssh_proxy_jump_host\".\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027max_reboots_to_test\u0027,"},{"line_number":96,"context_line":"               default\u003d0,"},{"line_number":97,"context_line":"               help\u003d\u0027Number of reboots to apply if tests requires reboots\u0027),"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # Options for special, \"advanced\" image like e.g. Ubuntu. Such image can be"},{"line_number":100,"context_line":"    # used in tests which require some more advanced tool than available in"}],"source_content_type":"text/x-python","patch_set":3,"id":"f642521f_f0a82c3f","line":97,"range":{"start_line":95,"start_character":4,"end_line":97,"end_character":76},"in_reply_to":"b34877d5_0661f7ea","updated":"2021-01-17 07:56:29.000000000","message":"Ahmm, i am not sure, so if i would like to run this test not on zuul ci, how will i control this parameter? Is there another way except to config.py?","commit_id":"91527a1352fe7ade4121346187bdc263e45ff136"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8af63c31d9d7af1ad44ed2ccda1a724e26c02c09","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    cfg.IntOpt(\u0027ssh_proxy_jump_port\u0027,"},{"line_number":93,"context_line":"               default\u003d22,"},{"line_number":94,"context_line":"               help\u003d\u0027Port used to connect to \"ssh_proxy_jump_host\".\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027max_reboots_to_test\u0027,"},{"line_number":96,"context_line":"               default\u003d0,"},{"line_number":97,"context_line":"               help\u003d\u0027Number of reboots to apply if tests requires reboots\u0027),"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # Options for special, \"advanced\" image like e.g. Ubuntu. Such image can be"},{"line_number":100,"context_line":"    # used in tests which require some more advanced tool than available in"}],"source_content_type":"text/x-python","patch_set":3,"id":"13d28c87_cf4bacd7","line":97,"range":{"start_line":95,"start_character":4,"end_line":97,"end_character":76},"in_reply_to":"f642521f_f0a82c3f","updated":"2021-01-18 15:25:37.000000000","message":"So IIUC Your point, You don\u0027t wan\u0027t to reboot vm in u/s ci but You want to modify that config option in Your d/s CI and reboot vm there, is that correct?\nIf there is/was really and issue with subports connectivity after vm reboot, why we can\u0027t simply reboot vm once and test connectivity then?","commit_id":"91527a1352fe7ade4121346187bdc263e45ff136"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3161cada7b93de4c109d5016e4da151f205bd7c3","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    cfg.IntOpt(\u0027ssh_proxy_jump_port\u0027,"},{"line_number":93,"context_line":"               default\u003d22,"},{"line_number":94,"context_line":"               help\u003d\u0027Port used to connect to \"ssh_proxy_jump_host\".\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027max_reboots_to_test\u0027,"},{"line_number":96,"context_line":"               default\u003d0,"},{"line_number":97,"context_line":"               help\u003d\u0027Number of reboots to apply if tests requires reboots\u0027),"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"2c63bcde_025ae281","line":95,"updated":"2021-01-20 10:35:10.000000000","message":"I would name this option \"reboots_in_test\" or something like that. With \"max\" in name it is more like some value which can\u0027t be exceeded but that can be less. Here it is more like \"please do exactly that many reboots in the test\" :)","commit_id":"8c0c8153dfe6eda832b05f18394e183c5f8c5ba5"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"511119fb27e2586d01009114fe126cb7519d4169","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    cfg.IntOpt(\u0027ssh_proxy_jump_port\u0027,"},{"line_number":93,"context_line":"               default\u003d22,"},{"line_number":94,"context_line":"               help\u003d\u0027Port used to connect to \"ssh_proxy_jump_host\".\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027max_reboots_to_test\u0027,"},{"line_number":96,"context_line":"               default\u003d0,"},{"line_number":97,"context_line":"               help\u003d\u0027Number of reboots to apply if tests requires reboots\u0027),"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"33c9455d_1dc17773","line":95,"in_reply_to":"2c63bcde_025ae281","updated":"2021-01-20 15:47:16.000000000","message":"Ack","commit_id":"8c0c8153dfe6eda832b05f18394e183c5f8c5ba5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3161cada7b93de4c109d5016e4da151f205bd7c3","unresolved":true,"context_lines":[{"line_number":93,"context_line":"               default\u003d22,"},{"line_number":94,"context_line":"               help\u003d\u0027Port used to connect to \"ssh_proxy_jump_host\".\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027max_reboots_to_test\u0027,"},{"line_number":96,"context_line":"               default\u003d0,"},{"line_number":97,"context_line":"               help\u003d\u0027Number of reboots to apply if tests requires reboots\u0027),"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # Options for special, \"advanced\" image like e.g. Ubuntu. Such image can be"}],"source_content_type":"text/x-python","patch_set":4,"id":"b78149ce_b852437b","line":96,"range":{"start_line":96,"start_character":23,"end_line":96,"end_character":24},"updated":"2021-01-20 10:35:10.000000000","message":"maybe default to 1 would be better as if we have test which is doing reboot, we wants to do it at least once, right?","commit_id":"8c0c8153dfe6eda832b05f18394e183c5f8c5ba5"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"511119fb27e2586d01009114fe126cb7519d4169","unresolved":false,"context_lines":[{"line_number":93,"context_line":"               default\u003d22,"},{"line_number":94,"context_line":"               help\u003d\u0027Port used to connect to \"ssh_proxy_jump_host\".\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027max_reboots_to_test\u0027,"},{"line_number":96,"context_line":"               default\u003d0,"},{"line_number":97,"context_line":"               help\u003d\u0027Number of reboots to apply if tests requires reboots\u0027),"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # Options for special, \"advanced\" image like e.g. Ubuntu. Such image can be"}],"source_content_type":"text/x-python","patch_set":4,"id":"228e82af_094f5b65","line":96,"range":{"start_line":96,"start_character":23,"end_line":96,"end_character":24},"in_reply_to":"b78149ce_b852437b","updated":"2021-01-20 15:47:16.000000000","message":"Ack","commit_id":"8c0c8153dfe6eda832b05f18394e183c5f8c5ba5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d131eb773057ff30a44253e4e1b64c4294ad9e90","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    cfg.IntOpt(\u0027ssh_proxy_jump_port\u0027,"},{"line_number":93,"context_line":"               default\u003d22,"},{"line_number":94,"context_line":"               help\u003d\u0027Port used to connect to \"ssh_proxy_jump_host\".\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027reboots_in_test\u0027,"},{"line_number":96,"context_line":"               default\u003d1,"},{"line_number":97,"context_line":"               help\u003d\u0027Number of reboots to apply if tests requires reboots\u0027),"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # Options for special, \"advanced\" image like e.g. Ubuntu. Such image can be"},{"line_number":100,"context_line":"    # used in tests which require some more advanced tool than available in"}],"source_content_type":"text/x-python","patch_set":9,"id":"3d1ceb60_e0363886","line":97,"range":{"start_line":95,"start_character":4,"end_line":97,"end_character":76},"updated":"2021-02-12 08:52:48.000000000","message":"I would go without this config option, and say in zuul environment 1 reboot is enough for us and no need for config","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"061ffa35e30715259985eb81db615da6b6772a88","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    cfg.IntOpt(\u0027ssh_proxy_jump_port\u0027,"},{"line_number":93,"context_line":"               default\u003d22,"},{"line_number":94,"context_line":"               help\u003d\u0027Port used to connect to \"ssh_proxy_jump_host\".\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027reboots_in_test\u0027,"},{"line_number":96,"context_line":"               default\u003d1,"},{"line_number":97,"context_line":"               help\u003d\u0027Number of reboots to apply if tests requires reboots\u0027),"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # Options for special, \"advanced\" image like e.g. Ubuntu. Such image can be"},{"line_number":100,"context_line":"    # used in tests which require some more advanced tool than available in"}],"source_content_type":"text/x-python","patch_set":9,"id":"6fa8908d_653d86eb","line":97,"range":{"start_line":95,"start_character":4,"end_line":97,"end_character":76},"in_reply_to":"3d1ceb60_e0363886","updated":"2021-02-16 17:32:36.000000000","message":"\u003e I would go without this config option, and say in zuul environment 1 reboot is enough for us and no need for config\n\nI\u0027m not sure, i would like to run this test with more than  soft reboot, since it is related to race conditions, from launchpad.\n\nIn non u/s ci, prefer to run it more than once","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"79edb666302c36655cc58325badeae4c29a6ccfa","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    cfg.IntOpt(\u0027ssh_proxy_jump_port\u0027,"},{"line_number":93,"context_line":"               default\u003d22,"},{"line_number":94,"context_line":"               help\u003d\u0027Port used to connect to \"ssh_proxy_jump_host\".\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027reboots_in_test\u0027,"},{"line_number":96,"context_line":"               default\u003d1,"},{"line_number":97,"context_line":"               help\u003d\u0027Number of reboots to apply if tests requires reboots\u0027),"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # Options for special, \"advanced\" image like e.g. Ubuntu. Such image can be"},{"line_number":100,"context_line":"    # used in tests which require some more advanced tool than available in"}],"source_content_type":"text/x-python","patch_set":9,"id":"e61c1e49_3616d0cc","line":97,"range":{"start_line":95,"start_character":4,"end_line":97,"end_character":76},"in_reply_to":"5d613dd0_a0f727b4","updated":"2021-02-17 13:57:57.000000000","message":"Done","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"66b64a3edcf0769e2f28f135e5938dc72383cb2d","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    cfg.IntOpt(\u0027ssh_proxy_jump_port\u0027,"},{"line_number":93,"context_line":"               default\u003d22,"},{"line_number":94,"context_line":"               help\u003d\u0027Port used to connect to \"ssh_proxy_jump_host\".\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027reboots_in_test\u0027,"},{"line_number":96,"context_line":"               default\u003d1,"},{"line_number":97,"context_line":"               help\u003d\u0027Number of reboots to apply if tests requires reboots\u0027),"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # Options for special, \"advanced\" image like e.g. Ubuntu. Such image can be"},{"line_number":100,"context_line":"    # used in tests which require some more advanced tool than available in"}],"source_content_type":"text/x-python","patch_set":9,"id":"5d613dd0_a0f727b4","line":97,"range":{"start_line":95,"start_character":4,"end_line":97,"end_character":76},"in_reply_to":"6fa8908d_653d86eb","updated":"2021-02-17 13:24:44.000000000","message":"ok I can understand this","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"}],"neutron_tempest_plugin/scenario/test_trunk.py":[{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"ca9c2359ebeaf14865726199d7cf9bf5c2bac2e3","unresolved":true,"context_lines":[{"line_number":260,"context_line":"        \"\"\" This test using test_subport_connectivity()"},{"line_number":261,"context_line":"            select one deployed vms reboots and verify ping and ssh"},{"line_number":262,"context_line":"        \"\"\""},{"line_number":263,"context_line":"        import ipdb; ipdb.set_trace()"},{"line_number":264,"context_line":"        self.test_subport_connectivity()"},{"line_number":265,"context_line":"        client \u003d self.os_admin.compute.ServersClient()"},{"line_number":266,"context_line":"        servers \u003d client.list_servers()"}],"source_content_type":"text/x-python","patch_set":1,"id":"0cb10c0d_1cc7b066","line":263,"updated":"2021-01-07 12:21:48.000000000","message":"You need to remove this debug line","commit_id":"9ab3a29d2eba41475ed28eaab0e14a07f9da8a06"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"c953d8ab8966129d031dca38d4ae30ef16ff1560","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        \"\"\" This test using test_subport_connectivity()"},{"line_number":261,"context_line":"            select one deployed vms reboots and verify ping and ssh"},{"line_number":262,"context_line":"        \"\"\""},{"line_number":263,"context_line":"        import ipdb; ipdb.set_trace()"},{"line_number":264,"context_line":"        self.test_subport_connectivity()"},{"line_number":265,"context_line":"        client \u003d self.os_admin.compute.ServersClient()"},{"line_number":266,"context_line":"        servers \u003d client.list_servers()"}],"source_content_type":"text/x-python","patch_set":1,"id":"f08be27c_41e587a7","line":263,"in_reply_to":"0cb10c0d_1cc7b066","updated":"2021-01-07 15:50:59.000000000","message":"Ack","commit_id":"9ab3a29d2eba41475ed28eaab0e14a07f9da8a06"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1e674c25351b3cc0b37caf8d7ae85b3e82f49c6a","unresolved":true,"context_lines":[{"line_number":266,"context_line":"        client \u003d self.os_admin.compute.ServersClient()"},{"line_number":267,"context_line":"        servers \u003d client.list_servers()"},{"line_number":268,"context_line":"        client \u003d self.os_admin.compute.ServersClient()"},{"line_number":269,"context_line":"        for i in range(0, CONF.neutron_plugin_options.max_reboots_to_test):"},{"line_number":270,"context_line":"            client.reboot_server(servers[\u0027servers\u0027][0][\u0027id\u0027],"},{"line_number":271,"context_line":"                                 **{\u0027type\u0027: \u0027SOFT\u0027})"},{"line_number":272,"context_line":"            self.wait_for_server_active(servers[\u0027servers\u0027][0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ac873a93_3dabb802","line":269,"updated":"2021-01-08 09:07:57.000000000","message":"do we really need number of reboots to be configurable? Why can\u0027t we simply reboot vm once?","commit_id":"1c7060144128b7aef8daf28e3e844c9dd264a881"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"dbf62460d8782654b77fa0ed7ecfc275ea164da4","unresolved":true,"context_lines":[{"line_number":266,"context_line":"        client \u003d self.os_admin.compute.ServersClient()"},{"line_number":267,"context_line":"        servers \u003d client.list_servers()"},{"line_number":268,"context_line":"        client \u003d self.os_admin.compute.ServersClient()"},{"line_number":269,"context_line":"        for i in range(0, CONF.neutron_plugin_options.max_reboots_to_test):"},{"line_number":270,"context_line":"            client.reboot_server(servers[\u0027servers\u0027][0][\u0027id\u0027],"},{"line_number":271,"context_line":"                                 **{\u0027type\u0027: \u0027SOFT\u0027})"},{"line_number":272,"context_line":"            self.wait_for_server_active(servers[\u0027servers\u0027][0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"b09a68cd_5e6c4465","line":269,"in_reply_to":"ac873a93_3dabb802","updated":"2021-01-10 08:30:08.000000000","message":"\u003e do we really need number of reboots to be configurable? Why can\u0027t we simply reboot vm once?\n\nAs per the initial Customer case, it happened inconsistent","commit_id":"1c7060144128b7aef8daf28e3e844c9dd264a881"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1e674c25351b3cc0b37caf8d7ae85b3e82f49c6a","unresolved":true,"context_lines":[{"line_number":269,"context_line":"        for i in range(0, CONF.neutron_plugin_options.max_reboots_to_test):"},{"line_number":270,"context_line":"            client.reboot_server(servers[\u0027servers\u0027][0][\u0027id\u0027],"},{"line_number":271,"context_line":"                                 **{\u0027type\u0027: \u0027SOFT\u0027})"},{"line_number":272,"context_line":"            self.wait_for_server_active(servers[\u0027servers\u0027][0])"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @test.unstable_test(\"bug 1897796\")"},{"line_number":275,"context_line":"    @testtools.skipUnless("}],"source_content_type":"text/x-python","patch_set":2,"id":"c705ecfd_f4f43eca","line":272,"updated":"2021-01-08 09:07:57.000000000","message":"didn\u0027t You forgot to test connectivity after reboot also?","commit_id":"1c7060144128b7aef8daf28e3e844c9dd264a881"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"dbf62460d8782654b77fa0ed7ecfc275ea164da4","unresolved":true,"context_lines":[{"line_number":269,"context_line":"        for i in range(0, CONF.neutron_plugin_options.max_reboots_to_test):"},{"line_number":270,"context_line":"            client.reboot_server(servers[\u0027servers\u0027][0][\u0027id\u0027],"},{"line_number":271,"context_line":"                                 **{\u0027type\u0027: \u0027SOFT\u0027})"},{"line_number":272,"context_line":"            self.wait_for_server_active(servers[\u0027servers\u0027][0])"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @test.unstable_test(\"bug 1897796\")"},{"line_number":275,"context_line":"    @testtools.skipUnless("}],"source_content_type":"text/x-python","patch_set":2,"id":"300fd1f2_e3e72cb4","line":272,"in_reply_to":"c705ecfd_f4f43eca","updated":"2021-01-10 08:30:08.000000000","message":"\u003e didn\u0027t You forgot to test connectivity after reboot also?\n\nAck, moved to WIP, have to verify it 1st 😊","commit_id":"1c7060144128b7aef8daf28e3e844c9dd264a881"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3161cada7b93de4c109d5016e4da151f205bd7c3","unresolved":true,"context_lines":[{"line_number":263,"context_line":"           reboot and check ssh"},{"line_number":264,"context_line":"        \"\"\""},{"line_number":265,"context_line":"        try:"},{"line_number":266,"context_line":"            self.test_subport_connectivity()"},{"line_number":267,"context_line":"        except Exception:"},{"line_number":268,"context_line":"            msg \u003d \"test_subport_connectivity raise exception\""},{"line_number":269,"context_line":"            LOG.exception(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"db952717_84b484fb","line":266,"updated":"2021-01-20 10:35:10.000000000","message":"instead of calling test_subport_connectivity() here, maybe You can refactor that method to extract some common parts and reuse them in both tests.","commit_id":"8c0c8153dfe6eda832b05f18394e183c5f8c5ba5"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"511119fb27e2586d01009114fe126cb7519d4169","unresolved":false,"context_lines":[{"line_number":263,"context_line":"           reboot and check ssh"},{"line_number":264,"context_line":"        \"\"\""},{"line_number":265,"context_line":"        try:"},{"line_number":266,"context_line":"            self.test_subport_connectivity()"},{"line_number":267,"context_line":"        except Exception:"},{"line_number":268,"context_line":"            msg \u003d \"test_subport_connectivity raise exception\""},{"line_number":269,"context_line":"            LOG.exception(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fc2e2a62_d361907e","line":266,"in_reply_to":"db952717_84b484fb","updated":"2021-01-20 15:47:16.000000000","message":"Ack\nI did not want to cause rejection for the patch 😊\nWill do that, +2","commit_id":"8c0c8153dfe6eda832b05f18394e183c5f8c5ba5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3161cada7b93de4c109d5016e4da151f205bd7c3","unresolved":true,"context_lines":[{"line_number":305,"context_line":"        vm2 \u003d self._create_server_with_trunk_port("},{"line_number":306,"context_line":"            subport_network\u003dvlan_network,"},{"line_number":307,"context_line":"            segmentation_id\u003dvlan_tag,"},{"line_number":308,"context_line":"            use_advanced_image\u003duse_advanced_image)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        for vm in [vm1, vm2]:"},{"line_number":311,"context_line":"            self.check_connectivity("}],"source_content_type":"text/x-python","patch_set":4,"id":"6f930dfd_4955334f","line":308,"updated":"2021-01-20 10:35:10.000000000","message":"maybe You can refactor this test a bit, and e.g. move that part to some separate method which will be used here and in Your new test also,","commit_id":"8c0c8153dfe6eda832b05f18394e183c5f8c5ba5"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"511119fb27e2586d01009114fe126cb7519d4169","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        vm2 \u003d self._create_server_with_trunk_port("},{"line_number":306,"context_line":"            subport_network\u003dvlan_network,"},{"line_number":307,"context_line":"            segmentation_id\u003dvlan_tag,"},{"line_number":308,"context_line":"            use_advanced_image\u003duse_advanced_image)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        for vm in [vm1, vm2]:"},{"line_number":311,"context_line":"            self.check_connectivity("}],"source_content_type":"text/x-python","patch_set":4,"id":"360abbfc_c38713a9","line":308,"in_reply_to":"6f930dfd_4955334f","updated":"2021-01-20 15:47:16.000000000","message":"Ack","commit_id":"8c0c8153dfe6eda832b05f18394e183c5f8c5ba5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3161cada7b93de4c109d5016e4da151f205bd7c3","unresolved":true,"context_lines":[{"line_number":330,"context_line":"        self.check_remote_connectivity("},{"line_number":331,"context_line":"            vm1.ssh_client,"},{"line_number":332,"context_line":"            vm2.subport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":333,"context_line":"            servers\u003d[vm1, vm2])"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.cold_migration,"},{"line_number":336,"context_line":"                          \u0027Cold migration is not available.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"c636db10_b79ee602","line":333,"updated":"2021-01-20 10:35:10.000000000","message":"and then this part in L318-L333 can maybe also be moved to separate method and used in both tests","commit_id":"8c0c8153dfe6eda832b05f18394e183c5f8c5ba5"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"511119fb27e2586d01009114fe126cb7519d4169","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        self.check_remote_connectivity("},{"line_number":331,"context_line":"            vm1.ssh_client,"},{"line_number":332,"context_line":"            vm2.subport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":333,"context_line":"            servers\u003d[vm1, vm2])"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.cold_migration,"},{"line_number":336,"context_line":"                          \u0027Cold migration is not available.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"0e46deea_abb98227","line":333,"in_reply_to":"c636db10_b79ee602","updated":"2021-01-20 15:47:16.000000000","message":"Ack","commit_id":"8c0c8153dfe6eda832b05f18394e183c5f8c5ba5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b131e2968fd83c581686a0885441adfd705e810d","unresolved":true,"context_lines":[{"line_number":127,"context_line":"                vms[1].subport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":128,"context_line":"                should_succeed\u003dshould_succeed)"},{"line_number":129,"context_line":"        except Exception as ex:"},{"line_number":130,"context_line":"            raise ex"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def _create_server_port(self, network\u003dNone, **params):"},{"line_number":133,"context_line":"        network \u003d network or self.network"}],"source_content_type":"text/x-python","patch_set":6,"id":"f5e80094_ff3550ee","line":130,"updated":"2021-01-26 11:30:01.000000000","message":"You don\u0027t need to handle and reraise exceptions here. check_remote_connectivity() will raise assertion error if connectivity will fail. See: https://github.com/openstack/neutron-tempest-plugin/blob/7520dba32f9b166187c6d7e1faa341b11e8b8bf4/neutron_tempest_plugin/scenario/base.py#L394","commit_id":"22b87dccfcd4821f52dca73513a56a1a13abb9fe"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1539ad3381617edb7754555fac721ec05614f4bd","unresolved":true,"context_lines":[{"line_number":293,"context_line":"        self.check_remote_connectivity("},{"line_number":294,"context_line":"            vm1.ssh_client,"},{"line_number":295,"context_line":"            vm2.subport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":296,"context_line":"            servers\u003d[vm1, vm2])"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.cold_migration,"},{"line_number":299,"context_line":"                          \u0027Cold migration is not available.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"6163e959_523e467d","side":"PARENT","line":296,"range":{"start_line":296,"start_character":12,"end_line":296,"end_character":30},"updated":"2021-02-03 12:18:23.000000000","message":"This is missing in \"_check_servers_remote_connectivity\".\n\nI know that was a requirement in a previous PS [1], but I see no benefit on this new method \"_check_servers_remote_connectivity\".\n\n[1]https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/769714/4/neutron_tempest_plugin/scenario/test_trunk.py#333","commit_id":"a45e0ba48bb9f1fab8664e96572256d0189801bd"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"06d9a2cad98d710a4089e14769dc441f782eccce","unresolved":true,"context_lines":[{"line_number":293,"context_line":"        self.check_remote_connectivity("},{"line_number":294,"context_line":"            vm1.ssh_client,"},{"line_number":295,"context_line":"            vm2.subport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":296,"context_line":"            servers\u003d[vm1, vm2])"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.cold_migration,"},{"line_number":299,"context_line":"                          \u0027Cold migration is not available.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"c0ab1d58_5f26358f","side":"PARENT","line":296,"range":{"start_line":296,"start_character":12,"end_line":296,"end_character":30},"in_reply_to":"6163e959_523e467d","updated":"2021-02-03 12:41:13.000000000","message":"\u003e This is missing in \"_check_servers_remote_connectivity\".\n\nI do not understand first comment, please explain:\n\nsee this:\n\n    def _check_servers_remote_connectivity(self, vms\u003dNone,\n                                           should_succeed\u003dTrue):\n        self.check_remote_connectivity(\n            vms[0].ssh_client,\n            vms[1].subport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],\n            should_succeed\u003dshould_succeed)\n\n\n\u003e \n\u003e I know that was a requirement in a previous PS [1], but I see no benefit on this new method \"_check_servers_remote_connectivity\".\n\nI can see the benefit, from code code reuse perspective\nIs it a must have from your perspective?\n\u003e \n\u003e [1]https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/769714/4/neutron_tempest_plugin/scenario/test_trunk.py#333","commit_id":"a45e0ba48bb9f1fab8664e96572256d0189801bd"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"ece6f9da197338ee45b6b7c8595cc1457c17f557","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        self.check_remote_connectivity("},{"line_number":294,"context_line":"            vm1.ssh_client,"},{"line_number":295,"context_line":"            vm2.subport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":296,"context_line":"            servers\u003d[vm1, vm2])"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.cold_migration,"},{"line_number":299,"context_line":"                          \u0027Cold migration is not available.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"cca03729_0892c617","side":"PARENT","line":296,"range":{"start_line":296,"start_character":12,"end_line":296,"end_character":30},"in_reply_to":"653e1ebb_313fc066","updated":"2021-02-04 11:43:17.000000000","message":"Ack","commit_id":"a45e0ba48bb9f1fab8664e96572256d0189801bd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ae8490516cff3d71cde0100a6017d038c91d61c9","unresolved":true,"context_lines":[{"line_number":293,"context_line":"        self.check_remote_connectivity("},{"line_number":294,"context_line":"            vm1.ssh_client,"},{"line_number":295,"context_line":"            vm2.subport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":296,"context_line":"            servers\u003d[vm1, vm2])"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.cold_migration,"},{"line_number":299,"context_line":"                          \u0027Cold migration is not available.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"653e1ebb_313fc066","side":"PARENT","line":296,"range":{"start_line":296,"start_character":12,"end_line":296,"end_character":30},"in_reply_to":"c0ab1d58_5f26358f","updated":"2021-02-04 11:04:07.000000000","message":"There is no code reuse if you are just wrapping a method.\n\nThe parameter \"servers\u003d[vm1, vm2]\" is missing in \"check_remote_connectivity\" call inside \"_check_servers_remote_connectivity\".","commit_id":"a45e0ba48bb9f1fab8664e96572256d0189801bd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1539ad3381617edb7754555fac721ec05614f4bd","unresolved":true,"context_lines":[{"line_number":291,"context_line":"        use_advanced_image \u003d ("},{"line_number":292,"context_line":"            not CONF.neutron_plugin_options.default_image_is_advanced)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        vms \u003d \\"},{"line_number":295,"context_line":"            self._create_servers_with_trunk_port("},{"line_number":296,"context_line":"                num_servers\u003d2,"},{"line_number":297,"context_line":"                subport_network\u003dvlan_network,"}],"source_content_type":"text/x-python","patch_set":7,"id":"295c4bdc_5f512080","line":294,"range":{"start_line":294,"start_character":14,"end_line":294,"end_character":15},"updated":"2021-02-03 12:18:23.000000000","message":"nit: unneeded","commit_id":"04986c22a9d469d867f020fa825909b2f11dae73"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"06d9a2cad98d710a4089e14769dc441f782eccce","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        use_advanced_image \u003d ("},{"line_number":292,"context_line":"            not CONF.neutron_plugin_options.default_image_is_advanced)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        vms \u003d \\"},{"line_number":295,"context_line":"            self._create_servers_with_trunk_port("},{"line_number":296,"context_line":"                num_servers\u003d2,"},{"line_number":297,"context_line":"                subport_network\u003dvlan_network,"}],"source_content_type":"text/x-python","patch_set":7,"id":"f719b365_34c73f2d","line":294,"range":{"start_line":294,"start_character":14,"end_line":294,"end_character":15},"in_reply_to":"295c4bdc_5f512080","updated":"2021-02-03 12:41:13.000000000","message":"Ack","commit_id":"04986c22a9d469d867f020fa825909b2f11dae73"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1539ad3381617edb7754555fac721ec05614f4bd","unresolved":true,"context_lines":[{"line_number":306,"context_line":"        # check remote connectivity true before reboots"},{"line_number":307,"context_line":"        self._check_servers_remote_connectivity(vms\u003dvms)"},{"line_number":308,"context_line":"        client \u003d self.os_tempest.compute.ServersClient()"},{"line_number":309,"context_line":"        for _ in range(0, CONF.neutron_plugin_options.reboots_in_test):"},{"line_number":310,"context_line":"            client.reboot_server(vms[1].server[\u0027id\u0027],"},{"line_number":311,"context_line":"                                 **{\u0027type\u0027: \u0027SOFT\u0027})"},{"line_number":312,"context_line":"            self.wait_for_server_active(vms[1].server)"}],"source_content_type":"text/x-python","patch_set":7,"id":"56904908_a2f41a6a","line":309,"range":{"start_line":309,"start_character":17,"end_line":309,"end_character":70},"updated":"2021-02-03 12:18:23.000000000","message":"nit: range(CONF.neutron_plugin_options.reboots_in_test)","commit_id":"04986c22a9d469d867f020fa825909b2f11dae73"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"06d9a2cad98d710a4089e14769dc441f782eccce","unresolved":true,"context_lines":[{"line_number":306,"context_line":"        # check remote connectivity true before reboots"},{"line_number":307,"context_line":"        self._check_servers_remote_connectivity(vms\u003dvms)"},{"line_number":308,"context_line":"        client \u003d self.os_tempest.compute.ServersClient()"},{"line_number":309,"context_line":"        for _ in range(0, CONF.neutron_plugin_options.reboots_in_test):"},{"line_number":310,"context_line":"            client.reboot_server(vms[1].server[\u0027id\u0027],"},{"line_number":311,"context_line":"                                 **{\u0027type\u0027: \u0027SOFT\u0027})"},{"line_number":312,"context_line":"            self.wait_for_server_active(vms[1].server)"}],"source_content_type":"text/x-python","patch_set":7,"id":"e5a7e97b_a9e95d46","line":309,"range":{"start_line":309,"start_character":17,"end_line":309,"end_character":70},"in_reply_to":"56904908_a2f41a6a","updated":"2021-02-03 12:41:13.000000000","message":"Ack","commit_id":"04986c22a9d469d867f020fa825909b2f11dae73"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bd448538e5c45f04ec3c3c7ce66c10ad47a553a7","unresolved":true,"context_lines":[{"line_number":122,"context_line":"                                           should_succeed\u003dTrue):"},{"line_number":123,"context_line":"        servers \u003d None"},{"line_number":124,"context_line":"        if should_succeed:"},{"line_number":125,"context_line":"            servers \u003d vms"},{"line_number":126,"context_line":"        self.check_remote_connectivity("},{"line_number":127,"context_line":"            vms[0].ssh_client,"},{"line_number":128,"context_line":"            vms[1].subport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"21999819_74b3b94f","line":125,"updated":"2021-02-11 13:38:40.000000000","message":"why is that? Why You don\u0027t want to pass \"servers\" in case when should_succeed\u003dFalse?","commit_id":"fb1dd711cbde7b4bee168ead19b41a610ef9b04c"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"6c9996ae193dc737067aeebd5a89724e6807dd67","unresolved":true,"context_lines":[{"line_number":122,"context_line":"                                           should_succeed\u003dTrue):"},{"line_number":123,"context_line":"        servers \u003d None"},{"line_number":124,"context_line":"        if should_succeed:"},{"line_number":125,"context_line":"            servers \u003d vms"},{"line_number":126,"context_line":"        self.check_remote_connectivity("},{"line_number":127,"context_line":"            vms[0].ssh_client,"},{"line_number":128,"context_line":"            vms[1].subport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"302ffc85_8d5f4c84","line":125,"in_reply_to":"21999819_74b3b94f","updated":"2021-02-11 14:19:56.000000000","message":"Ack you are correct, silly me","commit_id":"fb1dd711cbde7b4bee168ead19b41a610ef9b04c"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"ba2f23c22217c31fad53a321d82ae5ad42aa4137","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                                           should_succeed\u003dTrue):"},{"line_number":123,"context_line":"        servers \u003d None"},{"line_number":124,"context_line":"        if should_succeed:"},{"line_number":125,"context_line":"            servers \u003d vms"},{"line_number":126,"context_line":"        self.check_remote_connectivity("},{"line_number":127,"context_line":"            vms[0].ssh_client,"},{"line_number":128,"context_line":"            vms[1].subport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"83f68061_ee879478","line":125,"in_reply_to":"302ffc85_8d5f4c84","updated":"2021-02-11 17:08:24.000000000","message":"Ack","commit_id":"fb1dd711cbde7b4bee168ead19b41a610ef9b04c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bd448538e5c45f04ec3c3c7ce66c10ad47a553a7","unresolved":true,"context_lines":[{"line_number":285,"context_line":"         CONF.neutron_plugin_options.default_image_is_advanced),"},{"line_number":286,"context_line":"        \"Advanced image is required to run this test.\")"},{"line_number":287,"context_line":"    @testtools.skipUnless("},{"line_number":288,"context_line":"         (CONF.neutron_plugin_options.reboots_in_test \u003e 0),"},{"line_number":289,"context_line":"         \"Number of reboots \u003e 0 is reqired for this test\")"},{"line_number":290,"context_line":"    @decorators.idempotent_id(\u0027a8a02c9b-b453-49b5-89a2-cce7da6680fb\u0027)"},{"line_number":291,"context_line":"    def test_subport_connectivity_reboot(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"e2150561_3bbc1c42","line":288,"range":{"start_line":288,"start_character":38,"end_line":288,"end_character":53},"updated":"2021-02-11 13:38:40.000000000","message":"this name is pretty generic but as for now this is the only test which is doing that so I\u0027m ok with that name. I hope it can be reused in future tests if needed too :)","commit_id":"fb1dd711cbde7b4bee168ead19b41a610ef9b04c"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"6c9996ae193dc737067aeebd5a89724e6807dd67","unresolved":false,"context_lines":[{"line_number":285,"context_line":"         CONF.neutron_plugin_options.default_image_is_advanced),"},{"line_number":286,"context_line":"        \"Advanced image is required to run this test.\")"},{"line_number":287,"context_line":"    @testtools.skipUnless("},{"line_number":288,"context_line":"         (CONF.neutron_plugin_options.reboots_in_test \u003e 0),"},{"line_number":289,"context_line":"         \"Number of reboots \u003e 0 is reqired for this test\")"},{"line_number":290,"context_line":"    @decorators.idempotent_id(\u0027a8a02c9b-b453-49b5-89a2-cce7da6680fb\u0027)"},{"line_number":291,"context_line":"    def test_subport_connectivity_reboot(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"8fcba953_ad63b5c9","line":288,"range":{"start_line":288,"start_character":38,"end_line":288,"end_character":53},"in_reply_to":"e2150561_3bbc1c42","updated":"2021-02-11 14:19:56.000000000","message":"Ack","commit_id":"fb1dd711cbde7b4bee168ead19b41a610ef9b04c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bd448538e5c45f04ec3c3c7ce66c10ad47a553a7","unresolved":true,"context_lines":[{"line_number":305,"context_line":"        sg_rule \u003d self.create_pingable_secgroup_rule(self.security_group[\u0027id\u0027])"},{"line_number":306,"context_line":"        self.addCleanup("},{"line_number":307,"context_line":"                self.os_primary.network_client.delete_security_group_rule,"},{"line_number":308,"context_line":"                sg_rule[\u0027id\u0027])"},{"line_number":309,"context_line":"        # check remote connectivity true before reboots"},{"line_number":310,"context_line":"        self._check_servers_remote_connectivity(vms\u003dvms)"},{"line_number":311,"context_line":"        client \u003d self.os_tempest.compute.ServersClient()"}],"source_content_type":"text/x-python","patch_set":8,"id":"b90628b7_982b72cc","line":308,"range":{"start_line":308,"start_character":8,"end_line":308,"end_character":16},"updated":"2021-02-11 13:38:40.000000000","message":"nit: why those indentations are 8 spaces, not 4?\nAnd also, is this cleanup really needed? Wouldn\u0027t that be cleaned when self.security_group will be deleted?\nAnd 3rd thing - why this isn\u0027t done before VMs are created, e.g. in setUp method?","commit_id":"fb1dd711cbde7b4bee168ead19b41a610ef9b04c"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"ba2f23c22217c31fad53a321d82ae5ad42aa4137","unresolved":true,"context_lines":[{"line_number":305,"context_line":"        sg_rule \u003d self.create_pingable_secgroup_rule(self.security_group[\u0027id\u0027])"},{"line_number":306,"context_line":"        self.addCleanup("},{"line_number":307,"context_line":"                self.os_primary.network_client.delete_security_group_rule,"},{"line_number":308,"context_line":"                sg_rule[\u0027id\u0027])"},{"line_number":309,"context_line":"        # check remote connectivity true before reboots"},{"line_number":310,"context_line":"        self._check_servers_remote_connectivity(vms\u003dvms)"},{"line_number":311,"context_line":"        client \u003d self.os_tempest.compute.ServersClient()"}],"source_content_type":"text/x-python","patch_set":8,"id":"c2e691ef_1594b561","line":308,"range":{"start_line":308,"start_character":8,"end_line":308,"end_character":16},"in_reply_to":"b33766a9_9d6defeb","updated":"2021-02-11 17:08:24.000000000","message":"\u003e \u003e nit: why those indentations are 8 spaces, not 4?\n\u003e Thanks. was counting on tox :/\n\u003e \n\u003e \u003e And also, is this cleanup really needed? Wouldn\u0027t that be cleaned when self.security_group will be deleted?\n\u003e \u003e And 3rd thing - why this isn\u0027t done before VMs are created, e.g. in setUp method?\n\u003e Ack\n\nThis i interesting\nI see this method in setup method, are you suggesting \nto save the rule as self.rule? and fix all tests calling this method?\nSince it is already called, it could eliminate the call done in all other tests,\n\nWould you recommend doing so?","commit_id":"fb1dd711cbde7b4bee168ead19b41a610ef9b04c"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"6c9996ae193dc737067aeebd5a89724e6807dd67","unresolved":true,"context_lines":[{"line_number":305,"context_line":"        sg_rule \u003d self.create_pingable_secgroup_rule(self.security_group[\u0027id\u0027])"},{"line_number":306,"context_line":"        self.addCleanup("},{"line_number":307,"context_line":"                self.os_primary.network_client.delete_security_group_rule,"},{"line_number":308,"context_line":"                sg_rule[\u0027id\u0027])"},{"line_number":309,"context_line":"        # check remote connectivity true before reboots"},{"line_number":310,"context_line":"        self._check_servers_remote_connectivity(vms\u003dvms)"},{"line_number":311,"context_line":"        client \u003d self.os_tempest.compute.ServersClient()"}],"source_content_type":"text/x-python","patch_set":8,"id":"b33766a9_9d6defeb","line":308,"range":{"start_line":308,"start_character":8,"end_line":308,"end_character":16},"in_reply_to":"b90628b7_982b72cc","updated":"2021-02-11 14:19:56.000000000","message":"\u003e nit: why those indentations are 8 spaces, not 4?\nThanks. was counting on tox :/\n\n\u003e And also, is this cleanup really needed? Wouldn\u0027t that be cleaned when self.security_group will be deleted?\n\u003e And 3rd thing - why this isn\u0027t done before VMs are created, e.g. in setUp method?\nAck","commit_id":"fb1dd711cbde7b4bee168ead19b41a610ef9b04c"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"a0f3cea8b05dbcfe4c544c27e396236180f22f42","unresolved":true,"context_lines":[{"line_number":305,"context_line":"        sg_rule \u003d self.create_pingable_secgroup_rule(self.security_group[\u0027id\u0027])"},{"line_number":306,"context_line":"        self.addCleanup("},{"line_number":307,"context_line":"                self.os_primary.network_client.delete_security_group_rule,"},{"line_number":308,"context_line":"                sg_rule[\u0027id\u0027])"},{"line_number":309,"context_line":"        # check remote connectivity true before reboots"},{"line_number":310,"context_line":"        self._check_servers_remote_connectivity(vms\u003dvms)"},{"line_number":311,"context_line":"        client \u003d self.os_tempest.compute.ServersClient()"}],"source_content_type":"text/x-python","patch_set":8,"id":"d7a28adb_7c59a84d","line":308,"range":{"start_line":308,"start_character":8,"end_line":308,"end_character":16},"in_reply_to":"c2e691ef_1594b561","updated":"2021-02-17 14:28:55.000000000","message":"\u003e And also, is this cleanup really needed? Wouldn\u0027t that be cleaned when self.security_group will be deleted?\n\nThat is test run dependant.\nIf the whole class is called, one setup method will be called once, am i wrong?\nso each test should destroy the new rules it added for the test, is nt it?","commit_id":"fb1dd711cbde7b4bee168ead19b41a610ef9b04c"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"6c9996ae193dc737067aeebd5a89724e6807dd67","unresolved":true,"context_lines":[{"line_number":329,"context_line":"        use_advanced_image \u003d ("},{"line_number":330,"context_line":"            not CONF.neutron_plugin_options.default_image_is_advanced)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        vms \u003d \\"},{"line_number":333,"context_line":"            self._create_servers_with_trunk_port("},{"line_number":334,"context_line":"                num_servers\u003d2,"},{"line_number":335,"context_line":"                subport_network\u003dvlan_network,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fb51c2a6_cfb1c720","line":332,"range":{"start_line":332,"start_character":14,"end_line":332,"end_character":15},"updated":"2021-02-11 14:19:56.000000000","message":"I have to remove this also :/","commit_id":"fb1dd711cbde7b4bee168ead19b41a610ef9b04c"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"ba2f23c22217c31fad53a321d82ae5ad42aa4137","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        use_advanced_image \u003d ("},{"line_number":330,"context_line":"            not CONF.neutron_plugin_options.default_image_is_advanced)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        vms \u003d \\"},{"line_number":333,"context_line":"            self._create_servers_with_trunk_port("},{"line_number":334,"context_line":"                num_servers\u003d2,"},{"line_number":335,"context_line":"                subport_network\u003dvlan_network,"}],"source_content_type":"text/x-python","patch_set":8,"id":"61ec66e9_cc4d17f6","line":332,"range":{"start_line":332,"start_character":14,"end_line":332,"end_character":15},"in_reply_to":"fb51c2a6_cfb1c720","updated":"2021-02-11 17:08:24.000000000","message":"Ack","commit_id":"fb1dd711cbde7b4bee168ead19b41a610ef9b04c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d131eb773057ff30a44253e4e1b64c4294ad9e90","unresolved":true,"context_lines":[{"line_number":101,"context_line":"                                        subport_network\u003dNone,"},{"line_number":102,"context_line":"                                        segmentation_id\u003dNone,"},{"line_number":103,"context_line":"                                        vlan_subnet\u003dNone,"},{"line_number":104,"context_line":"                                        use_advanced_image\u003dFalse):"},{"line_number":105,"context_line":"        server_list \u003d []"},{"line_number":106,"context_line":"        for _ in range(0, num_servers):"},{"line_number":107,"context_line":"            vm \u003d self._create_server_with_trunk_port("}],"source_content_type":"text/x-python","patch_set":9,"id":"bd69b986_97794bfe","line":104,"range":{"start_line":104,"start_character":40,"end_line":104,"end_character":64},"updated":"2021-02-12 08:52:48.000000000","message":"nit: just too keep the signature simple and your test anyway depends on advanced image (l281.) remove this param, and call _create_server_with_trunk_port with use_advanced_image\u003dTrue, what do you think?","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e22c3b3a07dba952f8f3c64ba5598d1fb396dd13","unresolved":true,"context_lines":[{"line_number":101,"context_line":"                                        subport_network\u003dNone,"},{"line_number":102,"context_line":"                                        segmentation_id\u003dNone,"},{"line_number":103,"context_line":"                                        vlan_subnet\u003dNone,"},{"line_number":104,"context_line":"                                        use_advanced_image\u003dFalse):"},{"line_number":105,"context_line":"        server_list \u003d []"},{"line_number":106,"context_line":"        for _ in range(0, num_servers):"},{"line_number":107,"context_line":"            vm \u003d self._create_server_with_trunk_port("}],"source_content_type":"text/x-python","patch_set":9,"id":"fe50547f_e0fa85bc","line":104,"range":{"start_line":104,"start_character":40,"end_line":104,"end_character":64},"in_reply_to":"256860b6_c9ced37b","updated":"2021-03-22 09:06:41.000000000","message":"I\u0027m ok to leave it as it\u0027s now, just for consistency with  _create_server_with_trunk_port().","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"6c9d3623a02cb4285120441590ab4e2a58e86b85","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                                        subport_network\u003dNone,"},{"line_number":102,"context_line":"                                        segmentation_id\u003dNone,"},{"line_number":103,"context_line":"                                        vlan_subnet\u003dNone,"},{"line_number":104,"context_line":"                                        use_advanced_image\u003dFalse):"},{"line_number":105,"context_line":"        server_list \u003d []"},{"line_number":106,"context_line":"        for _ in range(0, num_servers):"},{"line_number":107,"context_line":"            vm \u003d self._create_server_with_trunk_port("}],"source_content_type":"text/x-python","patch_set":9,"id":"975297b7_5f5d18e2","line":104,"range":{"start_line":104,"start_character":40,"end_line":104,"end_character":64},"in_reply_to":"2e8ccc83_61efb600","updated":"2021-02-17 14:16:26.000000000","message":"Done","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"eacae528534821c924b69a2f8c80dbba05ecb9b9","unresolved":true,"context_lines":[{"line_number":101,"context_line":"                                        subport_network\u003dNone,"},{"line_number":102,"context_line":"                                        segmentation_id\u003dNone,"},{"line_number":103,"context_line":"                                        vlan_subnet\u003dNone,"},{"line_number":104,"context_line":"                                        use_advanced_image\u003dFalse):"},{"line_number":105,"context_line":"        server_list \u003d []"},{"line_number":106,"context_line":"        for _ in range(0, num_servers):"},{"line_number":107,"context_line":"            vm \u003d self._create_server_with_trunk_port("}],"source_content_type":"text/x-python","patch_set":9,"id":"256860b6_c9ced37b","line":104,"range":{"start_line":104,"start_character":40,"end_line":104,"end_character":64},"in_reply_to":"975297b7_5f5d18e2","updated":"2021-03-21 17:14:29.000000000","message":"Opening it, i found the following 😊\n\nAs per your suggestion, use_advanced_image in this method,\nThe problem is as following 😊\ndef _create_ssh_client(self, floating_ip, use_advanced_image\u003dFalse)\n\nif use_advanced_image\u003dTrue ssh use the following user\nCONF.neutron_plugin_options.advanced_image_ssh_user\nelse username \u003d CONF.validation.image_ssh_user\n\nIt seems that test is running and pass SUCCESS with use_advanced_image\u003dFalse\nIf i use use_advanced_image\u003dTrue, it is a must to add neutron_plugin_options.advanced_image_ssh_user, which is not the case by default\n\nAny suggestion here? i tend to keep the old code, it takes too much time","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"79edb666302c36655cc58325badeae4c29a6ccfa","unresolved":true,"context_lines":[{"line_number":101,"context_line":"                                        subport_network\u003dNone,"},{"line_number":102,"context_line":"                                        segmentation_id\u003dNone,"},{"line_number":103,"context_line":"                                        vlan_subnet\u003dNone,"},{"line_number":104,"context_line":"                                        use_advanced_image\u003dFalse):"},{"line_number":105,"context_line":"        server_list \u003d []"},{"line_number":106,"context_line":"        for _ in range(0, num_servers):"},{"line_number":107,"context_line":"            vm \u003d self._create_server_with_trunk_port("}],"source_content_type":"text/x-python","patch_set":9,"id":"2e8ccc83_61efb600","line":104,"range":{"start_line":104,"start_character":40,"end_line":104,"end_character":64},"in_reply_to":"999b1eec_1bbc8c9d","updated":"2021-02-17 13:57:57.000000000","message":"Thanks for clarifying\nSo the following tests calling this method _create_servers_with_trunk_port:\ntest_subport_connectivity_reboot\ntest_subport_connectivity\n\nboth of them use the following:\n        (CONF.neutron_plugin_options.advanced_image_ref or\n         CONF.neutron_plugin_options.default_image_is_advanced),\n\nso it is not needed, ack","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"061ffa35e30715259985eb81db615da6b6772a88","unresolved":true,"context_lines":[{"line_number":101,"context_line":"                                        subport_network\u003dNone,"},{"line_number":102,"context_line":"                                        segmentation_id\u003dNone,"},{"line_number":103,"context_line":"                                        vlan_subnet\u003dNone,"},{"line_number":104,"context_line":"                                        use_advanced_image\u003dFalse):"},{"line_number":105,"context_line":"        server_list \u003d []"},{"line_number":106,"context_line":"        for _ in range(0, num_servers):"},{"line_number":107,"context_line":"            vm \u003d self._create_server_with_trunk_port("}],"source_content_type":"text/x-python","patch_set":9,"id":"db893f6c_14871cdc","line":104,"range":{"start_line":104,"start_character":40,"end_line":104,"end_character":64},"in_reply_to":"bd69b986_97794bfe","updated":"2021-02-16 17:32:36.000000000","message":"\u003e nit: just too keep the signature simple and your test anyway depends on advanced image (l281.) remove this param, and call _create_server_with_trunk_port with use_advanced_image\u003dTrue, what do you think?\n\nI think i get you, but are you suggesting to remove it here also 😕\nPlease refer comment (l303.)","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"66b64a3edcf0769e2f28f135e5938dc72383cb2d","unresolved":true,"context_lines":[{"line_number":101,"context_line":"                                        subport_network\u003dNone,"},{"line_number":102,"context_line":"                                        segmentation_id\u003dNone,"},{"line_number":103,"context_line":"                                        vlan_subnet\u003dNone,"},{"line_number":104,"context_line":"                                        use_advanced_image\u003dFalse):"},{"line_number":105,"context_line":"        server_list \u003d []"},{"line_number":106,"context_line":"        for _ in range(0, num_servers):"},{"line_number":107,"context_line":"            vm \u003d self._create_server_with_trunk_port("}],"source_content_type":"text/x-python","patch_set":9,"id":"999b1eec_1bbc8c9d","line":104,"range":{"start_line":104,"start_character":40,"end_line":104,"end_character":64},"in_reply_to":"db893f6c_14871cdc","updated":"2021-02-17 13:24:44.000000000","message":"exactly: for connectivity testing you need anyway advanced image, so don\u0027t pass this use_advanced_image from method to method.","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"a7832cc586831b4ec3d0d216d558153aba1b679e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                                        subport_network\u003dNone,"},{"line_number":102,"context_line":"                                        segmentation_id\u003dNone,"},{"line_number":103,"context_line":"                                        vlan_subnet\u003dNone,"},{"line_number":104,"context_line":"                                        use_advanced_image\u003dFalse):"},{"line_number":105,"context_line":"        server_list \u003d []"},{"line_number":106,"context_line":"        for _ in range(0, num_servers):"},{"line_number":107,"context_line":"            vm \u003d self._create_server_with_trunk_port("}],"source_content_type":"text/x-python","patch_set":9,"id":"25ce9a76_d5d37e7d","line":104,"range":{"start_line":104,"start_character":40,"end_line":104,"end_character":64},"in_reply_to":"fe50547f_e0fa85bc","updated":"2021-03-22 13:20:30.000000000","message":"Ack","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d131eb773057ff30a44253e4e1b64c4294ad9e90","unresolved":true,"context_lines":[{"line_number":285,"context_line":"         (CONF.neutron_plugin_options.reboots_in_test \u003e 0),"},{"line_number":286,"context_line":"         \"Number of reboots \u003e 0 is reqired for this test\")"},{"line_number":287,"context_line":"    @decorators.idempotent_id(\u0027a8a02c9b-b453-49b5-89a2-cce7da6680fb\u0027)"},{"line_number":288,"context_line":"    def test_subport_connectivity_reboot(self):"},{"line_number":289,"context_line":"        vlan_tag \u003d 10"},{"line_number":290,"context_line":"        vlan_network \u003d self.create_network()"},{"line_number":291,"context_line":"        vlan_subnet \u003d self.create_subnet(network\u003dvlan_network, gateway\u003dNone)"}],"source_content_type":"text/x-python","patch_set":9,"id":"a8716a90_72e41ce1","line":288,"range":{"start_line":288,"start_character":8,"end_line":288,"end_character":40},"updated":"2021-02-12 08:52:48.000000000","message":"To make it clear test_subport_connectivity_soft_reboot","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"061ffa35e30715259985eb81db615da6b6772a88","unresolved":false,"context_lines":[{"line_number":285,"context_line":"         (CONF.neutron_plugin_options.reboots_in_test \u003e 0),"},{"line_number":286,"context_line":"         \"Number of reboots \u003e 0 is reqired for this test\")"},{"line_number":287,"context_line":"    @decorators.idempotent_id(\u0027a8a02c9b-b453-49b5-89a2-cce7da6680fb\u0027)"},{"line_number":288,"context_line":"    def test_subport_connectivity_reboot(self):"},{"line_number":289,"context_line":"        vlan_tag \u003d 10"},{"line_number":290,"context_line":"        vlan_network \u003d self.create_network()"},{"line_number":291,"context_line":"        vlan_subnet \u003d self.create_subnet(network\u003dvlan_network, gateway\u003dNone)"}],"source_content_type":"text/x-python","patch_set":9,"id":"56451436_353aa384","line":288,"range":{"start_line":288,"start_character":8,"end_line":288,"end_character":40},"in_reply_to":"a8716a90_72e41ce1","updated":"2021-02-16 17:32:36.000000000","message":"Ack","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d131eb773057ff30a44253e4e1b64c4294ad9e90","unresolved":true,"context_lines":[{"line_number":289,"context_line":"        vlan_tag \u003d 10"},{"line_number":290,"context_line":"        vlan_network \u003d self.create_network()"},{"line_number":291,"context_line":"        vlan_subnet \u003d self.create_subnet(network\u003dvlan_network, gateway\u003dNone)"},{"line_number":292,"context_line":"        use_advanced_image \u003d ("},{"line_number":293,"context_line":"            not CONF.neutron_plugin_options.default_image_is_advanced)"},{"line_number":294,"context_line":"        sg_rule \u003d self.create_pingable_secgroup_rule(self.security_group[\u0027id\u0027])"},{"line_number":295,"context_line":"        self.addCleanup("},{"line_number":296,"context_line":"            self.os_primary.network_client.delete_security_group_rule,"}],"source_content_type":"text/x-python","patch_set":9,"id":"a0e207e6_cc031d98","line":293,"range":{"start_line":292,"start_character":8,"end_line":293,"end_character":70},"updated":"2021-02-12 08:52:48.000000000","message":"You skip the test if there is no advanced image so this is useless, as I wrote above (l104)","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"6c9d3623a02cb4285120441590ab4e2a58e86b85","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        vlan_tag \u003d 10"},{"line_number":290,"context_line":"        vlan_network \u003d self.create_network()"},{"line_number":291,"context_line":"        vlan_subnet \u003d self.create_subnet(network\u003dvlan_network, gateway\u003dNone)"},{"line_number":292,"context_line":"        use_advanced_image \u003d ("},{"line_number":293,"context_line":"            not CONF.neutron_plugin_options.default_image_is_advanced)"},{"line_number":294,"context_line":"        sg_rule \u003d self.create_pingable_secgroup_rule(self.security_group[\u0027id\u0027])"},{"line_number":295,"context_line":"        self.addCleanup("},{"line_number":296,"context_line":"            self.os_primary.network_client.delete_security_group_rule,"}],"source_content_type":"text/x-python","patch_set":9,"id":"b1b626cd_dcc8a138","line":293,"range":{"start_line":292,"start_character":8,"end_line":293,"end_character":70},"in_reply_to":"7953befd_8eed7913","updated":"2021-02-17 14:16:26.000000000","message":"Done","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"061ffa35e30715259985eb81db615da6b6772a88","unresolved":true,"context_lines":[{"line_number":289,"context_line":"        vlan_tag \u003d 10"},{"line_number":290,"context_line":"        vlan_network \u003d self.create_network()"},{"line_number":291,"context_line":"        vlan_subnet \u003d self.create_subnet(network\u003dvlan_network, gateway\u003dNone)"},{"line_number":292,"context_line":"        use_advanced_image \u003d ("},{"line_number":293,"context_line":"            not CONF.neutron_plugin_options.default_image_is_advanced)"},{"line_number":294,"context_line":"        sg_rule \u003d self.create_pingable_secgroup_rule(self.security_group[\u0027id\u0027])"},{"line_number":295,"context_line":"        self.addCleanup("},{"line_number":296,"context_line":"            self.os_primary.network_client.delete_security_group_rule,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7953befd_8eed7913","line":293,"range":{"start_line":292,"start_character":8,"end_line":293,"end_character":70},"in_reply_to":"a0e207e6_cc031d98","updated":"2021-02-16 17:32:36.000000000","message":"Ack,\nIt is called if one of the two, \n CONF.neutron_plugin_options.default_image_is_advanced\n CONF.neutron_plugin_options.advanced_image_ref","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"061ffa35e30715259985eb81db615da6b6772a88","unresolved":true,"context_lines":[{"line_number":300,"context_line":"            subport_network\u003dvlan_network,"},{"line_number":301,"context_line":"            segmentation_id\u003dvlan_tag,"},{"line_number":302,"context_line":"            vlan_subnet\u003dvlan_subnet,"},{"line_number":303,"context_line":"            use_advanced_image\u003duse_advanced_image)"},{"line_number":304,"context_line":"        # allow intra-security-group traffic"},{"line_number":305,"context_line":"        # check remote connectivity true before reboots"},{"line_number":306,"context_line":"        self._check_servers_remote_connectivity(vms\u003dvms)"}],"source_content_type":"text/x-python","patch_set":9,"id":"afc4676f_58a3772e","line":303,"range":{"start_line":303,"start_character":12,"end_line":303,"end_character":49},"updated":"2021-02-16 17:32:36.000000000","message":"@Lajos\nLGTMT, ..use_advanced_image\u003dTRUE)","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"6c9d3623a02cb4285120441590ab4e2a58e86b85","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            subport_network\u003dvlan_network,"},{"line_number":301,"context_line":"            segmentation_id\u003dvlan_tag,"},{"line_number":302,"context_line":"            vlan_subnet\u003dvlan_subnet,"},{"line_number":303,"context_line":"            use_advanced_image\u003duse_advanced_image)"},{"line_number":304,"context_line":"        # allow intra-security-group traffic"},{"line_number":305,"context_line":"        # check remote connectivity true before reboots"},{"line_number":306,"context_line":"        self._check_servers_remote_connectivity(vms\u003dvms)"}],"source_content_type":"text/x-python","patch_set":9,"id":"0915eaec_9146b94d","line":303,"range":{"start_line":303,"start_character":12,"end_line":303,"end_character":49},"in_reply_to":"afc4676f_58a3772e","updated":"2021-02-17 14:16:26.000000000","message":"Done","commit_id":"b11cf83b8a36eb4bae806a2c769f1c98ef6322a2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1c17ed4b99afc5e5245e44fff93f52e9c4ff502b","unresolved":true,"context_lines":[{"line_number":275,"context_line":"            self._wait_for_trunk(vm.trunk)"},{"line_number":276,"context_line":"            self._assert_has_ssh_connectivity(vm1.ssh_client)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    @test.unstable_test(\"bug 1869244\")"},{"line_number":279,"context_line":"    @testtools.skipUnless("},{"line_number":280,"context_line":"        (CONF.neutron_plugin_options.advanced_image_ref or"},{"line_number":281,"context_line":"         CONF.neutron_plugin_options.default_image_is_advanced),"}],"source_content_type":"text/x-python","patch_set":11,"id":"0c014d57_ae81b6c6","line":278,"updated":"2021-02-18 08:29:25.000000000","message":"this test has some issue probably and due to this decorator it is skipped in tests results. Please see e.g. in https://7ce453a5d206c7c463f3-57fb9c0e693945c47fbc306535c3cca3.ssl.cf1.rackcdn.com/769714/11/check/neutron-tempest-plugin-scenario-openvswitch/3eb62f1/job-output.txt - skip message is like:\n\n    SKIPPED: neutron_tempest_plugin.scenario.test_trunk.TrunkTest.test_subport_connectivity_soft_reboot[id-a8a02c9b-b453-49b5-89a2-cce7da6680fb] was marked as unstable because of bug 1869244, failure was: \u0027ServerWithTrunkPort\u0027 object has no attribute \u0027get\u0027","commit_id":"e6fae2dc284c4cebc5cfb0e8b205bdeb41079242"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"8289ce29c929ac5410090aadf9d5a8de35c4d077","unresolved":true,"context_lines":[{"line_number":275,"context_line":"            self._wait_for_trunk(vm.trunk)"},{"line_number":276,"context_line":"            self._assert_has_ssh_connectivity(vm1.ssh_client)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    @test.unstable_test(\"bug 1869244\")"},{"line_number":279,"context_line":"    @testtools.skipUnless("},{"line_number":280,"context_line":"        (CONF.neutron_plugin_options.advanced_image_ref or"},{"line_number":281,"context_line":"         CONF.neutron_plugin_options.default_image_is_advanced),"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ae94201_ba7273c9","line":278,"in_reply_to":"0c014d57_ae81b6c6","updated":"2021-02-18 14:17:59.000000000","message":"I do not get it ServerWithTrunkPort is tuple.\nWhere did this get came from, i am using the same method from two tests 😮\nExcept to security group rule creation, i do not suspect that 😊","commit_id":"e6fae2dc284c4cebc5cfb0e8b205bdeb41079242"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"52d50a14516b9ba4f823338604adadca99a4227d","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            self._wait_for_trunk(vm.trunk)"},{"line_number":276,"context_line":"            self._assert_has_ssh_connectivity(vm1.ssh_client)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    @test.unstable_test(\"bug 1869244\")"},{"line_number":279,"context_line":"    @testtools.skipUnless("},{"line_number":280,"context_line":"        (CONF.neutron_plugin_options.advanced_image_ref or"},{"line_number":281,"context_line":"         CONF.neutron_plugin_options.default_image_is_advanced),"}],"source_content_type":"text/x-python","patch_set":11,"id":"687d8e5e_06e5469b","line":278,"in_reply_to":"3ae94201_ba7273c9","updated":"2021-02-22 07:29:10.000000000","message":"Got, the errors\nComparing the (l122) and (l302), i should parse dat different","commit_id":"e6fae2dc284c4cebc5cfb0e8b205bdeb41079242"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e22c3b3a07dba952f8f3c64ba5598d1fb396dd13","unresolved":true,"context_lines":[{"line_number":109,"context_line":"                segmentation_id,"},{"line_number":110,"context_line":"                use_advanced_image)"},{"line_number":111,"context_line":"            server_list.append(vm)"},{"line_number":112,"context_line":"            self.check_connectivity("},{"line_number":113,"context_line":"                host\u003dvm.floating_ip[\u0027floating_ip_address\u0027],"},{"line_number":114,"context_line":"                ssh_client\u003dvm.ssh_client)"},{"line_number":115,"context_line":"            self._configure_vlan_subport("}],"source_content_type":"text/x-python","patch_set":15,"id":"d4c13dae_f5bbbbc0","line":112,"updated":"2021-03-22 09:06:41.000000000","message":"sorry for late comment but I think that if You move this out of that loop, it could be faster, especially if You have more than one servers to create. Something like:\n\nfor _ in range(0, num_servers):\n    vm \u003d self._create_server_with_trunk_port(\n        subport_network,\n        segmentation_id,\n        use_advanced_image)\n    server_list.append(vm)\n    self._configure_vlan_subport(\n        vm\u003dvm,\n        vlan_tag\u003dsegmentation_id,\n        vlan_subnet\u003dvlan_subnet)\n\nfor server in server_list:\n    self.check_connectivity(\n        host\u003dserver.floating_ip[\u0027floating_ip_address\u0027],\n        ssh_client\u003dserver.ssh_client)\n\nAs it would first boot all servers and nova would be booting them as You would wait for connectivity for first of them.","commit_id":"dd719d5c976a394691f1706ce81e106fd79285f4"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"ce7a4114e6ef056199df0a5d290a407b81f2cb4a","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                segmentation_id,"},{"line_number":110,"context_line":"                use_advanced_image)"},{"line_number":111,"context_line":"            server_list.append(vm)"},{"line_number":112,"context_line":"            self.check_connectivity("},{"line_number":113,"context_line":"                host\u003dvm.floating_ip[\u0027floating_ip_address\u0027],"},{"line_number":114,"context_line":"                ssh_client\u003dvm.ssh_client)"},{"line_number":115,"context_line":"            self._configure_vlan_subport("}],"source_content_type":"text/x-python","patch_set":15,"id":"6905c01d_723b3540","line":112,"in_reply_to":"c217127f_8a769223","updated":"2021-03-22 16:14:14.000000000","message":"Ack","commit_id":"dd719d5c976a394691f1706ce81e106fd79285f4"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"a7832cc586831b4ec3d0d216d558153aba1b679e","unresolved":true,"context_lines":[{"line_number":109,"context_line":"                segmentation_id,"},{"line_number":110,"context_line":"                use_advanced_image)"},{"line_number":111,"context_line":"            server_list.append(vm)"},{"line_number":112,"context_line":"            self.check_connectivity("},{"line_number":113,"context_line":"                host\u003dvm.floating_ip[\u0027floating_ip_address\u0027],"},{"line_number":114,"context_line":"                ssh_client\u003dvm.ssh_client)"},{"line_number":115,"context_line":"            self._configure_vlan_subport("}],"source_content_type":"text/x-python","patch_set":15,"id":"c217127f_8a769223","line":112,"in_reply_to":"d4c13dae_f5bbbbc0","updated":"2021-03-22 13:20:30.000000000","message":"Opps, you are totally correct, +2","commit_id":"dd719d5c976a394691f1706ce81e106fd79285f4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e22c3b3a07dba952f8f3c64ba5598d1fb396dd13","unresolved":true,"context_lines":[{"line_number":331,"context_line":"            subport_network\u003dvlan_network,"},{"line_number":332,"context_line":"            segmentation_id\u003dvlan_tag,"},{"line_number":333,"context_line":"            vlan_subnet\u003dvlan_subnet,"},{"line_number":334,"context_line":"            use_advanced_image\u003duse_advanced_image)    "},{"line_number":335,"context_line":"        # Ping from server1 to server2 via VLAN interface should fail because"},{"line_number":336,"context_line":"        # we haven\u0027t allowed ICMP"},{"line_number":337,"context_line":"        self._check_servers_remote_connectivity(vms\u003dvms,"}],"source_content_type":"text/x-python","patch_set":15,"id":"f8da488e_6eaad628","line":334,"in_reply_to":"28029795_1b086ab5","updated":"2021-03-22 09:06:41.000000000","message":"\u003e pep8: W291 trailing whitespace\n\nPlease fix.","commit_id":"dd719d5c976a394691f1706ce81e106fd79285f4"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"ce7a4114e6ef056199df0a5d290a407b81f2cb4a","unresolved":false,"context_lines":[{"line_number":331,"context_line":"            subport_network\u003dvlan_network,"},{"line_number":332,"context_line":"            segmentation_id\u003dvlan_tag,"},{"line_number":333,"context_line":"            vlan_subnet\u003dvlan_subnet,"},{"line_number":334,"context_line":"            use_advanced_image\u003duse_advanced_image)    "},{"line_number":335,"context_line":"        # Ping from server1 to server2 via VLAN interface should fail because"},{"line_number":336,"context_line":"        # we haven\u0027t allowed ICMP"},{"line_number":337,"context_line":"        self._check_servers_remote_connectivity(vms\u003dvms,"}],"source_content_type":"text/x-python","patch_set":15,"id":"1bd5b386_91e83fda","line":334,"in_reply_to":"f8da488e_6eaad628","updated":"2021-03-22 16:14:14.000000000","message":"Ack","commit_id":"dd719d5c976a394691f1706ce81e106fd79285f4"}]}