)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7475eec12ceb4cab93ec6d1b919140da359f0829","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     ccamposr \u003cccamposr@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-02-12 12:26:08 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add skip funtion for checking enabled extensions in the l3 agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This function check the extension configured in the l3 network agent"},{"line_number":10,"context_line":"and if the extension is no enabled the test is skipped"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"37b86345_49d998e7","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":16},"updated":"2021-02-12 13:27:35.000000000","message":"nitty nit: function","commit_id":"e87e38585ac6ad26ffdb34d3c58dbff54a591543"}],"neutron_tempest_plugin/scenario/base.py":[{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"70238debc90516ce8ab6218af3bf18e8db047ad0","unresolved":true,"context_lines":[{"line_number":207,"context_line":"        LOG.debug(\"Created router %s\", router[\u0027name\u0027])"},{"line_number":208,"context_line":"        return router"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def skip_if_no_extension_enabled_in_l3_agents(self, extension):"},{"line_number":211,"context_line":"        l3_agents \u003d self.os_admin.network_client.list_agents("},{"line_number":212,"context_line":"                binary\u003d\u0027neutron-l3-agent\u0027)[\u0027agents\u0027]"},{"line_number":213,"context_line":"        for agent in l3_agents:"}],"source_content_type":"text/x-python","patch_set":1,"id":"20dfe347_af5a838f","line":210,"updated":"2021-02-12 13:20:37.000000000","message":"I am not sure about this, but, does it make sense doing this function more generic?\nI mean:\ndef skip_if_no_extension_enabled_in_agents(self, extension, agent_binary)","commit_id":"e87e38585ac6ad26ffdb34d3c58dbff54a591543"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7475eec12ceb4cab93ec6d1b919140da359f0829","unresolved":true,"context_lines":[{"line_number":207,"context_line":"        LOG.debug(\"Created router %s\", router[\u0027name\u0027])"},{"line_number":208,"context_line":"        return router"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def skip_if_no_extension_enabled_in_l3_agents(self, extension):"},{"line_number":211,"context_line":"        l3_agents \u003d self.os_admin.network_client.list_agents("},{"line_number":212,"context_line":"                binary\u003d\u0027neutron-l3-agent\u0027)[\u0027agents\u0027]"},{"line_number":213,"context_line":"        for agent in l3_agents:"}],"source_content_type":"text/x-python","patch_set":1,"id":"985bdd49_c3b3f22b","line":210,"in_reply_to":"20dfe347_af5a838f","updated":"2021-02-12 13:27:35.000000000","message":"I think it\u0027s fine like it is.","commit_id":"e87e38585ac6ad26ffdb34d3c58dbff54a591543"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"346d5702657d63713179ab1ea231318dd3d8b3ba","unresolved":true,"context_lines":[{"line_number":213,"context_line":"                binary\u003d\u0027neutron-l3-agent\u0027)[\u0027agents\u0027]"},{"line_number":214,"context_line":"        if not l3_agents:"},{"line_number":215,"context_line":"            # the tests should not be skipped when neutron-l3-agent does not"},{"line_number":216,"context_line":"            # exist (this validation only applies to ml2/ovs setups)"},{"line_number":217,"context_line":"            return"},{"line_number":218,"context_line":"        for agent in l3_agents:"},{"line_number":219,"context_line":"            if extension in agent[\u0027configurations\u0027].get(\u0027extensions\u0027, []):"}],"source_content_type":"text/x-python","patch_set":5,"id":"961a9b60_17b87d8f","line":216,"range":{"start_line":216,"start_character":21,"end_line":216,"end_character":67},"updated":"2021-02-22 08:56:47.000000000","message":"this isn\u0027t really true. It applies e.g. to ML2/Linuxbridge or may apply to some other deployments which will have L3 agents as well. It\u0027s more like it doesn\u0027t apply to ML2/OVN.","commit_id":"2223d2aab384f56760c7ee3e18af83a576a219b5"}],"neutron_tempest_plugin/scenario/test_port_forwardings.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6f943f97ec5fe42452d5662aac9a8d0cac472e05","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def resource_setup(cls):"},{"line_number":39,"context_line":"        super(PortForwardingTestJSON, cls).resource_setup()"},{"line_number":40,"context_line":"        cls.skip_if_no_extension_enabled_in_l3_agents(cls, \"port_forwarding\")"},{"line_number":41,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":42,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":43,"context_line":"        cls.router \u003d cls.create_router_by_client()"}],"source_content_type":"text/x-python","patch_set":3,"id":"32c4e38d_03762dcf","line":40,"range":{"start_line":40,"start_character":54,"end_line":40,"end_character":57},"updated":"2021-02-15 15:37:22.000000000","message":"why do You need to pass cls instance here? Wouldn\u0027t be better to make this method as classmethod and then it would be passed automatically?","commit_id":"da608d515239744f580d8fbfc2674e310eaaa05a"}]}