)]}'
{"neutron_tempest_plugin/scenario/test_ipv6.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"39c601368ba0ced7f5a446515d65c61872705923","unresolved":true,"context_lines":[{"line_number":77,"context_line":"class IPv6Test(base.BaseTempestTestCase):"},{"line_number":78,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    _ip_version \u003d lib_constants.IP_VERSION_6"},{"line_number":81,"context_line":"    ipv6_ra_mode \u003d \u0027slaac\u0027"},{"line_number":82,"context_line":"    ipv6_address_mode \u003d \u0027slaac\u0027"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b2185093_bf223268","line":80,"range":{"start_line":80,"start_character":4,"end_line":80,"end_character":44},"updated":"2021-04-06 11:24:03.000000000","message":"You are right in your answer in L88.\n\nWhy this parameter is removed in PS3? If you set the class \"_ip_version\", then you don\u0027t need to check \"CONF.network_feature_enabled.ipv6\" again.","commit_id":"2c24faf6d771fe5998bdaae226667c80a5587290"},{"author":{"_account_id":15921,"name":"Ilya Bumarskov","email":"bumarskov@gmail.com","username":"ibumarskov"},"change_message_id":"8bfa6c03c7d9cc80b19986eb0db0be4f92910e62","unresolved":false,"context_lines":[{"line_number":77,"context_line":"class IPv6Test(base.BaseTempestTestCase):"},{"line_number":78,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    _ip_version \u003d lib_constants.IP_VERSION_6"},{"line_number":81,"context_line":"    ipv6_ra_mode \u003d \u0027slaac\u0027"},{"line_number":82,"context_line":"    ipv6_address_mode \u003d \u0027slaac\u0027"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"737c8027_91b8cb6d","line":80,"range":{"start_line":80,"start_character":4,"end_line":80,"end_character":44},"in_reply_to":"52c2b1ce_423c307e","updated":"2021-04-15 07:51:01.000000000","message":"Done","commit_id":"2c24faf6d771fe5998bdaae226667c80a5587290"},{"author":{"_account_id":15921,"name":"Ilya Bumarskov","email":"bumarskov@gmail.com","username":"ibumarskov"},"change_message_id":"e7696d805dc0dd1ede907b53e0e3bb272071318d","unresolved":true,"context_lines":[{"line_number":77,"context_line":"class IPv6Test(base.BaseTempestTestCase):"},{"line_number":78,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    _ip_version \u003d lib_constants.IP_VERSION_6"},{"line_number":81,"context_line":"    ipv6_ra_mode \u003d \u0027slaac\u0027"},{"line_number":82,"context_line":"    ipv6_address_mode \u003d \u0027slaac\u0027"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"52c2b1ce_423c307e","line":80,"range":{"start_line":80,"start_character":4,"end_line":80,"end_character":44},"in_reply_to":"b2185093_bf223268","updated":"2021-04-06 13:50:12.000000000","message":"This breaks the test, look at the Zuul results for PS2 (https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_70a/783802/2/check/neutron-tempest-plugin-scenario-openvswitch/70a2971/testr_results.html)","commit_id":"2c24faf6d771fe5998bdaae226667c80a5587290"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"98abd0d45a2e7559e385960f9739b6d6522ac25c","unresolved":true,"context_lines":[{"line_number":85,"context_line":"    def skip_checks(cls):"},{"line_number":86,"context_line":"        super(IPv6Test, cls).skip_checks()"},{"line_number":87,"context_line":"        if not CONF.network_feature_enabled.ipv6_subnet_attributes:"},{"line_number":88,"context_line":"            raise cls.skipException(\"DHCPv6 attributes are not enabled.\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @classmethod"},{"line_number":91,"context_line":"    @tempest_utils.requires_ext(extension\u003d\"router\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"f50355db_c9277a88","line":88,"updated":"2021-03-30 08:14:09.000000000","message":"This seems pretty coarse, I don\u0027t think all tests are related to this specific feature. IMO you should only skip the affected tests and not everything.","commit_id":"2c24faf6d771fe5998bdaae226667c80a5587290"},{"author":{"_account_id":15921,"name":"Ilya Bumarskov","email":"bumarskov@gmail.com","username":"ibumarskov"},"change_message_id":"270e8a041015f3f1eefcebcb4f221cfe6e23b759","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def skip_checks(cls):"},{"line_number":86,"context_line":"        super(IPv6Test, cls).skip_checks()"},{"line_number":87,"context_line":"        if not CONF.network_feature_enabled.ipv6_subnet_attributes:"},{"line_number":88,"context_line":"            raise cls.skipException(\"DHCPv6 attributes are not enabled.\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @classmethod"},{"line_number":91,"context_line":"    @tempest_utils.requires_ext(extension\u003d\"router\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"21b0318f_0b8061f2","line":88,"in_reply_to":"070af202_8cf1b703","updated":"2021-03-30 09:37:49.000000000","message":"CONF.network_feature_enabled.ipv6 check occurs in parent class: https://review.opendev.org/plugins/gitiles/openstack/neutron-tempest-plugin/+/refs/heads/master/neutron_tempest_plugin/api/base.py#90\nso we don\u0027t need to double-check it in this method.","commit_id":"2c24faf6d771fe5998bdaae226667c80a5587290"},{"author":{"_account_id":15921,"name":"Ilya Bumarskov","email":"bumarskov@gmail.com","username":"ibumarskov"},"change_message_id":"d5aedbf2373a9363b528ad5da7d8d5d262d73fac","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def skip_checks(cls):"},{"line_number":86,"context_line":"        super(IPv6Test, cls).skip_checks()"},{"line_number":87,"context_line":"        if not CONF.network_feature_enabled.ipv6_subnet_attributes:"},{"line_number":88,"context_line":"            raise cls.skipException(\"DHCPv6 attributes are not enabled.\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @classmethod"},{"line_number":91,"context_line":"    @tempest_utils.requires_ext(extension\u003d\"router\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"f9762eca_23c19076","line":88,"in_reply_to":"f50355db_c9277a88","updated":"2021-03-30 08:24:36.000000000","message":"Done","commit_id":"2c24faf6d771fe5998bdaae226667c80a5587290"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4b188aafeaa56702d505c6ede152f6549f82883f","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def skip_checks(cls):"},{"line_number":86,"context_line":"        super(IPv6Test, cls).skip_checks()"},{"line_number":87,"context_line":"        if not CONF.network_feature_enabled.ipv6_subnet_attributes:"},{"line_number":88,"context_line":"            raise cls.skipException(\"DHCPv6 attributes are not enabled.\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @classmethod"},{"line_number":91,"context_line":"    @tempest_utils.requires_ext(extension\u003d\"router\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"070af202_8cf1b703","line":88,"in_reply_to":"f9762eca_23c19076","updated":"2021-03-30 08:36:14.000000000","message":"Sorry for the ping pong, but you need to check more config parameters. Those IPv6 tests should check\n1) CONF.network_feature_enabled.ipv6 is enabled. This should be implemented here, in this method\n2) CONF.network_feature_enabled.ipv6_subnet_attributes, that could be checked in the specific methods using those parameters (as in PS2).\n\nSo, IMO, you need this method checking CONF.network_feature_enabled.ipv6 in general for all tests under this class and what you have implemented in PS2 for each method checking CONF.network_feature_enabled.ipv6_subnet_attributes.","commit_id":"2c24faf6d771fe5998bdaae226667c80a5587290"}]}