)]}'
{"neutron_tempest_plugin/scenario/test_connectivity.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"55cac6dd2115dbbf188e38f2698aac90f754ee49","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        ap1_rt \u003d self.create_router("},{"line_number":85,"context_line":"            router_name\u003ddata_utils.rand_name(\"ap1_rt\"),"},{"line_number":86,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":87,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"},{"line_number":88,"context_line":"        ap2_rt \u003d self.create_router("},{"line_number":89,"context_line":"            router_name\u003ddata_utils.rand_name(\"ap2_rt\"),"},{"line_number":90,"context_line":"            admin_state_up\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"becee675_834154ca","line":87,"updated":"2021-04-27 15:06:53.000000000","message":"I wonder whether it could have been created with self.create_router_by_client() instead ?","commit_id":"edf3cba046fd960bfbd6a17890ad995fd2c7d955"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"55cac6dd2115dbbf188e38f2698aac90f754ee49","unresolved":true,"context_lines":[{"line_number":87,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"},{"line_number":88,"context_line":"        ap2_rt \u003d self.create_router("},{"line_number":89,"context_line":"            router_name\u003ddata_utils.rand_name(\"ap2_rt\"),"},{"line_number":90,"context_line":"            admin_state_up\u003dTrue)"},{"line_number":91,"context_line":"        self._wait_for_router_ha_active(ap1_rt[\u0027id\u0027])"},{"line_number":92,"context_line":"        self._wait_for_router_ha_active(ap2_rt[\u0027id\u0027])"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"cf833ecd_a73f39b1","line":90,"updated":"2021-04-27 15:06:53.000000000","message":"Unfortunately not this one as it\u0027s not specifying an external network id, unless we change create_router_by_client().","commit_id":"edf3cba046fd960bfbd6a17890ad995fd2c7d955"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"55cac6dd2115dbbf188e38f2698aac90f754ee49","unresolved":true,"context_lines":[{"line_number":142,"context_line":"            router_name\u003ddata_utils.rand_name(\"east_west_traffic_router\"),"},{"line_number":143,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":144,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"},{"line_number":145,"context_line":"        self._wait_for_router_ha_active(router[\u0027id\u0027])"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        internal_port_1 \u003d self.create_port("},{"line_number":148,"context_line":"            net_1, security_groups\u003d[self.secgroup[\u0027id\u0027]])"}],"source_content_type":"text/x-python","patch_set":4,"id":"bdfb28b6_c7c2fc0d","line":145,"updated":"2021-04-27 15:06:53.000000000","message":"I wonder whether it could have been created with self.create_router_by_client() instead ?\n\nOnly mentioning this since I had to go through the code to make sure you didn\u0027t miss one, and then thought about why these three were different.","commit_id":"edf3cba046fd960bfbd6a17890ad995fd2c7d955"}],"neutron_tempest_plugin/scenario/test_internal_dns.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"41b2ef9a5e1fb6b62ab0aec302e5717f216f791e","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class InternalDNSTest(base.BaseTempestTestCase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    credentials \u003d [\u0027admin\u0027]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @utils.requires_ext(extension\u003d\"dns-integration\", service\u003d\"network\")"},{"line_number":31,"context_line":"    @decorators.idempotent_id(\u0027988347de-07af-471a-abfa-65aea9f452a6\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"aa90f806_c187b471","line":28,"updated":"2021-04-21 14:30:53.000000000","message":"In order to setup the clients, \"BaseNetworkTest.setup_clients\", you always need \"os_primary\". You should append \"primary\" to this list.","commit_id":"f0a134d0092b8e83ec0de87376c61bad6c1f479b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0a1ecd61e1d5a7f5aa7164e8f50bd9e6d9d1c1b9","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class InternalDNSTest(base.BaseTempestTestCase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    credentials \u003d [\u0027admin\u0027]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @utils.requires_ext(extension\u003d\"dns-integration\", service\u003d\"network\")"},{"line_number":31,"context_line":"    @decorators.idempotent_id(\u0027988347de-07af-471a-abfa-65aea9f452a6\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"781d2e24_858b4d84","line":28,"in_reply_to":"aa90f806_c187b471","updated":"2021-04-21 15:52:02.000000000","message":"Done","commit_id":"f0a134d0092b8e83ec0de87376c61bad6c1f479b"}],"neutron_tempest_plugin/services/network/json/network_client.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f766b6022f8bd8bc49531c2500d97447e5271e73","unresolved":true,"context_lines":[{"line_number":363,"context_line":"        body \u003d jsonutils.loads(body)"},{"line_number":364,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def get_router(self, router_id):"},{"line_number":367,"context_line":"        uri \u003d \u0027%s/routers/%s\u0027 % (self.uri_prefix, router_id)"},{"line_number":368,"context_line":"        get_resp, get_resp_body \u003d self.get(uri)"},{"line_number":369,"context_line":"        self.expected_success(200, get_resp.status)"}],"source_content_type":"text/x-python","patch_set":2,"id":"594e01f2_e0c08681","line":366,"updated":"2021-04-21 14:35:10.000000000","message":"__getattr__(self, name) (in L165) will provide you \"show_router(router_id)\" method","commit_id":"f0a134d0092b8e83ec0de87376c61bad6c1f479b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0a1ecd61e1d5a7f5aa7164e8f50bd9e6d9d1c1b9","unresolved":true,"context_lines":[{"line_number":363,"context_line":"        body \u003d jsonutils.loads(body)"},{"line_number":364,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def get_router(self, router_id):"},{"line_number":367,"context_line":"        uri \u003d \u0027%s/routers/%s\u0027 % (self.uri_prefix, router_id)"},{"line_number":368,"context_line":"        get_resp, get_resp_body \u003d self.get(uri)"},{"line_number":369,"context_line":"        self.expected_success(200, get_resp.status)"}],"source_content_type":"text/x-python","patch_set":2,"id":"38d65052_6aced39d","line":366,"in_reply_to":"594e01f2_e0c08681","updated":"2021-04-21 15:52:02.000000000","message":"ups, I missed it :) Thx","commit_id":"f0a134d0092b8e83ec0de87376c61bad6c1f479b"}]}