)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7b63098f96cca6ccd3b4264acdc6e3a46c78ecae","unresolved":true,"context_lines":[{"line_number":10,"context_line":"unique constraint, it will allow creating portforwardings"},{"line_number":11,"context_line":"which have multiple floating_IP:port to one same fixed_IP:port."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"And, this case looks redundant, there are API tests in Neutron."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"If Neutron stable branches do not use the master branch of"},{"line_number":16,"context_line":"neutron-tempest-plugin, new test cases after the constraint"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"50d14dca_f55a5a6a","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":63},"updated":"2021-05-31 11:10:26.000000000","message":"You mean unit/functional or fullstack tests cover this case in Neutron?","commit_id":"d36dcff7ac66a19cc3e1149af2de199228514fad"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5a4484300fe703e0ce19f69cae8a6ee191bf1a51","unresolved":true,"context_lines":[{"line_number":10,"context_line":"unique constraint, it will allow creating portforwardings"},{"line_number":11,"context_line":"which have multiple floating_IP:port to one same fixed_IP:port."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"And, this case looks redundant, there are API tests in Neutron."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"If Neutron stable branches do not use the master branch of"},{"line_number":16,"context_line":"neutron-tempest-plugin, new test cases after the constraint"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"db40a013_19e35be1","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":63},"in_reply_to":"11d79682_da6c6799","updated":"2021-06-01 08:34:44.000000000","message":"I meant tests that cover the \"old\" behaviour on older (\u003c\u003dWallaby) branches, to keep the coverage, if we assume that this fix will not be backported.","commit_id":"d36dcff7ac66a19cc3e1149af2de199228514fad"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3d6eaf4e936ed815f34641b70bad4a9a3e3b8525","unresolved":true,"context_lines":[{"line_number":10,"context_line":"unique constraint, it will allow creating portforwardings"},{"line_number":11,"context_line":"which have multiple floating_IP:port to one same fixed_IP:port."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"And, this case looks redundant, there are API tests in Neutron."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"If Neutron stable branches do not use the master branch of"},{"line_number":16,"context_line":"neutron-tempest-plugin, new test cases after the constraint"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"11d79682_da6c6799","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":63},"in_reply_to":"50d14dca_f55a5a6a","updated":"2021-05-31 11:28:41.000000000","message":"Yes, see these cases:\nhttps://review.opendev.org/c/openstack/neutron/+/787304/6/neutron/tests/unit/extensions/test_expose_port_forwarding_in_fip.py","commit_id":"d36dcff7ac66a19cc3e1149af2de199228514fad"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9535e46373b6e7fb0a2a67a9985078436d13babf","unresolved":true,"context_lines":[{"line_number":10,"context_line":"unique constraint, it will allow creating portforwardings"},{"line_number":11,"context_line":"which have multiple floating_IP:port to one same fixed_IP:port."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"And, this case looks redundant, there are API tests in Neutron."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"If Neutron stable branches do not use the master branch of"},{"line_number":16,"context_line":"neutron-tempest-plugin, new test cases after the constraint"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4859d108_7beda023","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":63},"in_reply_to":"a4f847fb_8a924c0d","updated":"2021-06-10 09:52:16.000000000","message":"Sorry for late reply.\nMy point is to keep the test coverage on old branches. Like cover the same scenario with fullstack for example.","commit_id":"d36dcff7ac66a19cc3e1149af2de199228514fad"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1be99b6d2b0645ffd5b819edb10c3ea218dc8496","unresolved":true,"context_lines":[{"line_number":10,"context_line":"unique constraint, it will allow creating portforwardings"},{"line_number":11,"context_line":"which have multiple floating_IP:port to one same fixed_IP:port."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"And, this case looks redundant, there are API tests in Neutron."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"If Neutron stable branches do not use the master branch of"},{"line_number":16,"context_line":"neutron-tempest-plugin, new test cases after the constraint"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a4f847fb_8a924c0d","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":63},"in_reply_to":"db40a013_19e35be1","updated":"2021-06-01 10:32:04.000000000","message":"Stable branch will not accept DB upgrading. So IMO, it should be fine if we remove these case here, since no chance to change the old behaviour in stable branch.","commit_id":"d36dcff7ac66a19cc3e1149af2de199228514fad"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7b63098f96cca6ccd3b4264acdc6e3a46c78ecae","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"And, this case looks redundant, there are API tests in Neutron."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"If Neutron stable branches do not use the master branch of"},{"line_number":16,"context_line":"neutron-tempest-plugin, new test cases after the constraint"},{"line_number":17,"context_line":"removal will be added."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Related-Bug: #1922653"},{"line_number":20,"context_line":"Change-Id: I95d9fd3224300c4406a1a397e514989d7495b370"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1dbb0fdd_10de898b","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":22},"updated":"2021-05-31 11:10:26.000000000","message":"As tempest (and neutron-tempest-plugin) is branchless stable branches use the same tests.\nCould You please check if this case is covered in unit tests or functional/fullstack tests?","commit_id":"d36dcff7ac66a19cc3e1149af2de199228514fad"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5a4484300fe703e0ce19f69cae8a6ee191bf1a51","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"And, this case looks redundant, there are API tests in Neutron."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"If Neutron stable branches do not use the master branch of"},{"line_number":16,"context_line":"neutron-tempest-plugin, new test cases after the constraint"},{"line_number":17,"context_line":"removal will be added."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Related-Bug: #1922653"},{"line_number":20,"context_line":"Change-Id: I95d9fd3224300c4406a1a397e514989d7495b370"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"2f6823c0_7d3d40b0","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":22},"in_reply_to":"0142bb59_e9e02429","updated":"2021-06-01 08:34:44.000000000","message":"see my answer above","commit_id":"d36dcff7ac66a19cc3e1149af2de199228514fad"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3d6eaf4e936ed815f34641b70bad4a9a3e3b8525","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"And, this case looks redundant, there are API tests in Neutron."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"If Neutron stable branches do not use the master branch of"},{"line_number":16,"context_line":"neutron-tempest-plugin, new test cases after the constraint"},{"line_number":17,"context_line":"removal will be added."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Related-Bug: #1922653"},{"line_number":20,"context_line":"Change-Id: I95d9fd3224300c4406a1a397e514989d7495b370"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0142bb59_e9e02429","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":22},"in_reply_to":"1dbb0fdd_10de898b","updated":"2021-05-31 11:28:41.000000000","message":"See these cases:\nhttps://review.opendev.org/c/openstack/neutron/+/787304/6/neutron/tests/unit/extensions/test_expose_port_forwarding_in_fip.py","commit_id":"d36dcff7ac66a19cc3e1149af2de199228514fad"}],"neutron_tempest_plugin/api/test_port_forwarding_negative.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d92fc19aca2ab4ed382c843572e49cbc69737491","unresolved":true,"context_lines":[{"line_number":81,"context_line":"            internal_port_id\u003dport[\u0027id\u0027],"},{"line_number":82,"context_line":"            internal_ip_address\u003dport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":83,"context_line":"            internal_port\u003d1111, external_port\u003d5555,"},{"line_number":84,"context_line":"            protocol\u003d\"tcp\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":87,"context_line":"    @decorators.idempotent_id(\u0027e9d3ffb6-e5bf-421d-acaa-ee6010dfbf14\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff538e3d_9b31390a","side":"PARENT","line":84,"updated":"2021-04-23 10:45:21.000000000","message":"maybe instead of removing it You should change that test to ensure that this is possible now?","commit_id":"d4988c4f32357a151d9eb715d071cfb696b6fd95"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b614fa421e1966baea5188b986664b461c959901","unresolved":true,"context_lines":[{"line_number":81,"context_line":"            internal_port_id\u003dport[\u0027id\u0027],"},{"line_number":82,"context_line":"            internal_ip_address\u003dport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":83,"context_line":"            internal_port\u003d1111, external_port\u003d5555,"},{"line_number":84,"context_line":"            protocol\u003d\"tcp\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":87,"context_line":"    @decorators.idempotent_id(\u0027e9d3ffb6-e5bf-421d-acaa-ee6010dfbf14\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"6de95902_83178495","side":"PARENT","line":84,"in_reply_to":"a643395b_0b3b8534","updated":"2021-05-25 03:35:15.000000000","message":"openstack-tox-docs https://zuul.opendev.org/t/openstack/build/23f91c6c11424689916c801dd5882b97 : SUCCESS in 4m 06s\nneutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/c6edc23e2d394baaac938e687d97a368 : SUCCESS in 42m 02s\nneutron-tempest-plugin-scenario-linuxbridge https://zuul.opendev.org/t/openstack/build/b5875473857b44c0a2224bb008ef2665 : FAILURE in 2h 07m 04s\nneutron-tempest-plugin-scenario-openvswitch https://zuul.opendev.org/t/openstack/build/10c8c5f179604eaca1dff2416cda30d0 : SUCCESS in 1h 23m 42s\nneutron-tempest-plugin-scenario-openvswitch-iptables_hybrid https://zuul.opendev.org/t/openstack/build/add1ae5ea04640f69ca83f089b0558b6 : SUCCESS in 59m 39s\nneutron-tempest-plugin-scenario-ovn https://zuul.opendev.org/t/openstack/build/18f49cab183040d8ba998bbb49c0f8ff : SUCCESS in 1h 47m 34s\nneutron-tempest-plugin-api-ussuri https://zuul.opendev.org/t/openstack/build/82c3f74a798942e1958c6632598ac5f5 : SUCCESS in 46m 06s\nneutron-tempest-plugin-scenario-linuxbridge-ussuri https://zuul.opendev.org/t/openstack/build/878129bc6d8e442b8f814433ac0cbb11 : SUCCESS in 2h 05m 56s\nneutron-tempest-plugin-scenario-openvswitch-ussuri https://zuul.opendev.org/t/openstack/build/1add5453e0974e70babd48d4477cd751 : SUCCESS in 1h 55m 23s\nneutron-tempest-plugin-scenario-openvswitch-iptables_hybrid-ussuri https://zuul.opendev.org/t/openstack/build/579a12ea7a1f48f18ac11f5462e3a32d : SUCCESS in 1h 34m 01s\nneutron-tempest-plugin-scenario-linuxbridge-victoria https://zuul.opendev.org/t/openstack/build/d445415dfd18421782f0d03830aa550a : SUCCESS in 1h 45m 30s\nneutron-tempest-plugin-scenario-openvswitch-victoria https://zuul.opendev.org/t/openstack/build/6d9ef73763c8449fb849ec9e027460ae : SUCCESS in 1h 32m 24s\nneutron-tempest-plugin-scenario-openvswitch-wallaby https://zuul.opendev.org/t/openstack/build/c33128e739704bb6821d913a53a2175e : SUCCESS in 1h 59m 54s\n\n\nOK, zuul result shows that stable branches will run cases of master branch of neutron-tempest-plugin. So we can not add new case for the constrain change, because DB upgrade will not be applied to stable branches.","commit_id":"d4988c4f32357a151d9eb715d071cfb696b6fd95"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"20ef55a5ec6f7ba6b84bc11ee02e8339a1f34198","unresolved":true,"context_lines":[{"line_number":81,"context_line":"            internal_port_id\u003dport[\u0027id\u0027],"},{"line_number":82,"context_line":"            internal_ip_address\u003dport[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":83,"context_line":"            internal_port\u003d1111, external_port\u003d5555,"},{"line_number":84,"context_line":"            protocol\u003d\"tcp\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":87,"context_line":"    @decorators.idempotent_id(\u0027e9d3ffb6-e5bf-421d-acaa-ee6010dfbf14\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a643395b_0b3b8534","side":"PARENT","line":84,"in_reply_to":"ff538e3d_9b31390a","updated":"2021-04-25 03:13:19.000000000","message":"Quote from commit message:\n\"\"\"\nAnd, this case looks redundant, there are API tests in Neutron.\n\"\"\"\n\nAnd this is the negative test cases.","commit_id":"d4988c4f32357a151d9eb715d071cfb696b6fd95"}]}