)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f6d607887815eb28a60bcd5a14b410cd450c462c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Sampat Ponnaganti \u003csp810x@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-05-05 16:59:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[1927249] Fix test to prevent network leak"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix the test case such that the original network ID"},{"line_number":10,"context_line":" is used during the clean up of the network"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0fef6b4e_7cbc7bc4","line":7,"updated":"2021-05-05 17:36:06.000000000","message":"Please, read the commit good practice guide: https://wiki.openstack.org/wiki/GitCommitMessages\n\n\nThis message should be:\n---\nFix test to prevent network leak\n\nFix the test case such that the original network ID\nis used during the clean up of the network.\n\nCloses-Bug: #1927249\nChange-Id: I82f3c5320c5b324167a8c22966e16828090ab4b7\n---","commit_id":"283558456c20378d3353373388f8208c4ffddf40"},{"author":{"_account_id":30515,"name":"Sampat Ponnaganti","email":"sp810x@att.com","username":"sp810x@att.com"},"change_message_id":"dcc8e598cd5e7faa30833607c956e0d2932a8782","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sampat Ponnaganti \u003csp810x@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-05-05 16:59:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[1927249] Fix test to prevent network leak"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix the test case such that the original network ID"},{"line_number":10,"context_line":" is used during the clean up of the network"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"273af214_3f0d4920","line":7,"in_reply_to":"0fef6b4e_7cbc7bc4","updated":"2021-05-06 13:09:13.000000000","message":"Thanks for the updated messaged. I used that.","commit_id":"283558456c20378d3353373388f8208c4ffddf40"}],"neutron_tempest_plugin/api/test_ports_negative.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f6d607887815eb28a60bcd5a14b410cd450c462c","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    def test_add_port_with_nonexist_network_id(self):"},{"line_number":56,"context_line":"        network \u003d self.network"},{"line_number":57,"context_line":"        # Copy and restore net ID so the cleanup will delete correct net"},{"line_number":58,"context_line":"        original_network_id \u003d network[\u0027id\u0027]"},{"line_number":59,"context_line":"        network[\u0027id\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":60,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":61,"context_line":"                          self.create_port,"}],"source_content_type":"text/x-python","patch_set":2,"id":"b4d3379e_2a40029f","line":58,"updated":"2021-05-05 17:36:06.000000000","message":"Thanks for this patch, good catch\n\nIn order to restore anything in a test, addCleanup() is preferable. That will ensure, regardless of the test execution, that the restoring code is always executed.","commit_id":"283558456c20378d3353373388f8208c4ffddf40"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4ef4e7204eaf85618108806741ea652dbe68a374","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def test_add_port_with_nonexist_network_id(self):"},{"line_number":56,"context_line":"        network \u003d self.network"},{"line_number":57,"context_line":"        # Copy and restore net ID so the cleanup will delete correct net"},{"line_number":58,"context_line":"        original_network_id \u003d network[\u0027id\u0027]"},{"line_number":59,"context_line":"        network[\u0027id\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":60,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":61,"context_line":"                          self.create_port,"}],"source_content_type":"text/x-python","patch_set":2,"id":"0a5f6097_9583b71f","line":58,"in_reply_to":"63572c24_7a17db75","updated":"2021-05-06 13:28:31.000000000","message":"The only resource we are creating in this test is a port and the command should exit fast with this exception, so no timeout wait will be running at the cleanup time.","commit_id":"283558456c20378d3353373388f8208c4ffddf40"},{"author":{"_account_id":30515,"name":"Sampat Ponnaganti","email":"sp810x@att.com","username":"sp810x@att.com"},"change_message_id":"dcc8e598cd5e7faa30833607c956e0d2932a8782","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def test_add_port_with_nonexist_network_id(self):"},{"line_number":56,"context_line":"        network \u003d self.network"},{"line_number":57,"context_line":"        # Copy and restore net ID so the cleanup will delete correct net"},{"line_number":58,"context_line":"        original_network_id \u003d network[\u0027id\u0027]"},{"line_number":59,"context_line":"        network[\u0027id\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":60,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":61,"context_line":"                          self.create_port,"}],"source_content_type":"text/x-python","patch_set":2,"id":"63572c24_7a17db75","line":58,"in_reply_to":"b4d3379e_2a40029f","updated":"2021-05-06 13:09:13.000000000","message":"Hi @Rodolfo I discuss addCleanup() in tempest IRC, @Ghanshyam  mentioned that add delay to the test run. addCleanup() waits build_timeout for the resource clean up.\nIf addCleanup() still recommended can we do that in a separate patchset?","commit_id":"283558456c20378d3353373388f8208c4ffddf40"}]}