)]}'
{"neutron_tempest_plugin/api/test_extra_dhcp_options.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"14a9516a9038bf44fa184fecaf7e7ff7f6db62e8","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        for retrieved_option in retrieved:"},{"line_number":92,"context_line":"            for option in extra_dhcp_opts:"},{"line_number":93,"context_line":"                # default ip_version is 4"},{"line_number":94,"context_line":"                ip_version \u003d option.get(\u0027ip_version\u0027, 4)"},{"line_number":95,"context_line":"                if (retrieved_option[\u0027opt_value\u0027] \u003d\u003d option[\u0027opt_value\u0027] and"},{"line_number":96,"context_line":"                    retrieved_option[\u0027opt_name\u0027] \u003d\u003d option[\u0027opt_name\u0027] and"},{"line_number":97,"context_line":"                    retrieved_option[\u0027ip_version\u0027] \u003d\u003d ip_version):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ac60977e_22b73bde","line":94,"range":{"start_line":94,"start_character":54,"end_line":94,"end_character":55},"updated":"2021-08-23 15:00:14.000000000","message":"nitty nit: please use constant from neutron_lib: https://github.com/openstack/neutron-lib/blob/master/neutron_lib/constants.py#L93","commit_id":"028d59c82c034c37a25ea7efac2c2adb4fd1c55e"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"3ccd0e15f3a7f2913a7325ca4f4de449a2a1c113","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        for retrieved_option in retrieved:"},{"line_number":92,"context_line":"            for option in extra_dhcp_opts:"},{"line_number":93,"context_line":"                # default ip_version is 4"},{"line_number":94,"context_line":"                ip_version \u003d option.get(\u0027ip_version\u0027, 4)"},{"line_number":95,"context_line":"                if (retrieved_option[\u0027opt_value\u0027] \u003d\u003d option[\u0027opt_value\u0027] and"},{"line_number":96,"context_line":"                    retrieved_option[\u0027opt_name\u0027] \u003d\u003d option[\u0027opt_name\u0027] and"},{"line_number":97,"context_line":"                    retrieved_option[\u0027ip_version\u0027] \u003d\u003d ip_version):"}],"source_content_type":"text/x-python","patch_set":2,"id":"18521080_b508fb83","line":94,"range":{"start_line":94,"start_character":54,"end_line":94,"end_character":55},"in_reply_to":"ac60977e_22b73bde","updated":"2021-08-24 09:08:11.000000000","message":"Done","commit_id":"028d59c82c034c37a25ea7efac2c2adb4fd1c55e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5372acb2f342e1867ea5476e6660e7c621ec2e7f","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron_tempest_plugin.api import base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron_lib import constants"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class ExtraDHCPOptionsTestJSON(base.BaseNetworkTest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"be5cf141_d8c9a8a0","line":21,"updated":"2021-08-25 11:45:29.000000000","message":"this should be in the same section as imports from tempest (L16-17)","commit_id":"eb751a2c389b91b267a44d70447faa6ce7119e34"}]}