)]}'
{"neutron_tempest_plugin/api/base.py":[{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"571a386341fd052fc36e3b88f8ae0fe10400d101","unresolved":true,"context_lines":[{"line_number":763,"context_line":"        return qos_policy"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"    @classmethod"},{"line_number":766,"context_line":"    def create_qos_bandwidth_limit_rule(cls, policy_id, max_kbps,"},{"line_number":767,"context_line":"                                        max_burst_kbps,"},{"line_number":768,"context_line":"                                        direction\u003dconst.EGRESS_DIRECTION):"},{"line_number":769,"context_line":"        \"\"\"Wrapper utility that returns a test QoS bandwidth limit rule.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"df03ebfe_ed3edac4","side":"PARENT","line":766,"updated":"2021-09-13 08:57:32.000000000","message":"Maybe I\u0027m missing something, but. isn\u0027t it possible to keep this method, using cls.os_admin.qos_limit_bandwidth_rules_client?\nWouldn\u0027t that reduce the changes needed in this refactoring?","commit_id":"a7c081344661e84a6cbed1fc3ec77ae30dae041a"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"15cf760766c7a59d28fe88148c18655e834f2e72","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        return qos_policy"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"    @classmethod"},{"line_number":766,"context_line":"    def create_qos_bandwidth_limit_rule(cls, policy_id, max_kbps,"},{"line_number":767,"context_line":"                                        max_burst_kbps,"},{"line_number":768,"context_line":"                                        direction\u003dconst.EGRESS_DIRECTION):"},{"line_number":769,"context_line":"        \"\"\"Wrapper utility that returns a test QoS bandwidth limit rule.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"e3c4a493_7c0d1325","side":"PARENT","line":766,"in_reply_to":"474ffbdd_dc6d42be","updated":"2021-09-13 10:59:05.000000000","message":"Yes, I understand your point. Having only the create method and ignoring all the others here does not look good.\n\nMy concern is that qos_rules will not be deleted in the resource_cleanup at [1]. Anyway, this is not necessary because, if I\u0027m not mistaken, when qos policies are deleted at [2], the rules will also disappear.\n\n\n[1] https://github.com/openstack/neutron-tempest-plugin/blob/master/neutron_tempest_plugin/api/base.py#L252\n[2] https://github.com/openstack/neutron-tempest-plugin/blob/master/neutron_tempest_plugin/api/base.py#L259","commit_id":"a7c081344661e84a6cbed1fc3ec77ae30dae041a"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"120dbe18d40882e4b8a9499c2005ed806b41146c","unresolved":true,"context_lines":[{"line_number":763,"context_line":"        return qos_policy"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"    @classmethod"},{"line_number":766,"context_line":"    def create_qos_bandwidth_limit_rule(cls, policy_id, max_kbps,"},{"line_number":767,"context_line":"                                        max_burst_kbps,"},{"line_number":768,"context_line":"                                        direction\u003dconst.EGRESS_DIRECTION):"},{"line_number":769,"context_line":"        \"\"\"Wrapper utility that returns a test QoS bandwidth limit rule.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"474ffbdd_dc6d42be","side":"PARENT","line":766,"in_reply_to":"df03ebfe_ed3edac4","updated":"2021-09-13 10:25:30.000000000","message":"In fact this method was used to \"Create QoS BW Limit\" only and all his \"friends\" like: List, Update, Delete and Show has been implemented in another file: \"network_client.py\" (L630 -:L680):\nhttps://review.opendev.org/c/openstack/neutron-tempest-plugin/+/806977/9/neutron_tempest_plugin/services/network/json/network_client.py#b630\n\nNow, after this Tempest commit: https://github.com/openstack/tempest/commit/ca3e51356502b6bca86fa5b2c81f2805aecb06f0 we have all \"QoS Limit BW\" APIs in one place (which is Tempest and the best choice for stuff like that I think), so there is no more need to have methods doing the same stuff in Neutron Tempest Plugin, that was the reason for removing all of them.\n\nUsually \"QoS BW Limit Rule\" tests are using not only \"Create\", it comes with : List, Show (Delete in cleanup) e.t.c. so once you have \"QoS client\" created in \"setup_clients\" you can simply use wherever you need directly from Tempest code.","commit_id":"a7c081344661e84a6cbed1fc3ec77ae30dae041a"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"571a386341fd052fc36e3b88f8ae0fe10400d101","unresolved":true,"context_lines":[{"line_number":774,"context_line":"        return qos_rule"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    @classmethod"},{"line_number":777,"context_line":"    def create_qos_minimum_bandwidth_rule(cls, policy_id, min_kbps,"},{"line_number":778,"context_line":"                                          direction\u003dconst.EGRESS_DIRECTION):"},{"line_number":779,"context_line":"        \"\"\"Wrapper utility that creates and returns a QoS min bw rule.\"\"\""},{"line_number":780,"context_line":"        body \u003d cls.admin_client.create_minimum_bandwidth_rule("}],"source_content_type":"text/x-python","patch_set":9,"id":"ab9f4b40_92046cac","side":"PARENT","line":777,"updated":"2021-09-13 08:57:32.000000000","message":"Maybe I\u0027m missing something, but, isn\u0027t it possible to keep this method, using cls.os_admin.qos_minimum_bandwidth_rules_client?\nWouldn\u0027t that reduce the changes needed in this refactoring?","commit_id":"a7c081344661e84a6cbed1fc3ec77ae30dae041a"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"15cf760766c7a59d28fe88148c18655e834f2e72","unresolved":false,"context_lines":[{"line_number":774,"context_line":"        return qos_rule"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    @classmethod"},{"line_number":777,"context_line":"    def create_qos_minimum_bandwidth_rule(cls, policy_id, min_kbps,"},{"line_number":778,"context_line":"                                          direction\u003dconst.EGRESS_DIRECTION):"},{"line_number":779,"context_line":"        \"\"\"Wrapper utility that creates and returns a QoS min bw rule.\"\"\""},{"line_number":780,"context_line":"        body \u003d cls.admin_client.create_minimum_bandwidth_rule("}],"source_content_type":"text/x-python","patch_set":9,"id":"aacff13a_5115881e","side":"PARENT","line":777,"in_reply_to":"aa4c8e65_d16087c9","updated":"2021-09-13 10:59:05.000000000","message":"Ack","commit_id":"a7c081344661e84a6cbed1fc3ec77ae30dae041a"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"120dbe18d40882e4b8a9499c2005ed806b41146c","unresolved":true,"context_lines":[{"line_number":774,"context_line":"        return qos_rule"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    @classmethod"},{"line_number":777,"context_line":"    def create_qos_minimum_bandwidth_rule(cls, policy_id, min_kbps,"},{"line_number":778,"context_line":"                                          direction\u003dconst.EGRESS_DIRECTION):"},{"line_number":779,"context_line":"        \"\"\"Wrapper utility that creates and returns a QoS min bw rule.\"\"\""},{"line_number":780,"context_line":"        body \u003d cls.admin_client.create_minimum_bandwidth_rule("}],"source_content_type":"text/x-python","patch_set":9,"id":"aa4c8e65_d16087c9","side":"PARENT","line":777,"in_reply_to":"ab9f4b40_92046cac","updated":"2021-09-13 10:25:30.000000000","message":"It\u0027s almost the answer as my previous, the only difference is that the \"Minimum BW Limit Rule\" APIs weren\u0027t added by me to Tempest and they\u0027ve just been there without being used in Neutron.\nI don\u0027t know why, but maybe these APIs have been merged to the Tempest after Neutron tests has already been implemented 😕","commit_id":"a7c081344661e84a6cbed1fc3ec77ae30dae041a"}]}