)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"0ba10712d4c9f3d7dd687557a0e305d6f5b5e349","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"93e3af0c_f80c9a0f","updated":"2021-12-06 20:53:16.000000000","message":"recheck","commit_id":"55a3262eee608f451ecbf021d4dd35eb104f8a12"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"9c6413be15019eb5910d22e3e4f24fe13cbf7e42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6ed1f435_2b5229b8","updated":"2021-12-07 22:40:49.000000000","message":"recheck","commit_id":"3b65b89496b63c05751a060d76a479b22123e5dd"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"8a8caace18f860de65688ac8b42468a70a807e60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9d84be56_e16ecdcf","updated":"2021-12-08 05:30:42.000000000","message":"recheck","commit_id":"3b65b89496b63c05751a060d76a479b22123e5dd"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"652dd6026d03503b0005d4a54b4f9c689b1168d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a1ec83a5_9051740e","updated":"2021-12-07 19:39:50.000000000","message":"recheck","commit_id":"3b65b89496b63c05751a060d76a479b22123e5dd"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"ff32695345c8d1596ac3225e39a4286a4015abba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f08ab0e8_7bd3d6a2","updated":"2021-12-07 17:47:31.000000000","message":"recheck","commit_id":"3b65b89496b63c05751a060d76a479b22123e5dd"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"82173b15b513d43968a4fbea4fa0cf0c1e48065c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6aa8c57c_ca7c4202","updated":"2021-12-09 11:47:45.000000000","message":"recheck","commit_id":"235439939b8a0b9d568243266b4a8e72d8bd004f"}],"neutron_tempest_plugin/scenario/test_internal_dns.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4d7efab41a97779bcf72525f0b33a5f385beb7bd","unresolved":true,"context_lines":[{"line_number":137,"context_line":"        self.check_remote_connectivity(ssh_client, \u0027leia.openstackgate.local\u0027,"},{"line_number":138,"context_line":"                                       servers\u003d[self.server, leia])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @utils.requires_ext(extension\u003d\"dns-integration\", service\u003d\"network\")"},{"line_number":141,"context_line":"    @decorators.idempotent_id(\u0027db5e612f-f17f-4974-b5f1-9fe89f4a6fc9\u0027)"},{"line_number":142,"context_line":"    def test_create_port_with_dns_name(self):"},{"line_number":143,"context_line":"        \"\"\"Test creation of port with correct internal dns-name (hostname).\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"767de37f_2a76d447","line":140,"updated":"2021-12-07 12:02:42.000000000","message":"If you ever want this test not to be skipped, you need to move it into  test_dns_integration.py","commit_id":"3b65b89496b63c05751a060d76a479b22123e5dd"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"654db35d65798c43ab9bed3723373dda9d1356db","unresolved":true,"context_lines":[{"line_number":137,"context_line":"        self.check_remote_connectivity(ssh_client, \u0027leia.openstackgate.local\u0027,"},{"line_number":138,"context_line":"                                       servers\u003d[self.server, leia])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @utils.requires_ext(extension\u003d\"dns-integration\", service\u003d\"network\")"},{"line_number":141,"context_line":"    @decorators.idempotent_id(\u0027db5e612f-f17f-4974-b5f1-9fe89f4a6fc9\u0027)"},{"line_number":142,"context_line":"    def test_create_port_with_dns_name(self):"},{"line_number":143,"context_line":"        \"\"\"Test creation of port with correct internal dns-name (hostname).\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"8734ed4b_f17d6e86","line":140,"in_reply_to":"767de37f_2a76d447","updated":"2021-12-07 15:08:15.000000000","message":"Why would it be skipped?","commit_id":"3b65b89496b63c05751a060d76a479b22123e5dd"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d8b79c8ca557b02dcecd057e580f9230367b18f5","unresolved":true,"context_lines":[{"line_number":137,"context_line":"        self.check_remote_connectivity(ssh_client, \u0027leia.openstackgate.local\u0027,"},{"line_number":138,"context_line":"                                       servers\u003d[self.server, leia])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @utils.requires_ext(extension\u003d\"dns-integration\", service\u003d\"network\")"},{"line_number":141,"context_line":"    @decorators.idempotent_id(\u0027db5e612f-f17f-4974-b5f1-9fe89f4a6fc9\u0027)"},{"line_number":142,"context_line":"    def test_create_port_with_dns_name(self):"},{"line_number":143,"context_line":"        \"\"\"Test creation of port with correct internal dns-name (hostname).\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"a649c079_7f6eb160","line":140,"in_reply_to":"8734ed4b_f17d6e86","updated":"2021-12-07 20:42:18.000000000","message":"The dns-integration extension used to be only enabled for the designate-scenario job, but this seems to have changed. So indeed the test does not get skipped, sorry for the confusion.","commit_id":"3b65b89496b63c05751a060d76a479b22123e5dd"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"4273a6cabda2e8ddbc2302e8e9402a933f04d417","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        self.check_remote_connectivity(ssh_client, \u0027leia.openstackgate.local\u0027,"},{"line_number":138,"context_line":"                                       servers\u003d[self.server, leia])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @utils.requires_ext(extension\u003d\"dns-integration\", service\u003d\"network\")"},{"line_number":141,"context_line":"    @decorators.idempotent_id(\u0027db5e612f-f17f-4974-b5f1-9fe89f4a6fc9\u0027)"},{"line_number":142,"context_line":"    def test_create_port_with_dns_name(self):"},{"line_number":143,"context_line":"        \"\"\"Test creation of port with correct internal dns-name (hostname).\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"d5244f2a_c97ec446","line":140,"in_reply_to":"a649c079_7f6eb160","updated":"2021-12-07 22:39:20.000000000","message":"Ack","commit_id":"3b65b89496b63c05751a060d76a479b22123e5dd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"871c540c04d75e2885fa7fa99c7e1e7b38d516ba","unresolved":true,"context_lines":[{"line_number":53,"context_line":"                {\u0027name\u0027: self.security_groups[-1][\u0027name\u0027]}],"},{"line_number":54,"context_line":"            name\u003d\u0027leia\u0027)"},{"line_number":55,"context_line":"        self.wait_for_server_active(leia[\u0027server\u0027])"},{"line_number":56,"context_line":"        self.wait_for_guest_os_ready(leia[\u0027server\u0027])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        ssh_client \u003d ssh.Client("},{"line_number":59,"context_line":"            self.fip[\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"6dcf935b_1fd1f17d","side":"PARENT","line":56,"updated":"2021-12-08 21:03:00.000000000","message":"why did You remove those lines?","commit_id":"82cd7afa96a03d14660810889e4486cb6f560081"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"8e0245e760794ab15210f60c060a672fdd0bee01","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                {\u0027name\u0027: self.security_groups[-1][\u0027name\u0027]}],"},{"line_number":54,"context_line":"            name\u003d\u0027leia\u0027)"},{"line_number":55,"context_line":"        self.wait_for_server_active(leia[\u0027server\u0027])"},{"line_number":56,"context_line":"        self.wait_for_guest_os_ready(leia[\u0027server\u0027])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        ssh_client \u003d ssh.Client("},{"line_number":59,"context_line":"            self.fip[\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"d658b8c8_c45fb294","side":"PARENT","line":56,"in_reply_to":"6dcf935b_1fd1f17d","updated":"2021-12-09 08:01:05.000000000","message":"I noticed these 2 methods are called at the end of the method \u0027self.create_server\u0027, therefore they\u0027re called twice consecutively.","commit_id":"82cd7afa96a03d14660810889e4486cb6f560081"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"da7178289f3adbdaa095497d6ff9fa2cc940cefb","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                {\u0027name\u0027: self.security_groups[-1][\u0027name\u0027]}],"},{"line_number":54,"context_line":"            name\u003d\u0027leia\u0027)"},{"line_number":55,"context_line":"        self.wait_for_server_active(leia[\u0027server\u0027])"},{"line_number":56,"context_line":"        self.wait_for_guest_os_ready(leia[\u0027server\u0027])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        ssh_client \u003d ssh.Client("},{"line_number":59,"context_line":"            self.fip[\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"670704da_04e706b1","side":"PARENT","line":56,"in_reply_to":"d658b8c8_c45fb294","updated":"2021-12-09 21:07:28.000000000","message":"ok, thx. That makes sense :)","commit_id":"82cd7afa96a03d14660810889e4486cb6f560081"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"871c540c04d75e2885fa7fa99c7e1e7b38d516ba","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    \"\"\"Base class of useful resources and functionalities for test class.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    port_error_msg \u003d (\u0027Openstack command returned incorrect\u0027"},{"line_number":33,"context_line":"                      \u0027 hostname value in port.\u0027)"},{"line_number":34,"context_line":"    ssh_error_msg \u003d (\u0027Remote shell command returned incorrect hostname value\u0027"},{"line_number":35,"context_line":"                     \" (command: \u0027hostname\u0027 OR \u0027cat /etc/hostname\u0027).\")"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"46a43cf4_b378e2d0","line":33,"updated":"2021-12-08 21:03:00.000000000","message":"nit: our general convention is to put space at the end of line, not the beginning of the line.","commit_id":"e8a27596787d3290443c3fb654ce9b8e1c094724"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"8e0245e760794ab15210f60c060a672fdd0bee01","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\"Base class of useful resources and functionalities for test class.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    port_error_msg \u003d (\u0027Openstack command returned incorrect\u0027"},{"line_number":33,"context_line":"                      \u0027 hostname value in port.\u0027)"},{"line_number":34,"context_line":"    ssh_error_msg \u003d (\u0027Remote shell command returned incorrect hostname value\u0027"},{"line_number":35,"context_line":"                     \" (command: \u0027hostname\u0027 OR \u0027cat /etc/hostname\u0027).\")"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"4b8a4740_c5646d29","line":33,"in_reply_to":"46a43cf4_b378e2d0","updated":"2021-12-09 08:01:05.000000000","message":"Done","commit_id":"e8a27596787d3290443c3fb654ce9b8e1c094724"}]}
