)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"edf3c224ea39bcefb61af670b2f4eb3d6feee9fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"efe1e41d_9952fad7","updated":"2022-02-14 21:56:08.000000000","message":"I think we may face the situation when the new test will use advanced image that is not default...","commit_id":"e2a638d257361bd74e7d13fb13c7ff7660a03912"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"ce5306fce644dc1cc71c5da239bd1463f5a79fd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"40d4db82_0dbf278f","updated":"2022-02-14 16:31:51.000000000","message":"This test fails in the downstream CI when RHEL images are used","commit_id":"e2a638d257361bd74e7d13fb13c7ff7660a03912"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0b2935afa590add2575ea2c7173e035a07c44889","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"740933ba_7fbf0655","updated":"2022-02-28 18:04:27.000000000","message":"It is failing \"test_established_tcp_session_after_re_attachinging_sg\" both in OVS (native) and OVN, in all branches.","commit_id":"e5f16cfcfa02e895005e3bb55a8269b3f8cd07f2"}],"neutron_tempest_plugin/common/utils.py":[{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"efddb5f15188f6d602d5075094e9caa9a88905d0","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        return \u0027attempt_{}\u0027.format(str(self.test_attempt).zfill(3))"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def _start_connection(self):"},{"line_number":167,"context_line":"        if CONF.neutron_plugin_options.default_image_is_advanced:"},{"line_number":168,"context_line":"            server_exec_method \u003d self.server_ssh.execute_script"},{"line_number":169,"context_line":"            client_exec_method \u003d self.client_ssh.execute_script"},{"line_number":170,"context_line":"        else:"},{"line_number":171,"context_line":"            server_exec_method \u003d self.server_ssh.exec_command"},{"line_number":172,"context_line":"            client_exec_method \u003d self.client_ssh.exec_command"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        self.server_ssh.exec_command("},{"line_number":175,"context_line":"                \u0027echo \"{}\" \u003e input.txt\u0027.format(self.test_str))"},{"line_number":176,"context_line":"        server_exec_method(\u0027tail -f input.txt | nc -lp \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"feebcf40_0496a746","line":173,"range":{"start_line":167,"start_character":0,"end_line":173,"end_character":0},"updated":"2022-02-28 14:10:37.000000000","message":"I\u0027m going to propose a different solution because my assumption (that execute_script works for advanced images and exec_command works for cirros ones when running a background command) is not right - I found some advance images (more specifically, RHEL7) that need to use exec_command for background command\n\nSo, the proposed solution will be something like \ntry:\n    execute_script(cmd)\nexcept paramiko.SSHException:\n    exec_command(cmd)","commit_id":"e2a638d257361bd74e7d13fb13c7ff7660a03912"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"1f6c4a66c5b6f7f18797fb78d17cbbafe600a63b","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        return \u0027attempt_{}\u0027.format(str(self.test_attempt).zfill(3))"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def _start_connection(self):"},{"line_number":167,"context_line":"        if CONF.neutron_plugin_options.default_image_is_advanced:"},{"line_number":168,"context_line":"            server_exec_method \u003d self.server_ssh.execute_script"},{"line_number":169,"context_line":"            client_exec_method \u003d self.client_ssh.execute_script"},{"line_number":170,"context_line":"        else:"},{"line_number":171,"context_line":"            server_exec_method \u003d self.server_ssh.exec_command"},{"line_number":172,"context_line":"            client_exec_method \u003d self.client_ssh.exec_command"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        self.server_ssh.exec_command("},{"line_number":175,"context_line":"                \u0027echo \"{}\" \u003e input.txt\u0027.format(self.test_str))"},{"line_number":176,"context_line":"        server_exec_method(\u0027tail -f input.txt | nc -lp \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"35c5d38b_b137b376","line":173,"range":{"start_line":167,"start_character":0,"end_line":173,"end_character":0},"in_reply_to":"feebcf40_0496a746","updated":"2022-02-28 15:22:19.000000000","message":"Done","commit_id":"e2a638d257361bd74e7d13fb13c7ff7660a03912"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"90de355b81c01f0c237bb3b7dc9bc9f5411a367b","unresolved":true,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def _start_connection(self):"},{"line_number":167,"context_line":"        def _run_background_command(ssh_client, cmd):"},{"line_number":168,"context_line":"            # Depending on the VM images used by the test, the background"},{"line_number":169,"context_line":"            # commands need to be executed with either execute_script or"},{"line_number":170,"context_line":"            # exec_command - Examples:"},{"line_number":171,"context_line":"            # ubuntu and RHEL8 images -\u003e execute_script"}],"source_content_type":"text/x-python","patch_set":2,"id":"4837b13c_d8048595","line":168,"updated":"2022-02-28 15:22:36.000000000","message":"+1, this is actually implemented (and working) in our CI","commit_id":"e5f16cfcfa02e895005e3bb55a8269b3f8cd07f2"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"dac9a3819e04b4e901759cce667410bfd5eaeb4d","unresolved":true,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def _start_connection(self):"},{"line_number":167,"context_line":"        def _run_background_command(ssh_client, cmd):"},{"line_number":168,"context_line":"            # Depending on the VM images used by the test, the background"},{"line_number":169,"context_line":"            # commands need to be executed with either execute_script or"},{"line_number":170,"context_line":"            # exec_command - Examples:"},{"line_number":171,"context_line":"            # ubuntu and RHEL8 images -\u003e execute_script"}],"source_content_type":"text/x-python","patch_set":2,"id":"60f1a203_15db2427","line":168,"in_reply_to":"4837b13c_d8048595","updated":"2022-02-28 18:08:14.000000000","message":"Unfortunately I was wrong about cirros...\n\nThis code works fine for RHEL7, which raises a paramiko.SSHException when execute_script is used and then exec_command works fine with RHEL7\nOn the contrary, cirros does not raise any exception, but the command run using execute_script does not work properly and the test fails\n\nSo, I\u0027m going to restore the previous patch set, which works fine for RHEL8, ubuntu and cirros\nIt won\u0027t work well with RHEL7, but this patch will not be backported to the corresponding RHOSP release, so it should not affect","commit_id":"e5f16cfcfa02e895005e3bb55a8269b3f8cd07f2"}]}
