)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"5a31bce549ef969334ab9ab7322599b682dfe00f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"66e492bd_e5b6d6ea","updated":"2022-03-01 10:02:48.000000000","message":"recheck","commit_id":"1e428dbf1a0d0f2ddb9fcc614204d0bced03ee16"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"6190331f4b5f86d44f34631fafe47da449efe74f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e62a09b6_245e0267","updated":"2022-03-01 13:32:19.000000000","message":"recheck","commit_id":"1e428dbf1a0d0f2ddb9fcc614204d0bced03ee16"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4d41978c22e0a0b8bdd48387c3d0b1d2d9e0b4d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"be5c1fa3_b93b8e37","updated":"2022-03-12 12:01:29.000000000","message":"recheck","commit_id":"fd7d8a711e772a1ecae2cc4a239e80348c414809"}],"neutron_tempest_plugin/scenario/test_ipv6.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0e0f1100c0ee900954e7a67c9204114b6db9bb0b","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    Required because guest images usually set only the first vNIC on boot."},{"line_number":42,"context_line":"    Searches for the IPv6 vNIC\u0027s MAC and brings it up."},{"line_number":43,"context_line":"    # NOTE(slaweq): on RHEL based OS ifcfg file for new interface is"},{"line_number":44,"context_line":"    # needed to make IPv6 working on it, so if"},{"line_number":45,"context_line":"    # /etc/sysconfig/network-scripts directory exists ifcfg-%(nic)s file"},{"line_number":46,"context_line":"    # should be added in it"}],"source_content_type":"text/x-python","patch_set":7,"id":"8274c80d_275f725e","line":43,"range":{"start_line":43,"start_character":11,"end_line":43,"end_character":17},"updated":"2022-03-09 09:37:08.000000000","message":"hmm, why You added me as author of that note? :)","commit_id":"f59c7eb322945fd72f74071c72956f09cfc26e2a"},{"author":{"_account_id":29088,"name":"Candido Campos Rivas","email":"ccamposr@redhat.com","username":"ccamposr"},"change_message_id":"a7c4cbbc953ca191ed08c424d158e60dba816781","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    Required because guest images usually set only the first vNIC on boot."},{"line_number":42,"context_line":"    Searches for the IPv6 vNIC\u0027s MAC and brings it up."},{"line_number":43,"context_line":"    # NOTE(slaweq): on RHEL based OS ifcfg file for new interface is"},{"line_number":44,"context_line":"    # needed to make IPv6 working on it, so if"},{"line_number":45,"context_line":"    # /etc/sysconfig/network-scripts directory exists ifcfg-%(nic)s file"},{"line_number":46,"context_line":"    # should be added in it"}],"source_content_type":"text/x-python","patch_set":7,"id":"38a4c9ed_96df4585","line":43,"range":{"start_line":43,"start_character":11,"end_line":43,"end_character":17},"in_reply_to":"8274c80d_275f725e","updated":"2022-03-10 08:17:52.000000000","message":"I\u0027ve recovered the old code in this part with the original comments :)","commit_id":"f59c7eb322945fd72f74071c72956f09cfc26e2a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0e0f1100c0ee900954e7a67c9204114b6db9bb0b","unresolved":true,"context_lines":[{"line_number":180,"context_line":"        for i in range(0, 60):"},{"line_number":181,"context_line":"            if guest_has_address(ipv6_address):"},{"line_number":182,"context_line":"                return"},{"line_number":183,"context_line":"            time.sleep(1)"},{"line_number":184,"context_line":"        if not guest_has_address(ipv6_address):"},{"line_number":185,"context_line":"            try:"},{"line_number":186,"context_line":"                # Set NIC with IPv6 to be UP and wait until IPv6 address"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f9808f0_efe374cb","line":183,"updated":"2022-03-09 09:37:08.000000000","message":"why such loop instead of the wait_until_true() function as is done below?","commit_id":"f59c7eb322945fd72f74071c72956f09cfc26e2a"},{"author":{"_account_id":29088,"name":"Candido Campos Rivas","email":"ccamposr@redhat.com","username":"ccamposr"},"change_message_id":"a7c4cbbc953ca191ed08c424d158e60dba816781","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        for i in range(0, 60):"},{"line_number":181,"context_line":"            if guest_has_address(ipv6_address):"},{"line_number":182,"context_line":"                return"},{"line_number":183,"context_line":"            time.sleep(1)"},{"line_number":184,"context_line":"        if not guest_has_address(ipv6_address):"},{"line_number":185,"context_line":"            try:"},{"line_number":186,"context_line":"                # Set NIC with IPv6 to be UP and wait until IPv6 address"}],"source_content_type":"text/x-python","patch_set":7,"id":"dea5743d_c5444b36","line":183,"in_reply_to":"7f9808f0_efe374cb","updated":"2022-03-10 08:17:52.000000000","message":"Done","commit_id":"f59c7eb322945fd72f74071c72956f09cfc26e2a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a64957b82e2118d6851ea1d36616ca3baed26493","unresolved":true,"context_lines":[{"line_number":33,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def turn_nic6_on(ssh, ipv6_port):"},{"line_number":37,"context_line":"    \"\"\"Turns the IPv6 vNIC on"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Required because guest images usually set only the first vNIC on boot."}],"source_content_type":"text/x-python","patch_set":8,"id":"08993e1a_329374fe","line":36,"range":{"start_line":36,"start_character":4,"end_line":36,"end_character":16},"updated":"2022-03-10 08:21:53.000000000","message":"nit: Just reading the method names, I don\u0027t see the difference between \"on\" and \"up\". I would have reused the same method with a parameter \"config\u003dTrue\", to trigger the nic configuration.","commit_id":"9ce1832bce8241aae0f65bd8cc34ca6a6e5833b4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8bae5cf0e80b5a4d8865d86d2a4df72aabd5f4b5","unresolved":true,"context_lines":[{"line_number":33,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def turn_nic6_on(ssh, ipv6_port, config_nic\u003dTrue):"},{"line_number":37,"context_line":"    \"\"\"Turns the IPv6 vNIC on"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Required because guest images usually set only the first vNIC on boot."}],"source_content_type":"text/x-python","patch_set":9,"id":"e76d7624_57d2996c","line":36,"range":{"start_line":36,"start_character":4,"end_line":36,"end_character":16},"updated":"2022-03-10 09:54:42.000000000","message":"that was just a nit! but thanks","commit_id":"fd7d8a711e772a1ecae2cc4a239e80348c414809"},{"author":{"_account_id":29088,"name":"Candido Campos Rivas","email":"ccamposr@redhat.com","username":"ccamposr"},"change_message_id":"082050eec81185324cb23345a0c1b2e10613d31e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def turn_nic6_on(ssh, ipv6_port, config_nic\u003dTrue):"},{"line_number":37,"context_line":"    \"\"\"Turns the IPv6 vNIC on"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Required because guest images usually set only the first vNIC on boot."}],"source_content_type":"text/x-python","patch_set":9,"id":"0a3679aa_738d0d06","line":36,"range":{"start_line":36,"start_character":4,"end_line":36,"end_character":16},"in_reply_to":"e76d7624_57d2996c","updated":"2022-03-10 10:36:43.000000000","message":":)","commit_id":"fd7d8a711e772a1ecae2cc4a239e80348c414809"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d3d58ed85e4b5541a3cd1cf3f48fd6c66567ff43","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    # should be added in it"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @param ssh: RemoteClient ssh instance to server"},{"line_number":47,"context_line":"    @param ipv6_port: port from IPv6 network attached to the server"},{"line_number":48,"context_line":"    \"\"\""},{"line_number":49,"context_line":"    ip_command \u003d ip.IPCommand(ssh)"},{"line_number":50,"context_line":"    nic \u003d ip_command.get_nic_name_by_mac(ipv6_port[\u0027mac_address\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"21db2468_e27a1703","line":47,"updated":"2022-03-10 12:43:09.000000000","message":"nit: can have added description about new param.","commit_id":"fd7d8a711e772a1ecae2cc4a239e80348c414809"}]}