)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4486f75c287f86a02edc854835446e00d5bef13d","unresolved":true,"context_lines":[{"line_number":10,"context_line":"using a new config option validation.ssh_key_type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Let\u0027s honour this while creating ssh and keypair"},{"line_number":13,"context_line":"clients. This is needed atleast for latest openssl"},{"line_number":14,"context_line":"package in CentOS 9-stream where support for \u0027rsa\u0027"},{"line_number":15,"context_line":"key is dropped."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"de27919d_1448ccdd","line":13,"range":{"start_line":13,"start_character":24,"end_line":13,"end_character":31},"updated":"2022-03-09 09:02:17.000000000","message":"nit: at least","commit_id":"2ad4d583ec0ce4a5a48212a675cbf1762d121640"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c27853b9a6ecbf34a0467d3e4ee251f1b52fe4f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bc21c227_75365b93","updated":"2022-03-09 06:21:20.000000000","message":"Based on current testing: https://bugs.launchpad.net/tripleo/+bug/1963907/comments/5\nneutron_tempest_plugin.scenario.test_port_forwardings.PortForwardingTestJSON.test_port_forwarding_to_2_servers\n\nand tempest.scenario.test_network_v6.TestGettingAddress.test_slaac_from_os are failing with\n\ntempest.lib.exceptions.ServerFault: Got server fault\nDetails: Unexpected API Error. Please report this at http://bugs.launchpad.net/nova/ and attach the Nova API log if possible.\n\u003cclass \u0027oslo_db.exception.DBConnectionError\u0027\u003e\n\nI think we can get this patch merged and investigate further.","commit_id":"2ad4d583ec0ce4a5a48212a675cbf1762d121640"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"599f500b9fb5da2aee98544fc817302ec64c340a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4ea3571c_e10c889f","updated":"2022-03-09 06:26:02.000000000","message":"LGTM!","commit_id":"2ad4d583ec0ce4a5a48212a675cbf1762d121640"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4486f75c287f86a02edc854835446e00d5bef13d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2d8b21aa_c272f089","updated":"2022-03-09 09:02:17.000000000","message":"Thanks","commit_id":"2ad4d583ec0ce4a5a48212a675cbf1762d121640"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"cb64faeea6a9556517cf449091c9d2b1c5d7ac11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5714322a_257de271","in_reply_to":"bc21c227_75365b93","updated":"2022-03-09 07:00:47.000000000","message":"Yes those are unrelated and seperate issues so can be investigated seperately.","commit_id":"2ad4d583ec0ce4a5a48212a675cbf1762d121640"}],"neutron_tempest_plugin/api/base.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"46874856f6b93358df739ea48190678173d030b3","unresolved":true,"context_lines":[{"line_number":1012,"context_line":"    def create_keypair(cls, client\u003dNone, name\u003dNone, **kwargs):"},{"line_number":1013,"context_line":"        client \u003d client or cls.os_primary.keypairs_client"},{"line_number":1014,"context_line":"        name \u003d name or data_utils.rand_name(\u0027keypair-test\u0027)"},{"line_number":1015,"context_line":"        keypair \u003d client.create_keypair(name\u003dname, **kwargs)[\u0027keypair\u0027]"},{"line_number":1016,"context_line":""},{"line_number":1017,"context_line":"        # save client for later cleanup"},{"line_number":1018,"context_line":"        keypair[\u0027client\u0027] \u003d client"}],"source_content_type":"text/x-python","patch_set":1,"id":"95bc4263_4460914a","line":1015,"range":{"start_line":1015,"start_character":8,"end_line":1015,"end_character":71},"updated":"2022-03-09 08:41:31.000000000","message":"Should we provide a default \"keypair_type\", using the config knob, when creating a new keypair?","commit_id":"2ad4d583ec0ce4a5a48212a675cbf1762d121640"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e56b229431a2dea6739a300195871f508e3d613a","unresolved":true,"context_lines":[{"line_number":1012,"context_line":"    def create_keypair(cls, client\u003dNone, name\u003dNone, **kwargs):"},{"line_number":1013,"context_line":"        client \u003d client or cls.os_primary.keypairs_client"},{"line_number":1014,"context_line":"        name \u003d name or data_utils.rand_name(\u0027keypair-test\u0027)"},{"line_number":1015,"context_line":"        keypair \u003d client.create_keypair(name\u003dname, **kwargs)[\u0027keypair\u0027]"},{"line_number":1016,"context_line":""},{"line_number":1017,"context_line":"        # save client for later cleanup"},{"line_number":1018,"context_line":"        keypair[\u0027client\u0027] \u003d client"}],"source_content_type":"text/x-python","patch_set":1,"id":"2176af7a_1c6b47ac","line":1015,"range":{"start_line":1015,"start_character":8,"end_line":1015,"end_character":71},"in_reply_to":"95bc4263_4460914a","updated":"2022-03-09 08:59:27.000000000","message":"I think it\u0027s good to just go with tempest defaults in config option as used in keyparirs_client, and if in future there is some needed create keypair of different types in neutron tests that can be done later.\n\nAlso custom types other than ecdsa i think for those processing needs to be done here as on tempest side only that is taken care off https://opendev.org/openstack/tempest/src/branch/master/tempest/lib/services/compute/keypairs_client.py#L82 and i doubt if nova supports creating other key types consider tempest code as special handling for ecdsa, but if needed i can look into nova side.","commit_id":"2ad4d583ec0ce4a5a48212a675cbf1762d121640"}]}