)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"4832739fa5479307a02fb7f364c17a6705a3a5ae","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Adding the skip_checks to the test fixes the issue."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"IT also removes RULES_NAME unused var."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[1]. https://review.opendev.org/c/openstack/tempest/+/822560"},{"line_number":35,"context_line":"[2]. https://review.rdoproject.org/r/c/rdoinfo/+/40228"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"63631278_84b4efbd","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":38},"updated":"2022-03-10 06:22:14.000000000","message":"i see it\u0027s used in tests, also you have not removed just moved to setUp, is this just extra here?","commit_id":"5475ea5eca5a3b2edfb98c6444b2ac2799c647ac"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"0bfffecfb626841a19cadfabec6da8e29e170bff","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Adding the skip_checks to the test fixes the issue."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"IT also removes RULES_NAME unused var."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[1]. https://review.opendev.org/c/openstack/tempest/+/822560"},{"line_number":35,"context_line":"[2]. https://review.rdoproject.org/r/c/rdoinfo/+/40228"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f9fa89c9_a9659616","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":38},"in_reply_to":"63631278_84b4efbd","updated":"2022-03-10 06:24:04.000000000","message":"Thanks for highlighting, removing this line.","commit_id":"5475ea5eca5a3b2edfb98c6444b2ac2799c647ac"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2e431618499fc90ec316a8c0c380e34c45ac7763","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Adding the skip_checks to the test fixes the issue."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"IT also removes RULES_NAME unused var."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[1]. https://review.opendev.org/c/openstack/tempest/+/822560"},{"line_number":35,"context_line":"[2]. https://review.rdoproject.org/r/c/rdoinfo/+/40228"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ac9ec354_cdcad9dc","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":38},"in_reply_to":"f9fa89c9_a9659616","updated":"2022-03-10 08:32:41.000000000","message":"Done","commit_id":"5475ea5eca5a3b2edfb98c6444b2ac2799c647ac"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"23fd26362113abc7b75490ca8fa57ed79828d452","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cc64b9ed_1065f9b8","updated":"2022-03-10 06:47:53.000000000","message":"Looks reasonable in order to get tempest discovery working with older neutron-lib in wallaby. The other option would be to move the use of qos_consts to setUp and use exclude list to skip the Test class. Bu auto detect/skip looks better for this case.","commit_id":"dd6f2c774fa2c0e70999926928c40979c6173b88"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a69978dd37419241cbd425faa5c33f0ea028c0dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4c725054_f912dd45","updated":"2022-03-10 06:57:49.000000000","message":"thanks chkumar","commit_id":"dd6f2c774fa2c0e70999926928c40979c6173b88"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"d9c152cf77b0241e2ea37e79e972b3adaf3ddf13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"90abfccf_b068972a","updated":"2022-03-10 11:08:14.000000000","message":"I\u0027ve tested it in wallaby with a package built in https://review.rdoproject.org/r/c/openstack/neutron-tempest-plugin-distgit/+/40284 and at least i can discover the tests wit no issue.\n\nPackage for cs9 wallaby is available in \n\nhttps://logserver.rdoproject.org/84/40284/2/check/DLRN-rpmbuild-centos9/7a024ad/buildset/centos9/current/\n\n\n","commit_id":"255586cca98d0f49d44ed511279627b83995d925"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"69a21f5058aef52e20eed5fb877fe83470d219dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1b7495f7_1f3d342c","updated":"2022-03-10 08:58:58.000000000","message":"LGTM","commit_id":"255586cca98d0f49d44ed511279627b83995d925"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c7e510f7af136ec1ba5d1fa90ca102e270caa9a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"eebe608f_ab25f1b9","updated":"2022-03-10 11:34:36.000000000","message":"Thanks","commit_id":"255586cca98d0f49d44ed511279627b83995d925"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"628064f396554d67396f4b88c3473ea40eb0d094","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"200bb3dd_71c26cbc","updated":"2022-03-10 10:54:53.000000000","message":"recheck","commit_id":"255586cca98d0f49d44ed511279627b83995d925"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ef878de818a6ade8a55c147b80935bdb6068c967","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4a5f1cf0_03a1b2b2","updated":"2022-03-10 10:54:48.000000000","message":"recheck tempest failure","commit_id":"255586cca98d0f49d44ed511279627b83995d925"}],"neutron_tempest_plugin/api/test_qos.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"21958b90e724b2dfb64e23ce7a4b849516e983b2","unresolved":true,"context_lines":[{"line_number":1408,"context_line":"            raise cls.skipException(\u0027Minimum Packet rate not supported\u0027)"},{"line_number":1409,"context_line":""},{"line_number":1410,"context_line":"    @classmethod"},{"line_number":1411,"context_line":"    @utils.requires_ext(service\u003d\u0027network\u0027,"},{"line_number":1412,"context_line":"                        extension\u003d\u0027port-resource-request-groups\u0027)"},{"line_number":1413,"context_line":"    def resource_setup(cls):"},{"line_number":1414,"context_line":"        super(QosMinimumPpsRuleTestJSON, cls).resource_setup()"},{"line_number":1415,"context_line":""},{"line_number":1416,"context_line":"    @classmethod"},{"line_number":1417,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"40a40f63_01cda460","line":1414,"range":{"start_line":1411,"start_character":0,"end_line":1414,"end_character":62},"updated":"2022-03-10 07:55:51.000000000","message":"seems the skip_checks is not needed, as https://github.com/openstack/neutron-lib/commit/1d64353340f68ced2499787999d5f8e87092652a is only available post xena, and tests should already be skipped in wallaby as that\u0027s missing. Just moving usage of RULE_TYPE_MINIMUM_PACKET_RATE to setUp should have been enough for handling tempest discovery issue.","commit_id":"dd6f2c774fa2c0e70999926928c40979c6173b88"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"121d041537cc34404d0c8e4afe5ebf813defcead","unresolved":true,"context_lines":[{"line_number":1408,"context_line":"            raise cls.skipException(\u0027Minimum Packet rate not supported\u0027)"},{"line_number":1409,"context_line":""},{"line_number":1410,"context_line":"    @classmethod"},{"line_number":1411,"context_line":"    @utils.requires_ext(service\u003d\u0027network\u0027,"},{"line_number":1412,"context_line":"                        extension\u003d\u0027port-resource-request-groups\u0027)"},{"line_number":1413,"context_line":"    def resource_setup(cls):"},{"line_number":1414,"context_line":"        super(QosMinimumPpsRuleTestJSON, cls).resource_setup()"},{"line_number":1415,"context_line":""},{"line_number":1416,"context_line":"    @classmethod"},{"line_number":1417,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"cc3a93d8_01feda71","line":1414,"range":{"start_line":1411,"start_character":0,"end_line":1414,"end_character":62},"in_reply_to":"40a40f63_01cda460","updated":"2022-03-10 08:16:00.000000000","message":"Thanks, It fixes the issue","commit_id":"dd6f2c774fa2c0e70999926928c40979c6173b88"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2e431618499fc90ec316a8c0c380e34c45ac7763","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"            raise cls.skipException(\u0027Minimum Packet rate not supported\u0027)"},{"line_number":1409,"context_line":""},{"line_number":1410,"context_line":"    @classmethod"},{"line_number":1411,"context_line":"    @utils.requires_ext(service\u003d\u0027network\u0027,"},{"line_number":1412,"context_line":"                        extension\u003d\u0027port-resource-request-groups\u0027)"},{"line_number":1413,"context_line":"    def resource_setup(cls):"},{"line_number":1414,"context_line":"        super(QosMinimumPpsRuleTestJSON, cls).resource_setup()"},{"line_number":1415,"context_line":""},{"line_number":1416,"context_line":"    @classmethod"},{"line_number":1417,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"45be4748_2cb34d0f","line":1414,"range":{"start_line":1411,"start_character":0,"end_line":1414,"end_character":62},"in_reply_to":"cc3a93d8_01feda71","updated":"2022-03-10 08:32:41.000000000","message":"Done","commit_id":"dd6f2c774fa2c0e70999926928c40979c6173b88"}]}