)]}'
{"neutron_tempest_plugin/sfc/tests/scenario/manager.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f021f1ff10390b32807985fb7de07d0b0c478c84","unresolved":true,"context_lines":[{"line_number":278,"context_line":"                        floating_ip[\u0027id\u0027])"},{"line_number":279,"context_line":"        return floating_ip"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def check_floating_ip_status(self, floating_ip, status):"},{"line_number":282,"context_line":"        \"\"\"Verifies floatingip reaches the given status"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        :param dict floating_ip: floating IP dict to check status"}],"source_content_type":"text/x-python","patch_set":2,"id":"e4ce84cc_346ce4db","side":"PARENT","line":281,"range":{"start_line":281,"start_character":8,"end_line":281,"end_character":32},"updated":"2022-04-05 11:24:50.000000000","message":"This is being called here [1]. Why it is not failing?\n\n[1]https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/836582/2/neutron_tempest_plugin/sfc/tests/scenario/test_sfc.py#90","commit_id":"96e90907b6a019574bc1714b776dee5acc2f38cf"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fc86a12562b8f0cccb5ff86e6b5932c74aba76c4","unresolved":true,"context_lines":[{"line_number":278,"context_line":"                        floating_ip[\u0027id\u0027])"},{"line_number":279,"context_line":"        return floating_ip"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def check_floating_ip_status(self, floating_ip, status):"},{"line_number":282,"context_line":"        \"\"\"Verifies floatingip reaches the given status"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        :param dict floating_ip: floating IP dict to check status"}],"source_content_type":"text/x-python","patch_set":2,"id":"ec701bf9_4650d6a6","side":"PARENT","line":281,"range":{"start_line":281,"start_character":8,"end_line":281,"end_character":32},"in_reply_to":"2f1b9a6d_32d9aea1","updated":"2022-05-03 15:08:15.000000000","message":"Right! Thanks!","commit_id":"96e90907b6a019574bc1714b776dee5acc2f38cf"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f2667e9d154c39b92ba6291bb94f75aa7f295a09","unresolved":true,"context_lines":[{"line_number":278,"context_line":"                        floating_ip[\u0027id\u0027])"},{"line_number":279,"context_line":"        return floating_ip"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def check_floating_ip_status(self, floating_ip, status):"},{"line_number":282,"context_line":"        \"\"\"Verifies floatingip reaches the given status"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        :param dict floating_ip: floating IP dict to check status"}],"source_content_type":"text/x-python","patch_set":2,"id":"2f1b9a6d_32d9aea1","side":"PARENT","line":281,"range":{"start_line":281,"start_character":8,"end_line":281,"end_character":32},"in_reply_to":"70db2cd8_236e0f0d","updated":"2022-05-03 15:01:13.000000000","message":"Thanks for explanation","commit_id":"96e90907b6a019574bc1714b776dee5acc2f38cf"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"fa7f230d3016f42e007d685a0c8e53ba7d84582b","unresolved":true,"context_lines":[{"line_number":278,"context_line":"                        floating_ip[\u0027id\u0027])"},{"line_number":279,"context_line":"        return floating_ip"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def check_floating_ip_status(self, floating_ip, status):"},{"line_number":282,"context_line":"        \"\"\"Verifies floatingip reaches the given status"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        :param dict floating_ip: floating IP dict to check status"}],"source_content_type":"text/x-python","patch_set":2,"id":"70db2cd8_236e0f0d","side":"PARENT","line":281,"range":{"start_line":281,"start_character":8,"end_line":281,"end_character":32},"in_reply_to":"e4ce84cc_346ce4db","updated":"2022-04-05 12:12:55.000000000","message":"In first patch [1] in this series of dependent patches, the ScenarioTest class inheritance was changed to tempests NetworkScenario test. Since the logic of Tempest\u0027s and Neutron\u0027s implementation of check_floating_ip_status is the same (just a little bug fix added to tempest\u0027s implementation [2]), there is no need to have duplicate implementation (See the effort\u0027s etherpad for more clarification [3]).\n\nUnused methods are on the beginning of the relation chain and have the \"Unused\" keyword in their title, the next ones are used, but are logically same, or similar (the difference is mostly made by bug fixes on tempest\u0027s side)\n\nHope this clarifies it:)\n\n[1]https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/836452/2/neutron_tempest_plugin/sfc/tests/scenario/manager.py#b38\n[2]https://opendev.org/openstack/tempest/commit/f4b5df6d1dd5e562caa672a67106be2e29ab4cf6\n[3]https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup","commit_id":"96e90907b6a019574bc1714b776dee5acc2f38cf"}]}