)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"084ddc16af82cac3d9ef0fd8749e5bc1a99d222d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"list floating ip api contains port forwarding id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if \"fip-pf-detail\" extension is enabled, list floating ip"},{"line_number":10,"context_line":"will return port_forwarding\u0027s \"id\" and \"internal_port_id\"."},{"line_number":11,"context_line":"this patch update list floating ip api except data."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b6812302_64395df1","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":17},"updated":"2022-07-29 13:08:07.000000000","message":"nit: I commented on the n-lib patch: this string should be changes. If my suggestion (justified in the n-lib patch) is accepted, that will change.","commit_id":"92cd80a04fda4e84b55ba749b68bb5706f1e232b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"084ddc16af82cac3d9ef0fd8749e5bc1a99d222d","unresolved":true,"context_lines":[{"line_number":10,"context_line":"will return port_forwarding\u0027s \"id\" and \"internal_port_id\"."},{"line_number":11,"context_line":"this patch update list floating ip api except data."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Needed-By: https://review.opendev.org/c/openstack/neutron/+/840565"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8a69d8786350f80d563f98607177c015134be523"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b2d128d1_ea091ac2","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":9},"updated":"2022-07-29 13:08:07.000000000","message":"This patch is not needed by the neutron one, depends-on.","commit_id":"92cd80a04fda4e84b55ba749b68bb5706f1e232b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cf68d46948336f3627869baaf2c9629d72ee2b3e","unresolved":true,"context_lines":[{"line_number":10,"context_line":"will return port_forwarding\u0027s \"id\" and \"internal_port_id\"."},{"line_number":11,"context_line":"this patch update list floating ip api except data."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron/+/840565"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8a69d8786350f80d563f98607177c015134be523"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b0936a87_31d5fb06","line":13,"updated":"2022-08-01 12:41:29.000000000","message":"I think that Depends-On should it be in the other way around. Neutron patch needs to depends on that one otherwise Zuul on neutron patch will be failing all the time.","commit_id":"47ed920b47d6388d5e187ab4fdcebf38949d6b61"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"f397485e7e453c66457273c116c9b978720b24eb","unresolved":true,"context_lines":[{"line_number":10,"context_line":"will return port_forwarding\u0027s \"id\" and \"internal_port_id\"."},{"line_number":11,"context_line":"this patch update list floating ip api except data."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron/+/840565"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8a69d8786350f80d563f98607177c015134be523"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9af86cea_0a6f7c59","line":13,"in_reply_to":"b0936a87_31d5fb06","updated":"2022-08-05 00:36:44.000000000","message":"hi slawek, rodolfo, this judgment \"utils.is_extension_enabled\" is based on the extensions set in the configuration file, not the actually loaded extensions. In this way, it is interdependent with neutron patch(https://review.opendev.org/c/openstack/neutron/+/840565). Is there any good solution?","commit_id":"47ed920b47d6388d5e187ab4fdcebf38949d6b61"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"53f806f6dc65fdc7d42c47354eef4e3025c9afb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d35c34d2_14a7b44c","updated":"2022-05-05 09:15:24.000000000","message":"recheck","commit_id":"4ce97af325b388bc8e3fd9009bbf1a7609a50aa3"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"7679cf4472fb5510555e654c4599c5b83a706069","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ec8179fc_26cce821","updated":"2022-08-01 07:07:38.000000000","message":"I see you addressed Rodolfo\u0027s comments, thanks!","commit_id":"47ed920b47d6388d5e187ab4fdcebf38949d6b61"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2ae593b2135a9c7821bb585b9584c76fda6bd19e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ec743dc5_1a6710a1","updated":"2022-09-06 11:54:22.000000000","message":"Thanks","commit_id":"02e4fbc4b4bb56070a5db8ab9f7ffe9522806fb9"}],"neutron_tempest_plugin/api/test_port_forwardings.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"aff3b0985b96b75b1e42c236d3435d5ab06fec19","unresolved":true,"context_lines":[{"line_number":131,"context_line":"        # Neutron is adding the return port_forwarding\u0027s \"id\" and"},{"line_number":132,"context_line":"        # \"internal_port_id to list floating ip api. after neutron is"},{"line_number":133,"context_line":"        # merged, can delete this compatibility judgment."},{"line_number":134,"context_line":"        include_id \u003d False"},{"line_number":135,"context_line":"        if fip[\u0027port_forwardings\u0027]:"},{"line_number":136,"context_line":"            include_id \u003d \u0027id\u0027 in fip[\u0027port_forwardings\u0027][0]"},{"line_number":137,"context_line":"        for pf in created_pfs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"074f439f_84bcee67","line":134,"updated":"2022-05-05 10:33:39.000000000","message":"Instead of doing such check, You should add new API extension and then check here if extension is available or not to determine if that new data should be available in response or not.","commit_id":"4ce97af325b388bc8e3fd9009bbf1a7609a50aa3"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"8f2f47a7a4805bb12c2f364fdd28c73d0d988a5a","unresolved":true,"context_lines":[{"line_number":131,"context_line":"        # Neutron is adding the return port_forwarding\u0027s \"id\" and"},{"line_number":132,"context_line":"        # \"internal_port_id to list floating ip api. after neutron is"},{"line_number":133,"context_line":"        # merged, can delete this compatibility judgment."},{"line_number":134,"context_line":"        include_id \u003d False"},{"line_number":135,"context_line":"        if fip[\u0027port_forwardings\u0027]:"},{"line_number":136,"context_line":"            include_id \u003d \u0027id\u0027 in fip[\u0027port_forwardings\u0027][0]"},{"line_number":137,"context_line":"        for pf in created_pfs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"c6faca01_193e7804","line":134,"in_reply_to":"074f439f_84bcee67","updated":"2022-05-06 00:40:09.000000000","message":"thanks slawek, I will update it.","commit_id":"4ce97af325b388bc8e3fd9009bbf1a7609a50aa3"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"50e436bcc976557abfcd5187c5b997f6a3d03baf","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        # Neutron is adding the return port_forwarding\u0027s \"id\" and"},{"line_number":132,"context_line":"        # \"internal_port_id to list floating ip api. after neutron is"},{"line_number":133,"context_line":"        # merged, can delete this compatibility judgment."},{"line_number":134,"context_line":"        include_id \u003d False"},{"line_number":135,"context_line":"        if fip[\u0027port_forwardings\u0027]:"},{"line_number":136,"context_line":"            include_id \u003d \u0027id\u0027 in fip[\u0027port_forwardings\u0027][0]"},{"line_number":137,"context_line":"        for pf in created_pfs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"2c1ebd8d_b80d0d2b","line":134,"in_reply_to":"c6faca01_193e7804","updated":"2022-05-07 03:11:03.000000000","message":"Done","commit_id":"4ce97af325b388bc8e3fd9009bbf1a7609a50aa3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8c6e0eba612aa01cddd82261d3c4500acf3d6019","unresolved":true,"context_lines":[{"line_number":127,"context_line":"    def _verify_created_pfs(self, fip_id, created_pfs):"},{"line_number":128,"context_line":"        # TODO(zhouhenglc) direct return until the patch("},{"line_number":129,"context_line":"        # https://review.opendev.org/c/openstack/neutron/+/840565) is merged."},{"line_number":130,"context_line":"        return"},{"line_number":131,"context_line":"        # Check that all PFs are visible in Floating IP details"},{"line_number":132,"context_line":"        fip \u003d self.client.show_floatingip(fip_id)[\u0027floatingip\u0027]"},{"line_number":133,"context_line":"        self.assertEqual(len(created_pfs), len(fip[\u0027port_forwardings\u0027]))"}],"source_content_type":"text/x-python","patch_set":10,"id":"63c46e52_21221a61","line":130,"updated":"2022-08-31 14:59:00.000000000","message":"instead of doing that You can use \"requires_ext\" decorator or is_extension_enabled() function and skip test if there is no required extension","commit_id":"637e63b3b7a3e18ee90d96817970b6ff1ec1dcad"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"bc065fe15d3df6aa82b40e74e54846fee70398a8","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def _verify_created_pfs(self, fip_id, created_pfs):"},{"line_number":128,"context_line":"        # TODO(zhouhenglc) direct return until the patch("},{"line_number":129,"context_line":"        # https://review.opendev.org/c/openstack/neutron/+/840565) is merged."},{"line_number":130,"context_line":"        return"},{"line_number":131,"context_line":"        # Check that all PFs are visible in Floating IP details"},{"line_number":132,"context_line":"        fip \u003d self.client.show_floatingip(fip_id)[\u0027floatingip\u0027]"},{"line_number":133,"context_line":"        self.assertEqual(len(created_pfs), len(fip[\u0027port_forwardings\u0027]))"}],"source_content_type":"text/x-python","patch_set":10,"id":"aa388c6c_32a521bd","line":130,"in_reply_to":"63c46e52_21221a61","updated":"2022-09-06 08:26:50.000000000","message":"Done","commit_id":"637e63b3b7a3e18ee90d96817970b6ff1ec1dcad"}]}