)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"a9d537f6f2d1afa39b61c2ecacdd1701afe5e5e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"23fbe942_ae25583c","updated":"2022-06-10 06:46:42.000000000","message":"LGTM","commit_id":"823b1a05bf53715a9d353818c6c6987f1e20d5dd"}],"neutron_tempest_plugin/common/ip.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4609157573b674f782aaf3b3b13e95ea3c468b5c","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        return shell.execute(command_line, ssh_client\u003dself.ssh_client,"},{"line_number":58,"context_line":"                             timeout\u003dself.timeout).stdout"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def configure_vlan(self, addresses, port, vlan_tag, subport_ips, mac\u003dNone):"},{"line_number":61,"context_line":"        port_device \u003d get_port_device_name(addresses\u003daddresses, port\u003dport)"},{"line_number":62,"context_line":"        subport_device \u003d \u0027{!s}.{!s}\u0027.format(port_device, vlan_tag)"},{"line_number":63,"context_line":"        LOG.debug(\u0027Configuring VLAN subport interface %r on top of interface \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"afe38efe_209e532b","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":22},"updated":"2022-06-14 06:58:50.000000000","message":"nit: this is more configure_vlan_interface() as the method makes much more thing than just configuring vlan","commit_id":"823b1a05bf53715a9d353818c6c6987f1e20d5dd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7b729c2b10fa6db858a04ff32f8132db89021723","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return shell.execute(command_line, ssh_client\u003dself.ssh_client,"},{"line_number":58,"context_line":"                             timeout\u003dself.timeout).stdout"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def configure_vlan(self, addresses, port, vlan_tag, subport_ips, mac\u003dNone):"},{"line_number":61,"context_line":"        port_device \u003d get_port_device_name(addresses\u003daddresses, port\u003dport)"},{"line_number":62,"context_line":"        subport_device \u003d \u0027{!s}.{!s}\u0027.format(port_device, vlan_tag)"},{"line_number":63,"context_line":"        LOG.debug(\u0027Configuring VLAN subport interface %r on top of interface \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"58fc16ac_901cf2d4","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":22},"in_reply_to":"afe38efe_209e532b","updated":"2022-06-15 08:54:16.000000000","message":"yeah, or just configure_interface()","commit_id":"823b1a05bf53715a9d353818c6c6987f1e20d5dd"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"551f8b679d5778a235255a29f855e89821e44a36","unresolved":true,"context_lines":[{"line_number":94,"context_line":"                \"subport\")"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        return self.configure_vlan(addresses, port, vlan_tag, subport_ips,"},{"line_number":97,"context_line":"                                   subport[\u0027mac_address\u0027])"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def configure_vlan_transparent(self, port, vlan_tag, ip_addresses):"},{"line_number":100,"context_line":"        addresses \u003d self.list_addresses()"}],"source_content_type":"text/x-python","patch_set":1,"id":"68eb12d8_31831b81","line":97,"range":{"start_line":97,"start_character":35,"end_line":97,"end_character":57},"updated":"2022-06-03 13:14:23.000000000","message":"maybe this is better for backward compatibility:\nsubport.get(\u0027mac_address\u0027)","commit_id":"823b1a05bf53715a9d353818c6c6987f1e20d5dd"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"a039fc9b8b2a35cf611a7c07f8a1c9ed5b12d0f1","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                \"subport\")"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        return self.configure_vlan(addresses, port, vlan_tag, subport_ips,"},{"line_number":97,"context_line":"                                   subport[\u0027mac_address\u0027])"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def configure_vlan_transparent(self, port, vlan_tag, ip_addresses):"},{"line_number":100,"context_line":"        addresses \u003d self.list_addresses()"}],"source_content_type":"text/x-python","patch_set":1,"id":"a4f22643_1f305226","line":97,"range":{"start_line":97,"start_character":35,"end_line":97,"end_character":57},"in_reply_to":"68eb12d8_31831b81","updated":"2022-06-03 14:56:22.000000000","message":"it seems the subports, as any ports, always have a mac_address - ignore my comment","commit_id":"823b1a05bf53715a9d353818c6c6987f1e20d5dd"}]}