)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"03fab7a502a1c96a1d70f06344f204fd6e472334","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ayenachew Molla \u003camolla@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-07 13:51:38 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a test for removig security group from running instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New test cases:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8017cb0e_e645f331","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":22},"updated":"2022-06-07 14:16:16.000000000","message":"nit: removing","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"eaa1c5c37812e44ecc9e56fdea72a143793c3e5f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ayenachew Molla \u003camolla@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-07 13:51:38 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a test for removig security group from running instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New test cases:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"479c00ab_314bb17f","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":22},"in_reply_to":"8017cb0e_e645f331","updated":"2022-06-09 14:22:12.000000000","message":"Done","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"1bb737c33bc72070926aba0e79ee630d01cc7e2c","unresolved":true,"context_lines":[{"line_number":12,"context_line":"1) Create a security group"},{"line_number":13,"context_line":"2) Create a VM"},{"line_number":14,"context_line":"3) Add security group to vm"},{"line_number":15,"context_line":"4) Delete the scurity group from vm"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I9fbcdd0f30beeb6985bab4de4d53af639f408c75"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"6453d771_33a85586","line":15,"updated":"2022-06-09 17:01:55.000000000","message":"nit: there is a typo there.\n\nIf you are using vim to write commit messages,\ntry running \u0027:set spell\u0027, it will highlight typos and will help noticing them.","commit_id":"87b9b2b45497e817b0d1beafd85dbde98c6feac1"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"87392ce03ca50ddcd8c31f6f591716c8304e7399","unresolved":false,"context_lines":[{"line_number":12,"context_line":"1) Create a security group"},{"line_number":13,"context_line":"2) Create a VM"},{"line_number":14,"context_line":"3) Add security group to vm"},{"line_number":15,"context_line":"4) Delete the scurity group from vm"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I9fbcdd0f30beeb6985bab4de4d53af639f408c75"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a12cee0_632a2503","line":15,"in_reply_to":"6453d771_33a85586","updated":"2022-06-13 09:25:06.000000000","message":"Done","commit_id":"87b9b2b45497e817b0d1beafd85dbde98c6feac1"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f3c105e4c49802ad88d6df15d3a1ac21b2d7ccc8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ayenachew Molla \u003camolla@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-20 19:48:49 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a test for removing security group from running instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New test cases:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f0d2533_6a724f8f","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":52},"updated":"2022-06-20 21:41:34.000000000","message":"ACTIVE","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"6e0439174707767944012b35c959c01e94716c52","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ayenachew Molla \u003camolla@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-20 19:48:49 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a test for removing security group from running instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New test cases:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"d22983c6_f247ac2b","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":52},"in_reply_to":"7f0d2533_6a724f8f","updated":"2022-06-21 08:23:39.000000000","message":"Done","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f3c105e4c49802ad88d6df15d3a1ac21b2d7ccc8","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a test for removing security group from running instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New test cases:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Test name: \"test_remove_security_group_from_running_instance\""},{"line_number":12,"context_line":"1) Create a security group"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"25e5d12b_39adf1ca","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":15},"updated":"2022-06-20 21:41:34.000000000","message":"There is only one test added","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"6e0439174707767944012b35c959c01e94716c52","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a test for removing security group from running instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New test cases:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Test name: \"test_remove_security_group_from_running_instance\""},{"line_number":12,"context_line":"1) Create a security group"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9d4ea734_0e2ed6d8","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":15},"in_reply_to":"25e5d12b_39adf1ca","updated":"2022-06-21 08:23:39.000000000","message":"Done","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f3c105e4c49802ad88d6df15d3a1ac21b2d7ccc8","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New test cases:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Test name: \"test_remove_security_group_from_running_instance\""},{"line_number":12,"context_line":"1) Create a security group"},{"line_number":13,"context_line":"2) Create a VM"},{"line_number":14,"context_line":"3) Add security group to vm"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5cce266e_8fa1252c","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":60},"updated":"2022-06-20 21:41:34.000000000","message":"Should be the same name as in your code.","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"6e0439174707767944012b35c959c01e94716c52","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New test cases:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Test name: \"test_remove_security_group_from_running_instance\""},{"line_number":12,"context_line":"1) Create a security group"},{"line_number":13,"context_line":"2) Create a VM"},{"line_number":14,"context_line":"3) Add security group to vm"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7e8811e9_7d5e063f","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":60},"in_reply_to":"5cce266e_8fa1252c","updated":"2022-06-21 08:23:39.000000000","message":"Done","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f3c105e4c49802ad88d6df15d3a1ac21b2d7ccc8","unresolved":true,"context_lines":[{"line_number":9,"context_line":"New test cases:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Test name: \"test_remove_security_group_from_running_instance\""},{"line_number":12,"context_line":"1) Create a security group"},{"line_number":13,"context_line":"2) Create a VM"},{"line_number":14,"context_line":"3) Add security group to vm"},{"line_number":15,"context_line":"4) Delete the scurity group from vm"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I9fbcdd0f30beeb6985bab4de4d53af639f408c75"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"19fde2f6_9ad7cd96","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":35},"updated":"2022-06-20 21:41:34.000000000","message":"This scenario explained here needs to be changed, for example there is nothing about PING here.","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"6e0439174707767944012b35c959c01e94716c52","unresolved":false,"context_lines":[{"line_number":9,"context_line":"New test cases:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Test name: \"test_remove_security_group_from_running_instance\""},{"line_number":12,"context_line":"1) Create a security group"},{"line_number":13,"context_line":"2) Create a VM"},{"line_number":14,"context_line":"3) Add security group to vm"},{"line_number":15,"context_line":"4) Delete the scurity group from vm"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I9fbcdd0f30beeb6985bab4de4d53af639f408c75"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f466af2c_6068b0ed","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":35},"in_reply_to":"19fde2f6_9ad7cd96","updated":"2022-06-21 08:23:39.000000000","message":"Done","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"03fab7a502a1c96a1d70f06344f204fd6e472334","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f17409b7_c901f79e","updated":"2022-06-07 14:16:16.000000000","message":"I recommend to fix all gate comments before people will start the review. ","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7bbf3e8a243f94218f8d4b10e6708169dcb141a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"87528d8b_840ef4db","updated":"2022-06-20 12:46:22.000000000","message":"recheck\nto have fresh results\nfor vpnaas, I have to check the results, as perhaps recent SQLAlchemy related changes","commit_id":"a9590fa3b301472df8b879d8b7ff8e4e4717ac14"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"177b0930ee1da72c33dc0ca19623c6e57ebfa82e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"68583aed_4ada6cde","updated":"2022-06-20 16:54:34.000000000","message":"thanks for the comment, i organized and refactoring the code","commit_id":"a9590fa3b301472df8b879d8b7ff8e4e4717ac14"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"6e0439174707767944012b35c959c01e94716c52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d8c2b278_cc0ab218","updated":"2022-06-21 08:23:39.000000000","message":"Fixed it all comment","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"e277645f0f36db147949c7a1cfdbd09bfa5ab3e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c06eab68_4c0dd5db","updated":"2022-06-21 20:09:40.000000000","message":"Fixed","commit_id":"f792a158b2dd1ea4f1b197a94935b8e1b633cd9b"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d4558cd060ccec30dd03bc60a6aea0545874b34a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"71313cf0_97143a4f","updated":"2022-06-21 18:28:47.000000000","message":"Some minors related to comments + one that should be fixed L684","commit_id":"f792a158b2dd1ea4f1b197a94935b8e1b633cd9b"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"6a50225209f35369ef4b8820925d8fd399a6a0e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d963feeb_a655163a","updated":"2022-06-22 20:05:30.000000000","message":"All Maor\u0027s comments are in place here, thanks Maor!\n","commit_id":"5f0fbb12e89594294c884f5e8467299afe6f7220"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"bb2f6778c05e9f0cb77384e73a27ddcffc45d769","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2588266c_e1aa721a","updated":"2022-06-22 20:54:17.000000000","message":"fixed! thanks Maor for the review and the comment","commit_id":"5f0fbb12e89594294c884f5e8467299afe6f7220"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"737321458d094ac113516ae52084fdaec0c020d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6367e3bc_a890688c","updated":"2022-06-22 19:52:48.000000000","message":"recheck","commit_id":"5f0fbb12e89594294c884f5e8467299afe6f7220"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"db2e70da9aa4c8e6ffe112f214b4b16d72752e59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"2cca2edd_ebd2d9c6","updated":"2022-06-28 07:06:51.000000000","message":"Code looks ok.","commit_id":"80648b5463a3e47800c7b6ae2db63bd19e83807a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4e90e091881f87931c1f286f6139a3de7c0be44a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3bd2de80_68fbada5","updated":"2022-06-28 09:06:50.000000000","message":"I\u0027m fine with this patch too but please address small comments from Lajos and Rodolfo","commit_id":"80648b5463a3e47800c7b6ae2db63bd19e83807a"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"353807e07d184bb277d35c6fac2585a51d5b7277","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"734693b9_bf055997","updated":"2022-06-23 07:00:01.000000000","message":"yw, code looks good to me.","commit_id":"80648b5463a3e47800c7b6ae2db63bd19e83807a"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"f2c1846cea30257b8ee413e2cf58a2f5569b81b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"95f1620a_055b92aa","updated":"2022-06-28 11:23:32.000000000","message":"Fixed","commit_id":"73c21fe1e43542983a5a2bb95b147941b79f03fc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"442c3ab0e7f6f727a8f98655b52739914ba2bbb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"f5c379f2_5405da0d","updated":"2022-06-28 15:04:45.000000000","message":"I don\u0027t want to be nitpicking, but I don\u0027t understand why you have 5 steps in the commit message and 3 in the method description.","commit_id":"73c21fe1e43542983a5a2bb95b147941b79f03fc"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"b0dd091a47bfa6f96bab73a34c1ba7b9ac0051a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"85cc8962_9ce217a3","updated":"2022-06-28 15:05:43.000000000","message":"recheck","commit_id":"73c21fe1e43542983a5a2bb95b147941b79f03fc"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"8adc8bf2404bc7e751dfd97259630a8b016dd49f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"ac36faa0_75150bf9","updated":"2022-06-29 10:22:38.000000000","message":"recheck","commit_id":"e3230013a6bfd6410fa7edbf92bb307f9c8eb237"}],"neutron_tempest_plugin/scenario/test_security_groups.py":[{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"dc98c3a0205eca9b5cb50bfa58354f85fec966fe","unresolved":true,"context_lines":[{"line_number":155,"context_line":"        # make sure ICMP connectivity works"},{"line_number":156,"context_line":"        self.check_remote_connectivity(server_ssh_clients[0], fips[1]["},{"line_number":157,"context_line":"            \u0027fixed_ip_address\u0027], should_succeed\u003dshould_succeed,"},{"line_number":158,"context_line":"                                       servers\u003dservers)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d764\u0027)"},{"line_number":161,"context_line":"    def test_default_sec_grp_scenarios(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"713ac2a8_a16714ff","line":158,"range":{"start_line":158,"start_character":12,"end_line":158,"end_character":39},"updated":"2022-06-07 15:08:40.000000000","message":"There is no reason to modify that. Please return it to the previous state","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"eaa1c5c37812e44ecc9e56fdea72a143793c3e5f","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        # make sure ICMP connectivity works"},{"line_number":156,"context_line":"        self.check_remote_connectivity(server_ssh_clients[0], fips[1]["},{"line_number":157,"context_line":"            \u0027fixed_ip_address\u0027], should_succeed\u003dshould_succeed,"},{"line_number":158,"context_line":"                                       servers\u003dservers)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d764\u0027)"},{"line_number":161,"context_line":"    def test_default_sec_grp_scenarios(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5d389de5_5bf56561","line":158,"range":{"start_line":158,"start_character":12,"end_line":158,"end_character":39},"in_reply_to":"713ac2a8_a16714ff","updated":"2022-06-09 14:22:12.000000000","message":"Done","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"dc98c3a0205eca9b5cb50bfa58354f85fec966fe","unresolved":true,"context_lines":[{"line_number":294,"context_line":"        ssh_sg \u003d self.create_security_group()"},{"line_number":295,"context_line":"        self.create_loginable_secgroup_rule(secgroup_id\u003dssh_sg[\u0027id\u0027])"},{"line_number":296,"context_line":"        vm_ssh, fips, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":297,"context_line":"            security_groups\u003d[{\u0027name\u0027: ssh_sg[\u0027name\u0027]}])"},{"line_number":298,"context_line":"        sg \u003d self.create_security_group()"},{"line_number":299,"context_line":"        nc_rule \u003d [{\u0027protocol\u0027: constants.PROTO_NUM_TCP,"},{"line_number":300,"context_line":"                    \u0027direction\u0027: constants.INGRESS_DIRECTION,"}],"source_content_type":"text/x-python","patch_set":1,"id":"44090c5d_5359a393","line":297,"updated":"2022-06-07 15:08:40.000000000","message":"There is no reason to modify that. Please return it to the previous state","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"eaa1c5c37812e44ecc9e56fdea72a143793c3e5f","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        ssh_sg \u003d self.create_security_group()"},{"line_number":295,"context_line":"        self.create_loginable_secgroup_rule(secgroup_id\u003dssh_sg[\u0027id\u0027])"},{"line_number":296,"context_line":"        vm_ssh, fips, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":297,"context_line":"            security_groups\u003d[{\u0027name\u0027: ssh_sg[\u0027name\u0027]}])"},{"line_number":298,"context_line":"        sg \u003d self.create_security_group()"},{"line_number":299,"context_line":"        nc_rule \u003d [{\u0027protocol\u0027: constants.PROTO_NUM_TCP,"},{"line_number":300,"context_line":"                    \u0027direction\u0027: constants.INGRESS_DIRECTION,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a2fbf81b_fc2b5656","line":297,"in_reply_to":"44090c5d_5359a393","updated":"2022-06-09 14:22:12.000000000","message":"Done","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"dc98c3a0205eca9b5cb50bfa58354f85fec966fe","unresolved":true,"context_lines":[{"line_number":302,"context_line":"                    \u0027port_range_max\u0027: 6666}]"},{"line_number":303,"context_line":"        self.create_secgroup_rules(nc_rule, secgroup_id\u003dsg[\u0027id\u0027])"},{"line_number":304,"context_line":"        srv_port \u003d self.client.list_ports(network_id\u003dself.network[\u0027id\u0027],"},{"line_number":305,"context_line":"                                          device_id\u003dvms[1][\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":306,"context_line":"        srv_ip \u003d srv_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":307,"context_line":"        with utils.StatefulConnection("},{"line_number":308,"context_line":"                vm_ssh[0], vm_ssh[1], srv_ip, 6666) as con:"}],"source_content_type":"text/x-python","patch_set":1,"id":"8c32623b_0ba8c6da","line":305,"updated":"2022-06-07 15:08:40.000000000","message":"There is no reason to modify that. Please return it to the previous state","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"eaa1c5c37812e44ecc9e56fdea72a143793c3e5f","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                    \u0027port_range_max\u0027: 6666}]"},{"line_number":303,"context_line":"        self.create_secgroup_rules(nc_rule, secgroup_id\u003dsg[\u0027id\u0027])"},{"line_number":304,"context_line":"        srv_port \u003d self.client.list_ports(network_id\u003dself.network[\u0027id\u0027],"},{"line_number":305,"context_line":"                                          device_id\u003dvms[1][\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":306,"context_line":"        srv_ip \u003d srv_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":307,"context_line":"        with utils.StatefulConnection("},{"line_number":308,"context_line":"                vm_ssh[0], vm_ssh[1], srv_ip, 6666) as con:"}],"source_content_type":"text/x-python","patch_set":1,"id":"8966a232_3b20d5b8","line":305,"in_reply_to":"8c32623b_0ba8c6da","updated":"2022-06-09 14:22:12.000000000","message":"Done","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"dc98c3a0205eca9b5cb50bfa58354f85fec966fe","unresolved":true,"context_lines":[{"line_number":307,"context_line":"        with utils.StatefulConnection("},{"line_number":308,"context_line":"                vm_ssh[0], vm_ssh[1], srv_ip, 6666) as con:"},{"line_number":309,"context_line":"            self.client.update_port(srv_port[\u0027id\u0027],"},{"line_number":310,"context_line":"                                    security_groups\u003d[ssh_sg[\u0027id\u0027], sg[\u0027id\u0027]])"},{"line_number":311,"context_line":"            con.test_connection()"},{"line_number":312,"context_line":"        with utils.StatefulConnection("},{"line_number":313,"context_line":"                vm_ssh[0], vm_ssh[1], srv_ip, 6666) as con:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9350acad_d349c13d","line":310,"updated":"2022-06-07 15:08:40.000000000","message":"There is no reason to modify that. Please return it to the previous state","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"eaa1c5c37812e44ecc9e56fdea72a143793c3e5f","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        with utils.StatefulConnection("},{"line_number":308,"context_line":"                vm_ssh[0], vm_ssh[1], srv_ip, 6666) as con:"},{"line_number":309,"context_line":"            self.client.update_port(srv_port[\u0027id\u0027],"},{"line_number":310,"context_line":"                                    security_groups\u003d[ssh_sg[\u0027id\u0027], sg[\u0027id\u0027]])"},{"line_number":311,"context_line":"            con.test_connection()"},{"line_number":312,"context_line":"        with utils.StatefulConnection("},{"line_number":313,"context_line":"                vm_ssh[0], vm_ssh[1], srv_ip, 6666) as con:"}],"source_content_type":"text/x-python","patch_set":1,"id":"e5594043_7a5915a6","line":310,"in_reply_to":"9350acad_d349c13d","updated":"2022-06-09 14:22:12.000000000","message":"Done","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"dc98c3a0205eca9b5cb50bfa58354f85fec966fe","unresolved":true,"context_lines":[{"line_number":312,"context_line":"        with utils.StatefulConnection("},{"line_number":313,"context_line":"                vm_ssh[0], vm_ssh[1], srv_ip, 6666) as con:"},{"line_number":314,"context_line":"            self.client.update_port("},{"line_number":315,"context_line":"                srv_port[\u0027id\u0027], security_groups\u003d[ssh_sg[\u0027id\u0027]])"},{"line_number":316,"context_line":"            con.test_connection(should_pass\u003dFalse)"},{"line_number":317,"context_line":"        with utils.StatefulConnection("},{"line_number":318,"context_line":"                vm_ssh[0], vm_ssh[1], srv_ip, 6666) as con:"}],"source_content_type":"text/x-python","patch_set":1,"id":"8b73274e_5e3f4f74","line":315,"updated":"2022-06-07 15:08:40.000000000","message":"There is no reason to modify that. Please return it to the previous state","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"eaa1c5c37812e44ecc9e56fdea72a143793c3e5f","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        with utils.StatefulConnection("},{"line_number":313,"context_line":"                vm_ssh[0], vm_ssh[1], srv_ip, 6666) as con:"},{"line_number":314,"context_line":"            self.client.update_port("},{"line_number":315,"context_line":"                srv_port[\u0027id\u0027], security_groups\u003d[ssh_sg[\u0027id\u0027]])"},{"line_number":316,"context_line":"            con.test_connection(should_pass\u003dFalse)"},{"line_number":317,"context_line":"        with utils.StatefulConnection("},{"line_number":318,"context_line":"                vm_ssh[0], vm_ssh[1], srv_ip, 6666) as con:"}],"source_content_type":"text/x-python","patch_set":1,"id":"65f3d0c0_30132ca7","line":315,"in_reply_to":"8b73274e_5e3f4f74","updated":"2022-06-09 14:22:12.000000000","message":"Done","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"dc98c3a0205eca9b5cb50bfa58354f85fec966fe","unresolved":true,"context_lines":[{"line_number":317,"context_line":"        with utils.StatefulConnection("},{"line_number":318,"context_line":"                vm_ssh[0], vm_ssh[1], srv_ip, 6666) as con:"},{"line_number":319,"context_line":"            self.client.update_port(srv_port[\u0027id\u0027],"},{"line_number":320,"context_line":"                                    security_groups\u003d[ssh_sg[\u0027id\u0027], sg[\u0027id\u0027]])"},{"line_number":321,"context_line":"            con.test_connection()"},{"line_number":322,"context_line":"            self.client.update_port(srv_port[\u0027id\u0027],"},{"line_number":323,"context_line":"                                    security_groups\u003d[ssh_sg[\u0027id\u0027]])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fcf078c9_740553b3","line":320,"updated":"2022-06-07 15:08:40.000000000","message":"There is no reason to modify that. Please return it to the previous state","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"eaa1c5c37812e44ecc9e56fdea72a143793c3e5f","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        with utils.StatefulConnection("},{"line_number":318,"context_line":"                vm_ssh[0], vm_ssh[1], srv_ip, 6666) as con:"},{"line_number":319,"context_line":"            self.client.update_port(srv_port[\u0027id\u0027],"},{"line_number":320,"context_line":"                                    security_groups\u003d[ssh_sg[\u0027id\u0027], sg[\u0027id\u0027]])"},{"line_number":321,"context_line":"            con.test_connection()"},{"line_number":322,"context_line":"            self.client.update_port(srv_port[\u0027id\u0027],"},{"line_number":323,"context_line":"                                    security_groups\u003d[ssh_sg[\u0027id\u0027]])"}],"source_content_type":"text/x-python","patch_set":1,"id":"06f49ffe_73a094dc","line":320,"in_reply_to":"fcf078c9_740553b3","updated":"2022-06-09 14:22:12.000000000","message":"Done","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"dc98c3a0205eca9b5cb50bfa58354f85fec966fe","unresolved":true,"context_lines":[{"line_number":320,"context_line":"                                    security_groups\u003d[ssh_sg[\u0027id\u0027], sg[\u0027id\u0027]])"},{"line_number":321,"context_line":"            con.test_connection()"},{"line_number":322,"context_line":"            self.client.update_port(srv_port[\u0027id\u0027],"},{"line_number":323,"context_line":"                                    security_groups\u003d[ssh_sg[\u0027id\u0027]])"},{"line_number":324,"context_line":"            con.test_connection(should_pass\u003dFalse)"},{"line_number":325,"context_line":"            self.client.update_port(srv_port[\u0027id\u0027],"},{"line_number":326,"context_line":"                                    security_groups\u003d[ssh_sg[\u0027id\u0027], sg[\u0027id\u0027]])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3372766f_da405919","line":323,"updated":"2022-06-07 15:08:40.000000000","message":"There is no reason to modify that. Please return it to the previous state","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"eaa1c5c37812e44ecc9e56fdea72a143793c3e5f","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                                    security_groups\u003d[ssh_sg[\u0027id\u0027], sg[\u0027id\u0027]])"},{"line_number":321,"context_line":"            con.test_connection()"},{"line_number":322,"context_line":"            self.client.update_port(srv_port[\u0027id\u0027],"},{"line_number":323,"context_line":"                                    security_groups\u003d[ssh_sg[\u0027id\u0027]])"},{"line_number":324,"context_line":"            con.test_connection(should_pass\u003dFalse)"},{"line_number":325,"context_line":"            self.client.update_port(srv_port[\u0027id\u0027],"},{"line_number":326,"context_line":"                                    security_groups\u003d[ssh_sg[\u0027id\u0027], sg[\u0027id\u0027]])"}],"source_content_type":"text/x-python","patch_set":1,"id":"02c1e5cc_77762f8d","line":323,"in_reply_to":"3372766f_da405919","updated":"2022-06-09 14:22:12.000000000","message":"Done","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"dc98c3a0205eca9b5cb50bfa58354f85fec966fe","unresolved":true,"context_lines":[{"line_number":323,"context_line":"                                    security_groups\u003d[ssh_sg[\u0027id\u0027]])"},{"line_number":324,"context_line":"            con.test_connection(should_pass\u003dFalse)"},{"line_number":325,"context_line":"            self.client.update_port(srv_port[\u0027id\u0027],"},{"line_number":326,"context_line":"                                    security_groups\u003d[ssh_sg[\u0027id\u0027], sg[\u0027id\u0027]])"},{"line_number":327,"context_line":"            con.test_connection()"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    @decorators.idempotent_id(\u00277ed39b86-006d-40fb-887a-ae46693dabc9\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"8728c824_95391e46","line":326,"updated":"2022-06-07 15:08:40.000000000","message":"There is no reason to modify that. Please return it to the previous state","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"eaa1c5c37812e44ecc9e56fdea72a143793c3e5f","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                                    security_groups\u003d[ssh_sg[\u0027id\u0027]])"},{"line_number":324,"context_line":"            con.test_connection(should_pass\u003dFalse)"},{"line_number":325,"context_line":"            self.client.update_port(srv_port[\u0027id\u0027],"},{"line_number":326,"context_line":"                                    security_groups\u003d[ssh_sg[\u0027id\u0027], sg[\u0027id\u0027]])"},{"line_number":327,"context_line":"            con.test_connection()"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    @decorators.idempotent_id(\u00277ed39b86-006d-40fb-887a-ae46693dabc9\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e89d9032_76b278fb","line":326,"in_reply_to":"8728c824_95391e46","updated":"2022-06-09 14:22:12.000000000","message":"Done","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"dc98c3a0205eca9b5cb50bfa58354f85fec966fe","unresolved":true,"context_lines":[{"line_number":630,"context_line":"        srv_ssh \u003d tmp_ssh[0]"},{"line_number":631,"context_line":"        srv_vm \u003d tmp_vm[0]"},{"line_number":632,"context_line":"        srv_port \u003d self.client.list_ports(network_id\u003dself.network[\u0027id\u0027],"},{"line_number":633,"context_line":"                                          device_id\u003dsrv_vm[\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":634,"context_line":"        srv_ip \u003d srv_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":635,"context_line":"        secgrps \u003d []"},{"line_number":636,"context_line":"        for i, vm in enumerate(vms):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3db2db22_e9c8892c","line":633,"updated":"2022-06-07 15:08:40.000000000","message":"There is no reason to modify that. Please return it to the previous state","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"eaa1c5c37812e44ecc9e56fdea72a143793c3e5f","unresolved":false,"context_lines":[{"line_number":630,"context_line":"        srv_ssh \u003d tmp_ssh[0]"},{"line_number":631,"context_line":"        srv_vm \u003d tmp_vm[0]"},{"line_number":632,"context_line":"        srv_port \u003d self.client.list_ports(network_id\u003dself.network[\u0027id\u0027],"},{"line_number":633,"context_line":"                                          device_id\u003dsrv_vm[\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":634,"context_line":"        srv_ip \u003d srv_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":635,"context_line":"        secgrps \u003d []"},{"line_number":636,"context_line":"        for i, vm in enumerate(vms):"}],"source_content_type":"text/x-python","patch_set":1,"id":"59dc2b5c_f843ae0a","line":633,"in_reply_to":"3db2db22_e9c8892c","updated":"2022-06-09 14:22:12.000000000","message":"Done","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"dc98c3a0205eca9b5cb50bfa58354f85fec966fe","unresolved":true,"context_lines":[{"line_number":637,"context_line":"            sg \u003d self.create_security_group(name\u003d\u0027secgrp-%d\u0027 % i)"},{"line_number":638,"context_line":"            self.create_loginable_secgroup_rule(secgroup_id\u003dsg[\u0027id\u0027])"},{"line_number":639,"context_line":"            port \u003d self.client.list_ports(network_id\u003dself.network[\u0027id\u0027],"},{"line_number":640,"context_line":"                                          device_id\u003dvm[\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":641,"context_line":"            self.client.update_port(port[\u0027id\u0027], security_groups\u003d[sg[\u0027id\u0027]])"},{"line_number":642,"context_line":"            secgrps.append(sg)"},{"line_number":643,"context_line":"        tcp_port \u003d 3000"}],"source_content_type":"text/x-python","patch_set":1,"id":"c2ac9d9b_c5e4b5b8","line":640,"updated":"2022-06-07 15:08:40.000000000","message":"There is no reason to modify that. Please return it to the previous state","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"eaa1c5c37812e44ecc9e56fdea72a143793c3e5f","unresolved":false,"context_lines":[{"line_number":637,"context_line":"            sg \u003d self.create_security_group(name\u003d\u0027secgrp-%d\u0027 % i)"},{"line_number":638,"context_line":"            self.create_loginable_secgroup_rule(secgroup_id\u003dsg[\u0027id\u0027])"},{"line_number":639,"context_line":"            port \u003d self.client.list_ports(network_id\u003dself.network[\u0027id\u0027],"},{"line_number":640,"context_line":"                                          device_id\u003dvm[\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":641,"context_line":"            self.client.update_port(port[\u0027id\u0027], security_groups\u003d[sg[\u0027id\u0027]])"},{"line_number":642,"context_line":"            secgrps.append(sg)"},{"line_number":643,"context_line":"        tcp_port \u003d 3000"}],"source_content_type":"text/x-python","patch_set":1,"id":"4e6e854e_4abc94ba","line":640,"in_reply_to":"c2ac9d9b_c5e4b5b8","updated":"2022-06-09 14:22:12.000000000","message":"Done","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"dc98c3a0205eca9b5cb50bfa58354f85fec966fe","unresolved":true,"context_lines":[{"line_number":652,"context_line":"                      \u0027port_range_max\u0027: tcp_port + 2,"},{"line_number":653,"context_line":"                      \u0027remote_group_id\u0027: secgrps[1][\u0027id\u0027]}]"},{"line_number":654,"context_line":"        self.client.update_port(srv_port[\u0027id\u0027],"},{"line_number":655,"context_line":"                                security_groups\u003d[secgrps[0][\u0027id\u0027], secgrps[1][\u0027id\u0027]])"},{"line_number":656,"context_line":"        self.create_secgroup_rules(rule_list, secgroup_id\u003dsecgrps[0][\u0027id\u0027])"},{"line_number":657,"context_line":"        # The conntrack entries are ruled by the OF definitions but conntrack"},{"line_number":658,"context_line":"        # status can change the datapath. Let\u0027s check the rules in two"}],"source_content_type":"text/x-python","patch_set":1,"id":"d6c0107c_8c232109","line":655,"updated":"2022-06-07 15:08:40.000000000","message":"There is no reason to modify that. Please return it to the previous state","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"eaa1c5c37812e44ecc9e56fdea72a143793c3e5f","unresolved":false,"context_lines":[{"line_number":652,"context_line":"                      \u0027port_range_max\u0027: tcp_port + 2,"},{"line_number":653,"context_line":"                      \u0027remote_group_id\u0027: secgrps[1][\u0027id\u0027]}]"},{"line_number":654,"context_line":"        self.client.update_port(srv_port[\u0027id\u0027],"},{"line_number":655,"context_line":"                                security_groups\u003d[secgrps[0][\u0027id\u0027], secgrps[1][\u0027id\u0027]])"},{"line_number":656,"context_line":"        self.create_secgroup_rules(rule_list, secgroup_id\u003dsecgrps[0][\u0027id\u0027])"},{"line_number":657,"context_line":"        # The conntrack entries are ruled by the OF definitions but conntrack"},{"line_number":658,"context_line":"        # status can change the datapath. Let\u0027s check the rules in two"}],"source_content_type":"text/x-python","patch_set":1,"id":"68aa2cac_ce7bbd70","line":655,"in_reply_to":"d6c0107c_8c232109","updated":"2022-06-09 14:22:12.000000000","message":"Done","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"dc98c3a0205eca9b5cb50bfa58354f85fec966fe","unresolved":true,"context_lines":[{"line_number":668,"context_line":"    def test_remove_security_group_from_running_instance(self):"},{"line_number":669,"context_line":"        # Try to remove SG from running VM"},{"line_number":670,"context_line":"        # create sg \u0026 vm"},{"line_number":671,"context_line":"        test_sg \u003d self.os_primary.network_client.create_security_group("},{"line_number":672,"context_line":"            name\u003d\u0027sec-grp_name\u0027)"},{"line_number":673,"context_line":"        self.security_groups.append(test_sg[\u0027security_group\u0027])"},{"line_number":674,"context_line":"        server_args \u003d {"},{"line_number":675,"context_line":"            \u0027flavor_ref\u0027: CONF.compute.flavor_ref,"},{"line_number":676,"context_line":"            \u0027image_ref\u0027: CONF.compute.image_ref,"}],"source_content_type":"text/x-python","patch_set":1,"id":"58c7db5b_bb035273","line":673,"range":{"start_line":671,"start_character":8,"end_line":673,"end_character":62},"updated":"2022-06-07 15:08:40.000000000","message":"just a hint. you can use self.create_security_group() method","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"eaa1c5c37812e44ecc9e56fdea72a143793c3e5f","unresolved":false,"context_lines":[{"line_number":668,"context_line":"    def test_remove_security_group_from_running_instance(self):"},{"line_number":669,"context_line":"        # Try to remove SG from running VM"},{"line_number":670,"context_line":"        # create sg \u0026 vm"},{"line_number":671,"context_line":"        test_sg \u003d self.os_primary.network_client.create_security_group("},{"line_number":672,"context_line":"            name\u003d\u0027sec-grp_name\u0027)"},{"line_number":673,"context_line":"        self.security_groups.append(test_sg[\u0027security_group\u0027])"},{"line_number":674,"context_line":"        server_args \u003d {"},{"line_number":675,"context_line":"            \u0027flavor_ref\u0027: CONF.compute.flavor_ref,"},{"line_number":676,"context_line":"            \u0027image_ref\u0027: CONF.compute.image_ref,"}],"source_content_type":"text/x-python","patch_set":1,"id":"21ddbfd4_409cdf1d","line":673,"range":{"start_line":671,"start_character":8,"end_line":673,"end_character":62},"in_reply_to":"58c7db5b_bb035273","updated":"2022-06-09 14:22:12.000000000","message":"Done","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"dc98c3a0205eca9b5cb50bfa58354f85fec966fe","unresolved":true,"context_lines":[{"line_number":671,"context_line":"        test_sg \u003d self.os_primary.network_client.create_security_group("},{"line_number":672,"context_line":"            name\u003d\u0027sec-grp_name\u0027)"},{"line_number":673,"context_line":"        self.security_groups.append(test_sg[\u0027security_group\u0027])"},{"line_number":674,"context_line":"        server_args \u003d {"},{"line_number":675,"context_line":"            \u0027flavor_ref\u0027: CONF.compute.flavor_ref,"},{"line_number":676,"context_line":"            \u0027image_ref\u0027: CONF.compute.image_ref,"},{"line_number":677,"context_line":"            \u0027key_name\u0027: self.keypair[\u0027name\u0027],"},{"line_number":678,"context_line":"            \u0027networks\u0027: [{\u0027uuid\u0027: self.network[\u0027id\u0027]}],"},{"line_number":679,"context_line":"        }"},{"line_number":680,"context_line":"        server \u003d self.create_server(**server_args)"},{"line_number":681,"context_line":"        server[\u0027security_groups\u0027] \u003d \u0027sec-grp_name\u0027"},{"line_number":682,"context_line":"        security_group_id \u003d None"},{"line_number":683,"context_line":"        for i in range(len(self.security_groups)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"22cc841d_542aec71","line":680,"range":{"start_line":674,"start_character":8,"end_line":680,"end_character":50},"updated":"2022-06-07 15:08:40.000000000","message":"easier will be to use self.create_vm_testing_sec_grp() method","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"eaa1c5c37812e44ecc9e56fdea72a143793c3e5f","unresolved":false,"context_lines":[{"line_number":671,"context_line":"        test_sg \u003d self.os_primary.network_client.create_security_group("},{"line_number":672,"context_line":"            name\u003d\u0027sec-grp_name\u0027)"},{"line_number":673,"context_line":"        self.security_groups.append(test_sg[\u0027security_group\u0027])"},{"line_number":674,"context_line":"        server_args \u003d {"},{"line_number":675,"context_line":"            \u0027flavor_ref\u0027: CONF.compute.flavor_ref,"},{"line_number":676,"context_line":"            \u0027image_ref\u0027: CONF.compute.image_ref,"},{"line_number":677,"context_line":"            \u0027key_name\u0027: self.keypair[\u0027name\u0027],"},{"line_number":678,"context_line":"            \u0027networks\u0027: [{\u0027uuid\u0027: self.network[\u0027id\u0027]}],"},{"line_number":679,"context_line":"        }"},{"line_number":680,"context_line":"        server \u003d self.create_server(**server_args)"},{"line_number":681,"context_line":"        server[\u0027security_groups\u0027] \u003d \u0027sec-grp_name\u0027"},{"line_number":682,"context_line":"        security_group_id \u003d None"},{"line_number":683,"context_line":"        for i in range(len(self.security_groups)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"adffcab3_a108196d","line":680,"range":{"start_line":674,"start_character":8,"end_line":680,"end_character":50},"in_reply_to":"22cc841d_542aec71","updated":"2022-06-09 14:22:12.000000000","message":"Done","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"dc98c3a0205eca9b5cb50bfa58354f85fec966fe","unresolved":true,"context_lines":[{"line_number":678,"context_line":"            \u0027networks\u0027: [{\u0027uuid\u0027: self.network[\u0027id\u0027]}],"},{"line_number":679,"context_line":"        }"},{"line_number":680,"context_line":"        server \u003d self.create_server(**server_args)"},{"line_number":681,"context_line":"        server[\u0027security_groups\u0027] \u003d \u0027sec-grp_name\u0027"},{"line_number":682,"context_line":"        security_group_id \u003d None"},{"line_number":683,"context_line":"        for i in range(len(self.security_groups)):"},{"line_number":684,"context_line":"            if self.security_groups[i][\u0027name\u0027] \u003d\u003d \u0027sec-grp_name\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7c12d2b3_aea448da","line":681,"range":{"start_line":681,"start_character":8,"end_line":681,"end_character":50},"updated":"2022-06-07 15:08:40.000000000","message":"this action will just modify the python object but not the openstack vm configuration. if you want to attach security group to the server you can do it like in the test case above [1]\n\n[1] https://opendev.org/openstack/neutron-tempest-plugin/src/branch/master/neutron_tempest_plugin/scenario/test_security_groups.py#L639-L641","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"eaa1c5c37812e44ecc9e56fdea72a143793c3e5f","unresolved":false,"context_lines":[{"line_number":678,"context_line":"            \u0027networks\u0027: [{\u0027uuid\u0027: self.network[\u0027id\u0027]}],"},{"line_number":679,"context_line":"        }"},{"line_number":680,"context_line":"        server \u003d self.create_server(**server_args)"},{"line_number":681,"context_line":"        server[\u0027security_groups\u0027] \u003d \u0027sec-grp_name\u0027"},{"line_number":682,"context_line":"        security_group_id \u003d None"},{"line_number":683,"context_line":"        for i in range(len(self.security_groups)):"},{"line_number":684,"context_line":"            if self.security_groups[i][\u0027name\u0027] \u003d\u003d \u0027sec-grp_name\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7023f9_3be88850","line":681,"range":{"start_line":681,"start_character":8,"end_line":681,"end_character":50},"in_reply_to":"7c12d2b3_aea448da","updated":"2022-06-09 14:22:12.000000000","message":"Done","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"dc98c3a0205eca9b5cb50bfa58354f85fec966fe","unresolved":true,"context_lines":[{"line_number":680,"context_line":"        server \u003d self.create_server(**server_args)"},{"line_number":681,"context_line":"        server[\u0027security_groups\u0027] \u003d \u0027sec-grp_name\u0027"},{"line_number":682,"context_line":"        security_group_id \u003d None"},{"line_number":683,"context_line":"        for i in range(len(self.security_groups)):"},{"line_number":684,"context_line":"            if self.security_groups[i][\u0027name\u0027] \u003d\u003d \u0027sec-grp_name\u0027:"},{"line_number":685,"context_line":"                security_group_id \u003d self.security_groups[i][\u0027id\u0027]"},{"line_number":686,"context_line":"                break"},{"line_number":687,"context_line":"            # Deleting the \"sec-grp_name\" Security Group"},{"line_number":688,"context_line":"            self.security_groups.remove(security_group_id)"},{"line_number":689,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"87b6da55_2bffccbd","line":688,"range":{"start_line":683,"start_character":8,"end_line":688,"end_character":58},"updated":"2022-06-07 15:08:40.000000000","message":"this part doesn\u0027t check if the security group is attached to the server. Instead you can query an API for the list of security groups attached to the server/port and then make sure if the desired one exist there.","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"eaa1c5c37812e44ecc9e56fdea72a143793c3e5f","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        server \u003d self.create_server(**server_args)"},{"line_number":681,"context_line":"        server[\u0027security_groups\u0027] \u003d \u0027sec-grp_name\u0027"},{"line_number":682,"context_line":"        security_group_id \u003d None"},{"line_number":683,"context_line":"        for i in range(len(self.security_groups)):"},{"line_number":684,"context_line":"            if self.security_groups[i][\u0027name\u0027] \u003d\u003d \u0027sec-grp_name\u0027:"},{"line_number":685,"context_line":"                security_group_id \u003d self.security_groups[i][\u0027id\u0027]"},{"line_number":686,"context_line":"                break"},{"line_number":687,"context_line":"            # Deleting the \"sec-grp_name\" Security Group"},{"line_number":688,"context_line":"            self.security_groups.remove(security_group_id)"},{"line_number":689,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"483a50ca_ec8219f2","line":688,"range":{"start_line":683,"start_character":8,"end_line":688,"end_character":58},"in_reply_to":"87b6da55_2bffccbd","updated":"2022-06-09 14:22:12.000000000","message":"Done","commit_id":"308db8a6de4580b4c7ab11247fc77ac8447d3d72"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"0ed78bac91fd5d13ad57dab2b92c2d6244e83884","unresolved":true,"context_lines":[{"line_number":668,"context_line":"    def test_remove_security_group_from_running_instance(self):"},{"line_number":669,"context_line":"        \"\"\"Try to remove SG from running VM\"\"\""},{"line_number":670,"context_line":"        sec_grp_test \u003d self.create_security_group(name\u003d\u0027test_sg\u0027)"},{"line_number":671,"context_line":"        self.create_port("},{"line_number":672,"context_line":"            self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":673,"context_line":"            security_groups\u003d[sec_grp_test[\u0027id\u0027]])"},{"line_number":674,"context_line":"        server_ssh_clients, fips, vm \u003d self.create_vm_testing_sec_grp("},{"line_number":675,"context_line":"            security_groups\u003d[{\u0027name\u0027: \u0027test_sg\u0027}])"},{"line_number":676,"context_line":"        self.create_loginable_secgroup_rule(secgroup_id\u003dsec_grp_test[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5202a62a_c775d053","line":673,"range":{"start_line":671,"start_character":0,"end_line":673,"end_character":49},"updated":"2022-06-09 14:54:58.000000000","message":"you do not use this port anywhere later in the test probably you can send it as a parameter to `create_vm_testing_sec_grp` method","commit_id":"87b9b2b45497e817b0d1beafd85dbde98c6feac1"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"177b0930ee1da72c33dc0ca19623c6e57ebfa82e","unresolved":false,"context_lines":[{"line_number":668,"context_line":"    def test_remove_security_group_from_running_instance(self):"},{"line_number":669,"context_line":"        \"\"\"Try to remove SG from running VM\"\"\""},{"line_number":670,"context_line":"        sec_grp_test \u003d self.create_security_group(name\u003d\u0027test_sg\u0027)"},{"line_number":671,"context_line":"        self.create_port("},{"line_number":672,"context_line":"            self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":673,"context_line":"            security_groups\u003d[sec_grp_test[\u0027id\u0027]])"},{"line_number":674,"context_line":"        server_ssh_clients, fips, vm \u003d self.create_vm_testing_sec_grp("},{"line_number":675,"context_line":"            security_groups\u003d[{\u0027name\u0027: \u0027test_sg\u0027}])"},{"line_number":676,"context_line":"        self.create_loginable_secgroup_rule(secgroup_id\u003dsec_grp_test[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"b7706df3_bcb2d26a","line":673,"range":{"start_line":671,"start_character":0,"end_line":673,"end_character":49},"in_reply_to":"5202a62a_c775d053","updated":"2022-06-20 16:54:34.000000000","message":"Done","commit_id":"87b9b2b45497e817b0d1beafd85dbde98c6feac1"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"0ed78bac91fd5d13ad57dab2b92c2d6244e83884","unresolved":true,"context_lines":[{"line_number":671,"context_line":"        self.create_port("},{"line_number":672,"context_line":"            self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":673,"context_line":"            security_groups\u003d[sec_grp_test[\u0027id\u0027]])"},{"line_number":674,"context_line":"        server_ssh_clients, fips, vm \u003d self.create_vm_testing_sec_grp("},{"line_number":675,"context_line":"            security_groups\u003d[{\u0027name\u0027: \u0027test_sg\u0027}])"},{"line_number":676,"context_line":"        self.create_loginable_secgroup_rule(secgroup_id\u003dsec_grp_test[\u0027id\u0027])"},{"line_number":677,"context_line":"        rule_list \u003d [{\u0027protocol\u0027: constants.PROTO_NUM_ICMP,"},{"line_number":678,"context_line":"                      \u0027direction\u0027: constants.INGRESS_DIRECTION,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f4bbc0c0_ac29d4c1","line":675,"range":{"start_line":674,"start_character":0,"end_line":675,"end_character":50},"updated":"2022-06-09 14:54:58.000000000","message":"by default it creates 2 servers. do you need 2?","commit_id":"87b9b2b45497e817b0d1beafd85dbde98c6feac1"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"177b0930ee1da72c33dc0ca19623c6e57ebfa82e","unresolved":false,"context_lines":[{"line_number":671,"context_line":"        self.create_port("},{"line_number":672,"context_line":"            self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":673,"context_line":"            security_groups\u003d[sec_grp_test[\u0027id\u0027]])"},{"line_number":674,"context_line":"        server_ssh_clients, fips, vm \u003d self.create_vm_testing_sec_grp("},{"line_number":675,"context_line":"            security_groups\u003d[{\u0027name\u0027: \u0027test_sg\u0027}])"},{"line_number":676,"context_line":"        self.create_loginable_secgroup_rule(secgroup_id\u003dsec_grp_test[\u0027id\u0027])"},{"line_number":677,"context_line":"        rule_list \u003d [{\u0027protocol\u0027: constants.PROTO_NUM_ICMP,"},{"line_number":678,"context_line":"                      \u0027direction\u0027: constants.INGRESS_DIRECTION,"}],"source_content_type":"text/x-python","patch_set":3,"id":"adb38682_c704dcf0","line":675,"range":{"start_line":674,"start_character":0,"end_line":675,"end_character":50},"in_reply_to":"f4bbc0c0_ac29d4c1","updated":"2022-06-20 16:54:34.000000000","message":"Done","commit_id":"87b9b2b45497e817b0d1beafd85dbde98c6feac1"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"0ed78bac91fd5d13ad57dab2b92c2d6244e83884","unresolved":true,"context_lines":[{"line_number":673,"context_line":"            security_groups\u003d[sec_grp_test[\u0027id\u0027]])"},{"line_number":674,"context_line":"        server_ssh_clients, fips, vm \u003d self.create_vm_testing_sec_grp("},{"line_number":675,"context_line":"            security_groups\u003d[{\u0027name\u0027: \u0027test_sg\u0027}])"},{"line_number":676,"context_line":"        self.create_loginable_secgroup_rule(secgroup_id\u003dsec_grp_test[\u0027id\u0027])"},{"line_number":677,"context_line":"        rule_list \u003d [{\u0027protocol\u0027: constants.PROTO_NUM_ICMP,"},{"line_number":678,"context_line":"                      \u0027direction\u0027: constants.INGRESS_DIRECTION,"},{"line_number":679,"context_line":"                      \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1b4c359b_6f1b91dc","line":676,"range":{"start_line":676,"start_character":8,"end_line":676,"end_character":75},"updated":"2022-06-09 14:54:58.000000000","message":"you do not check SSH in this test. do you need a rule to allow it?","commit_id":"87b9b2b45497e817b0d1beafd85dbde98c6feac1"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"177b0930ee1da72c33dc0ca19623c6e57ebfa82e","unresolved":false,"context_lines":[{"line_number":673,"context_line":"            security_groups\u003d[sec_grp_test[\u0027id\u0027]])"},{"line_number":674,"context_line":"        server_ssh_clients, fips, vm \u003d self.create_vm_testing_sec_grp("},{"line_number":675,"context_line":"            security_groups\u003d[{\u0027name\u0027: \u0027test_sg\u0027}])"},{"line_number":676,"context_line":"        self.create_loginable_secgroup_rule(secgroup_id\u003dsec_grp_test[\u0027id\u0027])"},{"line_number":677,"context_line":"        rule_list \u003d [{\u0027protocol\u0027: constants.PROTO_NUM_ICMP,"},{"line_number":678,"context_line":"                      \u0027direction\u0027: constants.INGRESS_DIRECTION,"},{"line_number":679,"context_line":"                      \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5d0489a1_50aa4902","line":676,"range":{"start_line":676,"start_character":8,"end_line":676,"end_character":75},"in_reply_to":"1b4c359b_6f1b91dc","updated":"2022-06-20 16:54:34.000000000","message":"Done","commit_id":"87b9b2b45497e817b0d1beafd85dbde98c6feac1"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"0ed78bac91fd5d13ad57dab2b92c2d6244e83884","unresolved":true,"context_lines":[{"line_number":674,"context_line":"        server_ssh_clients, fips, vm \u003d self.create_vm_testing_sec_grp("},{"line_number":675,"context_line":"            security_groups\u003d[{\u0027name\u0027: \u0027test_sg\u0027}])"},{"line_number":676,"context_line":"        self.create_loginable_secgroup_rule(secgroup_id\u003dsec_grp_test[\u0027id\u0027])"},{"line_number":677,"context_line":"        rule_list \u003d [{\u0027protocol\u0027: constants.PROTO_NUM_ICMP,"},{"line_number":678,"context_line":"                      \u0027direction\u0027: constants.INGRESS_DIRECTION,"},{"line_number":679,"context_line":"                      \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":680,"context_line":"        self.create_secgroup_rules(rule_list, secgroup_id\u003dsec_grp_test[\u0027id\u0027])"},{"line_number":681,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":682,"context_line":"        security_groups \u003d self.client.list_security_groups()[\u0027security_groups\u0027]"},{"line_number":683,"context_line":"        self.security_groups.remove(sec_grp_test)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0c284420_c4199e88","line":680,"range":{"start_line":677,"start_character":0,"end_line":680,"end_character":77},"updated":"2022-06-09 14:54:58.000000000","message":"you can use `create_pingable_secgroup_rule` method from upstream plugin scenario/base.py","commit_id":"87b9b2b45497e817b0d1beafd85dbde98c6feac1"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"177b0930ee1da72c33dc0ca19623c6e57ebfa82e","unresolved":false,"context_lines":[{"line_number":674,"context_line":"        server_ssh_clients, fips, vm \u003d self.create_vm_testing_sec_grp("},{"line_number":675,"context_line":"            security_groups\u003d[{\u0027name\u0027: \u0027test_sg\u0027}])"},{"line_number":676,"context_line":"        self.create_loginable_secgroup_rule(secgroup_id\u003dsec_grp_test[\u0027id\u0027])"},{"line_number":677,"context_line":"        rule_list \u003d [{\u0027protocol\u0027: constants.PROTO_NUM_ICMP,"},{"line_number":678,"context_line":"                      \u0027direction\u0027: constants.INGRESS_DIRECTION,"},{"line_number":679,"context_line":"                      \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":680,"context_line":"        self.create_secgroup_rules(rule_list, secgroup_id\u003dsec_grp_test[\u0027id\u0027])"},{"line_number":681,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":682,"context_line":"        security_groups \u003d self.client.list_security_groups()[\u0027security_groups\u0027]"},{"line_number":683,"context_line":"        self.security_groups.remove(sec_grp_test)"}],"source_content_type":"text/x-python","patch_set":3,"id":"339aa474_7adc660c","line":680,"range":{"start_line":677,"start_character":0,"end_line":680,"end_character":77},"in_reply_to":"0c284420_c4199e88","updated":"2022-06-20 16:54:34.000000000","message":"Done","commit_id":"87b9b2b45497e817b0d1beafd85dbde98c6feac1"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"0ed78bac91fd5d13ad57dab2b92c2d6244e83884","unresolved":true,"context_lines":[{"line_number":679,"context_line":"                      \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":680,"context_line":"        self.create_secgroup_rules(rule_list, secgroup_id\u003dsec_grp_test[\u0027id\u0027])"},{"line_number":681,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":682,"context_line":"        security_groups \u003d self.client.list_security_groups()[\u0027security_groups\u0027]"},{"line_number":683,"context_line":"        self.security_groups.remove(sec_grp_test)"},{"line_number":684,"context_line":"        self.assertIn(sec_grp_test[\u0027id\u0027],"},{"line_number":685,"context_line":"                      {sg[\u0027id\u0027] for sg in security_groups})"}],"source_content_type":"text/x-python","patch_set":3,"id":"77a8fc2f_98b7444f","line":682,"range":{"start_line":682,"start_character":8,"end_line":682,"end_character":79},"updated":"2022-06-09 14:54:58.000000000","message":"you list all the security groups here, not only the groups that attached to the server","commit_id":"87b9b2b45497e817b0d1beafd85dbde98c6feac1"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"177b0930ee1da72c33dc0ca19623c6e57ebfa82e","unresolved":false,"context_lines":[{"line_number":679,"context_line":"                      \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":680,"context_line":"        self.create_secgroup_rules(rule_list, secgroup_id\u003dsec_grp_test[\u0027id\u0027])"},{"line_number":681,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":682,"context_line":"        security_groups \u003d self.client.list_security_groups()[\u0027security_groups\u0027]"},{"line_number":683,"context_line":"        self.security_groups.remove(sec_grp_test)"},{"line_number":684,"context_line":"        self.assertIn(sec_grp_test[\u0027id\u0027],"},{"line_number":685,"context_line":"                      {sg[\u0027id\u0027] for sg in security_groups})"}],"source_content_type":"text/x-python","patch_set":3,"id":"a605626d_46b1718b","line":682,"range":{"start_line":682,"start_character":8,"end_line":682,"end_character":79},"in_reply_to":"77a8fc2f_98b7444f","updated":"2022-06-20 16:54:34.000000000","message":"Done","commit_id":"87b9b2b45497e817b0d1beafd85dbde98c6feac1"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"0ed78bac91fd5d13ad57dab2b92c2d6244e83884","unresolved":true,"context_lines":[{"line_number":680,"context_line":"        self.create_secgroup_rules(rule_list, secgroup_id\u003dsec_grp_test[\u0027id\u0027])"},{"line_number":681,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":682,"context_line":"        security_groups \u003d self.client.list_security_groups()[\u0027security_groups\u0027]"},{"line_number":683,"context_line":"        self.security_groups.remove(sec_grp_test)"},{"line_number":684,"context_line":"        self.assertIn(sec_grp_test[\u0027id\u0027],"},{"line_number":685,"context_line":"                      {sg[\u0027id\u0027] for sg in security_groups})"}],"source_content_type":"text/x-python","patch_set":3,"id":"614aee64_44cc3721","line":683,"range":{"start_line":683,"start_character":8,"end_line":683,"end_character":49},"updated":"2022-06-09 14:54:58.000000000","message":"this method removes the security group from the `self.security_groups` list, if you want to remove the security group from the server you will actually need to remove it from the attached port. please use the `update_port` method to do it.\n\nwhen you update a port you need to provide a new list of the security groups that will be assigned to it. all the old security groups will be replaced with the provided list.\n\nyou can check API calls with `openstack server remove security group \u003cserver\u003e \u003csg\u003e --debug` command to see how it actually works","commit_id":"87b9b2b45497e817b0d1beafd85dbde98c6feac1"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"177b0930ee1da72c33dc0ca19623c6e57ebfa82e","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        self.create_secgroup_rules(rule_list, secgroup_id\u003dsec_grp_test[\u0027id\u0027])"},{"line_number":681,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":682,"context_line":"        security_groups \u003d self.client.list_security_groups()[\u0027security_groups\u0027]"},{"line_number":683,"context_line":"        self.security_groups.remove(sec_grp_test)"},{"line_number":684,"context_line":"        self.assertIn(sec_grp_test[\u0027id\u0027],"},{"line_number":685,"context_line":"                      {sg[\u0027id\u0027] for sg in security_groups})"}],"source_content_type":"text/x-python","patch_set":3,"id":"cb29e6a6_7d8f65cc","line":683,"range":{"start_line":683,"start_character":8,"end_line":683,"end_character":49},"in_reply_to":"614aee64_44cc3721","updated":"2022-06-20 16:54:34.000000000","message":"Done","commit_id":"87b9b2b45497e817b0d1beafd85dbde98c6feac1"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"0ed78bac91fd5d13ad57dab2b92c2d6244e83884","unresolved":true,"context_lines":[{"line_number":681,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":682,"context_line":"        security_groups \u003d self.client.list_security_groups()[\u0027security_groups\u0027]"},{"line_number":683,"context_line":"        self.security_groups.remove(sec_grp_test)"},{"line_number":684,"context_line":"        self.assertIn(sec_grp_test[\u0027id\u0027],"},{"line_number":685,"context_line":"                      {sg[\u0027id\u0027] for sg in security_groups})"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa0d194_e421111d","line":685,"range":{"start_line":684,"start_character":8,"end_line":685,"end_character":59},"updated":"2022-06-09 14:54:58.000000000","message":"with this assertion you just check that security group exist in openstack environment. you probably need to check that security group is not assigned to the server anymore and then try to ping VM again (it should fail).","commit_id":"87b9b2b45497e817b0d1beafd85dbde98c6feac1"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"177b0930ee1da72c33dc0ca19623c6e57ebfa82e","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":682,"context_line":"        security_groups \u003d self.client.list_security_groups()[\u0027security_groups\u0027]"},{"line_number":683,"context_line":"        self.security_groups.remove(sec_grp_test)"},{"line_number":684,"context_line":"        self.assertIn(sec_grp_test[\u0027id\u0027],"},{"line_number":685,"context_line":"                      {sg[\u0027id\u0027] for sg in security_groups})"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a813fb0_9304890b","line":685,"range":{"start_line":684,"start_character":8,"end_line":685,"end_character":59},"in_reply_to":"7aa0d194_e421111d","updated":"2022-06-20 16:54:34.000000000","message":"Done","commit_id":"87b9b2b45497e817b0d1beafd85dbde98c6feac1"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f3c105e4c49802ad88d6df15d3a1ac21b2d7ccc8","unresolved":true,"context_lines":[{"line_number":665,"context_line":"                                             port, [])"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    @decorators.idempotent_id(\u002796dcd5ff-9d45-4e0d-bea0-0b438cbd388f\u0027)"},{"line_number":668,"context_line":"    def test_remove_sec_grp_from_running_instance(self):"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        \"\"\"Create SG and pingable rule \u0026 , with id we add it to the cleanup\"\"\""},{"line_number":671,"context_line":"        sec_grp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"15977ed4_2b38428a","line":668,"range":{"start_line":668,"start_character":8,"end_line":668,"end_character":49},"updated":"2022-06-20 21:41:34.000000000","message":"Maybe changing the test name to: \"test_remove_sec_grp_from_active_vm\"?","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"6e0439174707767944012b35c959c01e94716c52","unresolved":false,"context_lines":[{"line_number":665,"context_line":"                                             port, [])"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    @decorators.idempotent_id(\u002796dcd5ff-9d45-4e0d-bea0-0b438cbd388f\u0027)"},{"line_number":668,"context_line":"    def test_remove_sec_grp_from_running_instance(self):"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        \"\"\"Create SG and pingable rule \u0026 , with id we add it to the cleanup\"\"\""},{"line_number":671,"context_line":"        sec_grp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1e32c27c_d318600c","line":668,"range":{"start_line":668,"start_character":8,"end_line":668,"end_character":49},"in_reply_to":"15977ed4_2b38428a","updated":"2022-06-21 08:23:39.000000000","message":"Done","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f3c105e4c49802ad88d6df15d3a1ac21b2d7ccc8","unresolved":true,"context_lines":[{"line_number":667,"context_line":"    @decorators.idempotent_id(\u002796dcd5ff-9d45-4e0d-bea0-0b438cbd388f\u0027)"},{"line_number":668,"context_line":"    def test_remove_sec_grp_from_running_instance(self):"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        \"\"\"Create SG and pingable rule \u0026 , with id we add it to the cleanup\"\"\""},{"line_number":671,"context_line":"        sec_grp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":672,"context_line":"        secgrp \u003d self.os_primary.network_client.create_security_group("},{"line_number":673,"context_line":"            name\u003dsec_grp_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"b6f894f5_a082a07e","line":670,"range":{"start_line":670,"start_character":0,"end_line":670,"end_character":28},"updated":"2022-06-20 21:41:34.000000000","message":"Something is wrong in this comment,maybe: \n\"Create SG associated with ICMP rule and add its ID to the cleanup\"","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"6e0439174707767944012b35c959c01e94716c52","unresolved":false,"context_lines":[{"line_number":667,"context_line":"    @decorators.idempotent_id(\u002796dcd5ff-9d45-4e0d-bea0-0b438cbd388f\u0027)"},{"line_number":668,"context_line":"    def test_remove_sec_grp_from_running_instance(self):"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        \"\"\"Create SG and pingable rule \u0026 , with id we add it to the cleanup\"\"\""},{"line_number":671,"context_line":"        sec_grp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":672,"context_line":"        secgrp \u003d self.os_primary.network_client.create_security_group("},{"line_number":673,"context_line":"            name\u003dsec_grp_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ea7dada9_de841b7e","line":670,"range":{"start_line":670,"start_character":0,"end_line":670,"end_character":28},"in_reply_to":"b6f894f5_a082a07e","updated":"2022-06-21 08:23:39.000000000","message":"Done","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f3c105e4c49802ad88d6df15d3a1ac21b2d7ccc8","unresolved":true,"context_lines":[{"line_number":673,"context_line":"            name\u003dsec_grp_name)"},{"line_number":674,"context_line":"        sec_grp_id \u003d secgrp[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":675,"context_line":"        self.create_pingable_secgroup_rule(sec_grp_id)"},{"line_number":676,"context_line":"        self.security_groups.append(secgrp[\u0027security_group\u0027])"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        \"\"\"Create Port with the previous SG and use it for VM creation\"\"\""},{"line_number":679,"context_line":"        ex_port \u003d self.create_port("}],"source_content_type":"text/x-python","patch_set":5,"id":"5da5663e_a170a9db","line":676,"range":{"start_line":676,"start_character":0,"end_line":676,"end_character":13},"updated":"2022-06-20 21:41:34.000000000","message":"Cleanup should come imitatively after creation,it means in L674","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"6e0439174707767944012b35c959c01e94716c52","unresolved":false,"context_lines":[{"line_number":673,"context_line":"            name\u003dsec_grp_name)"},{"line_number":674,"context_line":"        sec_grp_id \u003d secgrp[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":675,"context_line":"        self.create_pingable_secgroup_rule(sec_grp_id)"},{"line_number":676,"context_line":"        self.security_groups.append(secgrp[\u0027security_group\u0027])"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        \"\"\"Create Port with the previous SG and use it for VM creation\"\"\""},{"line_number":679,"context_line":"        ex_port \u003d self.create_port("}],"source_content_type":"text/x-python","patch_set":5,"id":"fe766e25_dc12117a","line":676,"range":{"start_line":676,"start_character":0,"end_line":676,"end_character":13},"in_reply_to":"5da5663e_a170a9db","updated":"2022-06-21 08:23:39.000000000","message":"Done","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f3c105e4c49802ad88d6df15d3a1ac21b2d7ccc8","unresolved":true,"context_lines":[{"line_number":683,"context_line":"            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: sec_grp_name}],"},{"line_number":684,"context_line":"            ports\u003d[ex_port])"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        \"\"\"Ping the VM\"\"\""},{"line_number":687,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        \"\"\"\"Remove SG from VM by updating its Port and sure that PING fails\"\"\""},{"line_number":690,"context_line":"        self.client.update_port(ex_port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"96a43150_1a154006","line":687,"range":{"start_line":686,"start_character":0,"end_line":687,"end_character":60},"updated":"2022-06-20 21:41:34.000000000","message":"Just for better visibility, I\u0027d suggest joining this section with the next one and changing the comment accordingly.","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"6e0439174707767944012b35c959c01e94716c52","unresolved":false,"context_lines":[{"line_number":683,"context_line":"            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: sec_grp_name}],"},{"line_number":684,"context_line":"            ports\u003d[ex_port])"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        \"\"\"Ping the VM\"\"\""},{"line_number":687,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        \"\"\"\"Remove SG from VM by updating its Port and sure that PING fails\"\"\""},{"line_number":690,"context_line":"        self.client.update_port(ex_port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"5690956a_74265892","line":687,"range":{"start_line":686,"start_character":0,"end_line":687,"end_character":60},"in_reply_to":"96a43150_1a154006","updated":"2022-06-21 08:23:39.000000000","message":"Done","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f3c105e4c49802ad88d6df15d3a1ac21b2d7ccc8","unresolved":true,"context_lines":[{"line_number":686,"context_line":"        \"\"\"Ping the VM\"\"\""},{"line_number":687,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        \"\"\"\"Remove SG from VM by updating its Port and sure that PING fails\"\"\""},{"line_number":690,"context_line":"        self.client.update_port(ex_port[\u0027id\u0027],"},{"line_number":691,"context_line":"                                security_groups\u003d[])"},{"line_number":692,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"ea307a07_e9382900","line":689,"range":{"start_line":689,"start_character":0,"end_line":689,"end_character":28},"updated":"2022-06-20 21:41:34.000000000","message":"\"and sure\"?\n\nMaybe\n\"Remove SG from VM by updating its Port and validate that PING fails\"\not\n\"Remove SG from VM by updating its Port and ensure that PING fails\"","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"6e0439174707767944012b35c959c01e94716c52","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        \"\"\"Ping the VM\"\"\""},{"line_number":687,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        \"\"\"\"Remove SG from VM by updating its Port and sure that PING fails\"\"\""},{"line_number":690,"context_line":"        self.client.update_port(ex_port[\u0027id\u0027],"},{"line_number":691,"context_line":"                                security_groups\u003d[])"},{"line_number":692,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f5a0360_cd96031d","line":689,"range":{"start_line":689,"start_character":0,"end_line":689,"end_character":28},"in_reply_to":"ea307a07_e9382900","updated":"2022-06-21 08:23:39.000000000","message":"Done","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"f3c105e4c49802ad88d6df15d3a1ac21b2d7ccc8","unresolved":true,"context_lines":[{"line_number":691,"context_line":"                                security_groups\u003d[])"},{"line_number":692,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":693,"context_line":"                             should_succeed\u003dFalse)"},{"line_number":694,"context_line":"        self.delete_security_group(secgrp[\u0027security_group\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"aafc6dfa_d2562ce0","line":694,"range":{"start_line":694,"start_character":8,"end_line":694,"end_character":60},"updated":"2022-06-20 21:41:34.000000000","message":"Why do we need it?","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"6e0439174707767944012b35c959c01e94716c52","unresolved":false,"context_lines":[{"line_number":691,"context_line":"                                security_groups\u003d[])"},{"line_number":692,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":693,"context_line":"                             should_succeed\u003dFalse)"},{"line_number":694,"context_line":"        self.delete_security_group(secgrp[\u0027security_group\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"add8c60f_980828fb","line":694,"range":{"start_line":694,"start_character":8,"end_line":694,"end_character":60},"in_reply_to":"aafc6dfa_d2562ce0","updated":"2022-06-21 08:23:39.000000000","message":"Done","commit_id":"ccbf6abcaaa46d06fc42b21b4c80389b72e4c3b2"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d4558cd060ccec30dd03bc60a6aea0545874b34a","unresolved":true,"context_lines":[{"line_number":667,"context_line":"    @decorators.idempotent_id(\u002796dcd5ff-9d45-4e0d-bea0-0b438cbd388f\u0027)"},{"line_number":668,"context_line":"    def test_remove_sec_grp_from_active_vm(self):"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        \"\"\"Create SG associated with ICMP rule and add its ID to cleanup\"\"\""},{"line_number":671,"context_line":"        sec_grp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":672,"context_line":"        secgrp \u003d self.os_primary.network_client.create_security_group("},{"line_number":673,"context_line":"            name\u003dsec_grp_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"20dbf0cf_dae375a6","line":670,"range":{"start_line":670,"start_character":55,"end_line":670,"end_character":61},"updated":"2022-06-21 18:28:47.000000000","message":"Remove \"its ID\" as you are adding  , you are adding \"security_group\" key to security_groups list.\nMenas:\n\"Create SG associated with ICMP rule and add to cleanup\"","commit_id":"f792a158b2dd1ea4f1b197a94935b8e1b633cd9b"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"e277645f0f36db147949c7a1cfdbd09bfa5ab3e8","unresolved":false,"context_lines":[{"line_number":667,"context_line":"    @decorators.idempotent_id(\u002796dcd5ff-9d45-4e0d-bea0-0b438cbd388f\u0027)"},{"line_number":668,"context_line":"    def test_remove_sec_grp_from_active_vm(self):"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        \"\"\"Create SG associated with ICMP rule and add its ID to cleanup\"\"\""},{"line_number":671,"context_line":"        sec_grp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":672,"context_line":"        secgrp \u003d self.os_primary.network_client.create_security_group("},{"line_number":673,"context_line":"            name\u003dsec_grp_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fd75a99_f9e54148","line":670,"range":{"start_line":670,"start_character":55,"end_line":670,"end_character":61},"in_reply_to":"20dbf0cf_dae375a6","updated":"2022-06-21 20:09:40.000000000","message":"Done","commit_id":"f792a158b2dd1ea4f1b197a94935b8e1b633cd9b"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d4558cd060ccec30dd03bc60a6aea0545874b34a","unresolved":true,"context_lines":[{"line_number":679,"context_line":"        ex_port \u003d self.create_port("},{"line_number":680,"context_line":"            self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":681,"context_line":"            security_groups\u003d[sec_grp_id])"},{"line_number":682,"context_line":"        server_ssh_clients, fips, vm_test_sg \u003d self.create_vm_testing_sec_grp("},{"line_number":683,"context_line":"            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: sec_grp_name}],"},{"line_number":684,"context_line":"            ports\u003d[ex_port])"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        \"\"\"\"ping vm and remove SG by updating vm Port and ensure PING fails\"\"\""},{"line_number":687,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"a6fc853a_2123d3f8","line":684,"range":{"start_line":682,"start_character":0,"end_line":684,"end_character":28},"updated":"2022-06-21 18:28:47.000000000","message":"Since \"server_ssh_clients and vm_test_sg\" are not in use and the only return parameter you are interested in returned tuple is \"fips\", use indexing to get the \"fips\" only, it means using index [1] like here:\n\n        fips \u003d self.create_vm_testing_sec_grp(\n            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: sec_grp_name}],\n            ports\u003d[ex_port])[1]","commit_id":"f792a158b2dd1ea4f1b197a94935b8e1b633cd9b"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"e277645f0f36db147949c7a1cfdbd09bfa5ab3e8","unresolved":false,"context_lines":[{"line_number":679,"context_line":"        ex_port \u003d self.create_port("},{"line_number":680,"context_line":"            self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":681,"context_line":"            security_groups\u003d[sec_grp_id])"},{"line_number":682,"context_line":"        server_ssh_clients, fips, vm_test_sg \u003d self.create_vm_testing_sec_grp("},{"line_number":683,"context_line":"            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: sec_grp_name}],"},{"line_number":684,"context_line":"            ports\u003d[ex_port])"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        \"\"\"\"ping vm and remove SG by updating vm Port and ensure PING fails\"\"\""},{"line_number":687,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"03fab7b9_57787c2a","line":684,"range":{"start_line":682,"start_character":0,"end_line":684,"end_character":28},"in_reply_to":"a6fc853a_2123d3f8","updated":"2022-06-21 20:09:40.000000000","message":"Done","commit_id":"f792a158b2dd1ea4f1b197a94935b8e1b633cd9b"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"d4558cd060ccec30dd03bc60a6aea0545874b34a","unresolved":true,"context_lines":[{"line_number":683,"context_line":"            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: sec_grp_name}],"},{"line_number":684,"context_line":"            ports\u003d[ex_port])"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        \"\"\"\"ping vm and remove SG by updating vm Port and ensure PING fails\"\"\""},{"line_number":687,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":688,"context_line":"        self.client.update_port(ex_port[\u0027id\u0027],"},{"line_number":689,"context_line":"                                security_groups\u003d[])"}],"source_content_type":"text/x-python","patch_set":10,"id":"18182b7c_d54b4faa","line":686,"range":{"start_line":686,"start_character":12,"end_line":686,"end_character":16},"updated":"2022-06-21 18:28:47.000000000","message":"Nit:\nPing VM (PASS), remove SG by updating VM Port and ensure PING fails\"\"","commit_id":"f792a158b2dd1ea4f1b197a94935b8e1b633cd9b"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"e277645f0f36db147949c7a1cfdbd09bfa5ab3e8","unresolved":false,"context_lines":[{"line_number":683,"context_line":"            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: sec_grp_name}],"},{"line_number":684,"context_line":"            ports\u003d[ex_port])"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        \"\"\"\"ping vm and remove SG by updating vm Port and ensure PING fails\"\"\""},{"line_number":687,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":688,"context_line":"        self.client.update_port(ex_port[\u0027id\u0027],"},{"line_number":689,"context_line":"                                security_groups\u003d[])"}],"source_content_type":"text/x-python","patch_set":10,"id":"140b10a8_22750615","line":686,"range":{"start_line":686,"start_character":12,"end_line":686,"end_character":16},"in_reply_to":"18182b7c_d54b4faa","updated":"2022-06-21 20:09:40.000000000","message":"Done","commit_id":"f792a158b2dd1ea4f1b197a94935b8e1b633cd9b"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"d9f628b2b71aa38a225f95eadd2096beaa236738","unresolved":true,"context_lines":[{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        \"\"\"Create Port with the previous SG and use it for VM creation\"\"\""},{"line_number":679,"context_line":"        ex_port \u003d self.create_port("},{"line_number":680,"context_line":"            self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":681,"context_line":"            security_groups\u003d[sec_grp_id])"},{"line_number":682,"context_line":"        fips \u003d self.create_vm_testing_sec_grp("},{"line_number":683,"context_line":"            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: sec_grp_name}],"}],"source_content_type":"text/x-python","patch_set":12,"id":"bdb236ab_22077706","line":680,"range":{"start_line":680,"start_character":56,"end_line":680,"end_character":66},"updated":"2022-06-22 16:55:11.000000000","message":"\u0027self.subnets\u0027 may contain many subnets, and current code takes the first one \u0027self.subnets[0]\u0027, while \u0027self.subnet\u0027 refers directly to the subnet created for this test class \u0027NetworkSecGroupTest\u0027, created in \u0027resource_setup\u0027 method, line 86.\nI think \u0027self.subnet\u0027 is safer to use.","commit_id":"5f0fbb12e89594294c884f5e8467299afe6f7220"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"6a50225209f35369ef4b8820925d8fd399a6a0e7","unresolved":true,"context_lines":[{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        \"\"\"Create Port with the previous SG and use it for VM creation\"\"\""},{"line_number":679,"context_line":"        ex_port \u003d self.create_port("},{"line_number":680,"context_line":"            self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":681,"context_line":"            security_groups\u003d[sec_grp_id])"},{"line_number":682,"context_line":"        fips \u003d self.create_vm_testing_sec_grp("},{"line_number":683,"context_line":"            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: sec_grp_name}],"}],"source_content_type":"text/x-python","patch_set":12,"id":"65c96a4f_73b03ab8","line":680,"range":{"start_line":680,"start_character":56,"end_line":680,"end_character":66},"in_reply_to":"bdb236ab_22077706","updated":"2022-06-22 20:05:30.000000000","message":"+1","commit_id":"5f0fbb12e89594294c884f5e8467299afe6f7220"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"bb2f6778c05e9f0cb77384e73a27ddcffc45d769","unresolved":false,"context_lines":[{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        \"\"\"Create Port with the previous SG and use it for VM creation\"\"\""},{"line_number":679,"context_line":"        ex_port \u003d self.create_port("},{"line_number":680,"context_line":"            self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":681,"context_line":"            security_groups\u003d[sec_grp_id])"},{"line_number":682,"context_line":"        fips \u003d self.create_vm_testing_sec_grp("},{"line_number":683,"context_line":"            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: sec_grp_name}],"}],"source_content_type":"text/x-python","patch_set":12,"id":"55436d17_5971c809","line":680,"range":{"start_line":680,"start_character":56,"end_line":680,"end_character":66},"in_reply_to":"bdb236ab_22077706","updated":"2022-06-22 20:54:17.000000000","message":"Done","commit_id":"5f0fbb12e89594294c884f5e8467299afe6f7220"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"d9f628b2b71aa38a225f95eadd2096beaa236738","unresolved":true,"context_lines":[{"line_number":679,"context_line":"        ex_port \u003d self.create_port("},{"line_number":680,"context_line":"            self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":681,"context_line":"            security_groups\u003d[sec_grp_id])"},{"line_number":682,"context_line":"        fips \u003d self.create_vm_testing_sec_grp("},{"line_number":683,"context_line":"            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: sec_grp_name}],"},{"line_number":684,"context_line":"            ports\u003d[ex_port])[1]"},{"line_number":685,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"cc0ebde1_24020f7c","line":682,"range":{"start_line":682,"start_character":8,"end_line":682,"end_character":12},"updated":"2022-06-22 16:55:11.000000000","message":"there is only 1 fip, I would already take it using \u0027ports\u003d[ex_port])[1][0]\u0027, call the variable \u0027fip\u0027 and not use index 0 later (L687, L690).\nup to you.","commit_id":"5f0fbb12e89594294c884f5e8467299afe6f7220"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"6a50225209f35369ef4b8820925d8fd399a6a0e7","unresolved":true,"context_lines":[{"line_number":679,"context_line":"        ex_port \u003d self.create_port("},{"line_number":680,"context_line":"            self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":681,"context_line":"            security_groups\u003d[sec_grp_id])"},{"line_number":682,"context_line":"        fips \u003d self.create_vm_testing_sec_grp("},{"line_number":683,"context_line":"            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: sec_grp_name}],"},{"line_number":684,"context_line":"            ports\u003d[ex_port])[1]"},{"line_number":685,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"8e98bfe7_d6c45fb5","line":682,"range":{"start_line":682,"start_character":8,"end_line":682,"end_character":12},"in_reply_to":"cc0ebde1_24020f7c","updated":"2022-06-22 20:05:30.000000000","message":"+1","commit_id":"5f0fbb12e89594294c884f5e8467299afe6f7220"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"bb2f6778c05e9f0cb77384e73a27ddcffc45d769","unresolved":false,"context_lines":[{"line_number":679,"context_line":"        ex_port \u003d self.create_port("},{"line_number":680,"context_line":"            self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":681,"context_line":"            security_groups\u003d[sec_grp_id])"},{"line_number":682,"context_line":"        fips \u003d self.create_vm_testing_sec_grp("},{"line_number":683,"context_line":"            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: sec_grp_name}],"},{"line_number":684,"context_line":"            ports\u003d[ex_port])[1]"},{"line_number":685,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7ead8c0d_5bc10573","line":682,"range":{"start_line":682,"start_character":8,"end_line":682,"end_character":12},"in_reply_to":"cc0ebde1_24020f7c","updated":"2022-06-22 20:54:17.000000000","message":"Done","commit_id":"5f0fbb12e89594294c884f5e8467299afe6f7220"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"d9f628b2b71aa38a225f95eadd2096beaa236738","unresolved":true,"context_lines":[{"line_number":683,"context_line":"            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: sec_grp_name}],"},{"line_number":684,"context_line":"            ports\u003d[ex_port])[1]"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        \"\"\"\"Ping VM (PASS), remove SG by updating VM Port, ensure PING fails\"\"\""},{"line_number":687,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":688,"context_line":"        self.client.update_port(ex_port[\u0027id\u0027],"},{"line_number":689,"context_line":"                                security_groups\u003d[])"}],"source_content_type":"text/x-python","patch_set":12,"id":"a712949d_9f07f789","line":686,"range":{"start_line":686,"start_character":11,"end_line":686,"end_character":12},"updated":"2022-06-22 16:55:11.000000000","message":"nit: there is extra \" after comment opening \"\"\"","commit_id":"5f0fbb12e89594294c884f5e8467299afe6f7220"},{"author":{"_account_id":28609,"name":"Arkady Shtempler","email":"ashtempl@redhat.com","username":"ashtempl"},"change_message_id":"6a50225209f35369ef4b8820925d8fd399a6a0e7","unresolved":true,"context_lines":[{"line_number":683,"context_line":"            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: sec_grp_name}],"},{"line_number":684,"context_line":"            ports\u003d[ex_port])[1]"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        \"\"\"\"Ping VM (PASS), remove SG by updating VM Port, ensure PING fails\"\"\""},{"line_number":687,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":688,"context_line":"        self.client.update_port(ex_port[\u0027id\u0027],"},{"line_number":689,"context_line":"                                security_groups\u003d[])"}],"source_content_type":"text/x-python","patch_set":12,"id":"45b0c922_f1dfcb12","line":686,"range":{"start_line":686,"start_character":11,"end_line":686,"end_character":12},"in_reply_to":"a712949d_9f07f789","updated":"2022-06-22 20:05:30.000000000","message":"+1","commit_id":"5f0fbb12e89594294c884f5e8467299afe6f7220"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"bb2f6778c05e9f0cb77384e73a27ddcffc45d769","unresolved":false,"context_lines":[{"line_number":683,"context_line":"            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: sec_grp_name}],"},{"line_number":684,"context_line":"            ports\u003d[ex_port])[1]"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        \"\"\"\"Ping VM (PASS), remove SG by updating VM Port, ensure PING fails\"\"\""},{"line_number":687,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":688,"context_line":"        self.client.update_port(ex_port[\u0027id\u0027],"},{"line_number":689,"context_line":"                                security_groups\u003d[])"}],"source_content_type":"text/x-python","patch_set":12,"id":"e16893e3_9d805963","line":686,"range":{"start_line":686,"start_character":11,"end_line":686,"end_character":12},"in_reply_to":"a712949d_9f07f789","updated":"2022-06-22 20:54:17.000000000","message":"Done","commit_id":"5f0fbb12e89594294c884f5e8467299afe6f7220"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"159f14037920e8bfb146020e58dd6fe8f31a4afa","unresolved":true,"context_lines":[{"line_number":665,"context_line":"                                             port, [])"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    @decorators.idempotent_id(\u002796dcd5ff-9d45-4e0d-bea0-0b438cbd388f\u0027)"},{"line_number":668,"context_line":"    def test_remove_sec_grp_from_active_vm(self):"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        \"\"\"Create SG associated with ICMP rule and add to cleanup\"\"\""},{"line_number":671,"context_line":"        sec_grp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff501ea8_6d0f1f8d","line":668,"range":{"start_line":668,"start_character":8,"end_line":668,"end_character":42},"updated":"2022-06-23 07:32:09.000000000","message":"I am not sure if we need a whole new test there should be extra step for test_default_sec_grp_scenarios, but I can leave with it","commit_id":"80648b5463a3e47800c7b6ae2db63bd19e83807a"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"69da87fc3938323601aeba9d9bf76d82816726e7","unresolved":false,"context_lines":[{"line_number":665,"context_line":"                                             port, [])"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    @decorators.idempotent_id(\u002796dcd5ff-9d45-4e0d-bea0-0b438cbd388f\u0027)"},{"line_number":668,"context_line":"    def test_remove_sec_grp_from_active_vm(self):"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        \"\"\"Create SG associated with ICMP rule and add to cleanup\"\"\""},{"line_number":671,"context_line":"        sec_grp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1c706a2f_2d5cd752","line":668,"range":{"start_line":668,"start_character":8,"end_line":668,"end_character":42},"in_reply_to":"4953eb37_91e388ca","updated":"2022-06-28 10:54:36.000000000","message":"Done","commit_id":"80648b5463a3e47800c7b6ae2db63bd19e83807a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"db2e70da9aa4c8e6ffe112f214b4b16d72752e59","unresolved":true,"context_lines":[{"line_number":665,"context_line":"                                             port, [])"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    @decorators.idempotent_id(\u002796dcd5ff-9d45-4e0d-bea0-0b438cbd388f\u0027)"},{"line_number":668,"context_line":"    def test_remove_sec_grp_from_active_vm(self):"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        \"\"\"Create SG associated with ICMP rule and add to cleanup\"\"\""},{"line_number":671,"context_line":"        sec_grp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"4953eb37_91e388ca","line":668,"range":{"start_line":668,"start_character":8,"end_line":668,"end_character":42},"in_reply_to":"ff501ea8_6d0f1f8d","updated":"2022-06-28 07:06:51.000000000","message":"Yeah, I had the same initial thought but that test is checking only the default SGs. I know adding a new test will increase the testing time but I think this test worths it.","commit_id":"80648b5463a3e47800c7b6ae2db63bd19e83807a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"159f14037920e8bfb146020e58dd6fe8f31a4afa","unresolved":true,"context_lines":[{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    @decorators.idempotent_id(\u002796dcd5ff-9d45-4e0d-bea0-0b438cbd388f\u0027)"},{"line_number":668,"context_line":"    def test_remove_sec_grp_from_active_vm(self):"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        \"\"\"Create SG associated with ICMP rule and add to cleanup\"\"\""},{"line_number":671,"context_line":"        sec_grp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":672,"context_line":"        secgrp \u003d self.os_primary.network_client.create_security_group("}],"source_content_type":"text/x-python","patch_set":13,"id":"633c2b5e_5c93d4b9","line":669,"updated":"2022-06-23 07:32:09.000000000","message":"nit: unnecessary empty line","commit_id":"80648b5463a3e47800c7b6ae2db63bd19e83807a"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"f2c1846cea30257b8ee413e2cf58a2f5569b81b0","unresolved":false,"context_lines":[{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    @decorators.idempotent_id(\u002796dcd5ff-9d45-4e0d-bea0-0b438cbd388f\u0027)"},{"line_number":668,"context_line":"    def test_remove_sec_grp_from_active_vm(self):"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        \"\"\"Create SG associated with ICMP rule and add to cleanup\"\"\""},{"line_number":671,"context_line":"        sec_grp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":672,"context_line":"        secgrp \u003d self.os_primary.network_client.create_security_group("}],"source_content_type":"text/x-python","patch_set":13,"id":"4ba7ef79_266a702e","line":669,"in_reply_to":"633c2b5e_5c93d4b9","updated":"2022-06-28 11:23:32.000000000","message":"Done","commit_id":"80648b5463a3e47800c7b6ae2db63bd19e83807a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"159f14037920e8bfb146020e58dd6fe8f31a4afa","unresolved":true,"context_lines":[{"line_number":675,"context_line":"        sec_grp_id \u003d secgrp[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":676,"context_line":"        self.create_pingable_secgroup_rule(sec_grp_id)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        \"\"\"Create Port with the previous SG and use it for VM creation\"\"\""},{"line_number":679,"context_line":"        ex_port \u003d self.create_port("},{"line_number":680,"context_line":"            self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnet[\u0027id\u0027]}],"},{"line_number":681,"context_line":"            security_groups\u003d[sec_grp_id])"}],"source_content_type":"text/x-python","patch_set":13,"id":"8fb3c33d_b2651992","line":678,"range":{"start_line":678,"start_character":8,"end_line":678,"end_character":73},"updated":"2022-06-23 07:32:09.000000000","message":"nit: these docstrings should be just comments","commit_id":"80648b5463a3e47800c7b6ae2db63bd19e83807a"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"f2c1846cea30257b8ee413e2cf58a2f5569b81b0","unresolved":false,"context_lines":[{"line_number":675,"context_line":"        sec_grp_id \u003d secgrp[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":676,"context_line":"        self.create_pingable_secgroup_rule(sec_grp_id)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        \"\"\"Create Port with the previous SG and use it for VM creation\"\"\""},{"line_number":679,"context_line":"        ex_port \u003d self.create_port("},{"line_number":680,"context_line":"            self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnet[\u0027id\u0027]}],"},{"line_number":681,"context_line":"            security_groups\u003d[sec_grp_id])"}],"source_content_type":"text/x-python","patch_set":13,"id":"85839d8f_a4845b18","line":678,"range":{"start_line":678,"start_character":8,"end_line":678,"end_character":73},"in_reply_to":"5dbf3160_c4e86d6c","updated":"2022-06-28 11:23:32.000000000","message":"Done","commit_id":"80648b5463a3e47800c7b6ae2db63bd19e83807a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"db2e70da9aa4c8e6ffe112f214b4b16d72752e59","unresolved":true,"context_lines":[{"line_number":675,"context_line":"        sec_grp_id \u003d secgrp[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":676,"context_line":"        self.create_pingable_secgroup_rule(sec_grp_id)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        \"\"\"Create Port with the previous SG and use it for VM creation\"\"\""},{"line_number":679,"context_line":"        ex_port \u003d self.create_port("},{"line_number":680,"context_line":"            self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnet[\u0027id\u0027]}],"},{"line_number":681,"context_line":"            security_groups\u003d[sec_grp_id])"}],"source_content_type":"text/x-python","patch_set":13,"id":"5dbf3160_c4e86d6c","line":678,"range":{"start_line":678,"start_character":8,"end_line":678,"end_character":73},"in_reply_to":"8fb3c33d_b2651992","updated":"2022-06-28 07:06:51.000000000","message":"Agree. Please, check [1]\n\n[1]https://github.com/openstack/neutron-tempest-plugin/blob/fffd0a4dbf2942be3700899d10fb900ae5c5ee38/neutron_tempest_plugin/scenario/test_floatingip.py#L223-L231","commit_id":"80648b5463a3e47800c7b6ae2db63bd19e83807a"}]}