)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"1a6515d4f60fb94510140e2b07b14f6c3b9f0a80","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ayenachew Molla \u003camolla@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-30 15:49:01 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Test to remove TCP security group rule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I63ce3029bc69206671255f8a2335d88d15646ea2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7bea4da3_38ac7132","line":7,"updated":"2022-06-30 14:50:10.000000000","message":"The test doesn\u0027t seem to remove any security group rule, it does something else.","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ayenachew Molla \u003camolla@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-30 15:49:01 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Test to remove TCP security group rule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I63ce3029bc69206671255f8a2335d88d15646ea2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cbe58c8a_25a647c9","line":7,"in_reply_to":"7bea4da3_38ac7132","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"c24cc0965ec0173044616e46b3b733c4b79deeb9","unresolved":true,"context_lines":[{"line_number":14,"context_line":"5.Add a tcp rule port 80 connections to the security group"},{"line_number":15,"context_line":"6.Verify that you have tcp port 80 connectivity to the VM"},{"line_number":16,"context_line":"7.Delete the added tcp rule from the security group"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I63ce3029bc69206671255f8a2335d88d15646ea2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e9d69172_26de6964","line":17,"updated":"2022-07-25 16:32:56.000000000","message":"I would add 8th step, same check as 4th step.","commit_id":"20713b0c6ad961161d991aa86c7cb334534b0f57"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"ad65c6829b76209f5f0df03803cd3accb0d18063","unresolved":false,"context_lines":[{"line_number":14,"context_line":"5.Add a tcp rule port 80 connections to the security group"},{"line_number":15,"context_line":"6.Verify that you have tcp port 80 connectivity to the VM"},{"line_number":16,"context_line":"7.Delete the added tcp rule from the security group"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I63ce3029bc69206671255f8a2335d88d15646ea2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f36ddab_8513e701","line":17,"in_reply_to":"e9d69172_26de6964","updated":"2022-07-26 12:58:47.000000000","message":"Done","commit_id":"20713b0c6ad961161d991aa86c7cb334534b0f57"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b87fcca376b5bf0ee05a4455dc860490d55bec38","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Delete tcp rule from a security group"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Test name: \"test_remove_tcp_rule_from_sec_grp\""},{"line_number":10,"context_line":"1.Delete the tcp rule from the security group"},{"line_number":11,"context_line":"2.Verify that conections are not working"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"14a232d6_75daa4d9","line":9,"updated":"2022-08-04 08:33:57.000000000","message":"Please update that commit message as now it\u0027s not valid anymore 😊","commit_id":"e61de8fbe95a4843076d8e3c21d2381c2c4cdcff"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"083e82d7984a5207e93c3c3943144d87f7326164","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Delete tcp rule from a security group"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Test name: \"test_remove_tcp_rule_from_sec_grp\""},{"line_number":10,"context_line":"1.Delete the tcp rule from the security group"},{"line_number":11,"context_line":"2.Verify that conections are not working"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa2a191c_415f46df","line":9,"in_reply_to":"14a232d6_75daa4d9","updated":"2022-08-04 09:45:37.000000000","message":"updating,thanks","commit_id":"e61de8fbe95a4843076d8e3c21d2381c2c4cdcff"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"2331779e7673b3f7f393a29c5c5b3cd7998764b2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Delete tcp rule from a security group"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Test name: \"test_remove_tcp_rule_from_sec_grp\""},{"line_number":10,"context_line":"1.Delete the tcp rule from the security group"},{"line_number":11,"context_line":"2.Verify that conections are not working"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"f81c077e_b16e331d","line":9,"in_reply_to":"fa2a191c_415f46df","updated":"2022-08-04 09:46:27.000000000","message":"Done","commit_id":"e61de8fbe95a4843076d8e3c21d2381c2c4cdcff"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"f1998cfaaaf45a7ac4b44924f83d8ce9d0ced8c7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d35459c2_5040de25","updated":"2022-07-07 15:47:20.000000000","message":"I left a few comments also in code. \n\nPlease write test steps in commit message or doc string, I\u0027m not sure what are the specific steps you are working on, that way I can be more helpful.\n\nAlso please run these steps manually and verify they work as expected before working on automation code, it may spare plenty of time.\n\nThanks, BR.","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6a628353_8111440e","in_reply_to":"d35459c2_5040de25","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6560beac_ad870fd8","updated":"2022-07-20 08:30:15.000000000","message":"Fixed","commit_id":"ecb56d0ee99f5bf161acdedcf04539bfba2394a4"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"c24cc0965ec0173044616e46b3b733c4b79deeb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3e1f0492_c45c66d1","updated":"2022-07-25 16:32:56.000000000","message":"Code looks generally good to me, just a few comments 😊","commit_id":"20713b0c6ad961161d991aa86c7cb334534b0f57"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"ad65c6829b76209f5f0df03803cd3accb0d18063","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3b59da20_72bb986d","in_reply_to":"3e1f0492_c45c66d1","updated":"2022-07-26 12:58:47.000000000","message":"Fixed, thanks for the comment","commit_id":"20713b0c6ad961161d991aa86c7cb334534b0f57"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"ad65c6829b76209f5f0df03803cd3accb0d18063","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"126f6e0f_d118e949","updated":"2022-07-26 12:58:47.000000000","message":"Fixed, thanks for the comment","commit_id":"0c6c4e69fc3306257c013014e850cd2482d22918"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"3e64ee42dcd28494cea7fe733db4a620e8e01fea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b92cc082_8d7d2ab3","updated":"2022-07-27 09:40:58.000000000","message":"ok thanks for the review i will add steps to the test_multiple_ports_portrange_remote test","commit_id":"0c6c4e69fc3306257c013014e850cd2482d22918"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e9a77689621f985c8473a10973f3e924417e3c33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ad67896e_b972eaa8","updated":"2022-08-16 04:23:08.000000000","message":"LGTM","commit_id":"111226608a396676c051da3e90cf151f38af2725"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"4136cd2efbaa4830ef3cd363e9f7baa7f3abccaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0dd27c23_b5209216","updated":"2022-08-11 09:50:50.000000000","message":"recheck","commit_id":"111226608a396676c051da3e90cf151f38af2725"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"a689586290459134028d26b7128b60e789bafd11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"27b067a6_7835d4af","updated":"2022-08-11 06:41:55.000000000","message":"recheck","commit_id":"111226608a396676c051da3e90cf151f38af2725"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"8c821e9f01529a3b1502925a60b40645db70a9da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"54cd47c2_b98af182","updated":"2022-08-15 06:20:47.000000000","message":"recheck","commit_id":"111226608a396676c051da3e90cf151f38af2725"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"03cda75f8ec284754d99c5d60ae6f74ae4b53187","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b244a76e_0b883493","updated":"2022-08-11 13:15:54.000000000","message":"recheck","commit_id":"111226608a396676c051da3e90cf151f38af2725"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"21eccb3629f9bf5c6eaaf2b96da961fd8f2b2860","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e6b45b94_9ec28f21","updated":"2022-08-15 13:52:40.000000000","message":"recheck","commit_id":"111226608a396676c051da3e90cf151f38af2725"}],"neutron_tempest_plugin/scenario/test_security_groups.py":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"1a6515d4f60fb94510140e2b07b14f6c3b9f0a80","unresolved":true,"context_lines":[{"line_number":695,"context_line":"                             should_succeed\u003dFalse)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"    @decorators.idempotent_id(\u00279c590cdb-d2d8-4431-b439-effeff493297\u0027)"},{"line_number":698,"context_line":"    def test_remove_tcp_rule_from_sec_grp(self):"},{"line_number":699,"context_line":"        \"\"\"create SG\"\"\""},{"line_number":700,"context_line":"        secgrp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":701,"context_line":"        sec_grp \u003d self.create_security_group(name\u003dsecgrp_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"55429928_1f819eec","line":698,"updated":"2022-06-30 14:50:10.000000000","message":"The test doesn\u0027t seem to remove any security group rule, it does something else.","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":695,"context_line":"                             should_succeed\u003dFalse)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"    @decorators.idempotent_id(\u00279c590cdb-d2d8-4431-b439-effeff493297\u0027)"},{"line_number":698,"context_line":"    def test_remove_tcp_rule_from_sec_grp(self):"},{"line_number":699,"context_line":"        \"\"\"create SG\"\"\""},{"line_number":700,"context_line":"        secgrp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":701,"context_line":"        sec_grp \u003d self.create_security_group(name\u003dsecgrp_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"319c90a4_210e2af3","line":698,"in_reply_to":"55429928_1f819eec","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"1a6515d4f60fb94510140e2b07b14f6c3b9f0a80","unresolved":true,"context_lines":[{"line_number":696,"context_line":""},{"line_number":697,"context_line":"    @decorators.idempotent_id(\u00279c590cdb-d2d8-4431-b439-effeff493297\u0027)"},{"line_number":698,"context_line":"    def test_remove_tcp_rule_from_sec_grp(self):"},{"line_number":699,"context_line":"        \"\"\"create SG\"\"\""},{"line_number":700,"context_line":"        secgrp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":701,"context_line":"        sec_grp \u003d self.create_security_group(name\u003dsecgrp_name)"},{"line_number":702,"context_line":"        sec_grp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"93ccc767_37e75c74","line":699,"updated":"2022-06-30 14:50:10.000000000","message":"nit: SG or SGs? group or groups?","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":696,"context_line":""},{"line_number":697,"context_line":"    @decorators.idempotent_id(\u00279c590cdb-d2d8-4431-b439-effeff493297\u0027)"},{"line_number":698,"context_line":"    def test_remove_tcp_rule_from_sec_grp(self):"},{"line_number":699,"context_line":"        \"\"\"create SG\"\"\""},{"line_number":700,"context_line":"        secgrp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":701,"context_line":"        sec_grp \u003d self.create_security_group(name\u003dsecgrp_name)"},{"line_number":702,"context_line":"        sec_grp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b5e957a3_18ed9616","line":699,"in_reply_to":"93ccc767_37e75c74","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"1a6515d4f60fb94510140e2b07b14f6c3b9f0a80","unresolved":true,"context_lines":[{"line_number":697,"context_line":"    @decorators.idempotent_id(\u00279c590cdb-d2d8-4431-b439-effeff493297\u0027)"},{"line_number":698,"context_line":"    def test_remove_tcp_rule_from_sec_grp(self):"},{"line_number":699,"context_line":"        \"\"\"create SG\"\"\""},{"line_number":700,"context_line":"        secgrp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":701,"context_line":"        sec_grp \u003d self.create_security_group(name\u003dsecgrp_name)"},{"line_number":702,"context_line":"        sec_grp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":703,"context_line":"        sg \u003d self.create_security_group(sec_grp_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"00edd928_9be509b4","line":700,"updated":"2022-06-30 14:50:10.000000000","message":"In L700-703 it seems you create 2 security groups, is it the intention for this test?\nIf it is needed then I think using variable names with different meaning may help (ex: sg_good/sg_bad/sec_group_pass/sec_group_fail).","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":697,"context_line":"    @decorators.idempotent_id(\u00279c590cdb-d2d8-4431-b439-effeff493297\u0027)"},{"line_number":698,"context_line":"    def test_remove_tcp_rule_from_sec_grp(self):"},{"line_number":699,"context_line":"        \"\"\"create SG\"\"\""},{"line_number":700,"context_line":"        secgrp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":701,"context_line":"        sec_grp \u003d self.create_security_group(name\u003dsecgrp_name)"},{"line_number":702,"context_line":"        sec_grp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":703,"context_line":"        sg \u003d self.create_security_group(sec_grp_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3727a7be_80470efa","line":700,"in_reply_to":"00edd928_9be509b4","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"1a6515d4f60fb94510140e2b07b14f6c3b9f0a80","unresolved":true,"context_lines":[{"line_number":707,"context_line":"                    \u0027port_range_max\u0027: 80}]"},{"line_number":708,"context_line":"        self.create_secgroup_rules(nc_rule, secgroup_id\u003dsg[\u0027id\u0027])"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        \"\"\"create VM\"\"\""},{"line_number":711,"context_line":"        self.create_loginable_secgroup_rule(secgroup_id\u003dsec_grp)"},{"line_number":712,"context_line":"        vm_ssh, fips, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":713,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fedf8ebc_6e14468b","line":710,"updated":"2022-06-30 14:50:10.000000000","message":"Use a comment instead of string object, there is no need to create a string.","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":707,"context_line":"                    \u0027port_range_max\u0027: 80}]"},{"line_number":708,"context_line":"        self.create_secgroup_rules(nc_rule, secgroup_id\u003dsg[\u0027id\u0027])"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        \"\"\"create VM\"\"\""},{"line_number":711,"context_line":"        self.create_loginable_secgroup_rule(secgroup_id\u003dsec_grp)"},{"line_number":712,"context_line":"        vm_ssh, fips, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":713,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa3b980b_7f105c08","line":710,"in_reply_to":"fedf8ebc_6e14468b","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"f1998cfaaaf45a7ac4b44924f83d8ce9d0ced8c7","unresolved":true,"context_lines":[{"line_number":707,"context_line":"                    \u0027port_range_max\u0027: 80}]"},{"line_number":708,"context_line":"        self.create_secgroup_rules(nc_rule, secgroup_id\u003dsg[\u0027id\u0027])"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        \"\"\"create VM\"\"\""},{"line_number":711,"context_line":"        self.create_loginable_secgroup_rule(secgroup_id\u003dsec_grp)"},{"line_number":712,"context_line":"        vm_ssh, fips, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":713,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3402032a_1cce5580","line":710,"in_reply_to":"fedf8ebc_6e14468b","updated":"2022-07-07 15:47:20.000000000","message":"Please mark comments that you took care of, it will be easier to review when non relevant comments are not seen in between code.","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"1a6515d4f60fb94510140e2b07b14f6c3b9f0a80","unresolved":true,"context_lines":[{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        \"\"\"create VM\"\"\""},{"line_number":711,"context_line":"        self.create_loginable_secgroup_rule(secgroup_id\u003dsec_grp)"},{"line_number":712,"context_line":"        vm_ssh, fips, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":713,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}])"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"        \"\"\"Create a PORT\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3168156e_053ec257","line":712,"range":{"start_line":712,"start_character":16,"end_line":712,"end_character":20},"updated":"2022-06-30 14:50:10.000000000","message":"\u0027fips\u0027 is never used.","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"1a6515d4f60fb94510140e2b07b14f6c3b9f0a80","unresolved":true,"context_lines":[{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        \"\"\"create VM\"\"\""},{"line_number":711,"context_line":"        self.create_loginable_secgroup_rule(secgroup_id\u003dsec_grp)"},{"line_number":712,"context_line":"        vm_ssh, fips, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":713,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}])"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"        \"\"\"Create a PORT\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"d2eca05b_8edc81ec","line":712,"range":{"start_line":712,"start_character":8,"end_line":712,"end_character":10},"updated":"2022-06-30 14:50:10.000000000","message":"nit: \u0027vm_ssh\u0027 has many, maybe vm_ssh_clients/vms_ssh with plural word is more suitable.","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        \"\"\"create VM\"\"\""},{"line_number":711,"context_line":"        self.create_loginable_secgroup_rule(secgroup_id\u003dsec_grp)"},{"line_number":712,"context_line":"        vm_ssh, fips, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":713,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}])"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"        \"\"\"Create a PORT\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"e19e5aa1_ab300707","line":712,"range":{"start_line":712,"start_character":16,"end_line":712,"end_character":20},"in_reply_to":"3168156e_053ec257","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        \"\"\"create VM\"\"\""},{"line_number":711,"context_line":"        self.create_loginable_secgroup_rule(secgroup_id\u003dsec_grp)"},{"line_number":712,"context_line":"        vm_ssh, fips, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":713,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}])"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"        \"\"\"Create a PORT\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"b33f20b7_7ea4e994","line":712,"range":{"start_line":712,"start_character":8,"end_line":712,"end_character":10},"in_reply_to":"d2eca05b_8edc81ec","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"1a6515d4f60fb94510140e2b07b14f6c3b9f0a80","unresolved":true,"context_lines":[{"line_number":712,"context_line":"        vm_ssh, fips, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":713,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}])"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"        \"\"\"Create a PORT\"\"\""},{"line_number":716,"context_line":"        srv_port \u003d self.client.list_ports(network_id\u003dself.network[\u0027id\u0027],"},{"line_number":717,"context_line":"                                          device_id\u003dvms[1][\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":718,"context_line":"        srv_ip \u003d srv_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1573acc4_a40294b1","line":715,"updated":"2022-06-30 14:50:10.000000000","message":"Use a comment instead of string object, there is no need to create a string.","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"1a6515d4f60fb94510140e2b07b14f6c3b9f0a80","unresolved":true,"context_lines":[{"line_number":712,"context_line":"        vm_ssh, fips, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":713,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}])"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"        \"\"\"Create a PORT\"\"\""},{"line_number":716,"context_line":"        srv_port \u003d self.client.list_ports(network_id\u003dself.network[\u0027id\u0027],"},{"line_number":717,"context_line":"                                          device_id\u003dvms[1][\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":718,"context_line":"        srv_ip \u003d srv_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"49ee66a0_9744f659","line":715,"updated":"2022-06-30 14:50:10.000000000","message":"nit: there is no creation of new port here, it is done in previous code","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":712,"context_line":"        vm_ssh, fips, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":713,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}])"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"        \"\"\"Create a PORT\"\"\""},{"line_number":716,"context_line":"        srv_port \u003d self.client.list_ports(network_id\u003dself.network[\u0027id\u0027],"},{"line_number":717,"context_line":"                                          device_id\u003dvms[1][\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":718,"context_line":"        srv_ip \u003d srv_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"59c0915b_be87dcee","line":715,"in_reply_to":"1573acc4_a40294b1","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":712,"context_line":"        vm_ssh, fips, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":713,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}])"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"        \"\"\"Create a PORT\"\"\""},{"line_number":716,"context_line":"        srv_port \u003d self.client.list_ports(network_id\u003dself.network[\u0027id\u0027],"},{"line_number":717,"context_line":"                                          device_id\u003dvms[1][\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":718,"context_line":"        srv_ip \u003d srv_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f6e5459_390668af","line":715,"in_reply_to":"49ee66a0_9744f659","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"1a6515d4f60fb94510140e2b07b14f6c3b9f0a80","unresolved":true,"context_lines":[{"line_number":717,"context_line":"                                          device_id\u003dvms[1][\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":718,"context_line":"        srv_ip \u003d srv_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"        \"\"\"verify tcp port 80 connectivity FAIL\"\"\""},{"line_number":721,"context_line":"        with utils.StatefulConnection("},{"line_number":722,"context_line":"                vm_ssh[0], vm_ssh[1], srv_ip, 80) as con:"},{"line_number":723,"context_line":"            self.client.update_port("}],"source_content_type":"text/x-python","patch_set":1,"id":"964144c0_debb342a","line":720,"updated":"2022-06-30 14:50:10.000000000","message":"Use a comment instead of string object, there is no need to create a string.","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":717,"context_line":"                                          device_id\u003dvms[1][\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":718,"context_line":"        srv_ip \u003d srv_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"        \"\"\"verify tcp port 80 connectivity FAIL\"\"\""},{"line_number":721,"context_line":"        with utils.StatefulConnection("},{"line_number":722,"context_line":"                vm_ssh[0], vm_ssh[1], srv_ip, 80) as con:"},{"line_number":723,"context_line":"            self.client.update_port("}],"source_content_type":"text/x-python","patch_set":1,"id":"de125435_ed899e67","line":720,"in_reply_to":"964144c0_debb342a","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"1a6515d4f60fb94510140e2b07b14f6c3b9f0a80","unresolved":true,"context_lines":[{"line_number":724,"context_line":"                    srv_port[\u0027id\u0027], security_groups\u003d[sec_grp])"},{"line_number":725,"context_line":"            con.test_connection(should_pass\u003dFalse)"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"        \"\"\"verify tcp port 80 connectivity PASS\"\"\""},{"line_number":728,"context_line":"        with utils.StatefulConnection("},{"line_number":729,"context_line":"                vm_ssh[0], vm_ssh[1], srv_ip, 80) as con:"},{"line_number":730,"context_line":"            self.client.update_port(srv_port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"98eb7ff5_26c4efa5","line":727,"updated":"2022-06-30 14:50:10.000000000","message":"Use a comment instead of string object, there is no need to create a string.","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":724,"context_line":"                    srv_port[\u0027id\u0027], security_groups\u003d[sec_grp])"},{"line_number":725,"context_line":"            con.test_connection(should_pass\u003dFalse)"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"        \"\"\"verify tcp port 80 connectivity PASS\"\"\""},{"line_number":728,"context_line":"        with utils.StatefulConnection("},{"line_number":729,"context_line":"                vm_ssh[0], vm_ssh[1], srv_ip, 80) as con:"},{"line_number":730,"context_line":"            self.client.update_port(srv_port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7acafc97_207ab15e","line":727,"in_reply_to":"98eb7ff5_26c4efa5","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"1504da14f733ec128adb53f186213edb8be8b165"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"f1998cfaaaf45a7ac4b44924f83d8ce9d0ced8c7","unresolved":true,"context_lines":[{"line_number":730,"context_line":"        vms_ssh, fips, vms \u003d self.create_vm_testing_sec_grp()"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"        # Create remote and test security groups"},{"line_number":733,"context_line":"        for i in range(0, 2):"},{"line_number":734,"context_line":"            secgrs_for_tcp_test.append("},{"line_number":735,"context_line":"                self.create_security_group(name\u003d\u0027secgrp-%d\u0027 % i))"},{"line_number":736,"context_line":"            # configure sec groups to support SSH connectivity"}],"source_content_type":"text/x-python","patch_set":2,"id":"7fb8c60d_cda8b3c4","line":733,"range":{"start_line":733,"start_character":23,"end_line":733,"end_character":26},"updated":"2022-07-07 15:47:20.000000000","message":"No need for 2 arguments in range function, counting from 0 is the default behavior when range function used with 1 argument.","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":730,"context_line":"        vms_ssh, fips, vms \u003d self.create_vm_testing_sec_grp()"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"        # Create remote and test security groups"},{"line_number":733,"context_line":"        for i in range(0, 2):"},{"line_number":734,"context_line":"            secgrs_for_tcp_test.append("},{"line_number":735,"context_line":"                self.create_security_group(name\u003d\u0027secgrp-%d\u0027 % i))"},{"line_number":736,"context_line":"            # configure sec groups to support SSH connectivity"}],"source_content_type":"text/x-python","patch_set":2,"id":"f7b4c93d_7f4a75fb","line":733,"range":{"start_line":733,"start_character":23,"end_line":733,"end_character":26},"in_reply_to":"7fb8c60d_cda8b3c4","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"f1998cfaaaf45a7ac4b44924f83d8ce9d0ced8c7","unresolved":true,"context_lines":[{"line_number":737,"context_line":"            self.create_loginable_secgroup_rule("},{"line_number":738,"context_line":"                secgroup_id\u003dsecgrs_for_tcp_test[-1][\u0027id\u0027])"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"        # Configure security groups, first two servers as remotes"},{"line_number":741,"context_line":"        for i, vm in enumerate(vms):"},{"line_number":742,"context_line":"            port \u003d self.client.list_ports("},{"line_number":743,"context_line":"                network_id\u003dself.network[\u0027id\u0027], device_id\u003dvm[\u0027server\u0027]["}],"source_content_type":"text/x-python","patch_set":2,"id":"178ce353_93867db7","line":740,"range":{"start_line":740,"start_character":10,"end_line":740,"end_character":35},"updated":"2022-07-07 15:47:20.000000000","message":"I would mention the ports here as well, example \"Apply security groups on VMs using ports\".","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"f1998cfaaaf45a7ac4b44924f83d8ce9d0ced8c7","unresolved":true,"context_lines":[{"line_number":737,"context_line":"            self.create_loginable_secgroup_rule("},{"line_number":738,"context_line":"                secgroup_id\u003dsecgrs_for_tcp_test[-1][\u0027id\u0027])"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"        # Configure security groups, first two servers as remotes"},{"line_number":741,"context_line":"        for i, vm in enumerate(vms):"},{"line_number":742,"context_line":"            port \u003d self.client.list_ports("},{"line_number":743,"context_line":"                network_id\u003dself.network[\u0027id\u0027], device_id\u003dvm[\u0027server\u0027]["}],"source_content_type":"text/x-python","patch_set":2,"id":"b86bed05_ad6647d7","line":740,"range":{"start_line":740,"start_character":58,"end_line":740,"end_character":65},"updated":"2022-07-07 15:47:20.000000000","message":"What do you mean by \"first two servers as remotes\"?","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":737,"context_line":"            self.create_loginable_secgroup_rule("},{"line_number":738,"context_line":"                secgroup_id\u003dsecgrs_for_tcp_test[-1][\u0027id\u0027])"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"        # Configure security groups, first two servers as remotes"},{"line_number":741,"context_line":"        for i, vm in enumerate(vms):"},{"line_number":742,"context_line":"            port \u003d self.client.list_ports("},{"line_number":743,"context_line":"                network_id\u003dself.network[\u0027id\u0027], device_id\u003dvm[\u0027server\u0027]["}],"source_content_type":"text/x-python","patch_set":2,"id":"fdff1098_d3c18da5","line":740,"range":{"start_line":740,"start_character":10,"end_line":740,"end_character":35},"in_reply_to":"178ce353_93867db7","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":737,"context_line":"            self.create_loginable_secgroup_rule("},{"line_number":738,"context_line":"                secgroup_id\u003dsecgrs_for_tcp_test[-1][\u0027id\u0027])"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"        # Configure security groups, first two servers as remotes"},{"line_number":741,"context_line":"        for i, vm in enumerate(vms):"},{"line_number":742,"context_line":"            port \u003d self.client.list_ports("},{"line_number":743,"context_line":"                network_id\u003dself.network[\u0027id\u0027], device_id\u003dvm[\u0027server\u0027]["}],"source_content_type":"text/x-python","patch_set":2,"id":"68b2c369_fde6ff09","line":740,"range":{"start_line":740,"start_character":58,"end_line":740,"end_character":65},"in_reply_to":"b86bed05_ad6647d7","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"f1998cfaaaf45a7ac4b44924f83d8ce9d0ced8c7","unresolved":true,"context_lines":[{"line_number":738,"context_line":"                secgroup_id\u003dsecgrs_for_tcp_test[-1][\u0027id\u0027])"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"        # Configure security groups, first two servers as remotes"},{"line_number":741,"context_line":"        for i, vm in enumerate(vms):"},{"line_number":742,"context_line":"            port \u003d self.client.list_ports("},{"line_number":743,"context_line":"                network_id\u003dself.network[\u0027id\u0027], device_id\u003dvm[\u0027server\u0027]["},{"line_number":744,"context_line":"                    \u0027id\u0027])[\u0027ports\u0027][0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"844419bb_59035aa8","line":741,"range":{"start_line":741,"start_character":21,"end_line":741,"end_character":30},"updated":"2022-07-07 15:47:20.000000000","message":"nit: You already made \u0027vms\u0027 which could be indexed by same index \u0027i\u0027, therefore no need to use enumerate IMO.","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":738,"context_line":"                secgroup_id\u003dsecgrs_for_tcp_test[-1][\u0027id\u0027])"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"        # Configure security groups, first two servers as remotes"},{"line_number":741,"context_line":"        for i, vm in enumerate(vms):"},{"line_number":742,"context_line":"            port \u003d self.client.list_ports("},{"line_number":743,"context_line":"                network_id\u003dself.network[\u0027id\u0027], device_id\u003dvm[\u0027server\u0027]["},{"line_number":744,"context_line":"                    \u0027id\u0027])[\u0027ports\u0027][0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ccb69d80_eec33c03","line":741,"range":{"start_line":741,"start_character":21,"end_line":741,"end_character":30},"in_reply_to":"844419bb_59035aa8","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"f1998cfaaaf45a7ac4b44924f83d8ce9d0ced8c7","unresolved":true,"context_lines":[{"line_number":743,"context_line":"                network_id\u003dself.network[\u0027id\u0027], device_id\u003dvm[\u0027server\u0027]["},{"line_number":744,"context_line":"                    \u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":745,"context_line":"            ports_for_tcp_test.append(port)"},{"line_number":746,"context_line":"            secgroup \u003d secgrs_for_tcp_test[0 if i in range(0, 1) else 1]"},{"line_number":747,"context_line":"            self.client.update_port(port[\u0027id\u0027], security_groups\u003d["},{"line_number":748,"context_line":"                secgroup[\u0027id\u0027]])"},{"line_number":749,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"268d1bbd_a58b4827","line":746,"range":{"start_line":746,"start_character":43,"end_line":746,"end_character":71},"updated":"2022-07-07 15:47:20.000000000","message":"I think a single letter can do the same: i","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":743,"context_line":"                network_id\u003dself.network[\u0027id\u0027], device_id\u003dvm[\u0027server\u0027]["},{"line_number":744,"context_line":"                    \u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":745,"context_line":"            ports_for_tcp_test.append(port)"},{"line_number":746,"context_line":"            secgroup \u003d secgrs_for_tcp_test[0 if i in range(0, 1) else 1]"},{"line_number":747,"context_line":"            self.client.update_port(port[\u0027id\u0027], security_groups\u003d["},{"line_number":748,"context_line":"                secgroup[\u0027id\u0027]])"},{"line_number":749,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a61da82f_0a16d188","line":746,"range":{"start_line":746,"start_character":43,"end_line":746,"end_character":71},"in_reply_to":"268d1bbd_a58b4827","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"f1998cfaaaf45a7ac4b44924f83d8ce9d0ced8c7","unresolved":true,"context_lines":[{"line_number":748,"context_line":"                secgroup[\u0027id\u0027]])"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"         # verify SSH functionality"},{"line_number":751,"context_line":"        for fip in fips:"},{"line_number":752,"context_line":"            self.check_connectivity(fip[\u0027floating_ip_address\u0027],"},{"line_number":753,"context_line":"                                    CONF.validation.image_ssh_user,"},{"line_number":754,"context_line":"                                    self.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"e023b2ea_6f3029b2","line":751,"range":{"start_line":751,"start_character":19,"end_line":751,"end_character":23},"updated":"2022-07-07 15:47:20.000000000","message":"Do you need fips in this scenario?","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":748,"context_line":"                secgroup[\u0027id\u0027]])"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"         # verify SSH functionality"},{"line_number":751,"context_line":"        for fip in fips:"},{"line_number":752,"context_line":"            self.check_connectivity(fip[\u0027floating_ip_address\u0027],"},{"line_number":753,"context_line":"                                    CONF.validation.image_ssh_user,"},{"line_number":754,"context_line":"                                    self.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7271fbdf_f72016e6","line":751,"range":{"start_line":751,"start_character":19,"end_line":751,"end_character":23},"in_reply_to":"e023b2ea_6f3029b2","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"f1998cfaaaf45a7ac4b44924f83d8ce9d0ced8c7","unresolved":true,"context_lines":[{"line_number":756,"context_line":"        test_ip \u003d ports_for_tcp_test[1][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        # verify that conections are not working"},{"line_number":759,"context_line":"        for port in range(80, 80):"},{"line_number":760,"context_line":"            self._verify_http_connection("},{"line_number":761,"context_line":"                vms_ssh[0],"},{"line_number":762,"context_line":"                vms_ssh[1],"}],"source_content_type":"text/x-python","patch_set":2,"id":"6806c0c9_8e19f38b","line":759,"range":{"start_line":759,"start_character":20,"end_line":759,"end_character":33},"updated":"2022-07-07 15:47:20.000000000","message":"this will not do anything due to range call","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":756,"context_line":"        test_ip \u003d ports_for_tcp_test[1][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        # verify that conections are not working"},{"line_number":759,"context_line":"        for port in range(80, 80):"},{"line_number":760,"context_line":"            self._verify_http_connection("},{"line_number":761,"context_line":"                vms_ssh[0],"},{"line_number":762,"context_line":"                vms_ssh[1],"}],"source_content_type":"text/x-python","patch_set":2,"id":"4e2c1a8c_f171e4c2","line":759,"range":{"start_line":759,"start_character":20,"end_line":759,"end_character":33},"in_reply_to":"6806c0c9_8e19f38b","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"f1998cfaaaf45a7ac4b44924f83d8ce9d0ced8c7","unresolved":true,"context_lines":[{"line_number":755,"context_line":""},{"line_number":756,"context_line":"        test_ip \u003d ports_for_tcp_test[1][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        # verify that conections are not working"},{"line_number":759,"context_line":"        for port in range(80, 80):"},{"line_number":760,"context_line":"            self._verify_http_connection("},{"line_number":761,"context_line":"                vms_ssh[0],"},{"line_number":762,"context_line":"                vms_ssh[1],"},{"line_number":763,"context_line":"                test_ip, port,"},{"line_number":764,"context_line":"                vms,"},{"line_number":765,"context_line":"                should_pass\u003dFalse)"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"        # add TCP rule with port 80"},{"line_number":768,"context_line":"        rule_list \u003d [{\u0027protocol\u0027: constants.PROTO_NUM_TCP,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ea81510e_990e0174","line":765,"range":{"start_line":758,"start_character":0,"end_line":765,"end_character":34},"updated":"2022-07-07 15:47:20.000000000","message":"IIUC this test checks removal of security group rule, therefore I would also perform this check after SGR is deleted.","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":755,"context_line":""},{"line_number":756,"context_line":"        test_ip \u003d ports_for_tcp_test[1][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        # verify that conections are not working"},{"line_number":759,"context_line":"        for port in range(80, 80):"},{"line_number":760,"context_line":"            self._verify_http_connection("},{"line_number":761,"context_line":"                vms_ssh[0],"},{"line_number":762,"context_line":"                vms_ssh[1],"},{"line_number":763,"context_line":"                test_ip, port,"},{"line_number":764,"context_line":"                vms,"},{"line_number":765,"context_line":"                should_pass\u003dFalse)"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"        # add TCP rule with port 80"},{"line_number":768,"context_line":"        rule_list \u003d [{\u0027protocol\u0027: constants.PROTO_NUM_TCP,"}],"source_content_type":"text/x-python","patch_set":2,"id":"de6dc759_03a92e68","line":765,"range":{"start_line":758,"start_character":0,"end_line":765,"end_character":34},"in_reply_to":"ea81510e_990e0174","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"f1998cfaaaf45a7ac4b44924f83d8ce9d0ced8c7","unresolved":true,"context_lines":[{"line_number":769,"context_line":"                      \u0027direction\u0027: constants.INGRESS_DIRECTION,"},{"line_number":770,"context_line":"                      \u0027port_range_min\u0027: \u002780\u0027,"},{"line_number":771,"context_line":"                      \u0027port_range_max\u0027: \u002780\u0027}]"},{"line_number":772,"context_line":"        sg_rid \u003d self.create_secgroup_rules("},{"line_number":773,"context_line":"            rule_list, secgroup_id\u003dsecgrs_for_tcp_test[1][\u0027id\u0027])"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        # verify that conections are working"}],"source_content_type":"text/x-python","patch_set":2,"id":"0836b1b1_6dbfdd69","line":772,"updated":"2022-07-07 15:47:20.000000000","message":"Please also notice pep8 comments, you must write according to pep8, and they can be helpful in this case.","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":769,"context_line":"                      \u0027direction\u0027: constants.INGRESS_DIRECTION,"},{"line_number":770,"context_line":"                      \u0027port_range_min\u0027: \u002780\u0027,"},{"line_number":771,"context_line":"                      \u0027port_range_max\u0027: \u002780\u0027}]"},{"line_number":772,"context_line":"        sg_rid \u003d self.create_secgroup_rules("},{"line_number":773,"context_line":"            rule_list, secgroup_id\u003dsecgrs_for_tcp_test[1][\u0027id\u0027])"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        # verify that conections are working"}],"source_content_type":"text/x-python","patch_set":2,"id":"d90b046f_4441dc7e","line":772,"in_reply_to":"0836b1b1_6dbfdd69","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"f1998cfaaaf45a7ac4b44924f83d8ce9d0ced8c7","unresolved":true,"context_lines":[{"line_number":773,"context_line":"            rule_list, secgroup_id\u003dsecgrs_for_tcp_test[1][\u0027id\u0027])"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        # verify that conections are working"},{"line_number":776,"context_line":"        for port in range(80, 80):"},{"line_number":777,"context_line":"            self._verify_http_connection("},{"line_number":778,"context_line":"                vms_ssh[0],"},{"line_number":779,"context_line":"                vms_ssh[1],"}],"source_content_type":"text/x-python","patch_set":2,"id":"8c563f77_c89bcefa","line":776,"range":{"start_line":776,"start_character":20,"end_line":776,"end_character":33},"updated":"2022-07-07 15:47:20.000000000","message":"this will not do anything due to range call","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":773,"context_line":"            rule_list, secgroup_id\u003dsecgrs_for_tcp_test[1][\u0027id\u0027])"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        # verify that conections are working"},{"line_number":776,"context_line":"        for port in range(80, 80):"},{"line_number":777,"context_line":"            self._verify_http_connection("},{"line_number":778,"context_line":"                vms_ssh[0],"},{"line_number":779,"context_line":"                vms_ssh[1],"}],"source_content_type":"text/x-python","patch_set":2,"id":"4c668c73_e0c0dbe3","line":776,"range":{"start_line":776,"start_character":20,"end_line":776,"end_character":33},"in_reply_to":"8c563f77_c89bcefa","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"f1998cfaaaf45a7ac4b44924f83d8ce9d0ced8c7","unresolved":true,"context_lines":[{"line_number":781,"context_line":"                vms)"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"       # # Delete the SG"},{"line_number":784,"context_line":"       #  self.client.delete_security_group_rule(secgrs_for_tcp_test[1][\u0027id\u0027])"},{"line_number":785,"context_line":"        "},{"line_number":786,"context_line":"        pprint(100*\u0027\u003d\u0027)"},{"line_number":787,"context_line":"        pprint(secgrs_for_tcp_test[1][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"77c56a11_30dd4520","line":784,"updated":"2022-07-07 15:47:20.000000000","message":"ID argument for delete security group rule method does not point to a security group rule.","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"32a25c76de8cbd6c53314b353e556ce466e4780c","unresolved":false,"context_lines":[{"line_number":781,"context_line":"                vms)"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"       # # Delete the SG"},{"line_number":784,"context_line":"       #  self.client.delete_security_group_rule(secgrs_for_tcp_test[1][\u0027id\u0027])"},{"line_number":785,"context_line":"        "},{"line_number":786,"context_line":"        pprint(100*\u0027\u003d\u0027)"},{"line_number":787,"context_line":"        pprint(secgrs_for_tcp_test[1][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"f70bea6a_014777b9","line":784,"in_reply_to":"77c56a11_30dd4520","updated":"2022-07-20 08:30:15.000000000","message":"Done","commit_id":"307edc153a90b30fb689aad81505a5f872b24ec8"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"c24cc0965ec0173044616e46b3b733c4b79deeb9","unresolved":true,"context_lines":[{"line_number":704,"context_line":"        4.Verify that you don\u0027t have tcp port 80 connectivity to the VM"},{"line_number":705,"context_line":"        5.Add a tcp rule port 80 connections to the security group"},{"line_number":706,"context_line":"        6.Verify that you have tcp port 80 connectivity to the VM"},{"line_number":707,"context_line":"        7.Delete the added tcp rule from the security group"},{"line_number":708,"context_line":"        \"\"\""},{"line_number":709,"context_line":"        secgrp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":710,"context_line":"        sec_grp \u003d self.os_primary.network_client.create_security_group("}],"source_content_type":"text/x-python","patch_set":4,"id":"72a0df24_f31b7c81","line":707,"updated":"2022-07-25 16:32:56.000000000","message":"I would add 8th step, same check as 4th step.","commit_id":"20713b0c6ad961161d991aa86c7cb334534b0f57"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"ad65c6829b76209f5f0df03803cd3accb0d18063","unresolved":false,"context_lines":[{"line_number":704,"context_line":"        4.Verify that you don\u0027t have tcp port 80 connectivity to the VM"},{"line_number":705,"context_line":"        5.Add a tcp rule port 80 connections to the security group"},{"line_number":706,"context_line":"        6.Verify that you have tcp port 80 connectivity to the VM"},{"line_number":707,"context_line":"        7.Delete the added tcp rule from the security group"},{"line_number":708,"context_line":"        \"\"\""},{"line_number":709,"context_line":"        secgrp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":710,"context_line":"        sec_grp \u003d self.os_primary.network_client.create_security_group("}],"source_content_type":"text/x-python","patch_set":4,"id":"c9030dd1_fa845f48","line":707,"in_reply_to":"72a0df24_f31b7c81","updated":"2022-07-26 12:58:47.000000000","message":"Done","commit_id":"20713b0c6ad961161d991aa86c7cb334534b0f57"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"c24cc0965ec0173044616e46b3b733c4b79deeb9","unresolved":true,"context_lines":[{"line_number":707,"context_line":"        7.Delete the added tcp rule from the security group"},{"line_number":708,"context_line":"        \"\"\""},{"line_number":709,"context_line":"        secgrp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":710,"context_line":"        sec_grp \u003d self.os_primary.network_client.create_security_group("},{"line_number":711,"context_line":"            name\u003dsecgrp_name)"},{"line_number":712,"context_line":"        self.security_groups.append(sec_grp[\u0027security_group\u0027])"},{"line_number":713,"context_line":"        sec_grp_id \u003d sec_grp[\u0027security_group\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ef89f9c5_e7e33393","line":710,"range":{"start_line":710,"start_character":8,"end_line":710,"end_character":15},"updated":"2022-07-25 16:32:56.000000000","message":"nit: It seems only \"sec_grp[\u0027security_group\u0027]\" is used afterwards and not \"sec_grp\", I would take this value directly in L710-711, then change L712-713 to be also more short/intuitive (also change in other relevant places).","commit_id":"20713b0c6ad961161d991aa86c7cb334534b0f57"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"ad65c6829b76209f5f0df03803cd3accb0d18063","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        7.Delete the added tcp rule from the security group"},{"line_number":708,"context_line":"        \"\"\""},{"line_number":709,"context_line":"        secgrp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":710,"context_line":"        sec_grp \u003d self.os_primary.network_client.create_security_group("},{"line_number":711,"context_line":"            name\u003dsecgrp_name)"},{"line_number":712,"context_line":"        self.security_groups.append(sec_grp[\u0027security_group\u0027])"},{"line_number":713,"context_line":"        sec_grp_id \u003d sec_grp[\u0027security_group\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"93a65b71_00ec058f","line":710,"range":{"start_line":710,"start_character":8,"end_line":710,"end_character":15},"in_reply_to":"ef89f9c5_e7e33393","updated":"2022-07-26 12:58:47.000000000","message":"Done","commit_id":"20713b0c6ad961161d991aa86c7cb334534b0f57"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"c24cc0965ec0173044616e46b3b733c4b79deeb9","unresolved":true,"context_lines":[{"line_number":720,"context_line":"                self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":721,"context_line":"                security_groups\u003d[sec_grp_id]))"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        vms_ssh, fips, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":724,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}], ports\u003dports)"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"        srv_port \u003d self.client.list_ports("}],"source_content_type":"text/x-python","patch_set":4,"id":"cb1386fa_32766283","line":723,"range":{"start_line":723,"start_character":17,"end_line":723,"end_character":21},"updated":"2022-07-25 16:32:56.000000000","message":"fips is never used, therefore this reference could be spared (it can also allow it to be garbage collected).\nThis can be done by using extended slice [::2]","commit_id":"20713b0c6ad961161d991aa86c7cb334534b0f57"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"ad65c6829b76209f5f0df03803cd3accb0d18063","unresolved":false,"context_lines":[{"line_number":720,"context_line":"                self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":721,"context_line":"                security_groups\u003d[sec_grp_id]))"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        vms_ssh, fips, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":724,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}], ports\u003dports)"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"        srv_port \u003d self.client.list_ports("}],"source_content_type":"text/x-python","patch_set":4,"id":"e3e652ae_b4c7a880","line":723,"range":{"start_line":723,"start_character":17,"end_line":723,"end_character":21},"in_reply_to":"cb1386fa_32766283","updated":"2022-07-26 12:58:47.000000000","message":"Done","commit_id":"20713b0c6ad961161d991aa86c7cb334534b0f57"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"c24cc0965ec0173044616e46b3b733c4b79deeb9","unresolved":true,"context_lines":[{"line_number":723,"context_line":"        vms_ssh, fips, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":724,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}], ports\u003dports)"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"        srv_port \u003d self.client.list_ports("},{"line_number":727,"context_line":"            network_id\u003dself.network[\u0027id\u0027],"},{"line_number":728,"context_line":"            device_id\u003dvms[1][\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":729,"context_line":"        test_ip \u003d srv_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":730,"context_line":"        port \u003d 80"},{"line_number":731,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"14226063_db6c8982","line":728,"range":{"start_line":726,"start_character":0,"end_line":728,"end_character":57},"updated":"2022-07-25 16:32:56.000000000","message":"object \u0027ports[1]\u0027 is supposed to work here as well, no need for \u0027list_ports\u0027 function call.\n\nI would keep the variable name to that port[1] since there is VM with http server running on it.\nAdditionally also here with \u0027srv_port\u0027 variable name, I would try to distinguish between port of http server, and neutron port of VM (aka server) in the name.","commit_id":"20713b0c6ad961161d991aa86c7cb334534b0f57"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"ad65c6829b76209f5f0df03803cd3accb0d18063","unresolved":false,"context_lines":[{"line_number":723,"context_line":"        vms_ssh, fips, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":724,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}], ports\u003dports)"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"        srv_port \u003d self.client.list_ports("},{"line_number":727,"context_line":"            network_id\u003dself.network[\u0027id\u0027],"},{"line_number":728,"context_line":"            device_id\u003dvms[1][\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":729,"context_line":"        test_ip \u003d srv_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":730,"context_line":"        port \u003d 80"},{"line_number":731,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"d722ed3b_4e98f631","line":728,"range":{"start_line":726,"start_character":0,"end_line":728,"end_character":57},"in_reply_to":"14226063_db6c8982","updated":"2022-07-26 12:58:47.000000000","message":"Done","commit_id":"20713b0c6ad961161d991aa86c7cb334534b0f57"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"c24cc0965ec0173044616e46b3b733c4b79deeb9","unresolved":true,"context_lines":[{"line_number":727,"context_line":"            network_id\u003dself.network[\u0027id\u0027],"},{"line_number":728,"context_line":"            device_id\u003dvms[1][\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":729,"context_line":"        test_ip \u003d srv_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":730,"context_line":"        port \u003d 80"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"        self._verify_http_connection(vms_ssh[0], vms_ssh[1], test_ip,"},{"line_number":733,"context_line":"                                     port, vms, should_pass\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"6440d321_e8046a13","line":730,"range":{"start_line":730,"start_character":8,"end_line":730,"end_character":12},"updated":"2022-07-25 16:32:56.000000000","message":"I would call it \u0027http_port\u0027 or something similar, to distinguish between neutron ports and tcp ports.\nFor example \u0027ports\u0027 is used here and more commonly references to objects of neutron ports, and not an http port.","commit_id":"20713b0c6ad961161d991aa86c7cb334534b0f57"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"ad65c6829b76209f5f0df03803cd3accb0d18063","unresolved":false,"context_lines":[{"line_number":727,"context_line":"            network_id\u003dself.network[\u0027id\u0027],"},{"line_number":728,"context_line":"            device_id\u003dvms[1][\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":729,"context_line":"        test_ip \u003d srv_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":730,"context_line":"        port \u003d 80"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"        self._verify_http_connection(vms_ssh[0], vms_ssh[1], test_ip,"},{"line_number":733,"context_line":"                                     port, vms, should_pass\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"91881fa9_66c43e79","line":730,"range":{"start_line":730,"start_character":8,"end_line":730,"end_character":12},"in_reply_to":"6440d321_e8046a13","updated":"2022-07-26 12:58:47.000000000","message":"Done","commit_id":"20713b0c6ad961161d991aa86c7cb334534b0f57"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"c24cc0965ec0173044616e46b3b733c4b79deeb9","unresolved":true,"context_lines":[{"line_number":729,"context_line":"        test_ip \u003d srv_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":730,"context_line":"        port \u003d 80"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"        self._verify_http_connection(vms_ssh[0], vms_ssh[1], test_ip,"},{"line_number":733,"context_line":"                                     port, vms, should_pass\u003dFalse)"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"        rule_list \u003d [{\u0027protocol\u0027: constants.PROTO_NUM_TCP,"}],"source_content_type":"text/x-python","patch_set":4,"id":"f4ecff36_cf24342c","line":732,"range":{"start_line":732,"start_character":61,"end_line":732,"end_character":68},"updated":"2022-07-25 16:32:56.000000000","message":"nit: IMO it seems a bit unclear what is \u0027test_ip\u0027 in the context of current test code, I would call it \u0027http_server_ip\u0027 (also in other relevant places).","commit_id":"20713b0c6ad961161d991aa86c7cb334534b0f57"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"ad65c6829b76209f5f0df03803cd3accb0d18063","unresolved":false,"context_lines":[{"line_number":729,"context_line":"        test_ip \u003d srv_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":730,"context_line":"        port \u003d 80"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"        self._verify_http_connection(vms_ssh[0], vms_ssh[1], test_ip,"},{"line_number":733,"context_line":"                                     port, vms, should_pass\u003dFalse)"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"        rule_list \u003d [{\u0027protocol\u0027: constants.PROTO_NUM_TCP,"}],"source_content_type":"text/x-python","patch_set":4,"id":"41336da0_1783f971","line":732,"range":{"start_line":732,"start_character":61,"end_line":732,"end_character":68},"in_reply_to":"f4ecff36_cf24342c","updated":"2022-07-26 12:58:47.000000000","message":"Done","commit_id":"20713b0c6ad961161d991aa86c7cb334534b0f57"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e93681b02222c580c29978b5e37341e6aeaff2a6","unresolved":true,"context_lines":[{"line_number":705,"context_line":"        5.Add a tcp rule port 80 connections to the security group"},{"line_number":706,"context_line":"        6.Verify that you have tcp port 80 connectivity to the VM"},{"line_number":707,"context_line":"        7.Delete the added tcp rule from the security group"},{"line_number":708,"context_line":"        8.Verify that you don\u0027t have tcp port 80 connectivity to the VM"},{"line_number":709,"context_line":"        \"\"\""},{"line_number":710,"context_line":"        secgrp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":711,"context_line":"        sec_grp \u003d self.os_primary.network_client.create_security_group("}],"source_content_type":"text/x-python","patch_set":5,"id":"1c731025_f2a0d13b","line":708,"updated":"2022-07-26 14:50:49.000000000","message":"is this whole test really needed? Can\u0027t You simply maybe add last step (delete rule and test connectivity is not possible) to the test test_multiple_ports_portrange_remote?","commit_id":"0c6c4e69fc3306257c013014e850cd2482d22918"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"71e10af6442d78609e65f7471233810b7c392b12","unresolved":true,"context_lines":[{"line_number":705,"context_line":"        5.Add a tcp rule port 80 connections to the security group"},{"line_number":706,"context_line":"        6.Verify that you have tcp port 80 connectivity to the VM"},{"line_number":707,"context_line":"        7.Delete the added tcp rule from the security group"},{"line_number":708,"context_line":"        8.Verify that you don\u0027t have tcp port 80 connectivity to the VM"},{"line_number":709,"context_line":"        \"\"\""},{"line_number":710,"context_line":"        secgrp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":711,"context_line":"        sec_grp \u003d self.os_primary.network_client.create_security_group("}],"source_content_type":"text/x-python","patch_set":5,"id":"597ab246_03746061","line":708,"in_reply_to":"1c731025_f2a0d13b","updated":"2022-07-27 08:15:54.000000000","message":"+1","commit_id":"0c6c4e69fc3306257c013014e850cd2482d22918"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"3e64ee42dcd28494cea7fe733db4a620e8e01fea","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        5.Add a tcp rule port 80 connections to the security group"},{"line_number":706,"context_line":"        6.Verify that you have tcp port 80 connectivity to the VM"},{"line_number":707,"context_line":"        7.Delete the added tcp rule from the security group"},{"line_number":708,"context_line":"        8.Verify that you don\u0027t have tcp port 80 connectivity to the VM"},{"line_number":709,"context_line":"        \"\"\""},{"line_number":710,"context_line":"        secgrp_name \u003d data_utils.rand_name(\u0027test_sg\u0027)"},{"line_number":711,"context_line":"        sec_grp \u003d self.os_primary.network_client.create_security_group("}],"source_content_type":"text/x-python","patch_set":5,"id":"030fe5d0_1cec7ae7","line":708,"in_reply_to":"1c731025_f2a0d13b","updated":"2022-07-27 09:40:58.000000000","message":"Done","commit_id":"0c6c4e69fc3306257c013014e850cd2482d22918"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"df2e835ca7e1cac458e02de0b16cbd8668f3db7c","unresolved":true,"context_lines":[{"line_number":715,"context_line":"        self.create_loginable_secgroup_rule(sec_grp_id)"},{"line_number":716,"context_line":"        self.create_pingable_secgroup_rule(sec_grp_id)"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        ports \u003d []"},{"line_number":719,"context_line":"        for i in range(2):"},{"line_number":720,"context_line":"            ports.append(self.create_port("},{"line_number":721,"context_line":"                self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":722,"context_line":"                security_groups\u003d[sec_grp_id]))"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        vms_ssh, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":725,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}], ports\u003dports)[::2]"}],"source_content_type":"text/x-python","patch_set":5,"id":"22af83d8_2362af83","line":722,"range":{"start_line":718,"start_character":8,"end_line":722,"end_character":46},"updated":"2022-07-26 15:00:09.000000000","message":"not sure that there is a reason to create port\u0027s in advance. you specify security groups when you create VMs. Tempest will create port for the VM automatically when you execute create_vm_testing_sec_grp method. In order to query port for the specific VM you can do something like this:\n\nports \u003d []\nfor vm in vms:\n    ports.append(self.client.list_ports(network_id\u003dself.network[\u0027id\u0027],\n                 device_id\u003dvm[\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0])\n                 \nBut I don\u0027t see why you need the port object","commit_id":"0c6c4e69fc3306257c013014e850cd2482d22918"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"3e64ee42dcd28494cea7fe733db4a620e8e01fea","unresolved":false,"context_lines":[{"line_number":715,"context_line":"        self.create_loginable_secgroup_rule(sec_grp_id)"},{"line_number":716,"context_line":"        self.create_pingable_secgroup_rule(sec_grp_id)"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        ports \u003d []"},{"line_number":719,"context_line":"        for i in range(2):"},{"line_number":720,"context_line":"            ports.append(self.create_port("},{"line_number":721,"context_line":"                self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":722,"context_line":"                security_groups\u003d[sec_grp_id]))"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        vms_ssh, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":725,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}], ports\u003dports)[::2]"}],"source_content_type":"text/x-python","patch_set":5,"id":"fdd1a62d_c3aef2ba","line":722,"range":{"start_line":718,"start_character":8,"end_line":722,"end_character":46},"in_reply_to":"22af83d8_2362af83","updated":"2022-07-27 09:40:58.000000000","message":"Done","commit_id":"0c6c4e69fc3306257c013014e850cd2482d22918"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"df2e835ca7e1cac458e02de0b16cbd8668f3db7c","unresolved":true,"context_lines":[{"line_number":721,"context_line":"                self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":722,"context_line":"                security_groups\u003d[sec_grp_id]))"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        vms_ssh, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":725,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}], ports\u003dports)[::2]"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"        neutron_port \u003d ports[1]"},{"line_number":728,"context_line":"        http_server_ip \u003d neutron_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"b8cbe0b4_19aa0a26","line":725,"range":{"start_line":724,"start_character":8,"end_line":725,"end_character":70},"updated":"2022-07-26 15:00:09.000000000","message":"better do it the following way:\n\nvms_ssh, _, vms \u003d self.create_vm_testing_sec_grp(security_groups[{\u0027name\u0027: secgrp_name}], ports\u003dports)","commit_id":"0c6c4e69fc3306257c013014e850cd2482d22918"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"3e64ee42dcd28494cea7fe733db4a620e8e01fea","unresolved":false,"context_lines":[{"line_number":721,"context_line":"                self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":722,"context_line":"                security_groups\u003d[sec_grp_id]))"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        vms_ssh, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":725,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}], ports\u003dports)[::2]"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"        neutron_port \u003d ports[1]"},{"line_number":728,"context_line":"        http_server_ip \u003d neutron_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"565ccb24_b732e403","line":725,"range":{"start_line":724,"start_character":8,"end_line":725,"end_character":70},"in_reply_to":"b8cbe0b4_19aa0a26","updated":"2022-07-27 09:40:58.000000000","message":"Done","commit_id":"0c6c4e69fc3306257c013014e850cd2482d22918"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"71e10af6442d78609e65f7471233810b7c392b12","unresolved":true,"context_lines":[{"line_number":721,"context_line":"                self.network, fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnets[0][\u0027id\u0027]}],"},{"line_number":722,"context_line":"                security_groups\u003d[sec_grp_id]))"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        vms_ssh, vms \u003d self.create_vm_testing_sec_grp("},{"line_number":725,"context_line":"            security_groups\u003d[{\u0027name\u0027: secgrp_name}], ports\u003dports)[::2]"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"        neutron_port \u003d ports[1]"},{"line_number":728,"context_line":"        http_server_ip \u003d neutron_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9b9bad0b_44c4c147","line":725,"range":{"start_line":724,"start_character":8,"end_line":725,"end_character":70},"in_reply_to":"b8cbe0b4_19aa0a26","updated":"2022-07-27 08:15:54.000000000","message":"Using underscore is a good common python solution here,\nbut even though its common I still think the existing extended slice approach offers extra advantages:\n1) We don\u0027t create a variable that references an object, when we never use the object/variable.\n2) When not creating this reference to the object, this unneeded object becomes inaccessible by our code, then could be garbage collected, free memory.\n\nAnyways it is a nit, both could work.\n\nIMO even better: \nSince scenarios that don\u0027t need fips are also very common,\nI would consider adding boolean parameter like \u0027create_fips\u0027 which defaults to True in create_vm_testing_sec_grp method.\nThis would spare time (API calls), just need to notice the returned tuple is still well defined and won\u0027t break existing code.","commit_id":"0c6c4e69fc3306257c013014e850cd2482d22918"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"df2e835ca7e1cac458e02de0b16cbd8668f3db7c","unresolved":true,"context_lines":[{"line_number":742,"context_line":"                                     http_port, vms)"},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"        self.client.delete_security_group_rule("},{"line_number":745,"context_line":"            sec_grp[\u0027security_group_rules\u0027][0][\u0027id\u0027])"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        self._verify_http_connection(vms_ssh[0], vms_ssh[1], http_server_ip,"},{"line_number":748,"context_line":"                                     http_port, vms, should_pass\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"103222c5_2596ffb7","line":745,"range":{"start_line":745,"start_character":12,"end_line":745,"end_character":19},"updated":"2022-07-26 15:00:09.000000000","message":"You didn\u0027t update sec_grp object with the new rule so I\u0027m not sure that [0] element is the reference to the http rule.","commit_id":"0c6c4e69fc3306257c013014e850cd2482d22918"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"083e82d7984a5207e93c3c3943144d87f7326164","unresolved":false,"context_lines":[{"line_number":742,"context_line":"                                     http_port, vms)"},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"        self.client.delete_security_group_rule("},{"line_number":745,"context_line":"            sec_grp[\u0027security_group_rules\u0027][0][\u0027id\u0027])"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        self._verify_http_connection(vms_ssh[0], vms_ssh[1], http_server_ip,"},{"line_number":748,"context_line":"                                     http_port, vms, should_pass\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"a58b028f_58745388","line":745,"range":{"start_line":745,"start_character":12,"end_line":745,"end_character":19},"in_reply_to":"103222c5_2596ffb7","updated":"2022-08-04 09:45:37.000000000","message":"Done","commit_id":"0c6c4e69fc3306257c013014e850cd2482d22918"},{"author":{"_account_id":31450,"name":"Alex Katz","email":"akatz@redhat.com","username":"akatz"},"change_message_id":"ff99626764028581dd661b184e95ad2098f3c82e","unresolved":true,"context_lines":[{"line_number":558,"context_line":"        self.client.delete_security_group_rule(sg_rule_id)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        # verify that conections are not working"},{"line_number":561,"context_line":"        for port in range(80, 84):"},{"line_number":562,"context_line":"            self._verify_http_connection("},{"line_number":563,"context_line":"                ssh_clients[0],"},{"line_number":564,"context_line":"                ssh_clients[2],"}],"source_content_type":"text/x-python","patch_set":7,"id":"38b482c1_d7006671","line":561,"range":{"start_line":561,"start_character":26,"end_line":561,"end_character":32},"updated":"2022-08-04 14:03:29.000000000","message":"there are two different rules created for this range of ports:\n- 80-81\n- 82-83\nyou searched (and so deleted) only the first one, so I expect that first and second iteration of this script will pass, but third and fourth will not.","commit_id":"149b7a986e7916fd7445ca40ca01931041d4af41"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"1d00211bbfa98d70f41b8c8b1e354ba047f9488c","unresolved":true,"context_lines":[{"line_number":558,"context_line":"        self.client.delete_security_group_rule(sg_rule_id)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        # verify that conections are not working"},{"line_number":561,"context_line":"        for port in range(80, 84):"},{"line_number":562,"context_line":"            self._verify_http_connection("},{"line_number":563,"context_line":"                ssh_clients[0],"},{"line_number":564,"context_line":"                ssh_clients[2],"}],"source_content_type":"text/x-python","patch_set":7,"id":"edadf4c5_9a890e3a","line":561,"range":{"start_line":561,"start_character":26,"end_line":561,"end_character":32},"in_reply_to":"38b482c1_d7006671","updated":"2022-08-10 14:43:34.000000000","message":"Fixed","commit_id":"149b7a986e7916fd7445ca40ca01931041d4af41"},{"author":{"_account_id":34819,"name":"ayenachew molla","email":"amolla@redhat.com","username":"amolla"},"change_message_id":"fce1ddb11473e4e39353d0e7042b8579c4551a33","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        self.client.delete_security_group_rule(sg_rule_id)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        # verify that conections are not working"},{"line_number":561,"context_line":"        for port in range(80, 84):"},{"line_number":562,"context_line":"            self._verify_http_connection("},{"line_number":563,"context_line":"                ssh_clients[0],"},{"line_number":564,"context_line":"                ssh_clients[2],"}],"source_content_type":"text/x-python","patch_set":7,"id":"76fd95bf_2b00ff71","line":561,"range":{"start_line":561,"start_character":26,"end_line":561,"end_character":32},"in_reply_to":"edadf4c5_9a890e3a","updated":"2022-08-10 14:43:51.000000000","message":"Done","commit_id":"149b7a986e7916fd7445ca40ca01931041d4af41"}]}